]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
Set GDB version number to 9.1.
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
899016d4
JB
12020-02-08 Joel Brobecker <brobecker@adacore.com>
2
3 * version.in: Set GDB version number to 9.1.
4
f49692df
IB
52020-02-05 Iain Buclaw <ibuclaw@gdcproject.org>
6
7 PR gdb/25190:
8 * gdb/remote-sim.c (gdb_os_write_stderr): Update.
9 * gdb/remote.c (remote_console_output): Update.
10 * gdb/ui-file.c (fputs_unfiltered): Rename to...
11 (ui_file_puts): ...this.
12 * gdb/ui-file.h (ui_file_puts): Add declaration.
13 * gdb/utils.c (emit_style_escape): Update.
14 (flush_wrap_buffer): Update.
15 (fputs_maybe_filtered): Update.
16 (fputs_unfiltered): Add function.
17
ff491e6b
IB
182020-02-05 Iain Buclaw <ibuclaw@gdcproject.org>
19
20 * gdb/event-loop.c (gdb_wait_for_event): Update.
21 * gdb/printcmd.c (printf_command): Update.
22 * gdb/remote-fileio.c (remote_fileio_func_write): Update.
23 * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
24 (gdb_os_flush_stderr): Update.
25 * gdb/remote.c (remote_console_output): Update.
26 * gdb/ui-file.c (gdb_flush): Rename to...
27 (ui_file_flush): ...this.
28 (stderr_file::write): Update.
29 (stderr_file::puts): Update.
30 * gdb/ui-file.h (gdb_flush): Rename to...
31 (ui_file_flush): ...this.
32 * gdb/utils.c (gdb_flush): Add function.
33 * gdb/utils.h (gdb_flush): Add declaration.
34
76f5096c
TT
352020-02-07 Tom Tromey <tromey@adacore.com>
36
37 PR breakpoints/24915:
38 * source.c (find_and_open_source): Do not check basenames_may_differ.
39
975292a9
CB
402020-01-10 Christian Biesinger <cbiesinger@google.com>
41
42 * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
43
3c473fad
TT
442020-01-07 Tom Tromey <tromey@adacore.com>
45
46 PR build/24937:
47 * stap-probe.c (class stap_static_probe_ops): Add constructor.
48
f7da8e5b
AB
492020-01-06 Andrew Burgess <andrew.burgess@embecosm.com>
50
51 * stack.c (print_frame_info): Move disassemble_next_line code
52 inside source_print block.
53
b8e46eb9
JB
542020-01-01 Joel Brobecker <brobecker@adacore.com>
55
56 * gdbarch.sh: Update copyright year range of generated files.
57
11bc5fe4
JB
582020-01-01 Joel Brobecker <brobecker@adacore.com>
59
60 Update copyright year range in all the GDB files automatically
61 handled by our copyright.py script.
62
8b371634
JB
632020-01-01 Joel Brobecker <brobecker@adacore.com>
64
65 * copyright.py: Convert to Python 3.
66
a292f79f
JB
672020-01-01 Joel Brobecker <brobecker@adacore.com>
68
69 * copyright.py: Adapt after move of gnulib directory from gdb
70 directory to toplevel directory.
71
1458b0f3
JB
722020-01-01 Joel Brobecker <brobecker@adacore.com>
73
74 * copyright.py (main): Exit if run from the wrong directory.
75
e9de78be
JB
762020-01-01 Joel Brobecker <brobecker@adacore.com>
77
78 * top.c (print_gdb_version): Change copyright year to 2020.
79
c0716f3e
CB
802019-12-26 Christian Biesinger <cbiesinger@google.com>
81
82 * configure: Regenerate.
83 * configure.ac: Quote variable arguments of test.
84 * gdbsupport/common.m4: Likewise.
85
527178f7
EZ
862019-12-21 Eli Zaretskii <eliz@gnu.org>
87
88 * top.c (print_gdb_configuration): Print "--with-xxhash" or
89 "--without-xxhash" according to HAVE_LIBXXHASH.
90
4ae7258e
TT
912019-12-18 Tom Tromey <tromey@adacore.com>
92
93 PR build/25268:
94 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
95 type on macOS. Add comment.
96
1c66314d
TT
972019-12-18 Tom Tromey <tromey@adacore.com>
98
99 PR build/25250:
100 * ui-out.c (ui_out::vmessage): Update.
101 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
102 Rename.
103 (string_field): Update.
104 (signed_field): Update.
105
be19b699
SM
1062019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
107
108 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
109
3f434671
JB
1102019-12-11 Joel Brobecker <brobecker@adacore.com>
111
112 * version.in: Set GDB version number to 9.0.90.DATE-git.
113
07d5aa38
JB
1142019-12-11 Joel Brobecker <brobecker@adacore.com>
115
116 GDB 9.0.90 released.
117
b06b5486
JB
1182019-12-11 Joel Brobecker <brobecker@adacore.com>
119
120 * version.in: Set GDB version number to 9.0.90.
121
41ec388b
JB
1222019-12-11 Joel Brobecker <brobecker@adacore.com>
123
124 * NEWS: Change "Changes since GDB 8.3" into "Changes in GDB 9".
125
c87abc50
JB
1262019-12-11 Joel Brobecker <brobecker@adacore.com>
127
128 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
129 * version.in: Bump version to 9.0.90.DATE-git.
130
2e744276
TT
1312019-12-11 Tom Tromey <tromey@adacore.com>
132
133 PR build/25268:
134 * gdbsupport/thread-pool.c (set_thread_name): New function.
135 (thread_pool::set_thread_count): Don't call pthread_setname_np.
136 (thread_pool::thread_function): Call set_thread_name.
137
aac4760f
TT
1382019-12-11 Tom Tromey <tromey@adacore.com>
139
140 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
141 bfd_get_signed_8.
142
d8edc8b7
PW
1432019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
144
145 * NEWS: Document -raw-values option and the related setting commands.
146 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
147 only set it on when /r is given.
148 * valprint.c (value_print_option_defs): New element raw-values.
149 * Makefile.in: Add the new file.
150
cb511130
CB
1512019-12-10 Christian Biesinger <cbiesinger@google.com>
152
153 * gdbsupport/safe-strerror.c: Supress the unused function warning
154 for select_strerror_r.
155
ab7d13f0
CB
1562019-12-10 Christian Biesinger <cbiesinger@google.com>
157
158 * config.in: Regenerate.
159 * configure: Regenerate.
160 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
161 safe_strerror instead of strerror.
162 * gdbsupport/common.m4: Don't check for strerror.
163 * gdbsupport/safe-strerror.c: Support both the glibc version
164 of strerror_r and the XSI version.
165
6c71eb7d
TT
1662019-12-10 Tom Tromey <tromey@adacore.com>
167
168 * ada-typeprint.c (print_choices): Use a single "?".
169 (print_variant_part): Print "?" if the discriminant name
170 is not known.
171
bac7c5cf
GB
1722019-12-10 George Barrett <bob@bob131.so>
173
174 Fix scripted probe breakpoints.
175 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
176 declaration forward.
177 (breakpoint_ops_for_event_location_type)
178 (breakpoint_ops_for_event_location): Add function definitions.
179 (break_command_1, trace_command): Use
180 breakpoint_ops_for_event_location.
181 * breakpoint.h (breakpoint_ops_for_event_location): Add function
182 declarations.
183 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
184 breakpoint_ops_for_event_location.
185 * python/py-breakpoint.c (bppy_init): Use
186 breakpoint_ops_for_event_location.
187
330f1d38
TBA
1882019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
189
190 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
191 when ranking an lvalue argument for an rvalue parameter.
192
b1f0c0b9
WA
1932019-12-08 Wataru Ashihara <wataash@wataash.com>
194
195 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
196 template argument for scoped_restore_tmpl from bool to int.
197
aa2d5a42
KS
1982019-12-07 Keith Seitz <keiths@redhat.com>
199
200 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
201 (build_id_to_debug_bfd): Make static, rewriting to use
202 build_id_to_bfd_suffix.
203 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
204 adding `suffix' parameter. Append SUFFIX to file names
205 when searching for matching files.
206 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
207 (build_id_to_exec_bfd): Likewise.
208 * build-id.h (build_id_to_debug_bfd): Clarify that function
209 searches for BFD of debug info file.
210 (build_id_to_exec_bfd): Declare.
211 * corelow.c: Include build-id.h.
212 (locate_exec_from_corefile_build_id): New function.
213 (core_target_open): If no executable BFD is found,
214 search for a core file BFD using build-id.
215
dfb65191
CB
2162019-12-06 Christian Biesinger <cbiesinger@google.com>
217
218 * bcache.c: Put in namespace gdb.
219 * bcache.h: Likewise.
220 * gdbtypes.c (check_types_worklist): Update.
221 (types_deeply_equal): Update.
222 * macrotab.c (struct macro_table) <bcache>: Update.
223 (new_macro_table): Update.
224 * macrotab.h (struct bcache): Put this forward declaration
225 inside namespace gdb.
226 (new_macro_table): Update.
227 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
228 Update.
229 <macro_cache>: Update.
230 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
231
93e55f0a
TV
2322019-12-06 Tom de Vries <tdevries@suse.de>
233
234 PR symtab/24971
235 * block.c (best_symbol, better_symbol): New function.
236 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
237 decl.
238
06acc08f
TBA
2392019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
240
241 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
242 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
243 for ranking see-through reference cases.
244
e0fad1ea
PW
2452019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
246 * stack.c (faas_command): Check a command is provided.
247 * thread.c (taas_command, tfaas_command): Likewise.
248
908641f5
PW
2492019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
250 * inferior.c (prune_inferiors): Only call delete_inferior,
251 Do not modify the inferior list.
252
b858499d
SM
2532019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
254
255 * c-exp.y: Update calls to lookup_typename,
256 lookup_signed_typename and lookup_unsigned_typename.
257 * c-lang.c (evaluate_subexp_c): Likewise.
258 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
259 Likewise.
260 * eval.c (binop_promote): Likewise.
261 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
262 (lookup_unsigned_typename): Likewise.
263 (lookup_signed_typename): Likewise.
264 * gdbtypes.h (lookup_unsigned_typename): Likewise.
265 (lookup_signed_typename): Likewise.
266 (lookup_typename): Likewise.
267 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
268 lookup_typename, lookup_signed_typename,
269 lookup_unsigned_typename.
270 * m2-exp.y: Likewise.
271 * printcmd.c (printf_wide_c_string): Likewise.
272 (ui_printf): Likewise.
273 * python/py-type.c (typy_lookup_typename): Likewise.
274 * python/py-xmethods.c (python_xmethod_worker::invoke):
275 Likewise.
276 * rust-exp.y: Likewise.
277
3a8fa228
CB
2782019-12-04 Christian Biesinger <cbiesinger@google.com>
279
280 * configure.nat (obsd64): Add missing files x86-nat.o and
281 nat/x86-dregs.o.
282
2dbc041e
TT
2832019-12-04 Tom Tromey <tom@tromey.com>
284
285 * valprint.c (val_print_string): Use metadata_style.
286 * go-valprint.c (print_go_string): Use metadata style.
287 * p-valprint.c (pascal_object_print_static_field): Use metadata
288 style.
289 * cp-valprint.c (cp_print_static_field): Use metadata style.
290
36c8fb93
AB
2912019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
292 Chris January <chris.january@arm.com>
293
294 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
295 tokens.
296 (typebase): New patterns for complex, single/double precision, and
297 single/double complex.
298 (f77_keywords): Change token for complex keyword, and add single,
299 double, and precision keywords.
300
c6170c2c
SM
3012019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
302
303 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
304 "info io_registers".
305
894ecaf4
SM
3062019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
307
308 * regcache.c (cooked_read_test): Initialize thread list of
309 mock_inferior.
310
be155ebb
SM
3112019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
312
313 * aarch64-linux-tdep.c: Remove includes.
314
c577cdd7
SM
3152019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
316
317 * aarch64-tdep.c: Remove includes.
318
610cfd61
SM
3192019-12-04 Simon Marchi <simon.marchi@efficios.com>
320
321 * filtered-iterator.h (filtered_iterator) <operator==,
322 operator!=>: Compare wrapped iterators, not wrapped pointers.
323 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
324 unittests/filtered_iterator-selftests.c.
325 * unittests/filtered_iterator-selftests.c: New file.
326
a05cf17a
TT
3272019-12-04 Tom Tromey <tromey@adacore.com>
328
329 * gdbtypes.c (create_range_type): Inherit endianity
330 from base type.
331
d5a22e77
TT
3322019-12-04 Tom Tromey <tromey@adacore.com>
333
334 * ada-lang.c (decode_constrained_packed_array)
335 (ada_value_assign, value_assign_to_component): Update.
336 * dwarf2loc.c (rw_pieced_value, access_memory)
337 (dwarf2_compile_expr_to_ax): Update.
338 * dwarf2read.c (dwarf2_add_field): Update.
339 * eval.c (evaluate_subexp_standard): Update.
340 * gdbarch.c, gdbarch.h: Rebuild.
341 * gdbarch.sh (bits_big_endian): Remove.
342 * gdbtypes.h (union field_location): Update comment.
343 * target-descriptions.c (make_gdb_type): Update.
344 * valarith.c (value_bit_index): Update.
345 * value.c (struct value) <bitpos>: Update comment.
346 (unpack_bits_as_long, modify_field): Update.
347 * value.h (value_bitpos): Update comment.
348
7ab4a236
TT
3492019-12-04 Tom Tromey <tromey@adacore.com>
350
351 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
352 endian-ness.
353
103a685e
TT
3542019-12-04 Tom Tromey <tromey@adacore.com>
355
356 * dwarf2read.c (dwarf2_init_float_type)
357 (dwarf2_init_complex_target_type): Add byte_order parameter.
358 (read_base_type): Compute byte order earlier.
359 * gdbtypes.c (init_float_type): Add byte_order parameter.
360 * gdbtypes.h (init_float_type): Add byte_order parameter.
361
7a9e9f9f
TT
3622019-12-04 Tom Tromey <tromey@adacore.com>
363
364 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
365
feee869b
TT
3662019-12-04 Tom Tromey <tromey@adacore.com>
367
368 * dwarf2read.c (process_structure_scope): Initialize
369 "discr_offset".
370
c2512106
AB
3712019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
372
373 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
374 add it into the search spec.
375 (parse_max_results_option): New function.
376 (mi_info_functions_or_variables): Parse -max-results flag and pass
377 it to mi_symbol_info.
378 (mi_cmd_symbol_info_modules): Likewise.
379 (mi_cmd_symbol_info_types): Likewise.
380 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
381 return type to bool, change result container into a set, and don't
382 add new results if we have enough already.
383 (global_symbol_searcher::add_matching_msymbols): Change return
384 type to bool, and don't add new results if we have enough already.
385 (sort_search_symbols_remove_dups): Delete.
386 (global_symbol_searcher::search): Early exit from search loop when
387 we have enough results. Use a std::set to collect the results
388 from calling add_matching_symbols.
389 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
390 member function.
391 (global_symbol_searcher) <m_max_search_results>: New member
392 variable.
393 (global_symbol_searcher) <add_matching_symbols>: Update header
394 comment and change return type to bool.
395 (global_symbol_searcher) <add_matching_msymbols>: Update header
396 comment and change return type to bool.
397
f97a63c5
AB
3982019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
399
400 * symtab.c (symbol_search::compare_search_syms): Update header
401 comment.
402 (global_symbol_searcher::is_suitable_msymbol): New function.
403 (global_symbol_searcher::expand_symtabs): New function.
404 (global_symbol_searcher::add_matching_symbols): New function.
405 (global_symbol_searcher::add_matching_msymbols): New function.
406 (global_symbol_searcher::search): Move most of the content
407 into the new functions above, and call them as needed.
408 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
409 function.
410 (global_symbol_searcher) <add_matching_symbols>: New member
411 function.
412 (global_symbol_searcher) <add_matching_msymbols>: New member
413 function.
414 (global_symbol_searcher) <is_suitable_msymbol>: New member
415 function.
416
293b38d6
AB
4172019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
418
419 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
420 -symbol-info-module-variables entries.
421 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
422 (mi_cmd_symbol_info_module_variables): Declare.
423 * mi/mi-symbol-cmds.c
424 (module_symbol_search_iterator): New typedef.
425 (output_module_symbols_in_single_module_and_file): New function.
426 (output_module_symbols_in_single_module): New function.
427 (mi_info_module_functions_or_variables): New function.
428 (mi_cmd_symbol_info_module_functions): New function.
429 (mi_cmd_symbol_info_module_variables): New function.
430 * NEWS: Mention new MI command.
431
4cbd39b2
CB
4322019-12-03 Christian Biesinger <cbiesinger@google.com>
433
434 * bcache.c (hash): Remove.
435 (hash_continue): Remove.
436 * bcache.h (hash): Remove.
437 (hash_continue): Remove.
438 (struct bcache) <ctor>: Update.
439 * psymtab.c (psymbol_hash): Update.
440 * stabsread.c (hashname): Update.
441 * utils.h (fast_hash): Add an argument for a start value,
442 defaulting to zero.
443
82f910ea
PW
4442019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
445 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
446 (destroy_block_symbol_cache): New function.
447 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
448 (resize_symbol_cache): Likewise.
449
de2396d0
TT
4502019-12-02 Tom Tromey <tom@tromey.com>
451
452 * unittests/tui-selftests.c (run_tests): Make conditional.
453 (_initialize_tui_selftest): Make conditional.
454
638d85bc
CB
4552019-12-02 Christian Biesinger <cbiesinger@google.com>
456
457 * aix-thread.c (debug_aix_thread): Change type to bool.
458
7532a164
LM
4592019-12-02 Luis Machado <luis.machado@linaro.org>
460
461 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
462
216a7e6b
AB
4632019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
464
465 * dwarf2read.c (read_tag_string_type): Read the fields required to
466 make a dynamic string, and possibly create a dynamic range for the
467 string.
468 (attr_to_dynamic_prop): Setup is_reference based on the type of
469 attribute being processed.
470 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
471 (resolve_dynamic_array): Rename to...
472 (resolve_dynamic_array_or_string): ...this, update header comment,
473 and accept TYPE_CODE_STRING.
474 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
475
11a8b164
AB
4762019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
477
478 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
479 of its implementation from...
480 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
481 the new function.
482
5bbd8269
AB
4832019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
484
485 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
486 create a range with stride where appropriate.
487 * f-valprint.c: Include 'gdbarch.h'.
488 (f77_print_array_1): Take the stride into account when walking the
489 array. Also convert the stride into addressable units.
490 * gdbtypes.c (create_range_type): Initialise the stride to
491 constant zero.
492 (create_range_type_with_stride): New function, initialise the
493 range as normal, and then setup the stride.
494 (has_static_range): Include the stride here. Also change the
495 return type to bool.
496 (create_array_type_with_stride): Consider the range stride if the
497 array isn't given its own stride.
498 (resolve_dynamic_range): Resolve the stride if needed.
499 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
500 (struct range_bounds) <flag_is_byte_stride>: New member variable.
501 (TYPE_BIT_STRIDE): Define.
502 (TYPE_ARRAY_BIT_STRIDE): Define.
503 (create_range_type_with_stride): Declare.
504 * valarith.c (value_subscripted_rvalue): Take range stride into
505 account when walking the array.
506
82e3b564
TT
5072019-12-01 Tom Tromey <tom@tromey.com>
508
509 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
510 specially.
511
517d261d
TT
5122019-12-01 Tom Tromey <tom@tromey.com>
513
514 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
515 \0.
516 * unittests/tui-selftests.c: New file.
517 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
518
484c9b64
TT
5192019-12-01 Tom Tromey <tom@tromey.com>
520
521 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
522
a2a7af0c
TT
5232019-12-01 Tom Tromey <tom@tromey.com>
524
525 * NEWS: Document new settings.
526 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
527 * tui/tui-win.c (_initialize_tui_win): Add border style
528 observers.
529 * tui/tui-io.h (tui_apply_style): Declare.
530 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
531 longer static.
532 (apply_ansi_escape, tui_set_reverse_mode): Update.
533 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
534 Add "skip_intensity" parameter.
535 <changed>: New member.
536 <do_set_value>: Declare.
537 (tui_border_style, tui_active_border_style): Declare.
538 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
539 globals.
540 (cli_style_option): Initialize "changed".
541 (cli_style_option::do_set_value): New function.
542 (cli_style_option::add_setshow_commands): Add "skip_intensity"
543 parameter. Update.
544 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
545 (_initialize_cli_style): Update. Create TUI border style
546 commands.
547
d1da6b01
TT
5482019-12-01 Tom Tromey <tom@tromey.com>
549
550 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
551 parameter.
552 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
553 parameter.
554 * tui/tui-win.h (compact_source): Declare.
555 * tui/tui-win.c (compact_source): New global.
556 (tui_set_compact_source, tui_show_compact_source): New functions.
557 (_initialize_tui_win): Add "compact-source" setting.
558 * tui/tui-source.c (tui_source_window::set_contents): Handle
559 compact_source setting.
560 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
561 * NEWS: Document new setting.
562
489dbda6
TT
5632019-11-30 Tom Tromey <tom@tromey.com>
564
565 * dwarf2read.c (dwarf2_add_field): Include field offset when
566 computing variant part length.
567
bf498525
PW
5682019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
569 * NEWS: Mention define-prefix. Tell that command names can now
570 contain a . character.
571
be09caf1
PW
5722019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
573
574 * command.h (valid_cmd_char_p): Declare.
575 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
576 the check of valid command char.
577 (find_command_name_length, valid_user_defined_cmd_name_p): Use
578 valid_cmd_char_p.
579 * cli/cli-script.c (validate_comname): Likewise.
580 * completer.c (gdb_completer_command_word_break_characters):
581 Do not remove . from the word break char, update comments.
582 (complete_line_internal_1): Use valid_cmd_char_p.
583 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
584 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
585
c6ac7fc9
PW
5862019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
587
588 * cli/cli-script.c (do_define_command): Ensure a redefined
589 prefix command is kept as a prefix command.
590 (define_prefix_command): New function.
591 (show_user_1): Report user defined prefixes.
592 (_initialize_cli_script): Create the new 'define-prefix' command.
593 Add completers for 'define' and 'document'.
594 * top.c (execute_command): If command is a user-defined prefix only
595 command, report the list of commands for this prefix command.
596
a992a3b0
TBA
5972019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
598
599 * valops.c (find_oload_champ): Improve debug output.
600
e9194a1a
TBA
6012019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
602
603 * valops.c (find_oload_champ): Print part of debug messages
604 before the badness vector is std::move'd.
605
53a008a6
TT
6062019-11-28 Tom Tromey <tom@tromey.com>
607
608 * value.c (creal_internal_fn): Fix comment.
609
bab05c83
TT
6102019-11-28 Tom Tromey <tom@tromey.com>
611
612 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
613 flag_bound_evaluated>: Now unsigned.
614
2522f049
TT
6152019-11-28 Tom Tromey <tom@tromey.com>
616
617 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
618 declare.
619
38b49e22
MS
6202019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
621
622 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
623 debug output.
624 * jit.c (jit_unregister_code): Add debug print to match
625 `jit_register_code`.
626
35125921
CB
6272019-11-27 Christian Biesinger <cbiesinger@google.com>
628
629 * NEWS: Mention the new multithreaded symbol loading.
630
62e77f56
CB
6312019-11-27 Christian Biesinger <cbiesinger@google.com>
632
633 * maint.c (n_worker_threads): Default to 0.
634 (worker_threads_disabled): New function.
635 * maint.h (worker_threads_disabled): New function.
636 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
637 here if worker_threads_disabled () is true.
638 (minimal_symbol_reader::install): Skip all threading if
639 worker_threads_disabled () is true.
640
f29d7f6b
CB
6412019-11-27 Christian Biesinger <cbiesinger@google.com>
642
643 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
644 hash code if possible.
645 (add_minsym_to_demangled_hash_table): Likewise.
646 (minimal_symbol_reader::install): Compute the hash codes for msymbol
647 on the background thread.
648 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
649 Add these fields.
650
e76b2246
CB
6512019-11-27 Christian Biesinger <cbiesinger@google.com>
652
653 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
654 of the mangled name on the background thread.
655 * symtab.c (symbol_set_names): Allow passing in the hash of the
656 linkage_name.
657 * symtab.h (symbol_set_names): Likewise.
658
8d9a2568
KB
6592019-11-27 Kevin Buettner <kevinb@redhat.com>
660
661 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
662 physnames are computed for inherited DIEs.
663
fad03f6e
TT
6642019-11-27 Tom Tromey <tromey@adacore.com>
665
666 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
667 backslashes.
668 * cp-support.c: Remove unnecessary backslashes.
669
43678b0a
CB
6702019-11-27 Christian Biesinger <cbiesinger@google.com>
671
672 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
673 with sym->set_linkage_name.
674 * coffread.c (coff_read_enum_type): Likewise.
675 * mdebugread.c (parse_symbol): Likewise.
676 * stabsread.c (patch_block_stabs): Likewise.
677 (define_symbol): Likewise.
678 (read_enum_type): Likewise.
679 (common_block_end): Likewise.
680 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
681 function.
682 (SYMBOL_SET_LINKAGE_NAME): Remove.
683 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
684 with sym->set_linkage_name.
685
db5960b4
AB
6862019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
687
688 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
689 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
690 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
691 * NEWS: Mention new MI command.
692
7dc42066
AB
6932019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
694
695 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
696 '-symbol-info-types', and '-symbol-info-variables'.
697 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
698 (mi_cmd_symbol_info_types): Declare.
699 (mi_cmd_symbol_info_variables): Declare.
700 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
701 (output_debug_symbol): New function.
702 (output_nondebug_symbol): New function.
703 (mi_symbol_info): New function.
704 (mi_info_functions_or_variables): New function.
705 (mi_cmd_symbol_info_functions): New function.
706 (mi_cmd_symbol_info_types): New function.
707 (mi_cmd_symbol_info_variables): New function.
708 * NEWS: Mention new commands.
709
5f512a7d
AB
7102019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
711
712 * symtab.c (symbol_to_info_string): New function, most content
713 moved from print_symbol_info, but updated to return a std::string.
714 (print_symbol_info): Update to use symbol_to_info_string and print
715 returned string.
716 * symtab.h (symbol_to_info_string): Declare new function.
717
470c0b1c
AB
7182019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
719
720 * python/python.c (gdbpy_rbreak): Convert to using
721 global_symbol_searcher.
722 * symtab.c (file_matches): Convert return type to bool, change
723 file list to std::vector, update header comment.
724 (search_symbols): Rename to...
725 (global_symbol_searcher::search): ...this and update now its
726 a member function of global_symbol_searcher. Take account of the
727 changes to file_matches.
728 (symtab_symbol_info): Convert to using global_symbol_searcher.
729 (rbreak_command): Likewise.
730 (search_module_symbols): Likewise.
731 * symtab.h (enum symbol_search): Update comment.
732 (search_symbols): Remove declaration.
733 (class global_symbol_searcher): New class.
734
57357d9d
TT
7352019-11-26 Tom Tromey <tromey@adacore.com>
736
737 * cp-support.c (_initialize_cp_support): Conditionally initialize
738 gdb_demangle_attempt_core_dump.
739
3ea16160
TT
7402019-11-26 Tom Tromey <tom@tromey.com>
741
742 * python/py-function.c (fnpy_init): Update.
743 * value.h (add_internal_function): Adjust declaration.
744 * value.c (function_destroyer): Remove.
745 (do_add_internal_function): Don't set destroyer or copy name.
746 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
747 Set name_allocated.
748 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
749 (cmdpy_init): Set name_allocated.
750 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
751 member.
752 (~cmd_list_element): Free "name" if needed.
753
1a6d41c6
TT
7542019-11-26 Tom Tromey <tom@tromey.com>
755
756 * value.h (add_internal_function): Add new overload. Move
757 documentation from value.h.
758 * value.c (do_add_internal_function): New function.
759 (add_internal_function): Use it. Add new overload.
760 (function_destroyer): Don't free doc.
761 * python/py-function.c (fnpy_init): Update.
762
8318f3c3
TT
7632019-11-26 Tom Tromey <tom@tromey.com>
764
765 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
766 (cmdpy_init): Set "doc_allocated".
767
4da8c3a8
TT
7682019-11-26 Tom Tromey <tom@tromey.com>
769
770 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
771 name of worker thread.
772 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
773 pthread_setname_np.
774 * configure, config.in: Rebuild.
775
971db5e2
TT
7762019-11-26 Tom Tromey <tom@tromey.com>
777
778 * python/python.c (class gdbpy_gil): New.
779 (struct gdbpy_event): Add constructor, destructor, operator().
780 (gdbpy_post_event): Use run_on_main_thread.
781 (gdbpy_initialize_events): Remove.
782 (do_start_initialization): Update.
783
22138db6
TT
7842019-11-26 Tom Tromey <tom@tromey.com>
785
786 * NEWS: Add entry.
787 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
788 commands. Call update_thread_pool_size.
789 (update_thread_pool_size, maintenance_set_worker_threads): New
790 functions.
791 (n_worker_threads): New global.
792
d55c9a68
TT
7932019-11-26 Christian Biesinger <cbiesinger@google.com>
794 Tom Tromey <tom@tromey.com>
795
796 * minsyms.c (minimal_symbol_reader::install): Use
797 parallel_for_each.
798 * gdbsupport/parallel-for.h: New file.
799 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
800
a0b57563
CB
8012019-11-26 Christian Biesinger <cbiesinger@google.com>
802 Tom Tromey <tom@tromey.com>
803
804 * gdbsupport/thread-pool.h: New file.
805 * gdbsupport/thread-pool.c: New file.
806 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
807 (HFILES_NO_SRCDIR): Add thread-pool.h.
808
3b3978bc
TT
8092019-11-26 Tom Tromey <tom@tromey.com>
810
811 * event-top.h (thread_local_segv_handler): Declare.
812 * event-top.c (thread_local_segv_handler): New global.
813 (install_handle_sigsegv, handle_sigsegv): New functions.
814 (async_init_signals): Install SIGSEGV handler.
815 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
816 thread-local.
817 (report_failed_demangle): New function.
818 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
819 handler-setting code, instead use segv_handler. Run warning code
820 on main thread.
821
9411c49e
TT
8222019-11-26 Tom Tromey <tom@tromey.com>
823
824 * run-on-main-thread.c: New file.
825 * run-on-main-thread.h: New file.
826 * unittests/main-thread-selftests.c: New file.
827 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
828 main-thread-selftests.c.
829 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
830 (COMMON_SFILES): Add run-on-main-thread.c.
831
c3efb965
TT
8322019-11-26 Tom Tromey <tom@tromey.com>
833
834 * main.c (setup_alternate_signal_stack): Remove.
835 (captured_main_1): Use gdb::alternate_signal_stack.
836 * gdbsupport/alt-stack.h: New file.
837
21987b9c
TT
8382019-11-26 Tom Tromey <tom@tromey.com>
839
840 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
841 Remove comment.
842 (save_original_signals_state, restore_original_signals_state): Use
843 gdb_sigmask.
844 * linux-nat.c (block_child_signals, restore_child_signals_mask)
845 (_initialize_linux_nat): Use gdb_sigmask.
846 * guile/guile.c (_initialize_guile): Use block_signals.
847 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
848 * gdbsupport/gdb-sigmask.h: New file.
849 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
850 * cp-support.c (gdb_demangle): Use gdb_sigmask.
851 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
852 pthread_sigmask.
853 * configure, config.in: Rebuild.
854 * gdbsupport/block-signals.h: New file.
855
5e030278
TT
8562019-11-26 Tom Tromey <tom@tromey.com>
857
858 * acinclude.m4: Include ax_pthread.m4.
859 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
860 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
861 (CLIBS): Use PTHREAD_LIBS.
862 (aclocal_m4_deps): Add ax_pthread.m4.
863 * config.in, configure: Rebuild.
864 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
865
5a79c107
TT
8662019-11-26 Tom Tromey <tom@tromey.com>
867
868 * symtab.h (struct minimal_symbol) <name_set>: New member.
869 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
870 Don't call symbol_set_names.
871 (minimal_symbol_reader::install): Call symbol_set_names.
872
aa369509
PW
8732019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
874
875 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
876 restore_active_ext_lang, as GIL is needed for (indirectly)
877 called PyOS_InterruptOccurred.
878
cadc9cb8
SM
8792019-11-26 Simon Marchi <simon.marchi@efficios.com>
880
881 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
882 definition.
883
d04afd58
SM
8842019-11-26 Simon Marchi <simon.marchi@efficios.com>
885
886 * remote-sim.c (simulator_command): Make static, remove
887 declaration.
888
dd694d77
SM
8892019-11-26 Simon Marchi <simon.marchi@efficios.com>
890
891 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
892 static.
893 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
894 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
895 (main): Likewise.
896 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
897 (main): Likewise.
898 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
899 (main): Likewise.
900 * unittests/basic_string_view/element_access/char/1.cc (test01):
901 Likewise.
902 (main): Likewise.
903 * unittests/basic_string_view/element_access/char/empty.cc (main):
904 Likewise.
905 * unittests/basic_string_view/element_access/char/front_back.cc
906 (test01): Likewise.
907 (main): Likewise.
908 * unittests/basic_string_view/inserters/char/2.cc (test05):
909 Likewise.
910 (main): Likewise.
911 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
912 (test01): Likewise.
913 (main): Likewise.
914 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
915 (test01): Likewise.
916 (main): Likewise.
917 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
918 Likewise.
919 * unittests/basic_string_view/operations/compare/char/1.cc
920 (test01): Likewise.
921 (main): Likewise.
922 * unittests/basic_string_view/operations/compare/char/13650.cc
923 (test01): Likewise.
924 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
925 Likewise.
926 (main): Likewise.
927 * unittests/basic_string_view/operations/data/char/1.cc (test01):
928 Likewise.
929 (main): Likewise.
930 * unittests/basic_string_view/operations/find/char/1.cc (test01):
931 Likewise.
932 (main): Likewise.
933 * unittests/basic_string_view/operations/find/char/2.cc (test02):
934 Likewise.
935 (main): Likewise.
936 * unittests/basic_string_view/operations/find/char/3.cc (test03):
937 Likewise.
938 (main): Likewise.
939 * unittests/basic_string_view/operations/find/char/4.cc (main):
940 Likewise.
941 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
942 Likewise.
943 (main): Likewise.
944 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
945 Likewise.
946 (main): Likewise.
947 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
948 Likewise.
949 (main): Likewise.
950 * unittests/basic_string_view/operations/substr/char/1.cc
951 (test01): Likewise.
952 (main): Likewise.
953 * unittests/basic_string_view/operators/char/2.cc (main):
954 Likewise.
955 * unittests/optional/assignment/1.cc (test): Likewise.
956 * unittests/optional/assignment/2.cc (test): Likewise.
957 * unittests/optional/assignment/3.cc (test): Likewise.
958 * unittests/optional/assignment/4.cc (test): Likewise.
959 * unittests/optional/assignment/5.cc (test): Likewise.
960 * unittests/optional/assignment/6.cc (test): Likewise.
961 * unittests/optional/assignment/7.cc (test): Likewise.
962 * unittests/optional/cons/copy.cc (test): Likewise.
963 * unittests/optional/cons/default.cc (test): Likewise.
964 * unittests/optional/cons/move.cc (test): Likewise.
965 * unittests/optional/cons/value.cc (test): Likewise.
966 * unittests/optional/in_place.cc (test): Likewise.
967 * unittests/optional/observers/1.cc (test): Likewise.
968 * unittests/optional/observers/2.cc (test): Likewise.
969
3b5c1d49
SM
9702019-11-26 Simon Marchi <simon.marchi@efficios.com>
971
972 * tui-win.h (tui_set_var_cmd): Remove.
973 * tui-win.c (tui_set_var_cmd): Make static.
974
adce99fe
SM
9752019-11-26 Simon Marchi <simon.marchi@efficios.com>
976
977 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
978 rbreak_command_wrapper): Remove.
979 * symtab.c (rbreak_command_wrapper): Remove.
980
fe3adccf
SM
9812019-11-26 Simon Marchi <simon.marchi@efficios.com>
982
983 * inferior.h (info_terminal_command): Remove declaration.
984 * inflow.c (info_terminal_command): Make static.
985
b926335f
SM
9862019-11-26 Simon Marchi <simon.marchi@efficios.com>
987
988 * inferior.c (exit_inferior_silent): Remove.
989
b62f6f54
SM
9902019-11-26 Simon Marchi <simon.marchi@efficios.com>
991
992 * dictionary.c (dict_empty, mdict_empty): Remove.
993 * dictionary.c (mdict_empty): Remove.
994
cb8c24b6
SM
9952019-11-26 Simon Marchi <simon.marchi@efficios.com>
996
997 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
998 (arc_insn_get_memory_offset): Likewise.
999 (arc_insn_dump): Likewise.
1000 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1001 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1002 * dictionary.c (dict_iterator_next): Likewise.
1003 (dict_iter_match_first): Likewise.
1004 (dict_iter_match_next): Likewise.
1005 * f-lang.c (evaluate_subexp_f): Likewise.
1006 * hppa-tdep.c (hppa_read_pc): Likewise.
1007 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1008 * parse.c (write_exp_elt_msym): Likewise.
1009 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1010 * remote.c (remote_packet_size): Likewise.
1011 (remote_notif_stop_parse): Likewise.
1012 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1013 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1014 * source.c (prepare_path_for_appending): Likewise.
1015 * sparc64-linux-tdep.c
1016 (sparc64_linux_handle_segmentation_fault); Likewise.
1017 * stack.c (frame_selection_by_function_completer): Likewise.
1018
781597ff
SM
10192019-11-26 Simon Marchi <simon.marchi@efficios.com>
1020
1021 * completer.c (set_gdb_completion_word_break_characters):
1022 Remove.
1023
23baa4cc
SM
10242019-11-26 Simon Marchi <simon.marchi@efficios.com>
1025
1026 * dwarf-index-write.c: Include dwarf-index-write.h.
1027 * mi/mi-interp.c: Include mi/mi-interp.h.
1028
23767560
SM
10292019-11-26 Simon Marchi <simon.marchi@efficios.com>
1030
1031 * aarch32-tdep.c: Include aarch32-tdep.h.
1032 * aarch32-tdep.h: Forward-declare struct target_desc.
1033
6d91ce9a
CB
10342019-11-26 Christian Biesinger <cbiesinger@google.com>
1035
1036 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1037 strerror.
1038 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1039 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1040
3cf2f237
TV
10412019-11-25 Tom de Vries <tdevries@suse.de>
1042
1043 * contrib/words.sh: Add -c option.
1044
5b89c67a
CB
10452019-11-25 Christian Biesinger <cbiesinger@google.com>
1046
1047 * solib.c (solib_find_1): Change int to bool.
1048 (exec_file_find): Change int to bool.
1049 (solib_find): Change int to bool.
1050 (solib_read_symbols): Change int to bool.
1051 (solib_used): Change int to bool.
1052 (solib_add): Change int to bool.
1053 (info_sharedlibrary_command): Change int to bool.
1054 (solib_contains_address_p): Change int to bool.
1055 (solib_keep_data_in_core): Change int to bool.
1056 (in_solib_dynsym_resolve_code): Change int to bool.
1057 (reload_shared_libraries_1): Change int to bool.
1058 (gdb_sysroot_changed): Change int to bool.
1059 * solib.h (solib_read_symbols): Change int to bool.
1060 (solib_contains_address_p): Change int to bool.
1061 (solib_keep_data_in_core): Change int to bool.
1062 (in_solib_dynsym_resolve_code): Change int to bool.
1063 (libpthread_name_p): Change int to bool.
1064
6cc8564b
LM
10652019-11-25 Luis Machado <luis.machado@linaro.org>
1066
1067 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1068 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1069 (remote_packet_max_chars): New static global.
1070 (show_remote_packet_max_chars): New function.
1071 (remote_target::putpkt_binary): Adjust to use new
1072 remote_packet_max_chars option.
1073 (remote_target::getpkt_or_notif_sane_1): Likewise.
1074 (_initialize_remote): Register new remote-packet-max-chars option.
1075
a7cdaa91
SM
10762019-11-24 Simon Marchi <simon.marchi@efficios.com>
1077
1078 * m68k-linux-nat.c: Include gdbarch.h.
1079
26abc753
TT
10802019-11-24 Tom Tromey <tom@tromey.com>
1081
1082 * symfile.c (read_symbols): Update.
1083 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1084 bool.
1085 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1086 (psym_lookup_symbol, psym_find_last_source_symtab)
1087 (psym_forget_cached_source_info, psym_print_stats)
1088 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1089 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1090 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1091 (psym_find_compunit_symtab_by_address)
1092 (maintenance_print_psymbols, maintenance_info_psymtabs)
1093 (maintenance_check_psymtabs): Update.
1094 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1095 bool.
1096
012fc909
TT
10972019-11-22 Tom Tromey <tom@tromey.com>
1098
1099 * observable.h: Update comments.
1100
c83d8d32
TT
11012019-11-22 Tom Tromey <tromey@adacore.com>
1102
1103 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1104 (print_ada_task_info): Don't try to fetch thread id if task is not
1105 alive.
1106
987012b8
CB
11072019-11-22 Christian Biesinger <cbiesinger@google.com>
1108
1109 * ada-exp.y: Update.
1110 * ada-lang.c (sort_choices): Update.
1111 (ada_print_symbol_signature): Update.
1112 (resolve_subexp): Update.
1113 (ada_parse_renaming): Update.
1114 (ada_read_renaming_var_value): Update.
1115 (lesseq_defined_than): Update.
1116 (remove_extra_symbols): Update.
1117 (remove_irrelevant_renamings): Update.
1118 (ada_add_block_symbols): Update.
1119 (ada_collect_symbol_completion_matches): Update.
1120 (ada_is_renaming_symbol): Update.
1121 (aggregate_assign_from_choices): Update.
1122 (ada_evaluate_subexp): Update.
1123 (ada_has_this_exception_support): Update.
1124 (ada_is_non_standard_exception_sym): Update.
1125 (ada_add_exceptions_from_frame): Update.
1126 (ada_add_global_exceptions): Update.
1127 (ada_print_subexp): Update.
1128 * ax-gdb.c (gen_var_ref): Update.
1129 (gen_maybe_namespace_elt): Update.
1130 (gen_expr_for_cast): Update.
1131 (gen_expr): Update.
1132 * block.h: Update.
1133 * blockframe.c (find_pc_partial_function): Update.
1134 * breakpoint.c (print_breakpoint_location): Update.
1135 (update_static_tracepoint): Update.
1136 * btrace.c (ftrace_print_function_name): Update.
1137 (ftrace_function_switched): Update.
1138 * buildsym.c (find_symbol_in_list): Update.
1139 * c-exp.y: Update.
1140 * c-typeprint.c (c_print_typedef): Update.
1141 (c_type_print_template_args): Update.
1142 * cli/cli-cmds.c (edit_command): Update.
1143 (list_command): Update.
1144 (print_sal_location): Update.
1145 * coffread.c (patch_opaque_types): Update.
1146 (process_coff_symbol): Update.
1147 (coff_read_enum_type): Update.
1148 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1149 (convert_one_symbol): Update.
1150 (hash_symname): Update.
1151 (eq_symname): Update.
1152 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1153 * compile/compile-cplus-types.c (debug_print_scope): Update.
1154 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1155 * compile/compile-object-load.c (get_out_value_type): Update.
1156 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1157 (search_symbol_list): Update.
1158 (cp_lookup_symbol_imports_or_template): Update.
1159 * cp-support.c (overload_list_add_symbol): Update.
1160 * ctfread.c (psymtab_to_symtab): Update.
1161 * dbxread.c (cp_set_block_scope): Update.
1162 * dictionary.c (iter_match_first_hashed): Update.
1163 (iter_match_next_hashed): Update.
1164 (insert_symbol_hashed): Update.
1165 (iter_match_next_linear): Update.
1166 * dictionary.h: Update.
1167 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1168 (locexpr_describe_location_piece): Update.
1169 (locexpr_describe_location_1): Update.
1170 (locexpr_generate_c_location): Update.
1171 (loclist_describe_location): Update.
1172 (loclist_generate_c_location): Update.
1173 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1174 (read_func_scope): Update.
1175 (process_enumeration_scope): Update.
1176 (new_symbol): Update.
1177 (dwarf2_const_value): Update.
1178 (dwarf2_symbol_mark_computed): Update.
1179 * eval.c (evaluate_funcall): Update.
1180 (evaluate_subexp_standard): Update.
1181 * expprint.c (print_subexp_standard): Update.
1182 (dump_subexp_body_standard): Update.
1183 * f-valprint.c (info_common_command_for_block): Update.
1184 * findvar.c (get_hosting_frame): Update.
1185 (default_read_var_value): Update.
1186 * go-lang.c (go_symbol_package_name): Update.
1187 * guile/scm-block.c (bkscm_print_block_smob): Update.
1188 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1189 (gdbscm_symbol_name): Update.
1190 (gdbscm_symbol_linkage_name): Update.
1191 (gdbscm_symbol_print_name): Update.
1192 * infcall.c (get_function_name): Update.
1193 * infcmd.c (jump_command): Update.
1194 (finish_command): Update.
1195 * infrun.c (insert_exception_resume_breakpoint): Update.
1196 * linespec.c (canonicalize_linespec): Update.
1197 (create_sals_line_offset): Update.
1198 (convert_linespec_to_sals): Update.
1199 (complete_label): Update.
1200 (find_label_symbols_in_block): Update.
1201 * m2-typeprint.c (m2_print_typedef): Update.
1202 * mdebugread.c (mdebug_reg_to_regnum): Update.
1203 (parse_symbol): Update.
1204 (mylookup_symbol): Update.
1205 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1206 (list_args_or_locals): Update.
1207 * objc-lang.c (compare_selectors): Update.
1208 (info_selectors_command): Update.
1209 (compare_classes): Update.
1210 (info_classes_command): Update.
1211 (find_imps): Update.
1212 * p-typeprint.c (pascal_print_typedef): Update.
1213 * printcmd.c (build_address_symbolic): Update.
1214 (info_address_command): Update.
1215 (print_variable_and_value): Update.
1216 * python/py-framefilter.c (extract_sym): Update.
1217 (py_print_single_arg): Update.
1218 * python/py-symbol.c (sympy_str): Update.
1219 (sympy_get_name): Update.
1220 (sympy_get_linkage_name): Update.
1221 * python/python.c (gdbpy_rbreak): Update.
1222 * record-btrace.c (btrace_get_bfun_name): Update.
1223 (btrace_call_history): Update.
1224 * rust-lang.c (rust_print_typedef): Update.
1225 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1226 * stabsread.c (stab_reg_to_regnum): Update.
1227 (define_symbol): Update.
1228 (read_enum_type): Update.
1229 (common_block_end): Update.
1230 (cleanup_undefined_types_1): Update.
1231 (scan_file_globals): Update.
1232 * stack.c (print_frame_arg): Update.
1233 (print_frame_args): Update.
1234 (find_frame_funname): Update.
1235 (info_frame_command_core): Update.
1236 (iterate_over_block_locals): Update.
1237 (print_block_frame_labels): Update.
1238 (do_print_variable_and_value): Update.
1239 (iterate_over_block_arg_vars): Update.
1240 (return_command): Update.
1241 * symmisc.c (dump_symtab_1): Update.
1242 (print_symbol): Update.
1243 * symtab.c (eq_symbol_entry): Update.
1244 (symbol_cache_dump): Update.
1245 (lookup_language_this): Update.
1246 (find_pc_sect_line): Update.
1247 (skip_prologue_sal): Update.
1248 (symbol_search::compare_search_syms): Update.
1249 (treg_matches_sym_type_name): Update.
1250 (search_symbols): Update.
1251 (print_symbol_info): Update.
1252 (rbreak_command): Update.
1253 (completion_list_add_symbol): Update.
1254 (find_gnu_ifunc): Update.
1255 (get_symbol_address): Update.
1256 (search_module_symbols): Update.
1257 (info_module_subcommand): Update.
1258 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1259 (SYMBOL_LINKAGE_NAME): Remove.
1260 (SYMBOL_DEMANGLED_NAME): Remove.
1261 (SYMBOL_PRINT_NAME): Remove.
1262 (SYMBOL_SEARCH_NAME): Remove.
1263 * tracepoint.c (set_traceframe_context): Update.
1264 (validate_actionline): Update.
1265 (collection_list::collect_symbol): Update.
1266 (encode_actions_1): Update.
1267 (info_scope_command): Update.
1268 (print_one_static_tracepoint_marker): Update.
1269 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1270 * valops.c (address_of_variable): Update.
1271 (find_overload_match): Update.
1272 (find_oload_champ): Update.
1273
c9d95fa3
CB
12742019-11-22 Christian Biesinger <cbiesinger@google.com>
1275
1276 * ada-lang.c (ada_lookup_simple_minsym): Update.
1277 (ada_collect_symbol_completion_matches): Update.
1278 * ada-tasks.c (read_atcb): Update.
1279 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1280 (amd64_windows_skip_trampoline_code): Update.
1281 * arm-tdep.c (skip_prologue_function): Update.
1282 (arm_skip_stack_protector): Update.
1283 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1284 (arm_wince_skip_main_prologue): Update.
1285 * ax-gdb.c (gen_expr): Update.
1286 * block.c (call_site_for_pc): Update.
1287 * blockframe.c (find_pc_partial_function): Update.
1288 * breakpoint.c (set_breakpoint_location_function): Update.
1289 * btrace.c (ftrace_print_function_name): Update.
1290 (ftrace_function_switched): Update.
1291 * c-valprint.c (print_unpacked_pointer): Update.
1292 * coffread.c (coff_symfile_read): Update.
1293 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1294 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1295 * dwarf-index-write.c (write_psymbols): Update.
1296 * dwarf2loc.c (call_site_to_target_addr): Update.
1297 (func_verify_no_selftailcall): Update.
1298 (tailcall_dump): Update.
1299 (call_site_find_chain_1): Update.
1300 (dwarf_expr_reg_to_entry_parameter): Update.
1301 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1302 * eval.c (evaluate_funcall): Update.
1303 (evaluate_subexp_standard): Update.
1304 (evaluate_subexp_for_sizeof): Update.
1305 * expprint.c (print_subexp_standard): Update.
1306 (dump_subexp_body_standard): Update.
1307 * frame.c (get_prev_frame_always_1): Update.
1308 * frv-tdep.c (frv_skip_main_prologue): Update.
1309 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1310 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1311 (gnuv3_get_typename_from_type_info): Update.
1312 (gnuv3_skip_trampoline): Update.
1313 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1314 * i386-tdep.c (i386_skip_main_prologue): Update.
1315 (i386_pe_skip_trampoline_code): Update.
1316 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1317 * infcall.c (get_function_name): Update.
1318 * linespec.c (minsym_found): Update.
1319 * linux-fork.c (info_checkpoints_command): Update.
1320 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1321 (m32c_m16c_pointer_to_address): Update.
1322 * maint.c (maintenance_translate_address): Update.
1323 * minsyms.c (add_minsym_to_hash_table): Update.
1324 (add_minsym_to_demangled_hash_table): Update.
1325 (lookup_minimal_symbol_mangled): Update.
1326 (lookup_minimal_symbol_demangled): Update.
1327 (lookup_minimal_symbol_linkage): Update.
1328 (lookup_minimal_symbol_text): Update.
1329 (lookup_minimal_symbol_by_pc_name): Update.
1330 (minimal_symbol_is_less_than): Update.
1331 (compact_minimal_symbols): Update.
1332 (build_minimal_symbol_hash_tables): Update.
1333 (find_solib_trampoline_target): Update.
1334 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1335 (mips_skip_pic_trampoline_code): Update.
1336 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1337 * objc-lang.c (info_selectors_command): Update.
1338 (info_classes_command): Update.
1339 (find_methods): Update.
1340 (find_imps): Update.
1341 * p-valprint.c (pascal_val_print): Update.
1342 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1343 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1344 * printcmd.c (build_address_symbolic): Update.
1345 (info_symbol_command): Update.
1346 * psymtab.c (psymbol_name_matches): Update.
1347 (match_partial_symbol): Update.
1348 (lookup_partial_symbol): Update.
1349 (print_partial_symbols): Update.
1350 (sort_pst_symbols): Update.
1351 (maintenance_check_psymtabs): Update.
1352 * python/py-framefilter.c (py_print_frame): Update.
1353 * python/python.c (gdbpy_rbreak): Update.
1354 * record-btrace.c (btrace_get_bfun_name): Update.
1355 (btrace_call_history): Update.
1356 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1357 (rs6000_skip_trampoline_code): Update.
1358 * sol-thread.c (info_cb): Update.
1359 * stabsread.c (scan_file_globals): Update.
1360 * stack.c (find_frame_funname): Update.
1361 (info_frame_command_core): Update.
1362 * symmisc.c (dump_msymbols): Update.
1363 * symtab.c (symbol_natural_name): Rename to..,
1364 (general_symbol_info::natural_name): ...this.
1365 (symbol_demangled_name): Rename to...
1366 (general_symbol_info::demangled_name): ...this.
1367 (symbol_search_name): Rename to...
1368 (general_symbol_info::search_name): ...this.
1369 (symbol_matches_search_name): Update.
1370 (find_pc_sect_line): Update.
1371 (skip_prologue_sal): Update.
1372 (search_symbols): Update.
1373 (print_msymbol_info): Update.
1374 (rbreak_command): Update.
1375 (completion_list_add_msymbol): Update.
1376 (completion_list_objc_symbol): Update.
1377 (get_msymbol_address): Update.
1378 * symtab.h (struct general_symbol_info): Add member functions
1379 natural_name (), linkage_name (), print_name (), demangled_name (),
1380 and search_name ().
1381 (SYMBOL_NATURAL_NAME): Update.
1382 (symbol_natural_name): Move to a member function on general_symbol_info.
1383 (SYMBOL_DEMANGLED_NAME): Update.
1384 (symbol_demangled_name): Move to a member function on
1385 general_symbol_info.
1386 (SYMBOL_SEARCH_NAME): Update.
1387 (symbol_search_name): Move to a member function on general_symbol_info.
1388 (MSYMBOL_NATURAL_NAME): Remove.
1389 (MSYMBOL_LINKAGE_NAME): Remove.
1390 (MSYMBOL_PRINT_NAME): Remove.
1391 (MSYMBOL_DEMANGLED_NAME): Remove.
1392 (MSYMBOL_SEARCH_NAME): Remove.
1393 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1394
f8bab2d6
CB
13952019-11-22 Christian Biesinger <cbiesinger@google.com>
1396
1397 * symtab.c (create_demangled_names_hash): Use per_bfd->
1398 minimal_symbol_count for computing the initial size, if greater
1399 than our default size.
1400
85e7588d
TV
14012019-11-22 Tom de Vries <tdevries@suse.de>
1402
1403 * contrib/words.sh: Improve words extraction.
1404
f6180073
TV
14052019-11-22 Tom de Vries <tdevries@suse.de>
1406
1407 * contrib/words.sh: Combine sed invocations.
1408
f10ffa41
CB
14092019-11-21 Christian Biesinger <cbiesinger@google.com>
1410
1411 * Makefile.in: Update.
1412 * demangle.c: Rename to...
1413 * gdb-demangle.c: ..this.
1414 (is_cplus_marker): Change return type to bool.
1415 (_initialize_demangler): Rename to...
1416 (_initialize_gdb_demangle): ...this.
1417 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1418 * symtab.h (demangle): Remove declaration; instead include
1419 gdb-demangle.h.
1420
6ba18521
TT
14212019-11-21 Tom Tromey <tromey@adacore.com>
1422
1423 * gdbsupport/format.c (format_pieces): Parse %I64d.
1424 * unittests/format_pieces-selftests.c (test_windows_formats): New
1425 function.
1426 (run_tests): Call it.
1427
34877895
PJ
14282019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1429
1430 Byte reverse display of variables with DW_END_big, DW_END_little
1431 (DW_AT_endianity) dwarf attributes if different than the native
1432 byte order.
1433 * ada-lang.c (ada_value_binop):
1434 Use type_byte_order instead of gdbarch_byte_order.
1435 * ada-valprint.c (printstr):
1436 (ada_val_print_string):
1437 * ada-lang.c (value_pointer):
1438 (ada_value_binop):
1439 Use type_byte_order instead of gdbarch_byte_order.
1440 * c-lang.c (c_get_string):
1441 Use type_byte_order instead of gdbarch_byte_order.
1442 * c-valprint.c (c_val_print_array):
1443 Use type_byte_order instead of gdbarch_byte_order.
1444 * cp-valprint.c (cp_print_class_member):
1445 Use type_byte_order instead of gdbarch_byte_order.
1446 * dwarf2loc.c (rw_pieced_value):
1447 Use type_byte_order instead of gdbarch_byte_order.
1448 * dwarf2read.c (read_base_type): Handle DW_END_big,
1449 DW_END_little
1450 * f-lang.c (f_get_encoding):
1451 Use type_byte_order instead of gdbarch_byte_order.
1452 * findvar.c (default_read_var_value):
1453 Use type_byte_order instead of gdbarch_byte_order.
1454 * gdbtypes.c (check_types_equal):
1455 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1456 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1457 and TYPE_ENDIANITY_LITTLE if set.
1458 (type_byte_order): new function.
1459 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1460 (struct main_type) <flag_endianity_not_default>:
1461 New field.
1462 (type_byte_order): New function.
1463 * infcmd.c (default_print_one_register_info):
1464 Use type_byte_order instead of gdbarch_byte_order.
1465 * p-lang.c (pascal_printstr):
1466 Use type_byte_order instead of gdbarch_byte_order.
1467 * p-valprint.c (pascal_val_print):
1468 Use type_byte_order instead of gdbarch_byte_order.
1469 * printcmd.c (print_scalar_formatted):
1470 Use type_byte_order instead of gdbarch_byte_order.
1471 * solib-darwin.c (darwin_current_sos):
1472 Use type_byte_order instead of gdbarch_byte_order.
1473 * solib-svr4.c (solib_svr4_r_ldsomap):
1474 Use type_byte_order instead of gdbarch_byte_order.
1475 * stap-probe.c (stap_modify_semaphore):
1476 Use type_byte_order instead of gdbarch_byte_order.
1477 * target-float.c (target_float_same_format_p):
1478 Use type_byte_order instead of gdbarch_byte_order.
1479 * valarith.c (scalar_binop):
1480 (value_bit_index):
1481 Use type_byte_order instead of gdbarch_byte_order.
1482 * valops.c (value_cast):
1483 Use type_byte_order instead of gdbarch_byte_order.
1484 * valprint.c (generic_emit_char):
1485 (generic_printstr):
1486 (val_print_string):
1487 Use type_byte_order instead of gdbarch_byte_order.
1488 * value.c (unpack_long):
1489 (unpack_bits_as_long):
1490 (unpack_value_bitfield):
1491 (modify_field):
1492 (pack_long):
1493 (pack_unsigned_long):
1494 Use type_byte_order instead of gdbarch_byte_order.
1495 * findvar.c (unsigned_pointer_to_address):
1496 (signed_pointer_to_address):
1497 (unsigned_address_to_pointer):
1498 (address_to_signed_pointer):
1499 (default_read_var_value):
1500 (default_value_from_register):
1501 Use type_byte_order instead of gdbarch_byte_order.
1502 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1503 Use type_byte_order instead of gdbarch_byte_order.
1504 * riscv-tdep.c (riscv_print_one_register_info):
1505 Use type_byte_order instead of gdbarch_byte_order.
1506
87fb00ea
SM
15072019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1508
1509 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1510 (current_ui_gdb_stdin_ptr): Likewise.
1511 (current_ui_gdb_stderr_ptr): Likewise.
1512 (current_ui_gdb_stdlog_ptr): Likewise.
1513 (current_ui_current_uiout_ptr): Likewise.
1514 (gen_ret_current_ui_field_ptr): Remove.
1515
65d1cd5f
TV
15162019-11-21 Tom de Vries <tdevries@suse.de>
1517
1518 PR gdb/24956
1519 * cli/cli-script.c (execute_control_command): Only switch to
1520 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1521
9f6ad286
TT
15222019-11-19 Tom Tromey <tom@tromey.com>
1523
1524 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1525 Now static. Change type of "name".
1526 (tui_set_win_height_command): Don't copy "arg".
1527 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1528 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1529
435d3d88
AT
15302019-11-19 Ali Tamur <tamur@google.com>
1531
1532 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1533 "if (attr != nullptr)".
1534 (dwarf2_find_base_address): Likewise.
1535 (dwarf2_build_include_psymtabs): Likewise.
1536 (read_cutu_die_from_dwo): Likewise.
1537 (read_func_scope): Likewise.
1538 (read_call_site_scope): Likewise.
1539 (dwarf2_get_pc_bounds): Likewise.
1540 (dwarf2_record_block_ranges): Likewise.
1541 (dwarf2_add_field): Likewise.
1542 (dwarf2_add_member_fn): Likewise.
1543 (read_structure_type): Likewise.
1544 (read_enumeration_type): Likewise.
1545 (read_array_type): Likewise.
1546 (read_array_order): Likewise.
1547 (read_set_type): Likewise.
1548 (read_common_block): Likewise.
1549 (read_tag_reference_type): Likewise.
1550 (read_tag_string_type): Likewise.
1551 (read_subroutine_type): Likewise.
1552 (read_base_type): Likewise.
1553 (read_subrange_type): Likewise.
1554 (new_symbol): Likewise.
1555 (prepare_one_comp_unit): Likewise.
1556
c9739b6a
TT
15572019-11-19 Tom Tromey <tromey@adacore.com>
1558
1559 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1560 result in error when DebugActiveProcess fails.
1561
494409bb
SDJ
15622019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1563 Pedro Alves <palves@redhat.com>
1564
1565 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1566 * target.c (target_stack::push): Call 'unpush' if there's a
1567 target on top of the stack.
1568
2e953aca
PW
15692019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1570
1571 * python/py-block.c (blpy_dealloc): Call tp_free.
1572 (blpy_block_syms_dealloc): Likewise.
1573 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1574 * python/py-inferior.c (infpy_dealloc): Likewise.
1575 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1576 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1577 * python/py-symbol.c (sympy_dealloc): Likewise.
1578 * python/py-symtab.c (stpy_dealloc): Likewise.
1579 * python/py-type.c (typy_iterator_dealloc): Likewise.
1580
6edc43ec
CB
15812019-11-18 Christian Biesinger <cbiesinger@google.com>
1582
1583 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1584 constructor instead of using a class initializer.
1585
cd850b40
CB
15862019-11-15 Christian Biesinger <cbiesinger@google.com>
1587
1588 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1589 * configure: Regenerate.
1590 * configure.ac: Don't source common.host.
1591 * gdbsupport/common.host: Remove.
1592 * gdbsupport/mingw-strerror.c: Remove.
1593 * gdbsupport/posix-strerror.c: Rename to...
1594 * gdbsupport/safe-strerror.c: ...this.
1595
53fea9c7
CB
15962019-11-15 Christian Biesinger <cbiesinger@google.com>
1597
1598 * maint.c (scoped_command_stats::print_time): Use localtime_r
1599 instead of localtime (provided through gnulib if necessary).
1600 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1601 of ctime.
1602
f8e27d88
CB
16032019-11-15 Christian Biesinger <cbiesinger@google.com>
1604
1605 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1606 avoid compile errors.
1607
5abebf3c
CB
16082019-11-15 Christian Biesinger <cbiesinger@google.com>
1609
1610 * config.in: Regenerate.
1611 * configure: Regenerate.
1612 * gdbsupport/common.m4: No longer check for strerror_r.
1613 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1614 POSIX version of strerror_r, now that gnulib provides it if
1615 necessary.
1616
9a351667
CB
16172019-11-14 Christian Biesinger <cbiesinger@google.com>
1618
1619 * README (`configure' options): Update.
1620
55708e99
TT
16212019-11-14 Tom Tromey <tromey@adacore.com>
1622
1623 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1624 expected type for the RHS if the LHS is a convenience variable.
1625
4b09bb2e
SM
16262019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1627
1628 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1629 Provide explicit default and copy constructor.
1630
bd454f8b
PW
16312019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1632
1633 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1634 only call Py_INCREF (newbp) in the bppy_pending_object case.
1635
d1aa3cf0
TT
16362019-11-13 Tom Tromey <tromey@adacore.com>
1637
1638 PR build/25182:
1639 * psympriv.h (partial_symbol): Remove static assert.
1640 * symtab.h (general_symbol_info, symbol): Remove static assert.
1641
e06f3d6e
AB
16422019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1643
1644 * gdbsupport/format.c (format_pieces::format_pieces): Support
1645 printf 'z' size modifier.
1646 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1647 * printcmd.c (ui_printf): Handle size_t_arg.
1648 * ui-out.c (ui_out::vmessage): Likewise.
1649 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1650 function.
1651 (run_tests): Call test_format_int_sizes.
1652
468c0cbb
CB
16532019-11-12 Christian Biesinger <cbiesinger@google.com>
1654
1655 * ada-exp.y (write_ambiguous_var): Update.
1656 * buildsym.c (add_symbol_to_list): Update.
1657 * dwarf2read.c (read_variable): Update.
1658 (new_symbol): Update.
1659 * jit.c (finalize_symtab): Update.
1660 * language.c (language_alloc_type_symbol): Update.
1661 * symtab.c (fixup_symbol_section): Update.
1662 (initialize_objfile_symbol_1): Move code to...
1663 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1664 (allocate_symbol): Update.
1665 (allocate_template_symbol): Update.
1666 (get_symbol_address): Update.
1667 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1668 of having as a field, and add a constructor.
1669 (SYMBOL_VALUE): Update.
1670 (SYMBOL_VALUE_ADDRESS): Update.
1671 (SET_SYMBOL_VALUE_ADDRESS): Update.
1672 (SYMBOL_VALUE_BYTES): Update.
1673 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1674 (SYMBOL_BLOCK_VALUE): Update.
1675 (SYMBOL_VALUE_CHAIN): Update.
1676 (SYMBOL_LANGUAGE): Update.
1677 (SYMBOL_SECTION): Update.
1678 (SYMBOL_OBJ_SECTION): Update.
1679 (SYMBOL_SET_LANGUAGE): Update.
1680 (SYMBOL_SET_LINKAGE_NAME): Update.
1681 (SYMBOL_SET_NAMES): Update.
1682 (SYMBOL_NATURAL_NAME): Update.
1683 (SYMBOL_LINKAGE_NAME): Update.
1684 (SYMBOL_DEMANGLED_NAME): Update.
1685 (SYMBOL_SEARCH_NAME): Update.
1686 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1687 (struct symbol): Update.
1688 (struct template_symbol): Update.
1689 (struct rust_vtable_symbol): Update.
1690 * xcoffread.c (SYMBOL_DUP): Update.
1691
ed2c82c3
TT
16922019-11-12 Tom Tromey <tom@tromey.com>
1693
1694 * tui/tui-layout.c (show_layout): Set current_layout.
1695 (show_source_disasm_command, show_data)
1696 (show_source_or_disasm_and_command): Don't set current_layout.
1697
d9fcefd5
TT
16982019-11-12 Tom Tromey <tom@tromey.com>
1699
1700 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1701
45e42163
TT
17022019-11-12 Tom Tromey <tom@tromey.com>
1703
1704 * tui/tui-win.c (resize_message): New global.
1705 (show_tui_resize_message): New function.
1706 (tui_async_resize_screen): Print message if requested.
1707 (_initialize_tui_win): Add tui-resize-message setting.
1708 * NEWS: Add entry for new commands.
1709
c86d74cc
TT
17102019-11-11 Tom Tromey <tom@tromey.com>
1711
1712 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1713 functions.
1714
7b7b9424
CB
17152019-11-11 Christian Biesinger <cbiesinger@google.com>
1716
1717 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1718
086baaf1
AB
17192019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1720
1721 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1722 function.
1723 * python/python-internal.h (gdbpy_lookup_static_symbols):
1724 Declare new function.
1725 * python/python.c (python_GdbMethods): Add
1726 gdb.lookup_static_symbols method.
1727 * NEWS: Mention gdb.lookup_static_symbols.
1728
09ff83af
AB
17292019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1730
1731 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1732 static block of current object file first. Also fix typo in
1733 header comment.
1734
eb2dd8df
AB
17352019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1736
1737 * stack.c (set_last_displayed_sal): Delete.
1738 (last_displayed_sal_valid): Delete.
1739 (last_displayed_pspace): Delete.
1740 (last_displayed_addr): Delete.
1741 (last_displayed_symtab): Delete.
1742 (last_displayed_line): Delete.
1743 (class last_displayed_symtab_info_type): New.
1744 (last_displayed_symtab_info): New static global variable.
1745 (print_frame_info): Call methods on last_displayed_symtab_info.
1746 (clear_last_displayed_sal): Update header comment, and make use of
1747 last_displayed_symtab_info.
1748 (last_displayed_sal_is_valid): Likewise.
1749 (get_last_displayed_pspace): Likewise.
1750 (get_last_displayed_addr): Likewise.
1751 (get_last_displayed_symtab): Likewise.
1752 (get_last_displayed_line): Likewise.
1753 (get_last_displayed_sal): Likewise.
1754 * stack.h (clear_last_displayed_sal): Update header comment.
1755 (last_displayed_sal_is_valid): Likewise.
1756 (get_last_displayed_pspace): Likewise.
1757 (get_last_displayed_addr): Likewise.
1758 (get_last_displayed_symtab): Likewise.
1759 (get_last_displayed_line): Likewise.
1760 (get_last_displayed_sal): Likewise.
1761
62137775
AB
17622019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1763
1764 * stack.c (frame_show_address): Convert return type to bool.
1765 * stack.h (frame_show_address): Likewise, and update header
1766 comment.
1767
cf57ad6d
AB
17682019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1769
1770 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1771 * unittests/vec-utils-selftests.c: New file.
1772 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1773
0b026263
TT
17742019-11-10 Tom Tromey <tom@tromey.com>
1775
1776 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1777 (tui_highlight_win): Likewise.
1778 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1779 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1780 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1781 Don't set can_highlight.
1782
b049ce2d
TT
17832019-11-10 Tom Tromey <tom@tromey.com>
1784
1785 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1786 Remove unused declaration.
1787
992a7040
TT
17882019-11-08 Tom Tromey <tromey@adacore.com>
1789
1790 * top.c (read_command_file): Update.
1791 (command_line_input): Make return type const.
1792 * python/py-gdb-readline.c: Update.
1793 * linespec.c (decode_line_2): Update.
1794 * defs.h (command_line_input): Make return type const.
1795 * cli/cli-script.c (read_next_line): Make return type const.
1796 * ada-lang.c (get_selections): Update.
1797
ca3a04f6
CB
17982019-11-06 Christian Biesinger <cbiesinger@google.com>
1799
1800 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1801 * mi/mi-main.c (output_cores): Likewise.
1802 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1803 (linux_xfer_osdata_modules): Likewise.
1804 * remote.c (register_remote_support_xml): Likewise.
1805 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1806 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1807
e0eac551
TT
18082019-11-06 Tom Tromey <tom@tromey.com>
1809
1810 * tui/tui-interp.c: Don't include readline.h.
1811 * tui/tui-hooks.c: Don't include readline.h.
1812 * symmisc.c: Include tilde.h, not readline.h.
1813 * symfile.c: Include tilde.h, not readline.h.
1814 * source.c: Include tilde.h, not readline.h.
1815 * solib.c: Include tilde.h, not readline.h.
1816 * psymtab.c: Include tilde.h, not readline.h.
1817 * exec.c: Include tilde.h, not readline.h.
1818 * corelow.c: Include tilde.h, not readline.h.
1819 * cli/cli-dump.c: Include tilde.h, not readline.h.
1820 * cli/cli-cmds.c: Don't include readline.h.
1821
825165c5
TT
18222019-11-05 Tom Tromey <tom@tromey.com>
1823
1824 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1825 (tui_disassemble): Set addr_size.
1826 (tui_disasm_window::set_contents): Use addr_size.
1827
91ae903f
TT
18282019-11-05 Tom Tromey <tom@tromey.com>
1829
1830 * rust-lang.c (rust_language_defn): Update.
1831 * python/py-value.c (valpy_string): Call c_get_string.
1832 * p-lang.c (pascal_language_defn): Update.
1833 * opencl-lang.c (opencl_language_defn): Update.
1834 * objc-lang.c (objc_language_defn): Update.
1835 * m2-lang.c (m2_language_defn): Update.
1836 * language.c (unknown_language_defn, auto_language_defn): Update.
1837 (default_get_string): Remove.
1838 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1839 * go-lang.c (go_language_defn): Update.
1840 * f-lang.c (f_language_defn): Update.
1841 * d-lang.c (d_language_defn): Update.
1842 * c-lang.c (c_language_defn, cplus_language_defn)
1843 (asm_language_defn, minimal_language_defn): Update.
1844 * ada-lang.c (ada_language_defn): Update.
1845 * language.h (struct language_defn) <la_get_string>: Remove.
1846 (LA_GET_STRING): Remove.
1847 (default_get_string): Don't declare.
1848
1df2f9ef
TT
18492019-11-05 Tom Tromey <tom@tromey.com>
1850
1851 * tui/tui-source.h (struct tui_source_window): Inline
1852 constructor. Remove destructor.
1853 <style_changed, m_observable>: Move to superclass.
1854 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1855 (struct tui_source_window_base): Move private members to end.
1856 <style_changed, m_observable>: Move from tui_source_window.
1857 * tui/tui-winsource.c (tui_copy_source_line): Move from
1858 tui-source.c. Rename from copy_source_line. Add special handling
1859 for negative line number.
1860 (tui_source_window_base::style_changed): Move from
1861 tui_source_window.
1862 (tui_source_window_base): Register observer.
1863 (~tui_source_window_base): New.
1864 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1865 rename.
1866 (tui_source_window::set_contents): Use tui_copy_source_line.
1867 (tui_source_window::tui_source_window): Move to tui-source.h.
1868 (tui_source_window::~tui_source_window): Remove.
1869 (tui_source_window::style_changed): Move to superclass.
1870 * tui/tui-disasm.c (tui_disassemble): Create string file with
1871 styling, when possible. Add "addr_size" parameter.
1872 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1873 Don't compute maximum size.
1874 (len_without_escapes): New function
1875
5d051055
TT
18762019-11-05 Tom Tromey <tom@tromey.com>
1877
1878 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1879 std::string.
1880 * tui/tui-winsource.c (tui_show_source_line): Update.
1881 * tui/tui-source.c (tui_source_window::set_contents): Update.
1882 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1883
ade7beea
CB
18842019-11-05 Christian Biesinger <cbiesinger@google.com>
1885
1886 * symtab.h (gdb_static_assert): Put && operator at the beginning
1887 of the line instead of the end.
1888
3573abe1
CB
18892019-11-04 Christian Biesinger <cbiesinger@google.com>
1890
1891 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1892 and sizeof (symbol).
1893 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1894
dae8b3eb
RO
18952019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1896
1897 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1898 * configure.host: Mark *-*-solaris2.10* obsolete.
1899 * configure.tgt: Mark Solaris < 11 obsolete.
1900 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1901 Update target triplet.
1902
5df96a4e
TT
19032019-11-01 Tom Tromey <tromey@adacore.com>
1904
1905 * utils.c (print_sys_errmsg): Simplify.
1906
b7481649
TT
19072019-11-01 Tom Tromey <tromey@adacore.com>
1908
1909 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1910
e48f6033
CB
19112019-11-01 Christian Biesinger <cbiesinger@google.com>
1912
1913 * configure: Regenerate.
1914 * configure.ac: Remove check for strerror_r.
1915 * gdbsupport/common.m4: Check for strerror_r.
1916
bd5766ec
LM
19172019-11-01 Luis Machado <luis.machado@linaro.org>
1918
1919 PR gdb/25124
1920
1921 * arm-tdep.c (arm_per_objfile): Rename to ...
1922 (arm_per_bfd): ... this.
1923 (arm_objfile_data_key): Rename to ...
1924 (arm_bfd_data_key): ... this.
1925 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1926 data.
1927 (arm_record_special_symbol): Likewise.
1928
e1709896
AB
19292019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1930
1931 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1932 end.
1933 * c-typeprint.c (c_print_typedef): Likewise.
1934 * f-typeprint.c (f_print_typedef): Likewise.
1935 * m2-typeprint.c (m2_print_typedef): Likewise.
1936 * p-typeprint.c (pascal_print_typedef): Likewise.
1937 * rust-lang.c (rust_print_typedef): Likewise.
1938 * symtab.c (print_symbol_info): Print a newline after calling
1939 typedef_print.
1940
165f8965
AB
19412019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1942
1943 * symtab.c (info_module_cmdlist): New variable.
1944 (info_module_command): New function.
1945 (search_module_symbols): New function.
1946 (info_module_subcommand): New function.
1947 (struct info_modules_var_func_options): New struct.
1948 (info_modules_var_func_options_defs): New variable.
1949 (make_info_modules_var_func_options_def_group): New function.
1950 (info_module_functions_command): New function.
1951 (info_module_variables_command): New function.
1952 (info_module_var_func_command_completer): New function.
1953 (_initialize_symtab): Register new 'info module functions' and
1954 'info module variables' commands.
1955 * symtab.h (typedef symbol_search_in_module): New typedef.
1956 (search_module_symbols): Declare new function.
1957 * NEWS: Mention new commands.
1958
59c35742
AB
19592019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1960
1961 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1962 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1963 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1964 MODULES_DOMAIN.
1965 (scan_partial_symbols): Only create partial module symbols for non
1966 declarations.
1967 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1968 and MODULES_DOMAIN.
1969 * symtab.c (search_domain_name): Likewise.
1970 (search_symbols): Likewise.
1971 (print_symbol_info): Likewise.
1972 (symtab_symbol_info): Likewise.
1973 (info_modules_command): New function.
1974 (_initialize_symtab): Register 'info modules' command.
1975 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1976 * NEWS: Mention new 'info modules' command.
1977
aed61d02
PW
19782019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1979
1980 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1981 and $_gdb_maint_setting_str.
1982
9ad9b77d
PW
19832019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1984
1985 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1986 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1987 (str_value_from_setting, gdb_setting_str_internal_fn)
1988 (gdb_maint_setting_str_internal_fn): New functions.
1989 (_initialize_cli_cmds): Define the new convenience functions.
1990 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1991 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1992
8d6efaa2
CB
19932019-10-31 Christian Biesinger <cbiesinger@google.com>
1994
1995 * agent.c (set_can_use_agent): When the setting is turned on,
1996 look up agent symbols if we don't have them yet.
1997 (agent_new_objfile): Don't look up agent symbols when the agent
1998 setting is off.
1999
33cb1647
CB
20002019-10-31 Christian Biesinger <cbiesinger@google.com>
2001
2002 * config.in: Regenerate.
2003
b231e86a
CB
20042019-10-31 Christian Biesinger <cbiesinger@google.com>
2005
2006 * configure: Regenerate.
2007 * configure.ac: Check for strerror_r.
2008 * gdbsupport/common-utils.h (safe_strerror): Change return value
2009 to const char * and document that this function is now threadsafe.
2010 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2011 thread_local and call strerror_r, if available.
2012 * utils.c (perror_string): Update.
2013 (print_sys_errmsg): Update.
2014
a2726d4f
LM
20152019-10-31 Luis Machado <luis.machado@linaro.org>
2016
2017 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2018 objfile_key.
2019 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2020 objfile to fetch per-bfd data.
2021 (arm_find_exidx_entry): Likewise.
2022
75cafaa6
CB
20232019-10-31 Christian Biesinger <cbiesinger@google.com>
2024
2025 * gdbsupport/agent.c (debug_agent): Change type to bool.
2026 (use_agent): Likewise.
2027 (all_agent_symbols_look_up): Likewise.
2028 (agent_loaded_p): Change return value to bool.
2029 (agent_look_up_symbols): Update.
2030 (agent_capability_check): Change return value to bool.
2031 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2032 (debug_agent): Change type to bool.
2033 (use_agent): Likewise.
2034 (agent_capability_check): Change return value to bool.
2035
808590ec
CB
20362019-10-30 Christian Biesinger <cbiesinger@google.com>
2037
2038 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2039 (build_minimal_symbol_hash_tables): Code to clear the table moved
2040 to clear_minimal_symbol_hash_tables.
2041 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2042 when needed.
2043
f18ad8a1
SM
20442019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2045
2046 * infcmd.c: Remove includes.
2047 * infrun.c: Remove includes.
2048
de93309a
SM
20492019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2050
2051 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2052 (grow_vect): Remove declaration.
2053 (ada_type_of_array): Remove declaration.
2054 (ada_update_initial_language): Remove declaration.
2055 (ada_fold_name): Remove declaration.
2056 (ada_fill_in_ada_prototype): Remove declaration.
2057 (user_select_syms): Remove declaration.
2058 (get_selections): Remove declaration.
2059 (ada_tag_type): Remove declaration.
2060 (ada_value_tag): Remove declaration.
2061 (ada_is_others_clause): Remove declaration.
2062 (ada_in_variant): Remove declaration.
2063 (ada_value_struct_elt): Remove declaration.
2064 (ada_attribute_name): Remove declaration.
2065 (ada_system_address_type): Remove declaration.
2066 * ada-lang.c (ada_watch_location_expression): Make static.
2067 (GROW_VECT): Move here from ada-lang.h.
2068 (grow_vect): Make static.
2069 (ada_update_initial_language): Make static.
2070 (ada_fold_name): Make static.
2071 (ada_type_of_array): Make static.
2072 (encoded_ordered_before): Move up.
2073 (sort_choices): Move up.
2074 (print_signatures): Move up.
2075 (ada_print_symbol_signature): Move up.
2076 (get_selections): Move up and make static.
2077 (user_select_syms): Move up and make static.
2078 (ada_value_struct_elt): Move up and make static.
2079 (ada_tag_type): Make static.
2080 (ada_value_tag): Make static.
2081 (ada_is_others_clause): Make static.
2082 (ada_in_variant): Make static.
2083 (ada_attribute_name): Make static.
2084
cdc46a9f
SM
20852019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2086
2087 * ada-lang.c: Remove includes.
2088 * ada-typeprint.c: Remove includes.
2089 * ada-valprint.c: Remove includes.
2090
90421c56
SM
20912019-10-29 Simon Marchi <simon.marchi@efficios.com>
2092
2093 * addrmap.c: Add static assertions of type size, moved from
2094 _initialize_addrmap.
2095 (_initialize_addrmap): Remove.
2096
31edb802
CB
20972019-10-29 Christian Biesinger <cbiesinger@google.com>
2098
2099 * coffread.c (record_minimal_symbol): Update.
2100 (process_coff_symbol): Update.
2101 * dbxread.c (read_dbx_symtab): Update.
2102 * dwarf2read.c (add_partial_symbol): Update.
2103 (fixup_go_packaging): Update.
2104 (load_partial_dies): Update.
2105 (new_symbol): Update.
2106 * elfread.c (record_minimal_symbol): Change signature to use
2107 gdb::string_view instead of name+len.
2108 (elf_symtab_read): Update.
2109 (elf_rel_plt_read): Update.
2110 * mdebugread.c (parse_partial_symbols): Update.
2111 (handle_psymbol_enumerators): Update.
2112 (new_symbol): Update.
2113 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2114 to use gdb::string_view instead of name+len.
2115 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2116 * psympriv.h (add_psymbol_to_list): Likewise.
2117 * psymtab.c (add_psymbol_to_bcache): Likewise.
2118 (add_psymbol_to_list): Likewise.
2119 * stabsread.c (define_symbol): Update.
2120 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2121 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2122 (symbol_set_names): Likewise.
2123 * xcoffread.c (scan_xcoff_symtab): Update.
2124
0c921b21
CB
21252019-10-29 Christian Biesinger <cbiesinger@google.com>
2126
2127 * symtab.h (symbol_set_names): Document that copy_name must be
2128 set to true for non-nullterminated strings.
2129 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2130 linkage_name if the entry was not found and we need to demangle.
2131
35e65c49
CB
21322019-10-29 Christian Biesinger <cbiesinger@google.com>
2133
2134 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2135 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2136 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2137 * gdbsupport/gdb_binary_search.h: New file.
2138
ed2a2229
CB
21392019-10-29 Christian Biesinger <cbiesinger@google.com>
2140
2141 * NEWS: Mention new --with-system-gdbinit-dir option.
2142 * config.in: Regenerate.
2143 * configure: Regenerate.
2144 * configure.ac: Add new option --with-system-gdbinit-dir.
2145 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2146 for a ".gdb" suffix.
2147 * main.c (get_init_files): Change system_gdbinit argument to
2148 a vector and return the files in SYSTEM_GDBINIT_DIR in
2149 addition to SYSTEM_GDBINIT.
2150 (captured_main_1): Update.
2151 (print_gdb_help): Update.
2152 * top.c (print_gdb_configuration): Also print the value of
2153 SYSTEM_GDBINIT_DIR.
2154
87f34879
CB
21552019-10-28 Christian Biesinger <cbiesinger@google.com>
2156
2157 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2158 that takes gdb::string_view arguments.
2159
30baf67b
TV
21602019-10-26 Tom de Vries <tdevries@suse.de>
2161
2162 * aarch64-linux-tdep.c: Fix typos in comments.
2163 * aarch64-tdep.c: Same.
2164 * ada-lang.c: Same.
2165 * amd64-nat.c: Same.
2166 * arc-tdep.c: Same.
2167 * arch/aarch64-insn.c: Same.
2168 * block.c: Same.
2169 * breakpoint.h: Same.
2170 * btrace.h: Same.
2171 * c-varobj.c: Same.
2172 * cli/cli-decode.c: Same.
2173 * cli/cli-script.c: Same.
2174 * cli/cli-utils.h: Same.
2175 * coff-pe-read.c: Same.
2176 * coffread.c: Same.
2177 * compile/compile-cplus-symbols.c: Same.
2178 * compile/compile-object-run.c: Same.
2179 * completer.c: Same.
2180 * corelow.c: Same.
2181 * cp-support.c: Same.
2182 * demangle.c: Same.
2183 * dwarf-index-write.c: Same.
2184 * dwarf2-frame.c: Same.
2185 * dwarf2-frame.h: Same.
2186 * eval.c: Same.
2187 * frame-base.h: Same.
2188 * frame.h: Same.
2189 * gdbcmd.h: Same.
2190 * gdbtypes.h: Same.
2191 * gnu-nat.c: Same.
2192 * guile/scm-objfile.c: Same.
2193 * i386-tdep.c: Same.
2194 * i386-tdep.h: Same.
2195 * infcall.c: Same.
2196 * infcall.h: Same.
2197 * linux-nat.c: Same.
2198 * m68k-tdep.c: Same.
2199 * macroexp.c: Same.
2200 * memattr.c: Same.
2201 * mi/mi-cmd-disas.c: Same.
2202 * mi/mi-getopt.h: Same.
2203 * mi/mi-main.c: Same.
2204 * minsyms.c: Same.
2205 * nat/aarch64-sve-linux-sigcontext.h: Same.
2206 * objfiles.h: Same.
2207 * ppc-linux-nat.c: Same.
2208 * ppc-linux-tdep.c: Same.
2209 * ppc-tdep.h: Same.
2210 * progspace.h: Same.
2211 * prologue-value.h: Same.
2212 * python/py-evtregistry.c: Same.
2213 * python/py-instruction.h: Same.
2214 * record-btrace.c: Same.
2215 * record-full.c: Same.
2216 * remote.c: Same.
2217 * rs6000-tdep.c: Same.
2218 * ser-tcp.c: Same.
2219 * sol-thread.c: Same.
2220 * sparc-sol2-tdep.c: Same.
2221 * sparc64-tdep.c: Same.
2222 * stabsread.c: Same.
2223 * symfile.c: Same.
2224 * symtab.h: Same.
2225 * target.c: Same.
2226 * tracepoint.c: Same.
2227 * tui/tui-data.h: Same.
2228 * tui/tui-io.c: Same.
2229 * tui/tui-win.c: Same.
2230 * tui/tui.c: Same.
2231 * unittests/rsp-low-selftests.c: Same.
2232 * user-regs.h: Same.
2233 * utils.c: Same.
2234 * utils.h: Same.
2235 * valarith.c: Same.
2236 * valops.c: Same.
2237 * valprint.c: Same.
2238 * valprint.h: Same.
2239 * value.c: Same.
2240 * value.h: Same.
2241 * varobj.c: Same.
2242 * x86-nat.h: Same.
2243 * xtensa-tdep.c: Same.
2244
1834d45f
AT
22452019-10-25 Ali Tamur <tamur@google.com>
2246
2247 * charset.c (find_charset_names): Reflect API change.
2248
5396ae17
CB
22492019-10-25 Christian Biesinger <cbiesinger@google.com>
2250
2251 * symtab.c (struct demangled_name_entry): Change demangled name
2252 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2253 part of the struct anymore.
2254 (symbol_set_names): No longer obstack allocate + copy the demangled
2255 name, just store the allocated name from bfd.
2256
93878f47
TT
22572019-10-25 Tom Tromey <tromey@adacore.com>
2258
2259 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2260 (bsearch_cie_cmp, add_cie): Remove.
2261 (find_cie): Reimplement.
2262 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2263 (dwarf2_build_frame_info): Update.
2264
7b71fc97
L
22652019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2266
2267 PR gdb/25126
2268 * symfile.c (reread_symbols): Call forget_cached_source_info to
2269 clear the stale source cache.
2270
cbb5a2ea
CB
22712019-10-24 Christian Biesinger <cbiesinger@google.com>
2272
2273 * configure: Regenerate.
2274 * configure.ac: Remove code that sets python_has_threads.
2275
71737c43
CB
22762019-10-24 Christian Biesinger <cbiesinger@google.com>
2277
2278 * config.in: Regenerate.
2279 * configure: Regenerate.
2280 * configure.ac: Remove the code that uses sed to get the python
2281 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2282
33d569b7
AB
22832019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2284
2285 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2286 error paths.
2287
f16f7b7c
TT
22882019-10-23 Tom Tromey <tom@tromey.com>
2289
2290 * arc-tdep.c: Remove ".." from include.
2291 * frv-tdep.c: Remove ".." from include.
2292 * lm32-tdep.c: Remove ".." from include.
2293 * microblaze-tdep.c: Remove ".." from include.
2294 * or1k-tdep.h: Remove ".." from include.
2295 * s12z-tdep.c: Remove ".." from include.
2296 * Makefile.in (OPCODES_CFLAGS): Add comment.
2297 (TOP_CFLAGS): New variable.
2298 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2299
6999161a
TT
23002019-10-23 Tom Tromey <tom@tromey.com>
2301
2302 * Makefile.in (READLINE_DIR): Update.
2303
12e7c35e
TBA
23042019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2305
2306 * infcall.c (call_function_by_hand_dummy): Fix the function
2307 comment. And extract out a code section into...
2308 (reserve_stack_space): ...this new function.
2309
37055cad
TBA
23102019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2311
2312 * infcall.c (value_arg_coerce): Remove an unused parameter.
2313 (call_function_by_hand_dummy): Update the call to
2314 'value_arg_coerce'.
2315
39bcc47c
TBA
23162019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2317
2318 * infcall.c (call_function_by_hand_dummy): Refactor.
2319
bd888c0f
TBA
23202019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2321
2322 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2323
c12d372d
TT
23242019-10-23 Tom Tromey <tom@tromey.com>
2325
2326 * configure: Rebuild.
2327 * configure.ac: Don't check for sigprocmask.
2328 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2329
4d0b984b
TT
23302019-10-23 Tom Tromey <tom@tromey.com>
2331
2332 * configure: Rebuild.
2333 * acinclude.m4: Use m4_include, not sinclude.
2334
7e785608
TV
23352019-10-23 Tom de Vries <tdevries@suse.de>
2336
2337 PR breakpoints/24687
2338 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2339
403772ef
CB
23402019-10-22 Christian Biesinger <cbiesinger@google.com>
2341
2342 * symtab.c (struct demangled_name_entry) <language>: Change from
2343 bitfield to regular variable.
2344
3a494279
CB
23452019-10-22 Christian Biesinger <cbiesinger@google.com>
2346
2347 * symtab.c (struct demangled_name_entry): Add a constructor.
2348 (free_demangled_name_entry): New function to call the destructor
2349 for demangled_name_entry.
2350 (create_demangled_names_hash): Pass free_demangled_name_entry to
2351 htab_create_alloc.
2352 (symbol_set_names): Call placement new for demangled_name_entry.
2353 * utils.c: No longer include xxhash.h here, now that fast_hash
2354 is inlined in the header.
2355 * utils.h: Instead, include it here.
2356
ccb1ba62
CB
23572019-10-22 Christian Biesinger <cbiesinger@google.com>
2358
2359 * Makefile.in: Link with libxxhash.
2360 * config.in: Regenerate.
2361 * configure: Regenerate.
2362 * configure.ac: Search for libxxhash.
2363 * utils.c (fast_hash): Use xxhash if present.
2364
1a6ff1a9
CB
23652019-10-22 Christian Biesinger <cbiesinger@google.com>
2366
2367 * utils.h (fast_hash): New function.
2368 * symtab.c (hash_demangled_name_entry): Call new function
2369 fast_hash.
2370
7bb43059
CB
23712019-10-22 Christian Biesinger <cbiesinger@google.com>
2372
2373 * symtab.c (struct demangled_name_entry): Change type of mangled
2374 to gdb::string_view. Also adds a constructor that takes the
2375 mangled name.
2376 (hash_demangled_name_entry): Update.
2377 (eq_demangled_name_entry): Update.
2378 (free_demangled_name_entry): New function to call the destructor
2379 now that this is not a POD anymore.
2380 (create_demangled_names_hash): Pass free_demangled_name_entry to
2381 htab_create_alloc.
2382 (symbol_set_names): Update.
2383
7ba99d21
AT
23842019-10-21 Ali Tamur <tamu@google.com>
2385
2386 * dwarf2read.c (dir_index): Change type.
2387 (file_name_index): Likewise.
2388 (line_header::include_dir_at): Change comment and implementation on
2389 whether it is DWARF 5.
2390 (line_header::is_valid_file_index): New function.
2391 (line_header::file_name_at): Change comment and implementation on
2392 whether it is DWARF 5.
2393 (line_header::file_names): Change to private field renamed as
2394 m_file_names and introduce a new accessor method.
2395 (line_header::file_names_size): New method.
2396 (line_header::include_dirs): Change to private field and rename as
2397 m_include_dirs.
2398 (dw2_get_file_names_reader): Define local var at a smaller scope and
2399 reflect API change.
2400 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2401 (process_structure_scope): Likewise.
2402 (line_header::add_include_dir): Change message and reflect renaming.
2403 (line_header::add_file_name): Likewise.
2404 (read_formatted_entries): Handle DW_FORM_data16.
2405 (dwarf_decode_line_header): Fix line header length calculation.
2406 (psymtab_include_file_name): Change comment and API.
2407 (lnp_state_machine::m_file): Update comment and reflect type change.
2408 (lnp_state_machine::record_line): Reflect type change.
2409 (dwarf_decode_lines): Reflect API change.
2410 (file_file_name): Likewise.
2411 (file_full_name): Likewise.
2412
45f47c3a
AB
24132019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2414
2415 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2416
e5f3c0e3
TT
24172019-10-21 Tom Tromey <tom@tromey.com>
2418
2419 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2420
a0a461e5
TT
24212019-10-21 Tom Tromey <tom@tromey.com>
2422
2423 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2424 NM_H. Use AC_CONFIG_LINKS.
2425 * configure: Rebuild.
2426 * Makefile.in (NM_H): New variable.
2427 (generated_files): Add NM_H. Remove gcore.
2428 (nm.h, stamp-nmh): New targets.
2429
54d83b8d
TT
24302019-10-20 Tom Tromey <tom@tromey.com>
2431
2432 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2433 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2434 obsolete comment.
2435 (put_objfile_before): Now static.
2436
23771117
SM
24372019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2438
2439 * gdbsupport/common-utils.h (startswith): Change return type to
2440 bool.
2441
39ef2f62
CB
24422019-10-19 Christian Biesinger <cbiesinger@google.com>
2443
2444 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2445 * breakpoint.c (bp_locations_compare): Rename to...
2446 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2447 (update_global_location_list): Use std::sort instead of qsort.
2448 * buildsym.c (compare_line_numbers): Rename to...
2449 (lte_is_less_than): ...this, and change to std::sort semantics.
2450 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2451 instead of qsort.
2452 * disasm.c (compare_lines): Rename to...
2453 (line_is_less_than): ...this, and change to std::sort semantics.
2454 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2455 of qsort.
2456 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2457 (fde_is_less_than): ...this, and change to std::sort semantics.
2458 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2459 * mdebugread.c (compare_blocks):
2460 (block_is_less_than): ...this, and change to std::sort semantics.
2461 (sort_blocks): Call std::sort instead of qsort.
2462 * objfiles.c (qsort_cmp): Rename to...
2463 (sort_cmp): ...this, and change to std::sort semantics.
2464 (update_section_map): Call std::sort instead of qsort.
2465 * remote.c (compare_pnums): Remove.
2466 (map_regcache_remote_table): Call std::sort instead of qsort.
2467 * utils.c (compare_positive_ints): Remove.
2468 * utils.h (compare_positive_ints): Remove.
2469 * xcoffread.c (compare_lte): Remove.
2470 (arrange_linetable): Call std::sort instead of qsort.
2471
f71433ee
SDJ
24722019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2473
2474 * symfile.c (init_entry_point_info): Fix typo.
2475 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2476
85102364
TV
24772019-10-18 Tom de Vries <tdevries@suse.de>
2478
2479 * aarch64-tdep.c: Fix typos in comments.
2480 * ada-lang.c: Same.
2481 * ada-tasks.c: Same.
2482 * alpha-tdep.c: Same.
2483 * alpha-tdep.h: Same.
2484 * amd64-nat.c: Same.
2485 * amd64-windows-tdep.c: Same.
2486 * arc-tdep.c: Same.
2487 * arc-tdep.h: Same.
2488 * arch-utils.c: Same.
2489 * arm-nbsd-tdep.c: Same.
2490 * arm-tdep.c: Same.
2491 * ax-gdb.c: Same.
2492 * blockframe.c: Same.
2493 * btrace.c: Same.
2494 * c-varobj.c: Same.
2495 * coff-pe-read.c: Same.
2496 * coffread.c: Same.
2497 * cris-tdep.c: Same.
2498 * darwin-nat.c: Same.
2499 * dbxread.c: Same.
2500 * dcache.c: Same.
2501 * disasm.c: Same.
2502 * dtrace-probe.c: Same.
2503 * dwarf-index-write.c: Same.
2504 * dwarf2-frame-tailcall.c: Same.
2505 * dwarf2-frame.c: Same.
2506 * dwarf2read.c: Same.
2507 * eval.c: Same.
2508 * exceptions.c: Same.
2509 * fbsd-tdep.c: Same.
2510 * findvar.c: Same.
2511 * frame.c: Same.
2512 * frv-tdep.c: Same.
2513 * gnu-v3-abi.c: Same.
2514 * go32-nat.c: Same.
2515 * h8300-tdep.c: Same.
2516 * hppa-tdep.c: Same.
2517 * i386-linux-tdep.c: Same.
2518 * i386-tdep.c: Same.
2519 * ia64-libunwind-tdep.c: Same.
2520 * ia64-tdep.c: Same.
2521 * infcmd.c: Same.
2522 * infrun.c: Same.
2523 * linespec.c: Same.
2524 * linux-nat.c: Same.
2525 * linux-thread-db.c: Same.
2526 * machoread.c: Same.
2527 * mdebugread.c: Same.
2528 * mep-tdep.c: Same.
2529 * mn10300-tdep.c: Same.
2530 * namespace.c: Same.
2531 * objfiles.c: Same.
2532 * opencl-lang.c: Same.
2533 * or1k-tdep.c: Same.
2534 * osabi.c: Same.
2535 * ppc-linux-nat.c: Same.
2536 * ppc-linux-tdep.c: Same.
2537 * ppc-sysv-tdep.c: Same.
2538 * printcmd.c: Same.
2539 * procfs.c: Same.
2540 * record-btrace.c: Same.
2541 * record-full.c: Same.
2542 * remote-fileio.c: Same.
2543 * remote.c: Same.
2544 * rs6000-tdep.c: Same.
2545 * s12z-tdep.c: Same.
2546 * score-tdep.c: Same.
2547 * ser-base.c: Same.
2548 * ser-go32.c: Same.
2549 * skip.c: Same.
2550 * sol-thread.c: Same.
2551 * solib-svr4.c: Same.
2552 * solib.c: Same.
2553 * source.c: Same.
2554 * sparc-nat.c: Same.
2555 * sparc-sol2-tdep.c: Same.
2556 * sparc-tdep.c: Same.
2557 * sparc64-tdep.c: Same.
2558 * stabsread.c: Same.
2559 * stack.c: Same.
2560 * symfile.c: Same.
2561 * symtab.c: Same.
2562 * target-descriptions.c: Same.
2563 * target-float.c: Same.
2564 * thread.c: Same.
2565 * utils.c: Same.
2566 * valops.c: Same.
2567 * valprint.c: Same.
2568 * value.c: Same.
2569 * varobj.c: Same.
2570 * windows-nat.c: Same.
2571 * xcoffread.c: Same.
2572 * xstormy16-tdep.c: Same.
2573 * xtensa-tdep.c: Same.
2574
c5adaa19
TT
25752019-10-17 Tom Tromey <tromey@adacore.com>
2576
2577 * configure: Rebuild.
2578 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2579 in AC_CONFIG_FILES invocation.
2580 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2581 new-style config.status invocation.
2582
405feb71
TV
25832019-10-17 Tom de Vries <tdevries@suse.de>
2584
2585 * arm-nbsd-nat.c: Fix typos in comments.
2586 * arm-tdep.c: Same.
2587 * darwin-nat-info.c: Same.
2588 * dwarf2read.c: Same.
2589 * elfread.c: Same.
2590 * event-top.c: Same.
2591 * findvar.c: Same.
2592 * gdbtypes.c: Same.
2593 * hppa-tdep.c: Same.
2594 * i386-tdep.c: Same.
2595 * jit.c: Same.
2596 * main.c: Same.
2597 * mdebugread.c: Same.
2598 * moxie-tdep.c: Same.
2599 * nto-procfs.c: Same.
2600 * osabi.c: Same.
2601 * ppc-linux-tdep.c: Same.
2602 * remote.c: Same.
2603 * riscv-tdep.c: Same.
2604 * s390-tdep.c: Same.
2605 * sh-tdep.c: Same.
2606 * sparc-linux-tdep.c: Same.
2607 * sparc-nat.c: Same.
2608 * stack.c: Same.
2609 * target-descriptions.c: Same.
2610 * top.c: Same.
2611 * varobj.c: Same.
2612
befcd486
TT
26132019-10-16 Tom Tromey <tom@tromey.com>
2614
2615 * objfiles.h (struct objfile) <original_name>: Now const.
2616
17bfe554
CB
26172019-10-16 Christian Biesinger <cbiesinger@google.com>
2618
2619 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2620 pass on to sigsetjmp's second argument.
2621 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2622
950b7495
KS
26232019-10-16 Keith Seitz <keiths@redhat.com>
2624
2625 PR gdb/23567
2626 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2627 sections whose size is greater than the file size.
2628
ff371ec9
JW
26292019-10-16 Jim Wilson <jimw@sifive.com>
2630
2631 * riscv-tdep.c (riscv_gcc_target_options): New.
2632 (riscv_gnu_triplet_regexp): New.
2633 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2634 set_gdbarch_gnu_triplet_regexp.
2635
fec4e896
CB
26362019-10-16 Christian Biesinger <cbiesinger@google.com>
2637
2638 * Makefile.in: Add xml-builtin.h.
2639 * features/feature_to_c.sh: Add an include for xml-builtin.h
2640 to ensure that the compiler checks that the types match.
2641 * xml-builtin.h: New file.
2642 * xml-support.c (fetch_xml_builtin): Add missing const.
2643 * xml-support.h: Remove declaration of xml_builtins.
2644
d10eccaa
TV
26452019-10-16 Tom de Vries <tdevries@suse.de>
2646
2647 PR tdep/25096
2648 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2649 (amd64_classify_aggregate): ... here.
2650 (amd64_classify_aggregate_field): Handled fiels of nested structs
2651 recursively.
2652
745ff14e
TV
26532019-10-16 Tom de Vries <tdevries@suse.de>
2654
2655 PR tdep/24104
2656 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2657 that handles 'theclass'.
2658
791b7405
AB
26592019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2660
2661 * linespec.c (decode_digits_ordinary): Update comment.
2662 * make-target-delegates: No longer need to handle VEC case.
2663 * memrange.c (normalize_mem_ranges): Update comment.
2664 * namespace.c (add_using_directive): Update comment.
2665 * objc-lang.c (uniquify_strings): Update comment.
2666 * ppc-linux-nat.c (struct thread_points): Update comment.
2667 * probe.h (find_probes_in_objfile): Update comment.
2668 * target.h (enum flash_preserve_mode): Update comment.
2669 * varobj.c (varobj_restrict_range): Update comment.
2670 * varobj.h (varobj_list_children): Update comment.
2671
0dc32745
AB
26722019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2673
2674 * Makefile.in: Remove references to vec.h and vec.c.
2675 * aarch64-tdep.c: No longer include vec.h.
2676 * ada-lang.c: Likewise.
2677 * ada-lang.h: Likewise.
2678 * arm-tdep.c: Likewise.
2679 * ax.h: Likewise.
2680 * breakpoint.h: Likewise.
2681 * charset.c: Likewise.
2682 * cp-support.h: Likewise.
2683 * dtrace-probe.c: Likewise.
2684 * dwarf2read.c: Likewise.
2685 * extension.h: Likewise.
2686 * gdb_bfd.c: Likewise.
2687 * gdbsupport/gdb_vecs.h: Likewise.
2688 * gdbsupport/vec.c: Remove.
2689 * gdbsupport/vec.h: Remove.
2690 * gdbthread.h: Likewise.
2691 * guile/scm-type.c: Likewise.
2692 * inline-frame.c: Likewise.
2693 * machoread.c: Likewise.
2694 * memattr.c: Likewise.
2695 * memrange.h: Likewise.
2696 * namespace.h: Likewise.
2697 * nat/linux-btrace.h: Likewise.
2698 * osdata.c: Likewise.
2699 * parser-defs.h: Likewise.
2700 * progspace.h: Likewise.
2701 * python/py-type.c: Likewise.
2702 * record-btrace.c: Likewise.
2703 * rust-exp.y: Likewise.
2704 * solib-target.c: Likewise.
2705 * stap-probe.c: Likewise.
2706 * target-descriptions.c: Likewise.
2707 * target-memory.c: Likewise.
2708 * target.h: Likewise.
2709 * varobj.c: Likewise.
2710 * varobj.h: Likewise.
2711 * xml-support.h: Likewise.
2712
ae640021
AB
27132019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2714
2715 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2716 Update for new std::vector based implementation.
2717 (process_psymtab_comp_unit_reader): Likewise.
2718 (scan_partial_symbols): Likewise.
2719 (recursively_compute_inclusions): Likewise.
2720 (compute_compunit_symtab_includes): Likewise.
2721 (process_imported_unit_die): Likewise.
2722 (queue_and_load_dwo_tu): Likewise.
2723 (follow_die_sig_1): Likewise.
2724 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2725 (typedef dwarf2_per_cu_ptr): Remove.
2726 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2727 function.
2728 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2729 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2730 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2731 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2732 std::vector.
2733
55dfc88f
TT
27342019-10-15 Tom Tromey <tromey@adacore.com>
2735
2736 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2737 TID.
2738
96b49c5e
TT
27392019-10-15 Tom Tromey <tromey@adacore.com>
2740
2741 * windows-nat.c (windows_nat_target::fetch_registers)
2742 (windows_nat_target::store_registers): Rename "pid" to "tid".
2743
953cff56
TT
27442019-10-15 Tom Tromey <tromey@adacore.com>
2745
2746 * gdbarch.h, gdbarch.c: Rebuild.
2747 * gdbarch.sh (gcc_target_options): Change return type to
2748 std::string.
2749 * compile/compile.c (get_args): Update.
2750 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2751 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2752 std::string.
2753 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2754 std::string.
2755 * arch-utils.c (default_gcc_target_options): Return std::string.
2756 * arch-utils.h (default_gcc_target_options): Return std::string.
2757 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2758
81e6b8eb
CB
27592019-10-15 Christian Biesinger <cbiesinger@google.com>
2760
2761 * breakpoint.c (breakpoint_chain): Make static.
2762 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2763 of accessing breakpoint_chain.
2764
95da600f
CB
27652019-10-15 Christian Biesinger <cbiesinger@google.com>
2766
2767 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2768 to a gdb::function_view and return value to bool.
2769 * breakpoint.h (iterate_over_breakpoints): Likewise.
2770 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2771 (pop_dummy_frame): Update.
2772 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2773 (gdbscm_breakpoints): Update.
2774 * python/py-breakpoint.c (build_bp_list): Update.
2775 (gdbpy_breakpoints): Update.
2776 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2777 Update.
2778 (bpfinishpy_handle_stop): Update.
2779 (bpfinishpy_handle_exit): Update.
2780 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2781 (svr4_update_solib_event_breakpoints): Update.
2782
ba18312d
AA
27832019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2784
2785 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2786 when unwrapping single-field structs.
2787
6acc1a0b
SM
27882019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2789
2790 * dwarf2read.c: Remove includes.
2791
284782de
SM
27922019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2793
2794 * ui-out.c (ui_out::call_do_message): Silence
2795 -Wformat-nonliteral warning.
2796
073bbbb0
SM
27972019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2798
2799 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2800 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2801 include: readline/tilde.h.
2802
7b9a15e1
CB
28032019-10-12 Christian Biesinger <cbiesinger@google.com>
2804
2805 * remote.c (remote_target::get_trace_status): Remove declaration of
2806 trace_regblock_size.
2807
cc8dee1f
CB
28082019-10-12 Christian Biesinger <cbiesinger@google.com>
2809
2810 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2811 (show_user): Remove declaration of cmdlist.
2812 * cli/cli-cmds.h (max_user_call_depth): Declare.
2813 * cli/cli-script.c (execute_user_command): Remove declaration
2814 of max_user_call_depth.
2815
a83d4ef6
JW
28162019-10-11 Jim Wilson <jimw@sifive.com>
2817
5f93c5a6
JW
2818 * gdbsupport/print-utils.h (pulongest): Fix comment.
2819 (plongest): Likewise.
2820 (phex): Add missing comment, mention leading zeros.
2821 (phex_nz): Add mention of no leading zeros to comment.
2822
a83d4ef6
JW
2823 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2824 plongest instead of unsigned long long cast.
2825
26344e0c
CB
28262019-10-10 Christian Biesinger <cbiesinger@google.com>
2827
2828 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2829 for external_editor_command and gdbtk_test.
2830
c2c440a9
CB
28312019-10-10 Christian Biesinger <cbiesinger@google.com>
2832
2833 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2834 * varobj.c (varobjdebug): Move comment to...
2835 * varobj.h (varobjdebug): ...here, and declare.
2836
a31bff9d
TT
28372019-10-09 Tom Tromey <tom@tromey.com>
2838
2839 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2840 erase_data_content.
2841
7523da63
TT
28422019-10-09 Tom Tromey <tom@tromey.com>
2843
2844 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2845 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2846 * tui/tui-command.c (tui_cmd_window::resize)
2847 (tui_refresh_cmd_win): Update.
2848 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2849 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2850 * tui/tui-data.c (~tui_gen_win_info): Remove.
2851 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2852 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2853 (tui_redisplay_readline, tui_mld_flush)
2854 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2855 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2856 (tui_data_window::erase_data_content)
2857 (tui_data_item_window::rerender)
2858 (tui_data_item_window::refresh_window): Update.
2859 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2860 (box_win, tui_gen_win_info::make_window)
2861 (tui_gen_win_info::make_visible): Update.
2862 (tui_delete_win): Remove.
2863 * tui/tui-winsource.c
2864 (tui_source_window_base::do_erase_source_content): Update.
2865 (tui_show_source_line, tui_source_window_base::update_tab_width)
2866 (tui_source_window_base::update_exec_info): Update.
2867 * tui/tui-data.h (struct curses_deleter): New.
2868 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2869 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2870
a7798e7f
TT
28712019-10-09 Tom Tromey <tom@tromey.com>
2872
2873 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2874
5c45899e
TT
28752019-10-09 Tom Tromey <tom@tromey.com>
2876
2877 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2878 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2879
6d7fd9aa
TT
28802019-10-09 Tom Tromey <tom@tromey.com>
2881
2882 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2883 window height directly.
2884 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2885 declare.
2886 * tui/tui-layout.c (tui_default_win_height): Remove.
2887 (tui_default_win_viewport_height): Remove.
2888
d2dd1084
TT
28892019-10-09 Tom Tromey <tom@tromey.com>
2890
2891 * tui/tui.h: Remove comments.
2892
cff32449
TV
28932019-10-09 Tom de Vries <tdevries@suse.de>
2894
2895 * python/lib/gdb/printer/bound_registers.py: Use
2896 '^builtin_type_bound128' as regexp argument for
2897 add_builtin_pretty_printer.
2898
6a25e8a2
CB
28992019-10-09 Christian Biesinger <cbiesinger@google.com>
2900
2901 * guile/guile.c (guile_extension_script_ops): Remove forward
2902 declaration and mark as static.
2903 (guile_script_ops): Likewise.
2904 (extension_language_guile): Move further down in the file so
2905 it can reference the definitions for guile_{extension_,}script_ops.
2906
6d9d6da4
AA
29072019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2908
2909 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2910 except SORTL, DFLTCC, and KDSA.
2911
3abea05d
TT
29122019-10-08 Tom Tromey <tromey@adacore.com>
2913
2914 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2915 (struct safe_symbol_file_add_args): Remove.
2916
dde996e2
TT
29172019-10-08 Tom Tromey <tromey@adacore.com>
2918
2919 * windows-nat.c: Don't include buildsym-legacy.h.
2920
cd6fdaa1
TT
29212019-10-08 Tom Tromey <tromey@adacore.com>
2922
2923 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2924
79bb1944
CB
29252019-10-08 Christian Biesinger <cbiesinger@google.com>
2926
2927 * gdbtypes.c (overload_debug): Move comment to header.
2928 * gdbtypes.h (overload_debug): Declare.
2929 * valops.c: Remove declaration of overload_debug, instead
2930 include gdbtypes.h.
2931
34916edc
CB
29322019-10-08 Christian Biesinger <cbiesinger@google.com>
2933
2934 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2935 through _().
2936 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2937 move comment...
2938 * language.h (lang_frame_mismatch_warn): ... here. Also add
2939 declaration.
2940 * top.c (lang_frame_mismatch_warn): Remove declaration.
2941 (check_frame_language_change): Pass lang_frame_mismatch_warn
2942 through _().
2943
bad5c026
CB
29442019-10-07 Christian Biesinger <cbiesinger@google.com>
2945
2946 * c-lang.h (vtbl_ptr_name): Declare.
2947 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2948 it from the header.
2949 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2950
51f1fdc3
CB
29512019-10-07 Christian Biesinger <cbiesinger@google.com>
2952
2953 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2954 gdb_static_assert.
2955
30d1f018
WP
29562019-10-07 Weimin Pan <weimin.pan@oracle.com>
2957
606813d5
WP
2958 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2959 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
2960 * ctfread.c: New file.
2961 * ctfread.h: New file.
2962 * elfread.c: Include ctfread.h.
2963 (struct elfinfo text_p): New member ctfsect.
2964 (elf_locate_sections): Mark CTF section.
2965 (elf_symfile_read): Call elfctf_build_psymtabs.
2966 * Makefile.in (LIBCTF): Add.
2967 (CLIBS): Use it.
2968 (CDEPS): Likewise.
2969 (DIST): Add ctfread.c.
606813d5
WP
2970
29712019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2972
2973 * ctfread.c (struct nextfield): Renamed to ...
2974 (struct ctf_nextfield): ... this.
2975 (struct field_info): Renamed to ...
2976 (strut ctf_field_info): ... this.
2977 (attach_fields_to_type): Update for renamed structures.
2978 (ctf_add_member_cb): Likewise.
2979 (ctf_add_enum_member_cb): Likewise.
2980 (process_struct_members): Likewise.
2981 (process_enum_type): Likewise.
30d1f018 2982
518fe38c
WP
29832019-10-07 Weimin Pan <weimin.pan@oracle.com>
2984
2985 * tracectf.h: Rename, was ctf.h.
2986 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2987 * tracefile.c: Likewise.
2988 * tracepoint.c: Remove unused include ctf.h.
2989 * mi/mi-main.c: Likewise.
2990 * Makefile.in Replace ctf.c with tracectf.c.
2991
225f296a
JB
29922019-10-06 Joel Brobecker <brobecker@adacore.com>
2993
2994 * version.in: Change version number to "9.0.50.DATE-git".
2995
77c2dba3
TT
29962019-10-03 Tom Tromey <tom@tromey.com>
2997
2998 PR rust/24976:
2999 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3000
179aed7f
AB
30012019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3002
3003 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3004 cp_search_name_hash.
3005 * NEWS: Add entry about nested function support.
3006
0a4b0913
AB
30072019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3008 Andrew Burgess <andrew.burgess@embecosm.com>
3009
3010 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3011 for nested static variables when searchin VAR_DOMAIN.
3012 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3013 global scope, update comment.
3014 (add_partial_subprogram): Call add_partial_subprogram recursively
3015 for nested subroutines when processinng Fortran.
3016 (load_partial_dies): Process the child entities of a subprogram
3017 when processing Fortran.
3018 (partial_die_parent_scope): Handle building scope
3019 for Fortran nested functions.
3020 (process_die): Record that nested functions have a scope.
3021 (new_symbol): Always record Fortran subprograms on the global
3022 symbol list.
3023 (determine_prefix): How to build the prefix for Fortran
3024 subprograms.
3025
d8c06f22
AB
30262019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3027
3028 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3029 have just sent the thread a SIGSTOP and are waiting for it to
3030 arrive.
3031
a8b3b8e9
AB
30322019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3033
3034 * btrace.c (btrace_add_pc): Remove whitespace before the template
3035 parameter in 'std::vector <...>'.
3036 (parse_xml_btrace_block): Likewise.
3037 (btrace_maint_decode_pt): Likewise.
3038 (btrace_maint_update_packets): Likewise.
3039 (btrace_maint_print_packets): Likewise.
3040 * btrace.h (struct btrace_maint_info): Likewise.
3041 * dwarf2read.c (struct type_unit_group): Likewise.
3042 (build_type_psymtabs_reader): Likewise.
3043 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3044 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3045 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3046
4d825eab
TV
30472019-10-03 Tom de Vries <tdevries@suse.de>
3048
3049 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3050 the first line of the help text for set/show style metadata.
3051
80fd2826
TT
30522019-10-02 Tom Tromey <tromey@adacore.com>
3053
3054 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3055 * gdbsupport/common-inferior.c: New file.
3056 * infcmd.c (startup_with_shell): Don't define.
3057 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3058 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3059 * inferior.h (startup_with_shell): Don't declare.
3060
70054538
CB
30612019-10-02 Christian Biesinger <cbiesinger@google.com>
3062
3063 * gdbsupport/gdb_assert.h: Include errors.h.
3064 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3065
37f6a7f4
TT
30662019-10-02 Tom Tromey <tromey@adacore.com>
3067
3068 * NEWS: Add $_ada_exception entry.
3069 * ada-lang.c (struct ada_catchpoint): Add constructor.
3070 <m_kind>: New member.
3071 (allocate_location_exception, re_set_exception): Remove
3072 "ex" parameter.
3073 (should_stop_exception): Compute $_ada_exception.
3074 (check_status_exception, print_it_exception)
3075 (print_one_exception, print_mention_exception): Remove
3076 "ex" parameter.
3077 (allocate_location_catch_exception, re_set_catch_exception)
3078 (check_status_exception, print_it_catch_exception)
3079 (print_one_catch_exception, print_mention_catch_exception)
3080 (print_recreate_catch_exception)
3081 (allocate_location_catch_exception_unhandled)
3082 (re_set_catch_exception_unhandled)
3083 (check_status_exception, print_it_catch_exception_unhandled)
3084 (print_one_catch_exception_unhandled)
3085 (print_mention_catch_exception_unhandled)
3086 (print_recreate_catch_exception_unhandled)
3087 (allocate_location_catch_assert, re_set_catch_assert)
3088 (check_status_assert, print_it_catch_assert)
3089 (print_one_catch_assert, print_mention_catch_assert)
3090 (print_recreate_catch_assert)
3091 (allocate_location_catch_handlers, re_set_catch_handlers)
3092 (check_status_handlers, print_it_catch_handlers)
3093 (print_one_catch_handlers, print_mention_catch_handlers)
3094 (print_recreate_catch_handlers): Remove.
3095 (create_ada_exception_catchpoint): Update.
3096 (initialize_ada_catchpoint_ops): Update.
3097
fccf9de1
TT
30982019-10-02 Tom Tromey <tromey@adacore.com>
3099
3100 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3101 (create_excep_cond_exprs): Simplify exception string computation.
3102 (ada_exception_catchpoint_cond_string): Likewise.
3103
4b610737
TT
31042019-10-02 Tom Tromey <tromey@adacore.com>
3105
3106 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3107 * ada-lang.c (lesseq_defined_than): Handle
3108 LOC_STATIC.
3109 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3110 parameter.
3111 (dwarf2_has_info): Likewise.
3112 (new_symbol): Set maybe_copied on symbol when
3113 appropriate.
3114 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3115 parameter.
3116 <can_copy>: New member.
3117 * elfread.c (record_minimal_symbol): Set maybe_copied
3118 on symbol when appropriate.
3119 (elf_symfile_read): Update call to dwarf2_has_info.
3120 * minsyms.c (lookup_minimal_symbol_linkage): New
3121 function.
3122 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3123 * symtab.c (get_symbol_address, get_msymbol_address):
3124 New functions.
3125 * symtab.h (get_symbol_address, get_msymbol_address):
3126 Declare.
3127 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3128 maybe_copied.
3129 (struct symbol, struct minimal_symbol) <maybe_copied>:
3130 New member.
3131
1dd58850
TT
31322019-10-02 Tom Tromey <tromey@adacore.com>
3133
3134 * source.c (struct current_source_location): New.
3135 (current_source_key): New global.
3136 (current_source_symtab, current_source_line)
3137 (current_source_pspace): Remove.
3138 (get_source_location): New function.
3139 (get_current_source_symtab_and_line)
3140 (set_default_source_symtab_and_line)
3141 (set_current_source_symtab_and_line)
3142 (clear_current_source_symtab_and_line, select_source_symtab)
3143 (info_source_command, print_source_lines_base)
3144 (info_line_command, search_command_helper, _initialize_source):
3145 Update.
3146
5c281dbb
TT
31472019-10-02 Tom Tromey <tromey@adacore.com>
3148
3149 * source.c (select_source_symtab): Don't call
3150 decode_line_with_current_source.
3151
d3d32391
AB
31522019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3153
3154 * symtab.c (lookup_global_symbol): Search global block.
3155
38583298
TT
31562019-10-02 Tom Tromey <tromey@adacore.com>
3157
3158 * coffread.c (process_coff_symbol): Update.
3159 * dwarf2read.c (var_decode_location, new_symbol): Update.
3160 * mdebugread.c (parse_symbol): Update.
3161 * objfiles.c (relocate_one_symbol): Update.
3162 * stabsread.c (define_symbol, fix_common_block)
3163 (scan_file_globals): Update.
3164 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3165 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3166 * xcoffread.c (process_xcoff_symbol): Update.
3167
9344c18f
AA
31682019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3169
3170 * MAINTAINERS: Update my email address.
3171
df07e2c7
AB
31722019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3173
3174 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3175 std::vector.
3176 (build_type_psymtabs_reader): Update for std::vector.
3177 (build_type_psymtab_dependencies): Likewise.
3178 * dwarf2read.h: Remove use of DEF_VEC_P.
3179 (typedef sig_type_ptr): Delete.
3180
554ac434
AB
31812019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3182
3183 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3184 to std::vector.
3185 (btrace_maint_decode_pt): Likewise, and move allocation of the
3186 vector outside of the loop.
3187 (btrace_maint_update_packets): Update to handle change from VEC to
3188 std::vector.
3189 (btrace_maint_print_packets): Likewise.
3190 (maint_info_btrace_cmd): Likewise.
3191 * btrace.h: Remove use of DEF_VEC_O.
3192 (typedef btrace_pt_packet_s): Delete.
3193 (struct btrace_maint_info) <packets>: Change fromm VEC to
3194 std::vector.
3195 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3196
46f29a9a
AB
31972019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3198
3199 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3200 make accesses into the vector constant references.
3201 (btrace_add_pc): Update for std::vector.
3202 (btrace_stitch_bts): Likewise.
3203 (parse_xml_btrace_block): Likewise.
3204 (btrace_maint_update_packets): Likewise.
3205 (btrace_maint_print_packets): Likewise.
3206 (maint_info_btrace_cmd): Likewise.
3207 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3208 std::vector.
3209 (btrace_data::empty): Likewise.
3210 (btrace_data_append): Likewise.
3211 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3212 (typedef btrace_block_s): Delete.
3213 (struct btrace_block): Add constructor.
3214 (struct btrace_data_bts) <blocks>: Change to std::vector.
3215 * nat/linux-btrace.c (perf_event_read_bts): Update for
3216 std::vector.
3217 (linux_read_bts): Likewise.
3218
d770d56f
TT
32192019-10-01 Tom Tromey <tom@tromey.com>
3220
3221 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3222
9d636d67
TT
32232019-10-01 Tom Tromey <tom@tromey.com>
3224
3225 * stack.c (print_frame, info_frame_command_core): Use
3226 styled_string.
3227 * linux-thread-db.c (try_thread_db_load_1)
3228 (try_thread_db_load_from_pdir_1): Use styled_string.
3229 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3230 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3231 (maybe_print_unsupported_script_warning)
3232 (maybe_print_script_not_found_warning): Use styled_string.
3233 * ada-lang.c (user_select_syms): Use styled_string.
3234
7f6aba03
TT
32352019-10-01 Tom Tromey <tom@tromey.com>
3236
3237 * p-lang.c (pascal_printstr): Use metadata style.
3238 * value.c (show_convenience): Use metadata style.
3239 * valprint.c (valprint_check_validity, val_print_optimized_out)
3240 (val_print_not_saved, val_print_unavailable)
3241 (val_print_invalid_address, generic_val_print, val_print)
3242 (value_check_printable, val_print_array_elements): Use metadata
3243 style.
3244 * ui-out.h (class ui_out) <field_fmt>: New overload.
3245 <do_field_fmt>: Add style parameter.
3246 * ui-out.c (ui_out::field_fmt): New overload.
3247 * typeprint.c (type_print_unknown_return_type)
3248 (val_print_not_allocated, val_print_not_associated): Use metadata
3249 style.
3250 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3251 parameter.
3252 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3253 * tracepoint.c (tvariables_info_1): Use metadata style.
3254 * stack.c (print_frame_arg, print_frame_info, print_frame)
3255 (info_frame_command_core): Use metadata style.
3256 * skip.c (info_skip_command): Use metadata style.
3257 * rust-lang.c (rust_print_enum): Use metadata style.
3258 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3259 metadata style.
3260 * python/py-framefilter.c (py_print_single_arg): Use metadata
3261 style.
3262 * printcmd.c (do_one_display, print_variable_and_value): Use
3263 metadata style.
3264 * p-valprint.c (pascal_val_print)
3265 (pascal_object_print_value_fields): Use metadata style.
3266 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3267 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3268 parameter.
3269 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3270 * m2-valprint.c (m2_print_long_set): Use metadata style.
3271 * m2-typeprint.c (m2_print_type): Use metadata style.
3272 * infcmd.c (print_return_value_1): Use metadata style.
3273 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3274 * f-valprint.c (info_common_command_for_block): Use metadata
3275 style.
3276 * f-typeprint.c (f_type_print_base): Use metadata style.
3277 * expprint.c (print_subexp_standard): Use metadata style.
3278 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3279 * cli/cli-style.h (class cli_style_option): Add constructor.
3280 (metadata_style): Declare.
3281 * cli/cli-style.c (metadata_style): New global.
3282 (_initialize_cli_style): Register metadata style.
3283 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3284 parameter.
3285 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3286 * c-typeprint.c (c_type_print_base_struct_union)
3287 (c_type_print_base_1): Use metadata style.
3288 * breakpoint.c (watchpoint_value_print)
3289 (print_one_breakpoint_location): Use metadata style.
3290 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3291 style.
3292 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3293 style.
3294 * ada-valprint.c (val_print_packed_array_elements, printstr)
3295 (print_field_values, ada_val_print_ref, ada_val_print): Use
3296 metadata style.
3297 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3298 style.
3299 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3300 style.
3301 * ada-lang.c (user_select_syms): Use metadata style.
3302
14309bb6
TT
33032019-10-01 Tom Tromey <tom@tromey.com>
3304
3305 * cli/cli-cmds.c (pwd_command): Style output.
3306
6a831f06
PA
33072019-10-01 Pedro Alves <palves@redhat.com>
3308 Tom Tromey <tom@tromey.com>
3309
3310 * symtab.c (print_symbol_info): Use %ps.
3311 (print_msymbol_info): Use %ps.
3312 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3313 * printcmd.c (print_variable_and_value): Use %ps.
3314 * macrocmd.c (show_pp_source_pos): Use %ps.
3315 * infrun.c (print_exited_reason): Use ui_out::message.
3316 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3317 (describe_other_breakpoints): Use ui_out::message and new
3318 formats.
3319 (say_where): Use new formats.
3320 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3321 and new formats.
3322
2a3c1174
PA
33232019-10-01 Pedro Alves <palves@redhat.com>
3324 Tom Tromey <tom@tromey.com>
3325
3326 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3327 (test_gdb_formats): New function.
3328 (run_tests): Call it.
3329 (test_format_specifier): Update.
3330 * utils.h (fputs_filtered): Update comment.
3331 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3332 (fputs_styled_unfiltered): Declare.
3333 * utils.c (fputs_styled_unfiltered): New function.
3334 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3335 (vfprintf_filtered): Update.
3336 (vfprintf_unfiltered, vprintf_filtered): Update.
3337 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3338 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3339 disallow_ui_out_field>: New constants.
3340 (enum class field_kind): New.
3341 (struct base_field_s, struct signed_field_s): New.
3342 (signed_field): New function.
3343 (struct string_field_s): New.
3344 (string_field): New function.
3345 (struct styled_string_s): New.
3346 (styled_string): New function.
3347 (class ui_out) <message>: Add comment.
3348 <vmessage, call_do_message>: New methods.
3349 <do_message>: Add style parameter.
3350 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3351 methods.
3352 (ui_out::message): Rewrite.
3353 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3354 parameter.
3355 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3356 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3357 gdb_extensions parameter.
3358 (class format_piece): Add parameter to constructor.
3359 (n_int_args): New field.
3360 * gdbsupport/format.c (format_pieces::format_pieces): Add
3361 gdb_extensions parameter. Handle '*'.
3362 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3363 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3364 vfprintf_styled_no_gdbfmt.
3365 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3366 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3367 unfiltered output.
3368 * ui-style.h (struct ui_file_style) <ptr>: New method.
3369
0dfe5bfb
TT
33702019-10-01 Tom Tromey <tom@tromey.com>
3371
3372 * unittests/format_pieces-selftests.c: Update. Add final format.
3373 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3374 empty literal pieces.
3375
e43b10e1
TT
33762019-10-01 Tom Tromey <tom@tromey.com>
3377
3378 * ui-out.h (enum class ui_out_style_kind): Remove.
3379 (class ui_out) <field_string, field_stsream, do_field_string>:
3380 Change type of "style".
3381 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3382 (ui_out::field_string): Update.
3383 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3384 of "style".
3385 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3386 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3387 * stack.c (print_frame_arg, print_frame_info, print_frame):
3388 Update.
3389 * source.c (print_source_lines_base): Update.
3390 * solib.c (info_sharedlibrary_command): Update.
3391 * skip.c (info_skip_command): Update.
3392 * record-btrace.c (btrace_call_history_src_line)
3393 (btrace_call_history): Update.
3394 * python/py-framefilter.c (py_print_frame): Update.
3395 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3396 "style".
3397 * mi/mi-out.c (mi_ui_out::do_table_header)
3398 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3399 (mi_ui_out::do_field_string): Update.
3400 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3401 Update.
3402 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3403 "style".
3404 * cli-out.c (cli_ui_out::do_table_header)
3405 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3406 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3407 (cli_ui_out::do_field_fmt): Update.
3408 * breakpoint.c (print_breakpoint_location): Update.
3409 (update_static_tracepoint): Update.
3410
cd7c32c3
PW
34112019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3412
3413 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3414 conversion of gdb_datadir.
3415 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3416 remove not needed c_str ().
3417
8fe0f950
AT
34182019-09-30 Ali Tamur <tamur@google.com>
3419
3420 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3421 (dwarf2_string_attr): Likewise.
3422
5f48f8f3
AT
34232019-09-30 Ali Tamur <tamur@google.com>
3424
3425 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3426 (process_full_type_unit): Likewise.
3427 (dump_die_shallow): Likewise.
3428 (cu_debug_loc_section): Likewise.
3429
6fb08628
CB
34302019-09-28 Christian Biesinger <cbiesinger@google.com>
3431
3432 * minsyms.c (compare_minimal_symbols): Rename to...
3433 (minimal_symbol_is_less_than): ...this, and adjust to STL
3434 conventions (return bool, take arguments as references)
3435 (minimal_symbol_reader::install): Call std::sort instead
3436 of qsort.
3437
c7ee338a
CB
34382019-09-29 Christian Biesinger <cbiesinger@google.com>
3439
3440 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3441 hash and why.
3442 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3443 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3444
703a86c2
SM
34452019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3446
3447 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3448 * psympriv.h (add_psymbol_to_list): Move comment here and update
3449 it.
3450
0df0352a
TV
34512019-09-29 Tom de Vries <tdevries@suse.de>
3452
3453 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3454 Use $tmpdir/$(basename "$output_file").dwz instead of
3455 "${output_file}.dwz".
3456
ad75efa6
SM
34572019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3458
3459 PR gdb/25045
3460 * hppa-linux-nat.c: Include gdbarch.h.
3461
ececd218
CB
34622019-09-26 Christian Biesinger <cbiesinger@google.com>
3463
3464 * blockframe.c (find_pc_partial_function): Change return type to bool.
3465 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3466 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3467 (stub_gnu_ifunc_resolve_name): Likewise.
3468 * symtab.c (compare_filenames_for_search): Likewise.
3469 (compare_glob_filenames_for_search): Likewise.
3470 (matching_obj_sections): Likewise.
3471 (symbol_matches_domain): Likewise.
3472 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3473 (find_line_pc): Change return type to bool.
3474 (find_line_pc_range): Likewise.
3475 (producer_is_realview): Likewise.
3476 * symtab.h (symbol_matches_domain): Likewise.
3477 (find_pc_partial_function): Likewise.
3478 (find_pc_line_pc_range): Likewise.
3479 (in_gnu_ifunc_stub): Likewise.
3480 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3481 (find_line_pc): Likewise.
3482 (find_line_pc_range): Likewise.
3483 (matching_obj_sections): Likewise.
3484 (find_line_symtab): Change out parameter to bool.
3485 (producer_is_realview): Change return type to bool.
3486 (compare_filenames_for_search): Likewise.
3487 (compare_glob_filenames_for_search): Likewise.
3488
27a900b8
TT
34892019-09-26 Tom Tromey <tom@tromey.com>
3490
3491 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3492 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3493 * gdb_usleep.h: Remove.
3494 * gdb_usleep.c: Remove.
3495 * utils.c: Don't include gdb_usleep.h.
3496
5d63b30a
TT
34972019-09-26 Tom Tromey <tromey@adacore.com>
3498
3499 * python/py-type.c (type_to_type_object): Call check_typedef
3500 for stub types.
3501
12904d37
TT
35022019-09-26 Tom Tromey <tom@tromey.com>
3503
3504 * utils.h (initialize_utils): Don't declare.
3505 * top.c (gdb_init): Don't call initialize_utils.
3506 * utils.c (initialize_utils): Remove. Move contents...
3507 (_initialize_utils): ... here.
3508
858f25f0
TT
35092019-09-25 Tom Tromey <tom@tromey.com>
3510
3511 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3512 * utils.h (make_hex_string): Don't declare.
3513 * utils.c (make_hex_string): Remove.
3514
3d435220
TV
35152019-09-24 Tom de Vries <tdevries@suse.de>
3516
3517 PR gdb/23815
3518 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3519 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3520
ddd44b70
DD
35212019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3522
3523 * NEWS: Mention new simulator port for PRU.
3524
f945dedf
CB
35252019-09-23 Christian Biesinger <cbiesinger@google.com>
3526
3527 * ada-exp.y (write_object_remaining): Update.
3528 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3529 and eliminate the static buffer.
3530 (ada_decode_symbol): Update.
3531 (ada_la_decode): Update.
3532 (ada_sniff_from_mangled_name): Update.
3533 (is_valid_name_for_wild_match): Update.
3534 (ada_lookup_name_info::matches): Update and simplify.
3535 (name_matches_regex): Update.
3536 (ada_add_global_exceptions): Update.
3537 * ada-lang.h (ada_decode): Update signature.
3538 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3539 * dwarf-index-write.c (debug_names::insert): Update.
3540
7ab78ccb
SM
35412019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3542
3543 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3544 formatting.
3545
9252448b
SM
35462019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3547
3548 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3549 Change "nonzero" to "true" in documentation.
3550
626ca2c0
CB
35512019-09-20 Christian Biesinger <cbiesinger@google.com>
3552
3553 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3554 (_initialize_darwin_solib): Don't set
3555 darwin_so_ops.lookup_lib_global_symbol.
3556 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3557 set_gdbarch_iterate_over_objfiles_in_search_order.
3558 (elf_lookup_lib_symbol): Rename to...
3559 (svr4_iterate_over_objfiles_in_search_order): this, and update
3560 to iterate semantics.
3561 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3562 * solib.c (solib_global_lookup): Remove.
3563 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3564 (solib_global_lookup): Remove.
3565 * symtab.c (lookup_global_or_static_symbol): Remove call to
3566 solib_global_lookup.
3567
5a3a0d63
JB
35682019-09-20 Joel Brobecker <brobecker@adacore.com>
3569
3570 * NEWS: Move entries about default MI version now being
3571 version 3, and about the GDB/MI fix for multi-location
3572 breakpoints to the "since GDB 8.3" section.
3573
ffea1427
JB
35742019-09-20 Joel Brobecker <brobecker@adacore.com>
3575
3576 GDB 8.3.1 released.
3577
abf516c6
UW
35782019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3579
3580 * NEWS: Mention that Cell/B.E. debugging support was removed.
3581 * MAINTAINERS: Remove spu target.
3582
3583 * config/djgpp/fnchange.lst: Remove entries for removed files.
3584
3585 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3586 spu-multiarch.o, and spu-tdep.o.
3587 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3588 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3589 spu-multiarch.c, and spu-tdep.c.
3590 * spu-linux-nat.c: Remove file.
3591 * spu-multiarch.c: Remove file.
3592 * spu-tdep.c: Remove file.
3593 * spu-tdep.h: Remove file.
3594 * solib-spu.c: Remove file.
3595 * solib-spu.h: Remove file.
3596
3597 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3598 * configure.nat (spu-linux): Remove.
3599 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3600 solib-multiarch.o from gdb_target_obs.
3601 (spu*-*-*): Remove.
3602
3603 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3604 feature flag.
3605 (ppc_linux_no_features): Update.
3606 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3607 Cell/B.E. support.
3608 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3609 (tdesc_powerpc_cell64l): Likewise.
3610 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3611 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3612 Cell/B.E. support.
3613 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3614 Do not include "features/rs6000/powerpc-cell32l.c" or
3615 "features/rs6000/powerpc-cell64l.c".
3616 (ppc_linux_spu_section): Remove.
3617 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3618 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3619 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3620 (ppc_linux_spe_context_lookup): Remove.
3621 (ppc_linux_spe_context_inferior_created): Remove.
3622 (ppc_linux_spe_context_solib_loaded): Remove.
3623 (ppc_linux_spe_context_solib_unloaded): Remove.
3624 (ppc_linux_spe_context): Remove.
3625 (struct ppu2spu_cache): Remove.
3626 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3627 (struct ppu2spu_data): Remove.
3628 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3629 ppu2spu_unwind): Remove.
3630 (ppc_linux_init_abi): Remove Cell/B.E. support.
3631 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3632
3633 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3634 (rs6000/powerpc-cell64l-expedite): Likewise
3635 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3636 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3637 rs6000/powerpc-cell64l.xml.
3638 * features/rs6000/powerpc-cell32l.xml: Remove.
3639 * features/rs6000/powerpc-cell64l.xml: Likewise.
3640 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3641 * features/rs6000/powerpc-cell64l.c: Likewise.
3642 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3643 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3644 * regformats/reg-spu.dat: Remove.
3645
3646 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3647 * corelow.c (struct spuid_list): Remove.
3648 (add_to_spuid_list): Remove.
3649 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3650 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3651 (remote_protocol_features): Remove associated entries.
3652 (_initialize_remote): No longer initialize them.
3653 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3654 * linux-nat.c (SPUFS_MAGIC): Remove.
3655 (linux_proc_xfer_spu): Remove.
3656 (spu_enumerate_spu_ids): Remove.
3657 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3658 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3659 (linux_make_corefile_notes): No longer call it.
3660
3661 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3662 (cooked_write_test): Likewise.
3663
78e8cb91
TT
36642019-09-20 Tom Tromey <tom@tromey.com>
3665
3666 * NEWS: Mention case-sensitivity of TUI commands.
3667 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3668 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3669 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3670
f074b67e
TT
36712019-09-20 Tom Tromey <tom@tromey.com>
3672
3673 * tui/tui-source.c (tui_source_window::set_contents): Use
3674 make_unique_xstrdup.
3675 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3676 make_unique_xstrdup.
3677
63c4bf19
TT
36782019-09-20 Tom Tromey <tom@tromey.com>
3679
3680 * tui/tui-data.c: Remove separator comments.
3681 * tui/tui-layout.c: Remove separator comments.
3682 * tui/tui-win.c: Remove separator comments.
3683 * tui/tui-wingeneral.c: Remove separator comments.
3684
43df9b2f
TT
36852019-09-20 Tom Tromey <tom@tromey.com>
3686
3687 * tui/tui.h (strcat_to_buf): Don't declare.
3688 * tui/tui.c (strcat_to_buf): Remove.
3689
7226433c
TT
36902019-09-20 Tom Tromey <tom@tromey.com>
3691
3692 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3693 from "fullname".
3694 * tui/tui-source.c (tui_source_window::set_contents)
3695 (tui_source_window::location_matches_p)
3696 (tui_source_window::maybe_update): Update.
3697
80df3337
TT
36982019-09-20 Tom Tromey <tom@tromey.com>
3699
3700 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3701 Update.
3702 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3703 prefix.
3704 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3705 (tui_data_window::line_from_reg_element_no)
3706 (tui_data_window::first_reg_element_no_inline)
3707 (tui_data_window::show_registers)
3708 (tui_data_window::show_register_group)
3709 (tui_data_window::display_registers_from)
3710 (tui_data_window::display_registers_from_line)
3711 (tui_data_window::first_data_item_displayed)
3712 (tui_data_window::delete_data_content_windows)
3713 (tui_data_window::erase_data_content)
3714 (tui_data_window::do_scroll_vertical)
3715 (tui_data_window::refresh_window)
3716 (tui_data_window::check_register_values): Update.
3717
9923f347
TT
37182019-09-20 Tom Tromey <tom@tromey.com>
3719
3720 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3721 (struct tui_locator_window) <full_name, proc_name>: Now
3722 std::string.
3723 * tui/tui-stack.c (tui_locator_window::make_status_line)
3724 (tui_locator_window::set_locator_fullname)
3725 (tui_locator_window::set_locator_info): Update.
3726 * tui/tui-source.c (tui_source_window::set_contents)
3727 (tui_source_window::showing_source_p): Update.
3728
b76251ab
TT
37292019-09-20 Tom Tromey <tom@tromey.com>
3730
3731 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3732 Don't call tui_locator_win_info_ptr.
3733
0891be08
TT
37342019-09-20 Tom Tromey <tom@tromey.com>
3735
3736 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3737
1b935acf
TT
37382019-09-20 Tom Tromey <tom@tromey.com>
3739
3740 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3741 height for locator.
3742 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3743 * tui/tui-layout.c (show_source_disasm_command, show_data)
3744 (show_source_or_disasm_and_command): Use 1 as height for locator.
3745
9abd8a65
TT
37462019-09-20 Tom Tromey <tom@tromey.com>
3747
3748 * tui/tui.c (tui_enable): Update.
3749 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3750 Update.
3751 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3752 Update.
3753 * tui/tui-data.c (win_resized): Now bool.
3754 (tui_win_resized): Return bool.
3755 (tui_set_win_resized_to): Accept a bool.
3756
b5457826
TT
37572019-09-20 Tom Tromey <tom@tromey.com>
3758
3759 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3760 Change type of "refresh_values_only".
3761 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3762 type of "refresh_values_only".
3763
6b915f7d
TT
37642019-09-20 Tom Tromey <tom@tromey.com>
3765
3766 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3767 std::string.
3768 (tui_disassemble): Add "pos" parameter.
3769 (tui_disasm_window::set_contents): Simplify.
3770
2ad52f6f
TT
37712019-09-20 Tom Tromey <tom@tromey.com>
3772
3773 * tui/tui-winsource.h (struct tui_source_window_base)
3774 <show_source_content>: Now private.
3775 * tui/tui-winsource.c
3776 (tui_source_window_base::show_source_content): Don't handle empty
3777 content case.
3778
b3b1bde6
TT
37792019-09-20 Tom Tromey <tom@tromey.com>
3780
3781 * tui/tui-layout.c (show_source_disasm_command)
3782 (show_source_or_disasm_and_command): Don't call
3783 show_source_content.
3784
71a25ed2
TT
37852019-09-20 Tom Tromey <tom@tromey.com>
3786
3787 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3788 Declare.
3789 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3790 from tui_make_status_line.
3791 (tui_locator_window::rerender): Update.
3792
f8532154
TT
37932019-09-20 Tom Tromey <tom@tromey.com>
3794
3795 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3796 (tui_locator_window::rerender): Update.
3797
2d81b349
TT
37982019-09-20 Tom Tromey <tom@tromey.com>
3799
3800 * tui/tui-winsource.h (struct tui_source_window_base)
3801 <~tui_source_window_base>: Don't declare.
3802 <fullname>: Remove.
3803 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3804 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3805 member.
3806 * tui/tui-source.c (tui_source_window::set_contents): Update.
3807 (tui_source_window::location_matches_p)
3808 (tui_source_window::maybe_update): Update.
3809
f14bec58
TT
38102019-09-20 Tom Tromey <tom@tromey.com>
3811
3812 * tui/tui-winsource.h (~tui_source_element): Remove.
3813 (tui_source_element): Update.
3814 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3815 * tui/tui-winsource.c (tui_show_source_line): Update.
3816 * tui/tui-source.c (tui_source_window::set_contents): Update.
3817 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3818
78d5933a
TT
38192019-09-20 Tom Tromey <tom@tromey.com>
3820
3821 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3822 declare.
3823 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3824 tui_clear_source_windows_detail.
3825 * tui/tui-winsource.h (struct tui_source_window_base)
3826 <clear_detail>: Don't declare.
3827 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3828 Remove.
3829 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3830
d4207696
TT
38312019-09-20 Tom Tromey <tromey@adacore.com>
3832
3833 PR ada/24919:
3834 * block.c (contained_in): Fix final return value.
3835
00f93c44
AM
38362019-09-20 Alan Modra <amodra@gmail.com>
3837
3838 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3839 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3840 (read_indirect_string_from_dwz): Use bfd accessor.
3841 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3842 * machoread.c (macho_symfile_read_all_oso): Likewise.
3843 * solib.c (solib_bfd_open): Likewise.
3844
e4153ae6
CB
38452019-09-19 Christian Biesinger <cbiesinger@google.com>
3846
3847 * eval.c: Move declaration of overload_resolution to...
3848 * value.h: ...here.
3849
c7ae7675
CB
38502019-09-19 Christian Biesinger <cbiesinger@google.com>
3851
3852 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3853 * arm-linux-tdep.c: Likewise.
3854 * arm-nbsd-nat.c: Likewise.
3855 * arm-tdep.h: Declare arm_apcs_32.
3856 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3857
e86f08d2
CB
38582019-09-19 Christian Biesinger <cbiesinger@google.com>
3859
3860 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3861 * dwarf2read.h: Declare dwarf_always_disassemble.
3862
f64e2f40
TV
38632019-09-19 Tom de Vries <tdevries@suse.de>
3864
3865 PR gdb/25009
3866 * source-cache.c (source_cache::ensure): Catch exception thrown during
3867 construction of the highlighter.
3868
fd361982
AM
38692019-09-18 Alan Modra <amodra@gmail.com>
3870
3871 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3872 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3873 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3874 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3875 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3876 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3877 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3878 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3879 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3880 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3881 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3882 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3883 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3884 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3885 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3886 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3887 * mi/mi-interp.c: Update throughout for bfd section macro and
3888 function changes.
3889 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3890 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3891
11061048
TT
38922019-09-18 Tom Tromey <tom@tromey.com>
3893
3894 * NEWS: Add entry.
3895 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3896 call rl_initialize.
3897 (tui_enable): Do not call rl_initialize.
3898
7a27b85f
CG
38992019-09-18 Christian Groessler <chris@groessler.org>
3900
3901 * alpha-linux-nat.c: Include gdbarch.h.
3902
f64eea3a
SM
39032019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3904
3905 * ui-file.c: Include cli/cli-style.h.
3906 (term_cli_styling): Remove cli_styling declaration.
3907
e6f7f6d1
AM
39082019-09-18 Alan Modra <amodra@gmail.com>
3909
3910 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3911 to bfd_asymbol_section.
3912
1d38e9d1
AM
39132019-09-18 Alan Modra <amodra@gmail.com>
3914
3915 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3916 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3917 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3918
90d92a63
AM
39192019-09-18 Alan Modra <amodra@gmail.com>
3920
3921 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3922 * spu-linux-nat.c (spu_bfd_open): Likewise.
3923
a3d181d2
CB
39242019-09-18 Christian Biesinger <cbiesinger@google.com>
3925
3926 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3927 to bool to match definition in dwarf2read.c.
3928
491144b5
CB
39292019-09-17 Christian Biesinger <cbiesinger@google.com>
3930
3931 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3932 (print_signatures): Likewise.
3933 (trust_pad_over_xvs): Likewise.
3934 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3935 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3936 * arm-linux-nat.c (arm_apcs_32): Likewise.
3937 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3938 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3939 * arm-tdep.c (arm_debug): Likewise.
3940 (arm_apcs_32): Likewise.
3941 * auto-load.c (debug_auto_load): Likewise.
3942 (auto_load_gdb_scripts): Likewise.
3943 (global_auto_load): Likewise.
3944 (auto_load_local_gdbinit): Likewise.
3945 (auto_load_local_gdbinit_loaded): Likewise.
3946 * auto-load.h (global_auto_load): Likewise.
3947 (auto_load_local_gdbinit): Likewise.
3948 (auto_load_local_gdbinit_loaded): Likewise.
3949 * breakpoint.c (disconnected_dprintf): Likewise.
3950 (breakpoint_proceeded): Likewise.
3951 (automatic_hardware_breakpoints): Likewise.
3952 (always_inserted_mode): Likewise.
3953 (target_exact_watchpoints): Likewise.
3954 (_initialize_breakpoint): Update.
3955 * breakpoint.h (target_exact_watchpoints): Change to bool.
3956 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3957 * cli/cli-cmds.c (trace_commands): Likewise.
3958 * cli/cli-cmds.h (trace_commands): Likewise.
3959 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3960 to bool*.
3961 * cli/cli-logging.c (logging_overwrite): Change to bool.
3962 (logging_redirect): Likewise.
3963 (debug_redirect): Likewise.
3964 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3965 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3966 to bool.
3967 <boolean_option_def>: Update.
3968 (struct flag_option_def): Change default type of Context to bool
3969 from int.
3970 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3971 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3972 (get_setshow_command_value_string): Likewise.
3973 * cli/cli-style.c (cli_styling): Change to bool.
3974 (source_styling): Likewise.
3975 * cli/cli-style.h (source_styling): Likewise.
3976 (cli_styling): Likewise.
3977 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3978 to bool.
3979 * command.h (var_types): Update comment.
3980 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3981 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3982 bool.
3983 (debug_compile_cplus_scopes): Likewise.
3984 * compile/compile-internal.h (compile_debug): Likewise.
3985 * compile/compile.c (compile_debug): Likewise.
3986 (struct compile_options) <raw>: Likewise.
3987 * cp-support.c (catch_demangler_crashes): Likewise.
3988 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3989 (usr_cmd_cris_dwarf2_cfi): Likewise.
3990 * csky-tdep.c (csky_debug): Likewise.
3991 * darwin-nat.c (enable_mach_exceptions): Likewise.
3992 * dcache.c (dcache_enabled_p): Likewise.
3993 * defs.h (info_verbose): Likewise.
3994 * demangle.c (demangle): Likewise.
3995 (asm_demangle): Likewise.
3996 * dwarf-index-cache.c (debug_index_cache): Likewise.
3997 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3998 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3999 * dwarf2read.c (check_physname): Likewise.
4000 (use_deprecated_index_sections): Likewise.
4001 (dwarf_always_disassemble): Likewise.
4002 * eval.c (overload_resolution): Likewise.
4003 * event-top.c (set_editing_cmd_var): Likewise.
4004 (exec_done_display_p): Likewise.
4005 * event-top.h (set_editing_cmd_var): Likewise.
4006 (exec_done_display_p): Likewise.
4007 * exec.c (write_files): Likewise.
4008 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4009 (debug_fbsd_nat): Likewise.
4010 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4011 Likewise.
4012 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4013 <backtrace_past_entry> Likewise.
4014 * gdb-demangle.h (demangle): Likewise.
4015 (asm_demangle): Likewise.
4016 * gdb_bfd.c (bfd_sharing): Likewise.
4017 * gdbcore.h (write_files): Likewise.
4018 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4019 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4020 * gdbthread.h (print_thread_events): Likewise.
4021 * gdbtypes.c (opaque_type_resolution): Likewise.
4022 (strict_type_checking): Likewise.
4023 * gnu-nat.c (gnu_debug_flag): Likewise.
4024 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4025 * guile/scm-param.c (pascm_variable): Add boolval.
4026 (add_setshow_generic): Update.
4027 (pascm_param_value): Update.
4028 (pascm_set_param_value_x): Update.
4029 * hppa-tdep.c (hppa_debug): Change to bool..
4030 * infcall.c (may_call_functions_p): Likewise.
4031 (coerce_float_to_double_p): Likewise.
4032 (unwind_on_signal_p): Likewise.
4033 (unwind_on_terminating_exception_p): Likewise.
4034 * infcmd.c (startup_with_shell): Likewise.
4035 * inferior.c (print_inferior_events): Likewise.
4036 * inferior.h (startup_with_shell): Likewise.
4037 (print_inferior_events): Likewise.
4038 * infrun.c (step_stop_if_no_debug): Likewise.
4039 (detach_fork): Likewise.
4040 (debug_displaced): Likewise.
4041 (disable_randomization): Likewise.
4042 (non_stop): Likewise.
4043 (non_stop_1): Likewise.
4044 (observer_mode): Likewise.
4045 (observer_mode_1): Likewise.
4046 (set_observer_mode): Update.
4047 (sched_multi): Change to bool.
4048 * infrun.h (debug_displaced): Likewise.
4049 (sched_multi): Likewise.
4050 (step_stop_if_no_debug): Likewise.
4051 (non_stop): Likewise.
4052 (disable_randomization): Likewise.
4053 * linux-tdep.c (use_coredump_filter): Likewise.
4054 (dump_excluded_mappings): Likewise.
4055 * linux-thread-db.c (auto_load_thread_db): Likewise.
4056 (check_thread_db_on_load): Likewise.
4057 * main.c (captured_main_1): Update.
4058 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4059 xx2_opt, boolean_opt>: Change to bool.
4060 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4061 * maint.c (maintenance_profile_p): Likewise.
4062 (per_command_time): Likewise.
4063 (per_command_space): Likewise.
4064 (per_command_symtab): Likewise.
4065 * memattr.c (inaccessible_by_default): Likewise.
4066 * mi/mi-main.c (mi_async): Likewise.
4067 (mi_async_1): Likewise.
4068 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4069 * nat/fork-inferior.h (startup_with_shell): Likewise.
4070 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4071 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4072 * nios2-tdep.c (nios2_debug): Likewise.
4073 * or1k-tdep.c (or1k_debug): Likewise.
4074 * parse.c (parser_debug): Likewise.
4075 * parser-defs.h (parser_debug): Likewise.
4076 * printcmd.c (print_symbol_filename): Likewise.
4077 * proc-api.c (procfs_trace): Likewise.
4078 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4079 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4080 (set_parameter_value): Update.
4081 (add_setshow_generic): Update.
4082 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4083 to bool*.
4084 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4085 int*.
4086 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4087 * record-btrace.c (record_btrace_target::store_registers): Update.
4088 * record-full.c (record_full_memory_query): Change to bool.
4089 (record_full_stop_at_limit): Likewise.
4090 * record-full.h (record_full_memory_query): Likewise.
4091 * remote-notif.c (notif_debug): Likewise.
4092 * remote-notif.h (notif_debug): Likewise.
4093 * remote.c (use_range_stepping): Likewise.
4094 (interrupt_on_connect): Likewise.
4095 (remote_break): Likewise.
4096 * ser-tcp.c (tcp_auto_retry): Likewise.
4097 * ser-unix.c (serial_hwflow): Likewise.
4098 * skip.c (debug_skip): Likewise.
4099 * solib-aix.c (solib_aix_debug): Likewise.
4100 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4101 (spu_auto_flush_cache_p): Likewise.
4102 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4103 Likewise.
4104 (struct info_print_options) <quiet>: Likewise.
4105 * symfile-debug.c (debug_symfile): Likewise.
4106 * symfile.c (auto_solib_add): Likewise.
4107 (separate_debug_file_debug): Likewise.
4108 * symfile.h (auto_solib_add): Likewise.
4109 (separate_debug_file_debug): Likewise.
4110 * symtab.c (basenames_may_differ): Likewise.
4111 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4112 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4113 (struct info_types_options) <quiet>: Likewise.
4114 * symtab.h (demangle): Likewise.
4115 (basenames_may_differ): Likewise.
4116 * target-dcache.c (stack_cache_enabled_1): Likewise.
4117 (code_cache_enabled_1): Likewise.
4118 * target.c (trust_readonly): Likewise.
4119 (may_write_registers): Likewise.
4120 (may_write_memory): Likewise.
4121 (may_insert_breakpoints): Likewise.
4122 (may_insert_tracepoints): Likewise.
4123 (may_insert_fast_tracepoints): Likewise.
4124 (may_stop): Likewise.
4125 (auto_connect_native_target): Likewise.
4126 (target_stop_and_wait): Update.
4127 (target_async_permitted): Change to bool.
4128 (target_async_permitted_1): Likewise.
4129 (may_write_registers_1): Likewise.
4130 (may_write_memory_1): Likewise.
4131 (may_insert_breakpoints_1): Likewise.
4132 (may_insert_tracepoints_1): Likewise.
4133 (may_insert_fast_tracepoints_1): Likewise.
4134 (may_stop_1): Likewise.
4135 * target.h (target_async_permitted): Likewise.
4136 (may_write_registers): Likewise.
4137 (may_write_memory): Likewise.
4138 (may_insert_breakpoints): Likewise.
4139 (may_insert_tracepoints): Likewise.
4140 (may_insert_fast_tracepoints): Likewise.
4141 (may_stop): Likewise.
4142 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4143 (make_thread_apply_all_options_def_group): Change argument from int*
4144 to bool*.
4145 (thread_apply_all_command): Update.
4146 (print_thread_events): Change to bool.
4147 * top.c (confirm): Likewise.
4148 (command_editing_p): Likewise.
4149 (history_expansion_p): Likewise.
4150 (write_history_p): Likewise.
4151 (info_verbose): Likewise.
4152 * top.h (confirm): Likewise.
4153 (history_expansion_p): Likewise.
4154 * tracepoint.c (disconnected_tracing): Likewise.
4155 (circular_trace_buffer): Likewise.
4156 * typeprint.c (print_methods): Likewise.
4157 (print_typedefs): Likewise.
4158 * utils.c (debug_timestamp): Likewise.
4159 (sevenbit_strings): Likewise.
4160 (pagination_enabled): Likewise.
4161 * utils.h (sevenbit_strings): Likewise.
4162 (pagination_enabled): Likewise.
4163 * valops.c (overload_resolution): Likewise.
4164 * valprint.h (struct value_print_options) <prettyformat_arrays,
4165 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4166 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4167 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4168 Likewise.
4169 * windows-nat.c (new_console): Likewise.
4170 (cygwin_exceptions): Likewise.
4171 (new_group): Likewise.
4172 (debug_exec): Likewise.
4173 (debug_events): Likewise.
4174 (debug_memory): Likewise.
4175 (debug_exceptions): Likewise.
4176 (useshell): Likewise.
4177 * windows-tdep.c (maint_display_all_tib): Likewise.
4178 * xml-support.c (debug_xml): Likewise.
4179
f1b620e9
MG
41802019-09-17 Mike Gulick <mgulick@mathworks.com>
4181
4182 * source.c (prepare_path_for_appending): New function.
4183 (openp): Make use of new function.
4184 (find_and_open_source): Search for the compilation directory and
4185 source file as a relative path beneath the directory search path.
4186
67f3ed6a
AB
41872019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4188
4189 * source-cache.c (source_cache::get_line_charpos): Catch
4190 exceptions and return false, this matches the behaviour documented
4191 in the header file.
4192
74332189
JB
41932019-09-17 Joel Brobecker <brobecker@adacore.com>
4194
4195 * ada-tasks.c (info_task): Remove quoting of the task's name.
4196
f2f24aa9
CB
41972019-09-16 Christian Biesinger <cbiesinger@google.com>
4198
4199 * symfile.c (auto_solib_add): Replace comment with a reference
4200 to the header file.
4201
6a062a93
CB
42022019-09-14 Christian Biesinger <cbiesinger@google.com>
4203
4204 * NEWS: Mention that gdb can now be compiled with Python 3
4205 on Windows.
4206
ec6c8338
AB
42072019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4208
4209 * maint.c (maint_print_section_data::maint_print_section_data):
4210 Force use of 'float log10 (float)' by casting the argument to
4211 float.
4212
aa17805f
AB
42132019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4214
4215 * maint.c: Add 'cmath' include.
4216 (struct maint_print_section_data): New structure.
4217 (print_section_index): New function.
4218 (print_bfd_section_info): Add header comment, small whitespace
4219 cleanup, and update to call new print_section_index function.
4220 (print_objfile_section_info): Likewise.
4221 (maint_obj_section_from_bfd_section): New function.
4222 (print_bfd_section_info_maybe_relocated): New function.
4223 (maintenance_info_sections): Add header comment, always use
4224 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4225
3dd9bb46
AB
42262019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4227
4228 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4229 inner scope, add check that the objfile has psymtabs before
4230 checking psymtabs_addrmap.
4231 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4232
4993045d
PW
42332019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4234
4235 * NEWS: Announce that Ada task names are now shown at more places,
4236 and between quotes (except in info task output).
4237 * gdb/ada-tasks.c (task_to_str): New function.
4238 (display_current_task_id): Call task_to_str.
4239 (task_command_1): Likewise.
4240 (print_ada_task_info): In non-mi mode, Properly align headers and data
4241 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4242
7a289707
RO
42432019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4244
4245 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4246 prstatus.pr_lwp.pr_info instead of making it up.
4247
f2aec7f6
CB
42482019-09-11 Christian Biesinger <cbiesinger@google.com>
4249
4250 * auto-load.c (auto_load_expand_dir_vars): Update.
4251 * defs.h (gdb_datadir): Change to std::string.
4252 (python_libdir): Likewise.
4253 (relocate_gdb_directory): Change return type to std::string.
4254 * guile/guile.c (gdbscm_data_directory): Update.
4255 (initialize_scheme_side): Update.
4256 * jit.c (jit_reader_dir): Change to std::string.
4257 (jit_reader_load_command): Update.
4258 * main.c (gdb_datadir): Change to std::string.
4259 (python_libdir): Likewise.
4260 (set_gdb_data_directory): Update.
4261 (relocate_path): Change to return std::string.
4262 (relocate_gdb_directory): Change to return std::string.
4263 (relocate_gdbinit_path_maybe_in_datadir): Update.
4264 (captured_main_1): Update.
4265 * python/python.c (do_start_initialization): Update.
4266 * top.c (show_gdb_datadir): Update.
4267 * xml-syscall.c (xml_init_syscalls_info): Update.
4268 (init_syscalls_info): Update.
4269
9224a013
CB
42702019-09-11 Christian Biesinger <cbiesinger@google.com>
4271
4272 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4273 out of get_init_files.
4274 (get_init_files): Update.
4275
f48cd836
CB
42762019-09-11 Christian Biesinger <cbiesinger@google.com>
4277
4278 * main.c (get_init_files): Change to use std::string.
4279 (captured_main_1): Update.
4280 (print_gdb_help): Update.
4281
9cab7ecd
AT
42822019-09-11 Ali Tamur <tamur@google.com>
4283
4284 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4285 implementation.
4286
67547d89
CB
42872019-09-11 Christian Biesinger <cbiesinger@google.com>
4288
4289 * dbxread.c (read_dbx_symtab): Update.
4290 * dwarf2read.c (load_partial_dies): Update.
4291 * mdebugread.c (parse_partial_symbols): Update.
4292 (handle_psymbol_enumerators): Update.
4293 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4294 * psymtab.c (add_psymbol_to_bcache): Likewise.
4295 (add_psymbol_to_list): Likewise.
4296 * symtab.c (symbol_set_names): Likewise.
4297 * symtab.h (symbol_set_names): Likewise.
4298 * xcoffread.c (scan_xcoff_symtab): Update.
4299
64b2d4a0
TT
43002019-09-11 Tom Tromey <tom@tromey.com>
4301
4302 * symfile-mem.c (symbol_file_add_from_memory): Use
4303 bfd_set_filename.
4304 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4305 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4306
3b00ef10
TT
43072019-09-10 Tom Tromey <tromey@adacore.com>
4308
4309 * dwarf-index-write.c (write_psymbols): Extend error message.
4310 (debug_names::insert): Add Ada code.
4311 (debug_names::write_psymbols): Remove Ada check.
4312 (debug_names) <m_string_obstack>: New member.
4313 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4314 (gdb_index_symbol_name_matcher::matches): Remove.
4315 (mapped_index_base::find_name_components_bounds): Add "lang"
4316 parameter.
4317 (mapped_index_base::build_name_components): Also split names
4318 according to Ada syntax.
4319 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4320 type of "match_callback".
4321 (check_match, check_find_bounds_finds)
4322 (dw2_expand_symtabs_matching): Update.
4323 (dw2_debug_names_iterator): Add new constructor.
4324 (dw2_debug_names_map_matching_symbols): New function.
4325 (dw2_debug_names_expand_symtabs_matching): Update.
4326 (dwarf2_debug_names_functions): Use
4327 dw2_debug_names_map_matching_symbols.
4328
aa391654
TT
43292019-09-10 Tom Tromey <tromey@adacore.com>
4330
4331 * dwarf2read.c (dw2_get_file_names_reader): Add the
4332 CU's file name to the results.
4333
b054970d
TT
43342019-09-10 Tom Tromey <tromey@adacore.com>
4335
4336 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4337 map_matching_symbols. Update.
4338 * dwarf2read.c (dw2_map_matching_symbols): Update.
4339 * psymtab.c (match_partial_symbol): Change type; update.
4340 (psym_map_matching_symbols): Likewise.
4341 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4342 type; update.
4343 * symfile.h (struct quick_symbol_functions)
4344 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4345 Remove "match".
4346
6a3dbf1b
TT
43472019-09-10 Tom Tromey <tromey@adacore.com>
4348
4349 * psymtab.c (map_block): Remove.
4350 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4351 * symtab.c (iterate_over_symbols_terminated): New function.
4352 * symtab.c (iterate_over_symbols_terminated): Declare.
4353
6969f124
TT
43542019-09-10 Tom Tromey <tromey@adacore.com>
4355
4356 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4357 * language.h (struct language_defn) <la_iterate_over_symbols>:
4358 Return bool.
4359 * symtab.c (iterate_over_symbols): Return bool.
4360 * symtab.h (iterate_over_symbols): Return bool.
4361
199b4314
TT
43622019-09-10 Tom Tromey <tromey@adacore.com>
4363
4364 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4365 (add_nonlocal_symbols): Update.
4366 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4367 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4368 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4369 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4370 Change type of "callback". Remove "data".
4371
a084a2a6
AT
4372
43732019-09-09 Ali Tamur <tamur@google.com>
4374
4375 * dwarf2read.c (comp_unit_head): Update comment.
4376 (dwarf2_dwo_name): New function declaration.
4377 (dwarf_unit_type_name): New function declaration.
4378 (read_comp_unit_head): Add support for new compilation units,
4379 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4380 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4381 (currently named as "signature") in their header. Also clarify error
4382 messages.
4383 (lookup_dwo_id): New function. Returns the dwo id of the given
4384 compile unit.
4385 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4386 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4387 functions.
4388 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4389 (dwarf2_dwo_name): Get the dwo name if present.
4390 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4391 purposes.
4392
25a2915e
TT
43932019-09-09 Tom Tromey <tom@tromey.com>
4394
4395 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4396
e4df0874
PW
43972019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4398
4399 * python/python.c (do_start_initialization): Make progname_copy static,
4400 to avoid a leak report.
4401
8634b462
TT
44022019-09-08 Tom Tromey <tom@tromey.com>
4403
4404 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4405
c7f839cb
SM
44062019-09-07 Simon Marchi <simon.marchi@efficios.com>
4407
4408 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4409 Change type to gdb::optional<block_enum>.
4410 (dw2_symtab_iter_init): Change block_index parameter type
4411 to gdb::optional<block_enum>.
4412 (dw2_lookup_symbol): Change block_index parameter
4413 type to block_enum.c
4414 (dw2_debug_names_lookup_symbol): Likewise.
4415 * psymtab.c (psym_lookup_symbol): Likewise.
4416 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4417 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4418 Likewise.
4419
ead0e69a
CB
44202019-09-06 Christian Biesinger <cbiesinger@google.com>
4421
4422 * defs.h (relocate_gdb_directory): Change int to bool in
4423 signature and rename flag to relocatable.
4424 * main.c (relocate_path): Likewise.
4425 (relocate_gdb_directory): Likewise.
4426
b16c44de
AM
44272019-09-06 Alan Modra <amodra@gmail.com>
4428
4429 * coffread.c (coff_symfile_read): Constify filename variable.
4430 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4431 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4432 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4433 * solib.c (reload_shared_libraries_1): Likewise.
4434 * symfile.c (reread_symbols): Likewise.
4435 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4436 * solib-darwin.c (darwin_bfd_open): Likewise.
4437 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4438
06ff036e
AB
44392019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4440
4441 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4442 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4443
4e962e74
TT
44442019-09-03 Tom Tromey <tromey@adacore.com>
4445
4446 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4447 types.
4448 (has_negatives): Unbias a range type bound.
4449 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4450 * gdbtypes.c (operator==): Handle new field.
4451 (create_range_type): Add "bias" parameter.
4452 (create_static_range_type, resolve_dynamic_range): Update.
4453 * gdbtypes.h (struct range_bounds) <bias>: New member.
4454 (create_range_type): Add bias parameter.
4455 * printcmd.c (print_scalar_formatted): Unbias range types.
4456 * value.c (unpack_long): Unbias range types.
4457 (pack_long): Bias range types.
4458
d90b8f26
AH
44592019-09-02 Alan Hayward <alan.hayward@arm.com>
4460
4461 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4462 probe arguments.
4463
fe01123e
AH
44642019-09-02 Alan Hayward <alan.hayward@arm.com>
4465
4466 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4467 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4468 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4469 (compile_probe_arg): Likewise.
4470 * probe.h (get_argument_count): Likewise.
4471 * solib-svr4.c (solib_event_probe_action): Likewise.
4472 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4473
e661ef01
AH
44742019-09-02 Alan Hayward <alan.hayward@arm.com>
4475
4476 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4477 code to here...
4478 (svr4_create_solib_event_breakpoints): ...from here.
4479
47a536d9
SDJ
44802019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4481
4482 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4483 suffix from warning message.
4484
d6a00eba
TT
44852019-08-30 Tom Tromey <tom@tromey.com>
4486
4487 * tui/tui-winsource.h (struct tui_source_window_base)
4488 <refresh_all>: Don't declare.
4489 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4490 Remove.
4491 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4492 tui_show_locator_content.
4493 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4494 declare.
4495 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4496 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4497 declare.
4498
55b2657b
TT
44992019-08-30 Tom Tromey <tom@tromey.com>
4500
4501 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4502
12a8555a
TT
45032019-08-30 Tom Tromey <tom@tromey.com>
4504
4505 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4506 Remove unnecessary forward declarations.
4507
900ac242
TT
45082019-08-30 Tom Tromey <tom@tromey.com>
4509
4510 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4511 rerender.
4512 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4513 tui_show_locator_content.
4514
99ab33fb
TT
45152019-08-30 Tom Tromey <tom@tromey.com>
4516
4517 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4518 (tui_locator_window::rerender): Rewrite using body of previous
4519 tui_show_locator_content.
4520
e594a5d1
TT
45212019-08-30 Tom Tromey <tom@tromey.com>
4522
4523 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4524 set_locator_fullname>: New methods.
4525 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4526 Rename from tui_set_locator_fullname.
4527 (tui_locator_window::set_locator_info): Rename from
4528 tui_set_locator_info. Return bool.
4529 (tui_update_locator_fullname, tui_show_frame_info): Update.
4530
715bb467
TT
45312019-08-30 Tom Tromey <tom@tromey.com>
4532
4533 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4534
772f3f03
TT
45352019-08-30 Tom Tromey <tom@tromey.com>
4536
4537 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4538 call touchwin.
4539
108e13ab
TT
45402019-08-30 Tom Tromey <tom@tromey.com>
4541
4542 * tui/tui-wingeneral.c (box_win): Assume win_info and
4543 win_info->handle cannot be NULL.
4544
cdaa6eb4
TT
45452019-08-30 Tom Tromey <tom@tromey.com>
4546
4547 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4548 refresh_window>: Declare.
4549 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4550 resize.
4551 (tui_data_item_window::rerender): Rename from
4552 tui_display_register.
4553 (tui_data_item_window::refresh_window): New method.
4554 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4555 no-op.
4556
89df7f90
TT
45572019-08-30 Tom Tromey <tom@tromey.com>
4558
4559 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4560 regs_column_count, current_group>: Move later. Now private.
4561 <get_current_group>: New method.
4562 * tui/tui-regs.c (tui_reg_command): Update.
4563 * tui/tui-layout.c (tui_set_layout): Update.
4564
1bf2866a
TT
45652019-08-30 Tom Tromey <tom@tromey.com>
4566
4567 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4568 (tui_data_window::rerender): Don't call
4569 check_and_display_highlight_if_needed.
4570 (tui_data_window::refresh_all): Remove call to
4571 erase_data_content.
4572
0670413d
TT
45732019-08-30 Tom Tromey <tom@tromey.com>
4574
4575 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4576 (tui_data_window::display_registers_from)
4577 (tui_data_window::display_reg_element_at_line)
4578 (tui_data_window::display_registers_from_line): Remove checks of
4579 "empty".
4580
18bb55c7
TT
45812019-08-30 Tom Tromey <tom@tromey.com>
4582
4583 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4584 Don't declare.
4585 * tui/tui-regs.c (tui_data_window::show_registers): Call
4586 rerender.
4587 (tui_data_window::rerender): Rename from display_all_data.
4588 (tui_data_window::rerender): Remove old implementation.
4589
1f6d2f10
TT
45902019-08-30 Tom Tromey <tom@tromey.com>
4591
4592 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4593 text.
4594 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4595
16d01f9c
BW
45962019-08-29 Bernhard Wodok <barto@gmx.net>
4597 Sergio Durigan Junior <sergiodj@redhat.com>
4598
4599 PR win32/24284
4600 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4601
d8f27c60
AB
46022019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4603
4604 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4605 when searching for types.
4606
1f20c35e
AB
46072019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4608
4609 * f-lang.c (f_language_defn): Use f_print_typedef.
4610 * f-lang.h (f_print_typedef): Declare.
4611 * f-typeprint.c (f_print_typedef): Define.
4612
550105b7
CB
46132019-08-27 Christian Biesinger <cbiesinger@google.com>
4614
4615 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4616
4acfdd20
AB
46172019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4618
4619 * cli/cli-utils.c (info_print_options_defs): Delete.
4620 (make_info_print_options_def_group): Delete.
4621 (extract_info_print_options): Delete.
4622 (info_print_command_completer): Delete.
4623 (info_print_args_help): Add extra parameter, and optionally
4624 include text about -n flag.
4625 * cli/cli-utils.h (struct info_print_options): Delete.
4626 (extract_info_print_options): Delete declaration.
4627 (info_print_command_completer): Delete declaration.
4628 (info_print_args_help): Add extra parameter, extend header
4629 comment.
4630 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4631 search_symbols.
4632 * stack.c (struct info_print_options): New type.
4633 (info_print_options_defs): New file scoped variable.
4634 (make_info_print_options_def_group): New static function.
4635 (info_print_command_completer): New static function.
4636 (info_locals_command): Update to use new local functions.
4637 (info_args_command): Likewise.
4638 (_initialize_stack): Add extra parameter to calls to
4639 info_print_args_help.
4640 * symtab.c (search_symbols): Add extra parameter, use this to
4641 possibly excluse non-debug symbols.
4642 (symtab_symbol_info): Add extra parameter, which is passed on to
4643 search_symbols.
4644 (struct info_print_options): New type.
4645 (info_print_options_defs): New file scoped variable.
4646 (make_info_print_options_def_group): New static function.
4647 (info_print_command_completer): New static function.
4648 (info_variables_command): Update to use local functions, and pass
4649 extra parameter through to symtab_symbol_info.
4650 (info_functions_command): Likewise.
4651 (info_types_command): Pass additional argument through to
4652 symtab_symbol_info.
4653 (rbreak_command): Pass extra argument to search_symbols.
4654 (_initialize_symtab): Add extra arguments for calls to
4655 info_print_args_help, and update help text for 'info variables',
4656 'whereis', and 'info functions' commands.
4657 * symtab.h (search_symbols): Add extra argument to declaration.
4658 * NEWS: Mention new flags.
4659
9aa55206
CB
46602019-08-26 Christian Biesinger <cbiesinger@google.com>
4661
4662 * symtab.c (lookup_static_symbol): Call the new function (and move
4663 it down to be next to lookup_global_symbol).
4664 (struct global_sym_lookup_data): Add block_enum member and rename to...
4665 (struct global_or_static_sym_lookup_data): ...this.
4666 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4667 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4668 (lookup_symbol_global_or_static_iterator_cb): ...this.
4669 (lookup_global_or_static_symbol): New function.
4670 (lookup_global_symbol): Call new function.
4671
5c31b358
TV
46722019-08-26 Tom de Vries <tdevries@suse.de>
4673
4674 PR c++/24852
4675 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4676 when pc_probe.prob == NULL.
4677
23c13d42
SM
46782019-08-25 Simon Marchi <simon.marchi@efficios.com>
4679
4680 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4681 variable symbol_linkage to symbol_linkage_.
4682
beadd3e8
SM
46832019-08-25 Simon Marchi <simon.marchi@efficios.com>
4684
4685 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4686 represent whether the symbol is static, dynamic, or we don't
4687 know.
4688
e3ec872f
YS
46892019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4690
4691 * gdb/rx-tdep.c (rx_register_names): New.
4692 (rx_register_name): Delete.
4693 (rx_psw_type): Delete.
4694 (rx_fpsw_type): Delete.
4695 (rx_register_type): Delete.
4696 (rx_gdbarch_init): Convert target-descriptions.
4697 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4698 * gdb/features/Makefile: Add rx.xml.
4699 * gdb/features/rx.xml: New.
4700 * gdb/features/rx.c: Generated.
4701 * gdb/NEWS: Mention target description support.
4702
d0509ba4
CB
47032019-08-22 Christian Biesinger <cbiesinger@google.com>
4704
4705 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4706 *slot_ptr.
4707
2d41fa11
SDJ
47082019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4709
4710 * configure.ac: Don't check for 'dlfcn.h' (moved to
4711 gdbsupport/common.m4).
4712 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4713 'gdbsupport/'.
4714 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4715 * compile/compile-c-support.c: Include
4716 'gdbsupport/gdb-dlfcn.h'.
4717 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4718 * gdb-dlfcn.c: Move to...
4719 * gdbsupport/gdb-dlfcn.c: ... here.
4720 * gdb-dlfcn.h: Move to...
4721 * gdbsupport/gdb-dlfcn.h: ... here.
4722
de8af808
SL
47232019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4724
4725 * nios2-tdep.c (struct reg_value): Improve comments. Make
4726 the offset field signed.
4727
27204489
CB
47282019-08-22 Christian Biesinger <cbiesinger@google.com>
4729
4730 * python/lib/gdb/__init__.py (_execute_file): New function.
4731 * python/python.c (python_run_simple_file): Call gdb._execute_file
4732 on Windows.
4733
43771869
AB
47342019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4735
4736 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4737 all uses as this was never set to anything but a zero value.
4738
26c957f1
PA
47392019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4740
4741 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4742
c07aae6e
CB
47432019-08-21 Christian Biesinger <cbiesinger@google.com>
4744
4745 * tui/tui-data.h (tui_gen_win_info): Add an =default
4746 move constructor, required by some GCC versions.
4747
3960cb7a
JF
47482019-08-21 Jinke Fan <fanjinke51@yeah.net>
4749
4750 * go32-nat.c (go32_sysinfo): Add hygon_p.
4751
04c72a68
TT
47522019-08-20 Tom Tromey <tom@tromey.com>
4753
4754 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4755 line_from_reg_element_no, first_reg_element_no_inline,
4756 display_all_data, delete_data_content_windows,
4757 erase_data_content>: Now private.
4758
072272ce
TT
47592019-08-20 Tom Tromey <tom@tromey.com>
4760
4761 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4762 (tui_unhighlight_win, tui_highlight_win)
4763 (tui_win_info::make_window): Update.
4764 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4765
973961bd
TT
47662019-08-20 Tom Tromey <tom@tromey.com>
4767
4768 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4769 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4770 (MAX_PID_WIDTH): Move to tui-stack.c.
4771 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4772 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4773 (MAX_PID_WIDTH): Move from tui-data.h.
4774
ab0e1f1a
TT
47752019-08-20 Tom Tromey <tom@tromey.com>
4776
4777 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4778 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4779 (box_win): Update.
4780 (tui_gen_win_info::make_window): Rename from tui_make_window.
4781 (tui_win_info::make_window): New method.
4782 (tui_gen_win_info::make_visible): Update.
4783 * tui/tui-source.c (tui_source_window::set_contents): Update.
4784 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4785 (tui_data_window::display_registers_from): Update.
4786 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4787 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4788 Declare.
4789 <can_box>: Remove.
4790 <title>: Remove.
4791 (struct tui_win_info) <make_window>: Declare.
4792 <can_box>: Now virtual.
4793 <title>: New member.
4794 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4795 * tui/tui-command.c (tui_cmd_window::resize): Update.
4796
100c2bf3
TT
47972019-08-20 Tom Tromey <tom@tromey.com>
4798
4799 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4800 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4801 (tui_data_window::check_register_values): Update.
4802
fa4dc567
TT
48032019-08-20 Tom Tromey <tom@tromey.com>
4804
4805 * tui/tui-regs.h (struct tui_data_window): Use
4806 DISABLE_COPY_AND_ASSIGN.
4807 <regs_content>: Change type, removing unique_ptr.
4808 <tui_data_window>: Add move constructor.
4809 * tui/tui-regs.c (tui_data_window::show_registers)
4810 (tui_data_window::show_register_group)
4811 (tui_data_window::display_registers_from)
4812 (tui_data_window::display_registers_from)
4813 (tui_data_window::first_data_item_displayed)
4814 (tui_data_window::delete_data_content_windows)
4815 (tui_data_window::rerender, tui_data_window::refresh_window)
4816 (tui_data_window::check_register_values): Update.
4817
ca02d7c8
TT
48182019-08-20 Tom Tromey <tom@tromey.com>
4819
4820 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4821 show_register_group>: Declare.
4822 (tui_show_register_group): Don't declare.
4823 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4824 tui_show_registers.
4825 (tui_data_window::show_register_group): Rename from
4826 tui_show_register_group.
4827 (tui_data_window::check_register_values, tui_reg_command):
4828 Update.
4829 * tui/tui-layout.c (tui_set_layout): Update.
4830
63356bfd
TT
48312019-08-20 Tom Tromey <tom@tromey.com>
4832
4833 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4834 Declare.
4835 (tui_check_register_values): Don't declare.
4836 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4837 from tui_check_register_values.
4838 * tui/tui-hooks.c (tui_register_changed): Update.
4839
42cc14a7
TT
48402019-08-20 Tom Tromey <tom@tromey.com>
4841
4842 * tui/tui-regs.c (tui_reg_layout): Move later.
4843 (tui_show_registers): Don't enable TUI mode or change layout.
4844
b9ad3686
TT
48452019-08-20 Tom Tromey <tom@tromey.com>
4846
4847 * tui/tui-regs.h (struct tui_data_item_window)
4848 <~tui_data_item_window>: Remove.
4849 <content>: Now a unique_xmalloc_ptr.
4850 * tui/tui-regs.c (tui_register_format): Return a
4851 unique_xmalloc_ptr.
4852 (tui_get_register): Update.
4853 (~tui_data_item_window): Remove.
4854 (tui_data_window::display_registers_from, tui_display_register):
4855 Update.
4856 * tui/tui-io.h (tui_expand_tabs): Update.
4857 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4858 Remove "col" parameter.
4859
8e114aab
TT
48602019-08-20 Tom Tromey <tom@tromey.com>
4861
4862 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4863 field.
4864 * tui/tui-regs.c (~tui_data_item_window): Update.
4865
1a4f81dd
TT
48662019-08-20 Tom Tromey <tom@tromey.com>
4867
4868 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4869 earlier.
4870
0f8d8876
TT
48712019-08-20 Tom Tromey <tom@tromey.com>
4872
4873 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4874
605dc2c2
TT
48752019-08-20 Tom Tromey <tom@tromey.com>
4876
4877 * tui/tui-source.h (struct tui_source_window): Update.
4878 * tui/tui-regs.c (tui_show_registers): Update.
4879 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4880 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4881 (NO_REGS_STRING): Remove defines.
4882
aedbe3bb
CM
48832019-08-20 Conrad Meyer <cem@FreeBSD.org>
4884
4885 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4886 unnecessary thread walk if remote doesn't support the packet.
4887
7ce8f214
TT
48882019-08-19 Tom Tromey <tromey@adacore.com>
4889
4890 * python/py-value.c (value_has_field): Fix indentation.
4891
f21c2bd7
TT
48922019-08-19 Tom Tromey <tromey@adacore.com>
4893
4894 * printcmd.c (do_one_display, info_display_command): Update.
4895 * block.h (contained_in): Return bool. Add allow_nested
4896 parameter.
4897 * block.c (contained_in): Return bool. Add allow_nested
4898 parameter.
4899
d806ea2d
TT
49002019-08-19 Tom Tromey <tom@tromey.com>
4901
4902 * configure: Rebuild.
4903 * configure.ac: Disallow the combination of -static-libstdc++ and
4904 source highlight.
4905 * source-cache.c (get_language_name): Handle rust.
4906 (source_cache::get_source_lines): Ignore highlighting exceptions.
4907
398fdd60
TT
49082019-08-16 Tom Tromey <tom@tromey.com>
4909
4910 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4911 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4912 (struct tui_source_window_base) <make_visible, refresh_window,
4913 resize>: Remove methods.
4914 <execution_info>: Remove field.
4915 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4916 (tui_show_source_line, tui_source_window_base)
4917 (~tui_source_window_base): Update.
4918 (tui_source_window_base::resize)
4919 (tui_source_window_base::make_visible)
4920 (tui_source_window_base::refresh_window): Remove.
4921 (tui_source_window_base::update_exec_info): Update.
4922 * tui/tui-source.c (tui_source_window::set_contents): Update.
4923 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4924
e699d331
TT
49252019-08-16 Tom Tromey <tom@tromey.com>
4926
4927 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4928 deprecated_query_hook.
4929
bb01dbfc
TT
49302019-08-16 Tom Tromey <tom@tromey.com>
4931
4932 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4933 (tui_update_source_windows_with_line): Update.
4934 * tui/tui-source.h (struct tui_source_window)
4935 <show_symtab_source>: Declare.
4936 (tui_show_symtab_source): Don't declare.
4937 * tui/tui-source.c (tui_show_symtab_source): Rename from
4938 tui_show_symtab_source.
4939
81c82c4b
TT
49402019-08-16 Tom Tromey <tom@tromey.com>
4941
4942 * tui/tui-winsource.h (struct tui_source_window_base)
4943 <set_contents>: Declare.
4944 * tui/tui-winsource.c
4945 (tui_source_window_base::update_source_window_as_is): Update.
4946 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4947 Declare.
4948 (tui_set_source_content): Don't declare.
4949 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4950 tui_set_source_content.
4951 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4952 Declare.
4953 (tui_set_disassem_content): Don't declare.
4954 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4955 tui_set_disassem_content.
4956
2ddaf614
TT
49572019-08-16 Tom Tromey <tom@tromey.com>
4958
4959 * tui/tui-winsource.h (struct tui_source_window_base)
4960 <update_breakpoint_info>: Declare.
4961 (tui_update_breakpoint_info): Don't declare.
4962 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4963 (tui_update_all_breakpoint_info): Update.
4964 (tui_source_window_base::update_breakpoint_info): Rename from
4965 tui_update_breakpoint_info.
4966 (tui_source_window_base::update_exec_info): Update.
4967
017f9828
TT
49682019-08-16 Tom Tromey <tom@tromey.com>
4969
4970 * tui/tui-winsource.h (struct tui_source_window_base)
4971 <update_source_window>: Declare.
4972 (tui_update_source_window): Don't declare.
4973 * tui/tui-winsource.c
4974 (tui_source_window_base::update_source_window): Rename from
4975 tui_update_source_window.
4976 (tui_source_window_base::rerender): Update.
4977 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4978 * tui/tui-disasm.c (tui_show_disassem)
4979 (tui_show_disassem_and_update_source)
4980 (tui_disasm_window::maybe_update): Update.
4981
ed8358e9
TT
49822019-08-16 Tom Tromey <tom@tromey.com>
4983
4984 * tui/tui-winsource.h (struct tui_source_window_base)
4985 <update_source_window_as_is>: Declare.
4986 (tui_update_source_window_as_is): Don't declare.
4987 * tui/tui-winsource.c (tui_update_source_window): Update
4988 (tui_source_window_base::update_source_window_as_is): Rename from
4989 tui_update_source_window_as_is.
4990 (tui_source_window_base::refill): Update.
4991 * tui/tui-source.c (tui_show_symtab_source): Update.
4992 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4993 Update.
4994
20149b6b
TT
49952019-08-16 Tom Tromey <tom@tromey.com>
4996
4997 * tui/tui-winsource.h (tui_update_source_window)
4998 (tui_update_source_window_as_is): Remove "noerror" parameter.
4999 * tui/tui-winsource.c (tui_update_source_window)
5000 (tui_update_source_window_as_is): Remove "noerror" parameter.
5001 (tui_update_source_windows_with_addr)
5002 (tui_update_source_windows_with_line)
5003 (tui_source_window_base::rerender)
5004 (tui_source_window_base::refill): Update.
5005 * tui/tui-source.h (tui_set_source_content)
5006 (tui_show_symtab_source): Remove "noerror" parameter.
5007 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5008 parameter.
5009 (tui_show_symtab_source): Likewise.
5010 (tui_source_window::maybe_update): Update.
5011 * tui/tui-disasm.c (tui_show_disassem)
5012 (tui_show_disassem_and_update_source)
5013 (tui_disasm_window::do_scroll_vertical)
5014 (tui_disasm_window::maybe_update): Update.
5015
2d83e710
TT
50162019-08-16 Tom Tromey <tom@tromey.com>
5017
5018 * tui/tui.c (tui_is_window_visible): Update.
5019 * tui/tui-wingeneral.c (tui_make_window)
5020 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5021 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5022 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5023 (tui_set_win_height_command, parse_scrolling_args): Update.
5024 * tui/tui-source.c (tui_source_window::style_changed): Update.
5025 * tui/tui-regs.c (tui_show_registers)
5026 (tui_data_window::first_data_item_displayed)
5027 (tui_data_window::delete_data_content_windows)
5028 (tui_check_register_values, tui_reg_command): Update.
5029 * tui/tui-disasm.c (tui_show_disassem): Update.
5030 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5031 method.
5032 <is_visible>: Remove field.
5033 * tui/tui-data.c (tui_next_win, tui_prev_win)
5034 (tui_delete_invisible_windows): Update.
5035
d4ab829a
TT
50362019-08-16 Tom Tromey <tom@tromey.com>
5037
5038 * tui/tui-winsource.h (struct tui_source_window_base)
5039 <m_has_locator>: Remove.
5040 * tui/tui-layout.c (show_source_disasm_command, show_data)
5041 (show_source_or_disasm_and_command): Update.
5042
aa7ca1bb
AH
50432019-08-16 Alan Hayward <alan.hayward@arm.com>
5044
5045 * NEWS (Other MI changes): New subsection.
5046 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5047 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5048 * arch-utils.c (default_get_pc_address_flags): New function.
5049 * arch-utils.h (default_get_pc_address_flags): New declaration.
5050 * gdbarch.sh: Add get_pc_address_flags.
5051 * gdbarch.c: Regenerate.
5052 * gdbarch.h: Likewise.
5053 * stack.c (print_pc): New function.
5054 (print_frame_info) (print_frame): Call print_pc.
5055
6eac171f
TV
50562019-08-16 Tom de Vries <tdevries@suse.de>
5057
5058 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5059 print_objfile_section_info.
5060
3df505f6
TT
50612019-08-15 Tom Tromey <tom@tromey.com>
5062
5063 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5064 calling update_cmdwin_start_line.
5065 * tui/tui-winsource.h (struct tui_source_window_base)
5066 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5067 <rerender>: Declare.
5068 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5069 Call rerender.
5070 (tui_source_window_base::set_new_height): Remove.
5071 (tui_source_window_base::rerender): Rename from
5072 do_make_visible_with_new_height.
5073 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5074 resize method.
5075 (tui_win_info::make_invisible_and_set_new_height)
5076 (tui_win_info::make_visible_with_new_height): Remove.
5077 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5078 Declare.
5079 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5080 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5081 do_make_visible_with_new_height>: Don't declare.
5082 <rerender>: Declare.
5083 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5084 set_new_height.
5085 (tui_data_window::do_make_visible_with_new_height): Remove.
5086 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5087 call tui_show_locator_content.
5088 (tui_gen_win_info::resize): Call rerender.
5089 (show_source_or_disasm_and_command): Don't call
5090 tui_show_locator_content.
5091 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5092 method.
5093 (struct tui_win_info) <rerender>: Declare.
5094 <set_new_height, make_invisible_and_set_new_height,
5095 make_visible_with_new_height>: Don't declare.
5096 * tui/tui-data.c (tui_win_list::rerender): New method.
5097 * tui/tui-command.h (struct tui_cmd_window)
5098 <do_make_visible_with_new_height>: Don't declare.
5099 * tui/tui-command.c
5100 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5101
272560b5
TT
51022019-08-15 Tom Tromey <tromey@adacore.com>
5103
5104 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5105 * ada-lang.c (ada_enum_name): Likewise.
5106
08235187
CB
51072019-08-15 Christian Biesinger <cbiesinger@google.com>
5108
5109 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5110 leading underscore.
5111 (GdbOutputErrorFile): Likewise.
5112 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5113 accordingly.
5114 (execute_unwinders): Rename to have a leading underscore.
5115 (auto_load_packages): Likewise.
5116 (global scope): Adjust call to auto_load_packages accordingly.
5117 (GdbSetPythonDirectory): Likewise.
5118 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5119 instead of execute_unwinders.
5120
db502012
TT
51212019-08-15 Tom Tromey <tom@tromey.com>
5122
5123 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5124 (show_data): Don't change window visibility.
5125 (tui_gen_win_info::resize): Remove special case for command
5126 window. Use wresize, when available.
5127 (show_source_or_disasm_and_command): Don't change window
5128 visibility.
5129 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5130 <make_visible>: New method.
5131 * tui/tui-command.c (tui_cmd_window::resize): New method.
5132
3891b65e
TT
51332019-08-15 Tom Tromey <tom@tromey.com>
5134
5135 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5136 (struct tui_source_windows): New.
5137 * tui/tui-winsource.c (tui_display_main): Update.
5138 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5139 (new_height_ok, parse_scrolling_args): Update.
5140 * tui/tui-layout.c (show_layout, show_data): Update.
5141 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5142 (tui_add_to_source_windows): Don't declare.
5143 * tui/tui-data.c (source_windows, tui_source_windows)
5144 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5145
ee556432
TT
51462019-08-15 Tom Tromey <tom@tromey.com>
5147
5148 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5149 Rename from reset.
5150 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5151 * tui/tui-layout.c (show_source_disasm_command, show_data):
5152 Update.
5153 (tui_gen_win_info::resize): Rename.
5154 (show_source_or_disasm_and_command): Update.
5155 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5156 reset.
5157
46f438e3
TT
51582019-08-15 Tom Tromey <tom@tromey.com>
5159
5160 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5161 * tui/tui-interp.c (tui_interp::init): Don't call
5162 tui_initialize_static_data.
5163 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5164
f4ce562c
TT
51652019-08-15 Tom Tromey <tom@tromey.com>
5166
5167 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5168 examine tui_win_list.
5169
c398c3d0
TT
51702019-08-15 Tom Tromey <tom@tromey.com>
5171
5172 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5173 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5174 tui_clear_source_content.
5175 (tui_clear_source_content): Remove.
5176 (tui_source_window_base::do_erase_source_content): Hoist call to
5177 content.clear().
5178 * tui/tui-stack.c (tui_show_frame_info): Don't call
5179 tui_clear_source_content.
5180
e25d2004
TT
51812019-08-15 Tom Tromey <tom@tromey.com>
5182
5183 * tui/tui-winsource.h (struct tui_source_window_base)
5184 <do_erase_source_content>: New method.
5185 <erase_source_content>: New method.
5186 (tui_erase_source_content): Don't declare.
5187 * tui/tui-winsource.c (tui_clear_source_content): Update.
5188 (tui_source_window_base::do_erase_source_content): Rename from
5189 tui_erase_source_content.
5190 (tui_source_window_base::show_source_content): Update.
5191 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5192 * tui/tui-source.h (struct tui_source_window)
5193 <erase_source_content>: New method.
5194 * tui/tui-disasm.h (struct tui_disasm_window)
5195 <erase_source_content>: New method.
5196
002f15c2
TT
51972019-08-15 Tom Tromey <tom@tromey.com>
5198
5199 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5200 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5201 constructor.
5202 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5203 * tui/tui-source.c (tui_set_source_content): Update.
5204 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5205
c9033fe8
TT
52062019-08-15 Tom Tromey <tom@tromey.com>
5207
5208 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5209 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5210 tui-source.c.
5211 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5212 Declare.
5213 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5214 method.
5215 (tui_source_window::maybe_update): Update.
5216
088f37dd
TT
52172019-08-15 Tom Tromey <tom@tromey.com>
5218
5219 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5220 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5221 tui-disasm.c.
5222 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5223 Declare.
5224 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5225 method.
5226 (tui_disasm_window::maybe_update): Update.
5227
a54700c6
TT
52282019-08-15 Tom Tromey <tom@tromey.com>
5229
5230 * tui/tui-winsource.h (struct tui_source_window_base)
5231 <maybe_update>: Declare.
5232 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5233 method.
5234 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5235 Declare.
5236 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5237 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5238 Declare.
5239 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5240
e2a678a5
TT
52412019-08-15 Tom Tromey <tom@tromey.com>
5242
5243 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5244
f2dda477
TT
52452019-08-15 Tom Tromey <tom@tromey.com>
5246
5247 * tui/tui-wingeneral.c: Include tui-stack.h.
5248 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5249 (struct tui_locator_window): Move from tui-data.h.
5250 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5251 (tui_initialize_static_data): Move from tui-data.c.
5252 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5253 (struct tui_locator_window): Move to tui-stack.c.
5254 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5255 (tui_initialize_static_data): Move to tui-stack.c.
5256
ed4a1084
TT
52572019-08-15 Tom Tromey <tom@tromey.com>
5258
5259 * tui/tui-layout.c (show_source_disasm_command)
5260 (show_source_or_disasm_and_command): Use make_visible method, not
5261 tui_make_window.
5262 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5263 Remove.
5264
65962b20
TT
52652019-08-15 Tom Tromey <tom@tromey.com>
5266
5267 * tui/tui-wingeneral.h (tui_make_window): Update.
5268 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5269 parameter.
5270 (tui_gen_win_info::make_visible): Update.
5271 * tui/tui-regs.c (tui_data_window::display_registers_from):
5272 Update.
5273 * tui/tui-layout.c (show_source_disasm_command)
5274 (show_source_or_disasm_and_command): Update.
5275 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5276 (enum tui_box): Remove.
5277 (struct tui_win_info) <can_box>: New method.
5278 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5279 method.
5280
2208ee91
TV
52812019-08-15 Tom de Vries <tdevries@suse.de>
5282
5283 * linux-nat-trad.c: Include gdbarch.h.
5284
75faf5c4
AH
52852019-08-14 Alan Hayward <alan.hayward@arm.com>
5286
5287 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5288 register sizes.
5289
b1c896b3
TT
52902019-08-14 Tom Tromey <tromey@adacore.com>
5291
5292 * darwin-nat.c: Include gdbarch.h.
5293 * darwin-nat-info.c: Include gdbarch.h.
5294
6405cd73
TT
52952019-08-13 Tom Tromey <tom@tromey.com>
5296
5297 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5298 Remove.
5299 * tui/tui-data.c (tui_initialize_static_data): Update.
5300
5216580d
TT
53012019-08-13 Tom Tromey <tom@tromey.com>
5302
5303 * tui/tui-winsource.h (struct tui_exec_info_window)
5304 <~tui_exec_info_window, maybe_allocate_content, get_content,
5305 m_content>: Remove.
5306 (struct tui_source_window_base) <set_exec_info_content,
5307 show_exec_info_content>: Don't declare.
5308 * tui/tui-winsource.c
5309 (tui_exec_info_window::maybe_allocate_content): Remove.
5310 (tui_source_window_base::update_exec_info): Rename from
5311 set_exec_info_content.
5312 (tui_source_window_base::show_exec_info_content)
5313 (tui_source_window_base::update_exec_info): Remove.
5314
93858ad3
TT
53152019-08-13 Tom Tromey <tom@tromey.com>
5316
5317 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5318 declare.
5319 * tui/tui-winsource.c (tui_update_source_window_as_is)
5320 (tui_update_source_windows_with_addr, tui_erase_source_content):
5321 Update.
5322 (tui_clear_exec_info_content): Remove.
5323
e321e7ce
TT
53242019-08-13 Tom Tromey <tom@tromey.com>
5325
5326 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5327 declare.
5328 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5329 call tui_erase_exec_info_content.
5330 (tui_clear_exec_info_content): Rename from
5331 tui_erase_exec_info_content.
5332 (tui_clear_exec_info_content): Delete.
5333
8270ac62
TT
53342019-08-13 Tom Tromey <tom@tromey.com>
5335
5336 * tui/tui-winsource.h (struct tui_source_window_base)
5337 <show_exec_info_content>: Declare.
5338 (tui_show_exec_info_content): Don't declare.
5339 * tui/tui-winsource.c
5340 (tui_source_window_base::show_exec_info_content): Rename from
5341 tui_show_exec_info_content.
5342 (tui_source_window_base::update_exec_info): Update.
5343
7b56485d
TT
53442019-08-13 Tom Tromey <tom@tromey.com>
5345
5346 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5347 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5348 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5349 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5350 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5351 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5352 ... here.
5353
7ba913dc
TT
53542019-08-13 Tom Tromey <tom@tromey.com>
5355
5356 * tui/tui-winsource.h (struct tui_source_window_base)
5357 <update_exec_info>: Declare.
5358 (tui_update_exec_info): Don't declare.
5359 * tui/tui-winsource.c (tui_update_source_window_as_is)
5360 (tui_source_window_base::refresh_all)
5361 (tui_update_all_breakpoint_info): Update.
5362 (tui_source_window_base::update_exec_info): Rename from
5363 tui_update_exec_info.
5364 * tui/tui-stack.c (tui_show_frame_info): Update.
5365
37a4a131
TT
53662019-08-13 Tom Tromey <tom@tromey.com>
5367
5368 * tui/tui-winsource.h (struct tui_source_window_base)
5369 <set_exec_info_content>: Declare.
5370 (tui_set_exec_info_content): Don't declare.
5371 * tui/tui-winsource.c
5372 (tui_source_window_base::set_exec_info_content): Rename from
5373 tui_set_exec_info_content.
5374 (tui_update_exec_info): Update.
5375
0bd27e07
TT
53762019-08-13 Tom Tromey <tom@tromey.com>
5377
5378 * tui/tui-winsource.h (struct tui_source_window_base)
5379 <show_source_content>: Declare.
5380 (tui_show_source_content): Don't declare.
5381 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5382 (tui_source_window_base::show_source_content): Rename from
5383 tui_show_source_content.
5384 (tui_source_window_base::refresh_all): Update.
5385 * tui/tui-layout.c (show_source_disasm_command)
5386 (show_source_or_disasm_and_command): Update.
5387
b4ef5aeb
TT
53882019-08-13 Tom Tromey <tom@tromey.com>
5389
5390 * tui/tui-winsource.c (tui_erase_source_content)
5391 (tui_show_source_content, tui_source_window_base::refresh_all):
5392 Update.
5393 * tui/tui-wingeneral.h
5394 (tui_check_and_display_highlight_if_needed): Don't declare.
5395 * tui/tui-wingeneral.c
5396 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5397 check_and_display_highlight_if_needed.
5398 * tui/tui-win.c (tui_rehighlight_all)
5399 (tui_win_info::make_visible_with_new_height): Update.
5400 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5401 (tui_data_window::erase_data_content)
5402 (tui_data_window::display_all_data): Update.
5403 * tui/tui-data.h (struct tui_win_info)
5404 <check_and_display_highlight_if_needed>: Declare.
5405
fede5273
TT
54062019-08-13 Tom Tromey <tom@tromey.com>
5407
5408 * tui/tui-win.c (tui_resize_all): Call
5409 tui_delete_invisible_windows.
5410 * tui/tui-layout.c (show_layout): Call
5411 tui_delete_invisible_windows.
5412 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5413 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5414
22c3f490
TT
54152019-08-13 Tom Tromey <tom@tromey.com>
5416
5417 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5418 tui_add_win_to_layout.
5419
16cb7910
TT
54202019-08-13 Tom Tromey <tom@tromey.com>
5421
5422 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5423 * tui/tui-layout.c (tui_default_win_height): Now static.
5424
cc0c3ffb
TT
54252019-08-13 Tom Tromey <tom@tromey.com>
5426
5427 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5428 single switch.
5429 (show_source_disasm_command, show_source_or_disasm_and_command):
5430 Don't check current layout.
5431
3f3ffe54
TT
54322019-08-13 Tom Tromey <tom@tromey.com>
5433
5434 * tui/tui-wingeneral.c (make_all_visible): Remove.
5435 (tui_make_all_invisible): Simplify.
5436 * tui/tui-layout.c (tui_make_all_invisible): Move from
5437 tui-wingeneral.c; simplify.
5438 (show_layout): Hoist call to tui_make_all_invisible.
5439 (show_data): Don't call tui_make_all_invisible.
5440
69258091
TT
54412019-08-13 Tom Tromey <tom@tromey.com>
5442
5443 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5444 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5445
62cf57fe
TT
54462019-08-13 Tom Tromey <tom@tromey.com>
5447
5448 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5449 tui-data.c.
5450 (show_source_disasm_command, show_data)
5451 (show_source_or_disasm_and_command): Don't use
5452 tui_set_current_layout_to.
5453 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5454 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5455 tui-layout.c.
5456 (tui_set_current_layout_to): Remove.
5457
2afade5d
TT
54582019-08-13 Tom Tromey <tom@tromey.com>
5459
5460 * tui/tui-layout.c (tui_set_layout): Update.
5461 * tui/tui-data.h (struct tui_layout_def): Remove.
5462 (tui_layout_def): Don't declare.
5463 * tui/tui-data.c (layout_def): Remove.
5464 (tui_layout_def): Remove.
5465
a3504e96
TT
54662019-08-13 Tom Tromey <tom@tromey.com>
5467
5468 * tui/tui-winsource.h (struct tui_source_window_base)
5469 <clear_detail>: No longer "override".
5470 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5471 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5472 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5473 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5474 Remove.
5475 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5476
29c92911
TT
54772019-08-13 Tom Tromey <tromey@adacore.com>
5478
5479 * tracepoint.c: Don't include readline.h or history.h.
5480
86c6b807
TT
54812019-08-12 Tom Tromey <tom@tromey.com>
5482
5483 * configure: Rebuild.
5484 * configure.ac: Check for readline 7.
5485 * NEWS: Mention readline 7 requirement.
5486 * README: Update.
5487
5db2718c
TT
54882019-08-12 Tom Tromey <tom@tromey.com>
5489
5490 * mingw-hdep.c (gdb_select): Remove readline hack.
5491
dac36daf
PFC
54922019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5493
5494 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5495 when the function fails.
5496
1022c627
AA
54972019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5498
5499 * s390-tdep.c (s390_type_align): New function.
5500 (s390_gdbarch_init): Set it as type_align gdbarch method.
5501
eba4caf2
TV
55022019-08-09 Tom de Vries <tdevries@suse.de>
5503
5504 PR gdb/24591
5505 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5506 pc_low with relocation offset.
5507
123cd851
TT
55082019-08-07 Tom Tromey <tromey@adacore.com>
5509
5510 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5511 (print_frame_args): Update.
5512 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5513 Update.
5514 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5515 * frame.h (struct frame_arg): Add initializers.
5516 <error>: Now a unique_xmalloc_ptr.
5517
3d31bc39
AH
55182019-08-07 Alan Hayward <alan.hayward@arm.com>
5519
5520 * NEWS: Expand the Pointer Authentication entry.
5521 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5522 (aarch64_frame_unmask_lr): ... to this.
5523 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5524 Call aarch64_frame_unmask_lr.
5525 * frame.c (struct frame_info): Add "masked" variable.
5526 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5527 (fprint_frame): Check for masked pc.
5528 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5529 declarations.
5530 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5531 * stack.c (print_frame): Check for masked pc.
5532
0cf9feb9
TT
55332019-08-06 Tom Tromey <tom@tromey.com>
5534
5535 * stabsread.c (patch_block_stabs, read_one_struct_field)
5536 (read_enum_type): Use obstack_strndup.
5537 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5538 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5539 * dwarf2read.c (guess_full_die_structure_name)
5540 (anonymous_struct_prefix): Use obstack_strndup.
5541 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5542 * c-exp.y (yylex): Use obstack_strndup.
5543 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5544 (write_var_or_type): Use obstack_strndup.
5545
efba19b0
TT
55462019-08-06 Tom Tromey <tom@tromey.com>
5547
5548 * symfile.c (reread_symbols): Use obstack_strdup.
5549 * stabsread.c (read_type): Use obstack_strdup.
5550 * gdb_obstack.h (obstack_strdup): New overload.
5551 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5552 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5553 (dwarf2_canonicalize_name): Use obstack_strdup.
5554 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5555 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5556 Use obstack_strdup.
5557
f25102f7
TT
55582019-08-06 Tom Tromey <tom@tromey.com>
5559
5560 * gdb_obstack.h (obstack_strdup): Define.
5561 * gdb_obstack.c (obstack_strdup): Don't define.
5562
021887d8
TT
55632019-08-06 Tom Tromey <tom@tromey.com>
5564
5565 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5566 obstack_strdup.
5567 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5568 obstack_strdup.
5569 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5570 * stabsread.c (common_block_start): Use obstack_strdup.
5571 * objfiles.c (set_objfile_main_name, objfile): Use
5572 obstack_strdup.
5573 * namespace.c (add_using_directive): Use obstack_strdup.
5574 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5575 * jit.c (finalize_symtab): Use obstack_strdup.
5576 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5577 (guess_partial_die_structure_name, partial_die_info::fixup)
5578 (dwarf2_name): Use obstack_strdup.
5579 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5580 obstack_strdup.
5581 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5582 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5583 obstack_strdup.
5584 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5585
d2834edc
PW
55862019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5587
5588 * unittests/help-doc-selftests.c: New file.
5589 * Makefile.in: Add the new file.
5590
590042fc
PW
55912019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5592
5593 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5594 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5595 the full first line, except when FOR_VALUE_PREFIX. In this case,
5596 the trailing '.' is not output, and the first character is uppercased.
5597 (print_help_for_command): Update call to print_doc_line.
5598 (print_doc_of_command): Likewise.
5599 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5600 * cli/cli-option.c (append_indented_doc): Do not append newline.
5601 (build_help_option): Append newline after first appended_indented_doc
5602 only if a second call is done.
5603 (build_help): Append 2 new lines before each option, except the first
5604 one.
5605 * compile/compile.c (_initialize_compile): Add new lines after
5606 %OPTIONS%, when not at the end of the help.
5607 Change help doc or code
5608 producing the help doc to respect the invariants.
5609 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5610 Also removed the new line after 'Options:', as all other commands
5611 do not put an empty line between 'Options:' and the first option.
5612 * printcmd.c (_initialize_printcmd): Likewise.
5613 * stack.c (_initialize_stack): Likewise.
5614 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5615 incorrectly telling COMMAND is optional.
5616 * ada-lang.c (_initialize_ada_language): Change help doc or code
5617 producing the help doc to respect the invariants.
5618 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5619 * breakpoint.c (_initialize_breakpoint): Likewise.
5620 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5621 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5622 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5623 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5624 _initialize_cli_style): Likewise.
5625 * corelow.c (core_target_info): Likewise.
5626 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5627 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5628 * filesystem.c (_initialize_filesystem): Likewise.
5629 * frame.c (_initialize_frame): Likewise.
5630 * gnu-nat.c (add_task_commands): Likewise.
5631 * infcall.c (_initialize_infcall): Likewise.
5632 * infcmd.c (_initialize_infcmd): Likewise.
5633 * interps.c (_initialize_interpreter): Likewise.
5634 * language.c (_initialize_language): Likewise.
5635 * linux-fork.c (_initialize_linux_fork): Likewise.
5636 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5637 * maint.c (_initialize_maint_cmds): Likewise.
5638 * memattr.c (_initialize_mem): Likewise.
5639 * printcmd.c (_initialize_printcmd): Likewise.
5640 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5641 _RegEx): Likewise.
5642 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5643 * record-btrace.c (_initialize_record_btrace): Likewise.
5644 * record-full.c (_initialize_record_full): Likewise.
5645 * record.c (_initialize_record): Likewise.
5646 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5647 * regcache.c (_initialize_regcache): Likewise.
5648 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5649 _initialize_remote): Likewise.
5650 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5651 * serial.c (_initialize_serial): Likewise.
5652 * skip.c (_initialize_step_skip): Likewise.
5653 * source.c (_initialize_source): Likewise.
5654 * stack.c (_initialize_stack): Likewise.
5655 * symfile.c (_initialize_symfile): Likewise.
5656 * symtab.c (_initialize_symtab): Likewise.
5657 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5658 * top.c (init_main): Likewise.
5659 * tracefile-tfile.c (tfile_target_info): Likewise.
5660 * tracepoint.c (_initialize_tracepoint): Likewise.
5661 * tui/tui-win.c (_initialize_tui_win): Likewise.
5662 * utils.c (add_internal_problem_command): Likewise.
5663 * valprint.c (value_print_option_defs): Likewise.
5664
404f2902
FCE
56652019-08-06 Frank Ch. Eigler <fche@redhat.com>
5666
5667 PR build/24886
5668 * configure.ac: Drop enable-libmcheck support.
5669 * configure, config.in: Rebuild.
5670 * libmcheck.m4: Remove.
5671 * acinclude.m4: Don't include it.
5672 * Makefile.in: Don't distribute it.
5673 * top.c (print_gdb_configuration): Don't mention it.
5674
046bebe1
TT
56752019-08-06 Tom Tromey <tom@tromey.com>
5676
5677 * utils.c (set_output_style): Sometimes pass stream to
5678 emit_style_escape.
5679 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5680 * record-btrace.c (btrace_insn_history): Update.
5681 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5682 method.
5683 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5684 Update initializers.
5685 <m_uiout>: New field.
5686 <m_di>: Move lower.
5687 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5688 Remove "uiout" parameter.
5689 (dump_insns): Update.
5690 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5691 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5692
ddbcedf5
CB
56932019-08-06 Christian Biesinger <cbiesinger@google.com>
5694
5695 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5696 (error_in_psymtab_expansion): Likewise.
5697 (lookup_symbol_via_quick_fns): Likewise.
5698 (basic_lookup_transparent_type_quick): Likewise.
5699 (basic_lookup_transparent_type_1): Likewise.
5700
b08b16c8
TT
57012019-08-06 Tom Tromey <tromey@adacore.com>
5702
5703 * source.c (last_source_error): Now bool.
5704 (print_source_lines_base): Make "noprint" bool. Only open
5705 source file when last_source_visited changes.
5706
cb44333d
TT
57072019-08-06 Tom Tromey <tromey@adacore.com>
5708
5709 * annotate.c (annotate_source_line): Use g_source_cache.
5710 * source-cache.c (source_cache::get_plain_source_lines): Change
5711 parameters. Populate m_offset_cache.
5712 (source_cache::ensure): New method.
5713 (source_cache::get_line_charpos): New method.
5714 (extract_lines): Move lower. Change parameters.
5715 (source_cache::get_source_lines): Move lower.
5716 * source-cache.h (class source_cache): Update comment.
5717 <get_line_charpos>: New method.
5718 <get_source_lines>: Update comment.
5719 <clear>: Clear m_offset_cache.
5720 <get_plain_source_lines>: Change parameters.
5721 <ensure>: New method
5722 <m_offset_cache>: New member.
5723 * source.c (forget_cached_source_info_for_objfile): Update.
5724 (info_source_command): Use g_source_cache.
5725 (find_source_lines, open_source_file_with_line_charpos): Remove.
5726 (print_source_lines_base, search_command_helper): Use g_source_cache.
5727 * source.h (open_source_file_with_line_charpos): Don't declare.
5728 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5729 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5730 Use g_source_cache.
5731
872dceaa
TT
57322019-08-06 Tom Tromey <tromey@adacore.com>
5733
5734 * source-cache.c (source_cache::get_plain_source_lines):
5735 Remove "first_line" and "last_line" parameters.
5736 (source_cache::get_source_lines): Cache plain text.
5737 * source-cache.h (class source_cache)
5738 <get_plain_source_lines>: Update.
5739
269249d9
TT
57402019-08-06 Tom Tromey <tromey@adacore.com>
5741
5742 * source-cache.c (extract_lines): No longer a method.
5743 Changed type of parameter. Include final newline.
5744 (selftests::extract_lines_test): New function.
5745 (_initialize_source_cache): Likewise.
5746 * source-cache.h (class source_cache)
5747 <extract_lines>: Don't declare.
5748
c0e8dcd8
TT
57492019-08-06 Tom Tromey <tromey@adacore.com>
5750
5751 * breakpoint.c (init_breakpoint_sal): Update.
5752 (breakpoint): Update.
5753 * breakpoint.h (struct breakpoint) <filter>: Now a
5754 unique_xmalloc_ptr.
5755
0b27c27d
CB
57562019-08-05 Christian Biesinger <cbiesinger@google.com>
5757
5758 * NEWS: Mention dictionary access on blocks.
5759 * python/py-block.c (blpy_getitem): New function.
5760 (block_object_as_mapping): New struct.
5761 (block_object_type): Use new struct for tp_as_mapping field.
5762
4ee94178
CB
57632019-08-05 Christian Biesinger <cbiesinger@google.com>
5764
5765 * objfiles.h (objfile): Add a comment describing partial symbols.
5766
8abfcabc
TT
57672019-08-05 Tom Tromey <tromey@adacore.com>
5768
5769 * compile/compile.c (_initialize_compile): Use _(), not N_().
5770 * thread.c (_initialize_thread): Use _(), not N_().
5771 * stack.c (_initialize_stack): Use _(), not N_().
5772 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5773
2b79f376
SM
57742019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5775
5776 * dwarf2read.c (struct dw2_symtab_iterator):
5777 <want_specific_block>: Remove.
5778 <block_index>: Change type to gdb::optional.
5779 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5780 change type of BLOCK_INDEX parameter to gdb::optional.
5781 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5782 (dw2_lookup_symbol): Don't pass argument for
5783 WANT_SPECIFIC_BLOCK.
5784 (dw2_expand_symtabs_for_function): Don't pass argument for
5785 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5786 (class dw2_debug_names_iterator)
5787 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5788 parameter, change BLOCK_INDEX type to gdb::optional.
5789 <m_want_specific_block>: Remove.
5790 <m_block_index>: Change type to gdb::optional.
5791 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5792 gdb::optional. Re-write in function of gdb::optional.
5793 (dw2_debug_names_lookup_symbol): Don't pass argument for
5794 WANT_SPECIFIC_BLOCK.
5795 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5796 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5797 BLOCK_INDEX.
5798
ae60f04e
PW
57992019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5800
5801 * NEWS: Mention changes to "info sources" command.
5802
28cd9371
PW
58032019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5804
5805 * symtab.c (filename_partial_match_opts): New struct type.
5806 (struct output_source_filename_data): New members
5807 regexp, c_regexp, partial_match.
5808 (output_source_filename): Use new members to decide to print file.
5809 (info_sources_option_defs): New variable.
5810 (make_info_sources_options_def_group, print_info_sources_header,
5811 info_sources_command_completer):
5812 New functions.
5813 (info_sources_command): Read new optional arguments.
5814 (_initialize_symtab): Update info sources help.
5815
ca683e3a
AO
58162019-08-02 Alexandre Oliva <oliva@adacore.com>
5817
5818 * ada-lang.c (exception_support_info_v0): Renamed from...
5819 (default_exception_support_info): ... this. Create new
5820 definition for v1.
5821 (ada_has_this_exception_support): Look up catch_handlers_sym.
5822 (ada_exception_support_info_sniffer): Try v0 after default.
5823
f1264162
TT
58242019-08-01 Tom Tromey <tromey@adacore.com>
5825
5826 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5827 gdbarch.h.
5828
0a7b2485
CB
58292019-08-01 Christian Biesinger <cbiesinger@google.com>
5830
5831 * s12z-tdep.c: Fix include path for s12z-opc.h.
5832
c6bdbeb7
AH
58332019-08-01 Alan Hayward <alan.hayward@arm.com>
5834
5835 * NEWS: Require GNU make 3.82.
5836
a2bd7b82
TT
58372019-07-16 Tom Tromey <tom@tromey.com>
5838
5839 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5840 declare.
5841
aa3b6533
TT
58422019-07-30 Tom Tromey <tromey@adacore.com>
5843
5844 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5845
a1530dc7
KB
58462019-07-30 Kevin Buettner <kevinb@redhat.com>
5847
5848 * printcmd.c (print_address_symbolic): Print negative offsets.
5849 (build_address_symbolic): Force signed arithmetic when computing
5850 offset.
5851
2906593f
CB
58522019-07-30 Christian Biesinger <cbiesinger@google.com>
5853
5854 PR/24474: Add a function to lookup static variables.
5855 * NEWS: Mention this new function.
5856 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5857 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5858 * python/python.c (python_GdbMethods): Add new function.
5859
c620ed88
CB
58602019-07-29 Christian Biesinger <cbiesinger@google.com>
5861
5862 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5863 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5864 (objfpy_lookup_static_symbol): New function.
5865 (objfile_object_methods): Add new functions.
5866
bc4268a5
PW
58672019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5868
5869 * NEWS: Mention 'set|show print frame-info'. Mention new
5870 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5871 backtrace argument. Mention that python frame filtering code
5872 is now consistent with what 'backtrace' command prints.
5873
4b5e8d19
PW
58742019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5875
5876 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5877 comments.
5878 (print_frame_info_auto, print_frame_info_source_line,
5879 print_frame_info_location, print_frame_info_source_and_location,
5880 print_frame_info_location_and_address, print_frame_info_short_location):
5881 New declarations.
5882 (struct frame_print_options): New member print_frame_info.
5883 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5884 * stack.h (get_user_print_what_frame_info): New declaration.
5885 (frame_show_address): New declaration.
5886 * stack.c (print_frame_arguments_choices): New value 'presence'.
5887 (print_frame_info_auto, print_frame_info_source_line,
5888 print_frame_info_location, print_frame_info_source_and_location,
5889 print_frame_info_location_and_address, print_frame_info_short_location,
5890 print_frame_info_choices, print_frame_info_print_what): New definitions.
5891 (print_frame_args): Only print dots for args if print frame-arguments
5892 is 'presence'.
5893 (frame_print_option_defs): New element for "frame-info".
5894 (get_user_print_what_frame_info): New function.
5895 (frame_show_address): Make non static. Move comment to stack.h.
5896 (print_frame_info_to_print_what): New function.
5897 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5898 to decide what to print.
5899 (backtrace_command_1): Handle the new print_frame_arguments_presence
5900 value.
5901 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5902 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5903 (py_print_frame): In non-mi mode, use LOCATION as default for
5904 print_what, similarly to frame information printed directly by
5905 backtrace command. Handle frame-info user option in non MI mode.
5906
6bdfee81
KB
59072019-07-27 Kevin Buettner <kevinb@redhat.com>
5908
5909 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5910 Add case for debugging 32-bit target on 64-bit host. Revise
5911 comment.
5912
98a617f8
KB
59132019-07-27 Kevin Buettner <kevinb@redhat.com>
5914
5915 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5916 instead of find_function_entry_range_from_pc.
5917
567238c9
KB
59182019-07-27 Kevin Buettner <kevinb@redhat.com>
5919
5920 * stack.c (find_frame_funname): Remove code which preferred
5921 minsym over symtab sym in "certain pathological cases".
5922
2dc80cf8
KB
5923 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5924 parameter. Change type of "do_demangle" to bool.
5925 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5926 Pass suitable "prefer_sym_over_minsym" flag to
5927 build_address_symbolic(). Don't output "+" for negative offsets.
5928 * printcmd.c (print_address_symbolic): Update invocation of
5929 build_address_symbolic to include a "prefer_sym_over_minsym"
5930 flag.
5931 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5932 Restrict cases in which use of minimal symbol is preferred to that
5933 of a found symbol. Update comments.
5934
1aff7173
KB
5935 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5936 for entry pc when entry pc is out of range for that FDE.
5937
89b085ac
BC
59382019-07-26 Brian Callahan <bcallah@openbsd.org>
5939
5940 PR gdb/24839:
5941 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5942 type.
5943
f32feb4a
CB
59442019-07-25 Christian Biesinger <cbiesinger@google.com>
5945
5946 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5947 this function's Python signature.
5948
5949
59502019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
5951
5952 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5953 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5954 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5955 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5956 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5957
5958
c54e4253
YS
59592019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5960
5961 * h8300-tdep.c (h8300_register_name_common): New.
5962 h8300_register_name): Use h8300_register_name_common.
5963 (h8300s_register_name): Likewise.
5964 (h8300sx_register_name): Likewise.
5965 (h8300h_register_nam): New.
5966 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5967
5968
40eadf04
SP
59692019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5970
5971 * arm-tdep.c (arm_skip_cmse_entry): New function.
5972 (arm_is_sgstubs_section): New function.
5973 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5974
bfa2a36d
TT
59752019-07-22 Tom Tromey <tom@tromey.com>
5976
5977 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5978 Don't self-assign.
5979
a8e9d247
AB
59802019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5981
5982 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5983 type_print.
5984
eb86c5e2
AB
59852019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5986
5987 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5988 so that GDB doesn't match any msymbols when searching in the
5989 TYPES_DOMAIN.
5990 (print_symbol_info): Print using typedef_print or type_print based
5991 on the type of the symbol. Add updated FIXME comment moved from...
5992 (_initialize_symtab): ... move and update FIXME comment to above.
5993
a8eab7c6
AB
59942019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5995
5996 * NEWS: Mention adding -q option to "info types".
5997 * symtab.c (struct info_types_options): New struct.
5998 (info_types_options_defs): New variable.
5999 (make_info_types_options_def_group): New function.
6000 (info_types_command): Use gdb::option framework to parse options.
6001 (info_types_command_completer): New function.
6002 (_initialize_symtab): Extend the help text on "info types" and
6003 register command completer.
6004
b4603c34
CB
60052019-07-21 Christian Biesinger <cbiesinger@google.com>
6006
6007 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6008 (lookup_symbol_in_objfile): Change int to block_enum and add a
6009 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6010
c8cdc1e0
CB
60112019-07-20 Christian Biesinger <cbiesinger@google.com>
6012
6013 * MAINTAINERS (Write After Approval): Add self.
6014
01e175fe
AB
60152019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6016
6017 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6018 instruction to the dummy code region.
6019
56f79b63
TT
60202019-07-19 Tom Tromey <tromey@adacore.com>
6021
6022 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6023 (ARGSUSED, PARAMS, __func__): Remove rules.
6024
4c5aa8e0
AH
60252019-07-19 Alan Hayward <alan.hayward@arm.com>
6026
6027 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6028 * features/arm/arm-with-iwmmxt.c: Remove.
6029 * features/arm/arm-with-iwmmxt.xml: Remove.
6030 * features/arm/arm-with-m-fpa-layout.c: Remove.
6031 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6032 * features/arm/arm-with-m-vfp-d16.c: Remove.
6033 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6034 * features/arm/arm-with-m.c: Remove.
6035 * features/arm/arm-with-m.xml: Remove.
6036 * features/arm/arm-with-neon.c: Remove.
6037 * features/arm/arm-with-neon.xml: Remove.
6038 * features/arm/arm-with-vfpv2.c: Remove.
6039 * features/arm/arm-with-vfpv2.xml: Remove.
6040 * features/arm/arm-with-vfpv3.c: Remove.
6041 * features/arm/arm-with-vfpv3.xml: Remove.
6042
f42b2617
AH
60432019-07-19 Alan Hayward <alan.hayward@arm.com>
6044
6045 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6046
f29ec966
AH
60472019-07-19 Alan Hayward <alan.hayward@arm.com>
6048
6049 * arch/aarch32.c (aarch32_create_target_description): Create
6050 target descriptions using features.
6051 * arch/arm.c (arm_create_target_description)
6052 (arm_create_mprofile_target_description): Likewise.
6053 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6054
d105cce5
AH
60552019-07-19 Alan Hayward <alan.hayward@arm.com>
6056
6057 * Makefile.in: Add new files.
6058 * aarch32-tdep.c: New file.
6059 * aarch32-tdep.h: New file.
6060 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6061 Call aarch32_read_description.
6062 * arch/aarch32.c: New file.
6063 * arch/aarch32.h: New file.
6064 * arch/arm.c (arm_create_target_description)
6065 (arm_create_mprofile_target_description): New function.
6066 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6067 (arm_create_target_description)
6068 (arm_create_mprofile_target_description): New declaration.
6069 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6070 read_description functions.
6071 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6072 Likewise.
6073 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6074 * arm-tdep.c (tdesc_arm_list): New variable.
6075 (arm_register_g_packet_guesses): Call create description functions.
6076 (arm_read_description) (arm_read_mprofile_description): New
6077 function.
6078 * arm-tdep.h (arm_read_description)
6079 (arm_read_mprofile_description): Add declaration.
6080 * configure.tgt: Add new files.
6081
afe09f0b
GL
60822019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6083
6084 * top.c (new_ui_command): Open specified terminal just once.
6085
cd215b2e
TT
60862019-07-18 Tom Tromey <tromey@adacore.com>
6087
6088 * symtab.c (main_name): Constify return type.
6089 * symfile.c (set_initial_language): Update.
6090 * symtab.h (main_name): Constify return type.
6091
d8f68fcb
TT
60922019-07-17 Tom Tromey <tom@tromey.com>
6093
6094 * tui/tui-winsource.c (tui_update_source_window)
6095 (tui_update_source_window_as_is)
6096 (tui_update_source_windows_with_line): Remove return.
6097 * tui/tui-disasm.c (tui_show_disassem)
6098 (tui_show_disassem_and_update_source): Remove return.
6099 * tui/tui.c (tui_reset): Remove return.
6100 * tui/tui-wingeneral.c
6101 (tui_check_and_display_highlight_if_needed): Remove return.
6102
ca5af91e
TT
61032019-07-17 Tom Tromey <tom@tromey.com>
6104
6105 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6106
5104fe36
TT
61072019-07-17 Tom Tromey <tom@tromey.com>
6108
6109 * tui/tui-winsource.h (struct tui_exec_info_window)
6110 (struct tui_source_window_base): Move from tui-data.h.
6111 * tui/tui-winsource.c: Move many method definitions from
6112 elsewhere. Remove "structuring" comments.
6113 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6114 (tui_source_window_base::refresh_window): Move to
6115 tui-winsource.c.
6116 * tui/tui-win.c (tui_source_window_base::refresh_all)
6117 (tui_source_window_base::update_tab_width)
6118 (tui_source_window_base::set_new_height)
6119 (tui_source_window_base::do_make_visible_with_new_height): Move to
6120 tui-winsource.c.
6121 * tui/tui-source.h: Update.
6122 * tui/tui-source.c (tui_source_window_base::reset): Move to
6123 tui-winsource.c.
6124 * tui/tui-disasm.h: Update.
6125 * tui/tui-data.h (struct tui_exec_info_window): Move to
6126 tui-winsource.h.
6127 (struct tui_source_window_base): Likewise.
6128 * tui/tui-data.c (tui_source_window_base::clear_detail)
6129 (tui_source_window_base, ~tui_source_window_base): Move to
6130 tui-winsource.c.
6131
daa15dde
TT
61322019-07-17 Tom Tromey <tom@tromey.com>
6133
6134 * tui/tui-win.c (tui_resize_all)
6135 (tui_source_window_base::update_tab_width)
6136 (tui_adjust_win_heights): Update.
6137 (tui_win_info::make_invisible_and_set_new_height): Rename from
6138 make_invisible_and_set_new_height.
6139 * tui/tui-data.h (struct tui_win_info)
6140 <make_invisible_and_set_new_height>: New method.
6141
bfad4537
TT
61422019-07-17 Tom Tromey <tom@tromey.com>
6143
6144 * tui/tui.c: Update.
6145 * tui/tui-source.h (struct tui_source_window): Move from
6146 tui-data.h.
6147 * tui/tui-layout.c: Update.
6148 * tui/tui-disasm.c: Update.
6149 * tui/tui-data.h (struct tui_source_window): Move to
6150 tui-source.h.
6151
88f7e873
TT
61522019-07-17 Tom Tromey <tom@tromey.com>
6153
6154 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6155 tui-data.h.
6156 * tui/tui-data.h (struct tui_disasm_window): Move to
6157 tui-disasm.h.
6158
96bd6233
TT
61592019-07-17 Tom Tromey <tom@tromey.com>
6160
6161 * tui/tui-regs.h (struct tui_data_item_window): Move from
6162 tui-data.h.
6163 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6164 * tui/tui-data.h (struct tui_data_item_window): Move to
6165 tui-regs.h.
6166 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6167
ce38393b
TT
61682019-07-17 Tom Tromey <tom@tromey.com>
6169
6170 * tui/tui.c: Update.
6171 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6172 (tui_cmd_window::max_height): Move to tui-command.c.
6173 * tui/tui-layout.c: Update.
6174 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6175 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6176 tui-command.c.
6177 * tui/tui-command.h (struct tui_cmd_window): Move from
6178 tui-data.h.
6179 * tui/tui-command.c: Remove "structuring" comments.
6180 (tui_cmd_window::clear_detail)
6181 (tui_cmd_window::do_make_visible_with_new_height)
6182 (tui_cmd_window::max_height): Move from elsewhere.
6183
2d8b51cb
TT
61842019-07-17 Tom Tromey <tom@tromey.com>
6185
6186 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6187 Now static.
6188 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6189 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6190
18ab23af
TT
61912019-07-17 Tom Tromey <tom@tromey.com>
6192
6193 * tui/tui.c: Update.
6194 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6195 tui-regs.c.
6196 * tui/tui-windata.h: Remove file.
6197 * tui/tui-windata.c: Remove file.
6198 * tui/tui-win.c (tui_data_window::set_new_height)
6199 (tui_data_window::do_make_visible_with_new_height): Move to
6200 tui-regs.c.
6201 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6202 * tui/tui-regs.c: Remove "structuring" comments.
6203 (tui_data_window::first_data_item_displayed)
6204 (tui_data_window::delete_data_content_windows)
6205 (tui_data_window::erase_data_content)
6206 (tui_data_window::display_all_data)
6207 (tui_data_window::refresh_all)
6208 (tui_data_window::do_scroll_vertical)
6209 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6210 (tui_data_window::do_make_visible_with_new_height)
6211 (tui_data_window::refresh_window): Move from elsewhere.
6212 (_initialize_tui_regs): Move to end of file.
6213 * tui/tui-layout.c: Update.
6214 * tui/tui-hooks.c: Update.
6215 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6216 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6217 tui-regs.c.
6218 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6219
88b7e7cc
TT
62202019-07-17 Tom Tromey <tom@tromey.com>
6221
6222 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6223 seen.
6224
0fcd3711
TT
62252019-07-17 Tom Tromey <tom@tromey.com>
6226
6227 * tui/tui-win.c (tui_source_window_base::set_new_height)
6228 (tui_source_window_base::do_make_visible_with_new_height): Use
6229 m_has_locator field directly.
6230 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6231 method.
6232 (struct tui_source_window_base) <has_locator>: Likewise.
6233
4a38112d
TT
62342019-07-17 Tom Tromey <tom@tromey.com>
6235
6236 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6237 Don't declare.
6238 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6239 Remove.
6240 * tui/tui-win.c (tui_source_window_base::set_new_height)
6241 (tui_source_window_base::set_new_height)
6242 (make_invisible_and_set_new_height)
6243 (tui_source_window_base::do_make_visible_with_new_height)
6244 (tui_source_window_base::do_make_visible_with_new_height):
6245 Update.
6246 * tui/tui-layout.c (show_source_disasm_command, show_data)
6247 (show_source_or_disasm_and_command): Update.
6248 * tui/tui-layout.c (show_layout): Update.
6249
09129226
TT
62502019-07-17 Tom Tromey <tom@tromey.com>
6251
6252 * tui/tui-layout.c (make_data_window): Remove.
6253 (show_data): Unify creation and re-initialization cases.
6254
4a8a5e84
TT
62552019-07-17 Tom Tromey <tom@tromey.com>
6256
6257 * tui/tui-layout.c (make_source_window, make_disasm_window):
6258 Remove.
6259 (show_data): Unify creation and re-initialization cases.
6260
76d2be8e
TT
62612019-07-17 Tom Tromey <tom@tromey.com>
6262
6263 * tui/tui-layout.c (make_command_window): Remove.
6264 (show_source_disasm_command, show_source_or_disasm_and_command):
6265 Unify creation and re-initialization cases.
6266
890b8bde
TT
62672019-07-17 Tom Tromey <tom@tromey.com>
6268
6269 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6270 creation and re-initialization cases.
6271
2cdfa113
TT
62722019-07-17 Tom Tromey <tom@tromey.com>
6273
6274 * tui/tui-regs.c (tui_get_register): Return void.
6275
8e3cfd09
TT
62762019-07-17 Tom Tromey <tom@tromey.com>
6277
6278 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6279 Simplify.
6280
f4e04977
TT
62812019-07-17 Tom Tromey <tom@tromey.com>
6282
6283 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6284 resetting.
6285
0379b883
TT
62862019-07-17 Tom Tromey <tom@tromey.com>
6287
6288 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6289 * tui/tui-regs.c (tui_reg_layout): New function.
6290 (tui_show_registers, tui_reg_command): Use it.
6291 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6292 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6293 parameters.
6294 (tui_layout_command): Remove.
6295
b7fbad91
TT
62962019-07-17 Tom Tromey <tom@tromey.com>
6297
6298 * tui/tui-layout.h (tui/tui-layout): Return void.
6299 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6300
4e1e56b9
TT
63012019-07-17 Tom Tromey <tom@tromey.com>
6302
6303 * tui/tui-layout.c (show_source_disasm_command, show_data):
6304 Update.
6305 (reset_locator): Remove.
6306 (show_source_or_disasm_and_command): Update.
6307
1e0c09ba
TT
63082019-07-17 Tom Tromey <tom@tromey.com>
6309
6310 * tui/tui-source.c (tui_source_window_base::reset): Remove
6311 win_type parameter.
6312 * tui/tui-layout.c (make_command_window, make_source_window)
6313 (make_disasm_window, make_data_window)
6314 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6315 (reset_locator, show_source_or_disasm_and_command): Update.
6316 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6317 win_type parameter.
6318 (struct tui_source_window_base) <reset>: Likewise.
6319
1bf605de
TT
63202019-07-17 Tom Tromey <tom@tromey.com>
6321
6322 * tui/tui-layout.c (show_source_disasm_command): Use
6323 reset_locator.
6324 (reset_locator): New function.
6325 (init_and_make_win): Remove.
6326 (show_source_or_disasm_and_command): Use reset_locator.
6327
098f9ed4
TT
63282019-07-17 Tom Tromey <tom@tromey.com>
6329
6330 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6331 condition.
6332 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6333 Remove condition.
6334 * tui/tui-source.c (tui_source_window_base::reset): New method.
6335 * tui/tui-layout.c (make_command_window): Don't call
6336 init_and_make_win.
6337 (make_source_window, make_disasm_window): Don't call
6338 make_source_or_disasm_window.
6339 (make_data_window): Don't call init_and_make_win. Change calling
6340 convention.
6341 (show_source_disasm_command, show_data): Simplify.
6342 (make_source_or_disasm_window): Remove.
6343 (show_source_or_disasm_and_command): Simplify.
6344 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6345 (struct tui_source_window_base) <reset>: Likewise.
6346 <execution_info>: Remove initializer.
6347 * tui/tui-data.c (tui_source_window_base): Initialize
6348 execution_info.
6349
80110957
TT
63502019-07-17 Tom Tromey <tom@tromey.com>
6351
6352 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6353 variable.
6354
cf82af05
TT
63552019-07-17 Tom Tromey <tom@tromey.com>
6356
6357 * tui/tui.c (tui_rl_other_window): Update.
6358 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6359 superclass method first. Always iterate over regs_content.
6360 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6361 method.
6362 * tui/tui-win.c (tui_set_focus_command): Update.
6363
01aeb396
TT
63642019-07-17 Tom Tromey <tom@tromey.com>
6365
6366 * tui/tui-win.c (tui_set_focus_command): Rename from
6367 tui_set_focus. Call tui_enable.
6368 (tui_set_focus_command): Remove.
6369
fd6c75ee
TT
63702019-07-17 Tom Tromey <tom@tromey.com>
6371
6372 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6373 refresh_window.
6374 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6375 touchwin.
6376 (tui_data_window::refresh_window): Call refresh_window on data
6377 items. Always call superclass refresh_window.
6378 (tui_win_info::refresh): Remove.
6379 (tui_source_window_base::refresh_window): Update.
6380 (tui_refresh_all): Update.
6381 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6382 refresh_window.
6383 (show_source_or_disasm_and_command): Likewise.
6384 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6385 (struct tui_source_window_base) <refresh>: Likewise.
6386
f6cc34a9
TT
63872019-07-17 Tom Tromey <tom@tromey.com>
6388
6389 * tui/tui-winsource.c (tui_clear_source_content)
6390 (tui_show_source_content): Update.
6391 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6392 whether content is empty.
6393 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6394 Remove.
6395
f31ec9af
TT
63962019-07-17 Tom Tromey <tom@tromey.com>
6397
6398 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6399 window's contents.
6400 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6401 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6402
d1b6f1e5
TT
64032019-07-17 Tom Tromey <tom@tromey.com>
6404
6405 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6406 (struct tui_data_item_window): Update.
6407
d9743a13
TT
64082019-07-17 Tom Tromey <tom@tromey.com>
6409
6410 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6411 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6412 defines.
6413
caf0bc4e
TT
64142019-07-17 Tom Tromey <tom@tromey.com>
6415
6416 * tui/tui-winsource.h (tui_erase_source_content)
6417 (tui_clear_source_content): Remove "display_prompt" parameter.
6418 * tui/tui-winsource.c (tui_update_source_window_as_is)
6419 (tui_update_source_windows_with_addr): Update.
6420 (tui_clear_source_content): Remove "display_prompt" parameter.
6421 (tui_erase_source_content): Likewise. Simplify.
6422 (tui_show_source_content): Update.
6423 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6424 * tui/tui-stack.c (tui_show_frame_info): Update.
6425 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6426 Remove defines.
6427
9d391078
TT
64282019-07-17 Tom Tromey <tom@tromey.com>
6429
6430 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6431 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6432 parameter.
6433 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6434 parameter.
6435
a38da35d
TT
64362019-07-17 Tom Tromey <tom@tromey.com>
6437
6438 * tui/tui-winsource.c (tui_clear_source_content)
6439 (tui_show_source_content, tui_show_exec_info_content)
6440 (tui_clear_exec_info_content): Update.
6441 * tui/tui-stack.c (tui_show_locator_content): Update.
6442 (tui_show_frame_info): Update.
6443 * tui/tui-source.h (tui_source_window): Don't declare.
6444 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6445 from tui_source_is_displayed.
6446 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6447 Remove field.
6448 (struct tui_source_window_base) <content_in_use>: New field. Now
6449 bool.
6450 (struct tui_source_window) <showing_source_p>: New method.
6451 (TUI_SRC_WIN): Change cast.
6452 * tui/tui-data.c (tui_initialize_static_data): Update.
6453
c2cd8994
TT
64542019-07-17 Tom Tromey <tom@tromey.com>
6455
6456 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6457 location_matches_p.
6458 * tui/tui-source.c (tui_source_window::location_matches_p): New
6459 method.
6460 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6461 method.
6462 * tui/tui-data.h (struct tui_source_window_base)
6463 <location_matches_p>: New method.
6464 (struct tui_source_window, struct tui_disasm_window)
6465 <location_matches_p>: Likewise.
6466
4dde7b34
TT
64672019-07-17 Tom Tromey <tom@tromey.com>
6468
6469 * tui/tui-win.c (tui_set_win_height_command): Rename from
6470 tui_set_win_height.
6471 (tui_set_win_height_command): Remove.
6472
b73dd877
TT
64732019-07-17 Tom Tromey <tom@tromey.com>
6474
6475 * tui/tui-source.c (tui_source_window): New constructor. Add
6476 observer.
6477 (~tui_source_window): New destructor.
6478 (tui_source_window::style_changed): New method.
6479 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6480 (tui_attach_detach_observers): Update.
6481 * tui/tui-data.h (struct tui_source_window): Make constructor not
6482 inline. Add destructor.
6483 (struct tui_source_window) <style_changed>: New method.
6484 <m_observable>: New member.
6485
ae2b5380
TT
64862019-07-17 Tom Tromey <tom@tromey.com>
6487
6488 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6489 * tui/tui-win.c (tui_resize_all): Fix typo.
6490
1ce3e844
TT
64912019-07-17 Tom Tromey <tom@tromey.com>
6492
6493 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6494 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6495 (tui_refresh_all): Remove "list" parameter. Use foreach.
6496 * tui/tui-win.c (window_name_completer): Use foreach.
6497 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6498 (update_tab_width): Likewise.
6499 * tui/tui-layout.c (show_layout): Update.
6500 * tui/tui-data.h (class tui_window_iterator): New.
6501 (struct all_tui_windows): New.
6502 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6503
fe3eaf1c
TT
65042019-07-17 Tom Tromey <tom@tromey.com>
6505
6506 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6507 parameter. Don't reference globals.
6508 (tui_reg_command): Update.
6509
368c1354
TT
65102019-07-17 Tom Tromey <tom@tromey.com>
6511
6512 * tui/tui-regs.c (tui_show_registers): Simplify.
6513
e80cd204
TT
65142019-07-17 Tom Tromey <tom@tromey.com>
6515
6516 * tui/tui-regs.c (tui_show_registers): Update.
6517 (tui_show_register_group): Add win_info parameter.
6518
aca2dd16
TT
65192019-07-17 Tom Tromey <tom@tromey.com>
6520
6521 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6522 Rename from tui_display_reg_element_at_line.
6523 (tui_data_window::display_registers_from_line): Update.
6524 * tui/tui-data.h (struct tui_data_window)
6525 <display_reg_element_at_line>: New method.
6526
517e9505
TT
65272019-07-17 Tom Tromey <tom@tromey.com>
6528
6529 * tui/tui-regs.h (tui_display_registers_from)
6530 (tui_display_registers_from_line): Don't declare.
6531 * tui/tui-windata.c (tui_data_window::display_all_data)
6532 (tui_data_window::refresh_all)
6533 (tui_data_window::do_scroll_vertical): Update.
6534 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6535 from tui_display_registers_from.
6536 (tui_display_reg_element_at_line): Update.
6537 (tui_data_window::display_registers_from_line): Rename from
6538 tui_display_registers_from_line.
6539 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6540 display_registers_from_line>: New methods.
6541
f76d8b19
TT
65422019-07-17 Tom Tromey <tom@tromey.com>
6543
6544 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6545 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6546 from tui_erase_data_content.
6547 (tui_data_window::display_all_data)
6548 (tui_data_window::refresh_all)
6549 (tui_data_window::do_scroll_vertical): Update.
6550 * tui/tui-regs.c (tui_show_registers): Update.
6551 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6552 New method.
6553
b4094625
TT
65542019-07-17 Tom Tromey <tom@tromey.com>
6555
6556 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6557 declare.
6558 * tui/tui-windata.c
6559 (tui_data_window::delete_data_content_windows): Rename from
6560 tui_delete_data_content_windows.
6561 (tui_data_window::display_all_data)
6562 (tui_data_window::do_scroll_vertical): Update.
6563 * tui/tui-data.h (struct tui_data_window)
6564 <delete_data_content_windows>: New method.
6565
c223a729
TT
65662019-07-17 Tom Tromey <tom@tromey.com>
6567
6568 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6569 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6570
50daf268
TT
65712019-07-17 Tom Tromey <tom@tromey.com>
6572
6573 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6574 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6575 from tui_display_all_data.
6576 * tui/tui-win.c
6577 (tui_data_window::do_make_visible_with_new_height): Update.
6578 * tui/tui-regs.c (tui_show_registers): Update.
6579 * tui/tui-layout.c (tui_set_layout): Update.
6580 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6581 method.
6582
df5f8cab
TT
65832019-07-17 Tom Tromey <tom@tromey.com>
6584
6585 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6586 * tui/tui-windata.c (tui_display_data_from): Remove.
6587 (tui_data_window::refresh_all): Update.
6588
80cb6c27
TT
65892019-07-17 Tom Tromey <tom@tromey.com>
6590
6591 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6592 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6593 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6594 tui_display_registers_from_line.
6595 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6596 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6597 "force_display" parameter.
6598
baff0c28
TT
65992019-07-17 Tom Tromey <tom@tromey.com>
6600
6601 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6602 declare.
6603 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6604 Rename from tui_first_reg_element_no_inline.
6605 (tui_display_reg_element_at_line)
6606 (tui_display_registers_from_line): Update.
6607 * tui/tui-data.h (struct tui_data_window)
6608 <first_reg_element_no_inline>: New method.
6609
3b23c5f2
TT
66102019-07-17 Tom Tromey <tom@tromey.com>
6611
6612 * tui/tui-windata.c (tui_display_data_from)
6613 (tui_data_window::do_scroll_vertical): Update.
6614 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6615 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6616 Rename from tui_line_from_reg_element_no.
6617 (tui_display_registers_from_line): Update.
6618 * tui/tui-data.h (struct tui_data_window)
6619 <line_from_reg_element_no>: New method.
6620
0b5ec218
TT
66212019-07-17 Tom Tromey <tom@tromey.com>
6622
6623 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6624 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6625 tui_last_regs_line_no.
6626 (tui_display_reg_element_at_line)
6627 (tui_display_registers_from_line): Update.
6628 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6629 method.
6630
0807ab7b
TT
66312019-07-17 Tom Tromey <tom@tromey.com>
6632
6633 PR tui/24722:
6634 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6635 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6636 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6637 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6638 (tui_update_breakpoint_info): Likewise.
6639 * tui/tui-hooks.c (tui_event_create_breakpoint)
6640 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6641 Update.
6642
9ad7fdef
TT
66432019-07-17 Tom Tromey <tom@tromey.com>
6644
6645 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6646
5813316f
TT
66472019-07-17 Tom Tromey <tom@tromey.com>
6648
6649 * tui/tui-winsource.c (tui_update_source_window_as_is)
6650 (tui_update_source_windows_with_addr): Update.
6651 * tui/tui-source.h (tui_set_source_content)
6652 (tui_show_symtab_source): Add "win_info" parameter.
6653 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6654 parameter.
6655 (tui_show_symtab_source): Likewise.
6656
00e264e7
TT
66572019-07-17 Tom Tromey <tom@tromey.com>
6658
6659 * tui/tui-wingeneral.c
6660 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6661
06210ce4
TT
66622019-07-17 Tom Tromey <tom@tromey.com>
6663
6664 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6665 (struct tui_cmd_window) <can_scroll>: New method.
6666 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6667 method.
6668
381befee
TT
66692019-07-17 Tom Tromey <tromey@adacore.com>
6670
6671 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6672 do_field_signed>: Rename. Change type of "value".
6673 * ui-out.c (ui_out::field_signed): Rename from field_int.
6674 Change type of "value".
6675 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6676 type of "value".
6677 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6678 do_field_int. Change type of "value".
6679 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6680 do_field_int. Change type of "value".
6681 * tracepoint.c (trace_status_mi, tfind_1)
6682 (print_one_static_tracepoint_marker): Update.
6683 * thread.c (print_thread_info_1, print_selected_thread_frame):
6684 Update.
6685 * stack.c (print_frame, print_frame_info): Update.
6686 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6687 Update.
6688 * source.c (print_source_lines_base): Update.
6689 * skip.c (info_skip_command): Update.
6690 * record-btrace.c (btrace_ui_out_decode_error)
6691 (btrace_call_history_src_line): Update.
6692 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6693 Update.
6694 * progspace.c (print_program_space): Update.
6695 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6696 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6697 do_field_int. Change type of "value".
6698 * mi/mi-out.c (mi_ui_out::do_table_begin)
6699 (mi_ui_out::do_table_header): Update.
6700 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6701 type of "value".
6702 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6703 (mi_cmd_data_list_changed_registers, output_register)
6704 (mi_cmd_data_read_memory, mi_load_progress)
6705 (mi_cmd_trace_frame_collected): Update.
6706 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6707 Update.
6708 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6709 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6710 (mi_cmd_var_list_children, varobj_update_one): Update.
6711 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6712 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6713 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6714 * inferior.c (print_inferior): Update.
6715 * gdb_bfd.c (print_one_bfd): Update.
6716 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6717 Update.
6718 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6719 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6720 do_field_int. Change type of "value".
6721 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6722 do_field_int. Change type of "value".
6723 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6724 (print_one_breakpoint_location, print_it_catch_fork)
6725 (print_one_catch_fork, print_it_catch_vfork)
6726 (print_one_catch_vfork, print_it_catch_solib)
6727 (print_it_catch_exec, print_it_ranged_breakpoint)
6728 (print_mention_watchpoint, print_mention_masked_watchpoint)
6729 (bkpt_print_it, update_static_tracepoint): Update.
6730 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6731 * break-catch-syscall.c (print_it_catch_syscall): Update.
6732 * ada-tasks.c (print_ada_task_info): Update.
6733 * ada-lang.c (print_it_exception, print_mention_exception):
6734 Update.
6735
6b78c3f8
AB
67362019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6737
6738 PR breakpoints/24541
6739 * gdbarch.c: Regenerate.
6740 * gdbarch.h: Regenerate.
6741 * gdbarch.sh: Adjust return type and parameter types for
6742 'stap_adjust_register'.
6743 (i386_stap_adjust_register): Adjust signature and return new
6744 register name.
6745 * stap-probe.c (stap_parse_register_operand): Adjust use of
6746 'gdbarch_stap_adjust_register'.
6747
d72a9b85
TT
67482019-07-17 Tom Tromey <tromey@adacore.com>
6749
6750 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6751 declare VEC.
6752 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6753 std::vector.
6754 (struct s390_process_info): Add initializers.
6755 (s390_add_process): Use new.
6756 (s390_linux_nat_target::low_forget_process): Use delete.
6757 (s390_linux_nat_target::low_new_fork)
6758 (s390_linux_nat_target::stopped_by_watchpoint)
6759 (s390_linux_nat_target::low_prepare_to_resume)
6760 (s390_linux_nat_target::insert_watchpoint)
6761 (s390_linux_nat_target::insert_hw_breakpoint)
6762 (s390_linux_nat_target::remove_watchpoint)
6763 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6764
206e6c58
JB
67652019-07-16 John Baldwin <jhb@FreeBSD.org>
6766
6767 * aarch64-fbsd-nat.c: Include regcache.h.
6768 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6769 argument.
6770 (aarch64_fbsd_nat_target::fetch_registers)
6771 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6772 variable.
6773 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6774
cbde90f2
JB
67752019-07-16 John Baldwin <jhb@FreeBSD.org>
6776
6777 * fbsd-nat.c: Include gdbarch.h.
6778
07128006
TT
67792019-07-15 Tom Tromey <tromey@adacore.com>
6780
6781 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6782
1f77b012
TT
67832019-07-15 Tom Tromey <tromey@adacore.com>
6784
6785 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6786 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6787 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6788 * cli-out.c (cli_ui_out::do_field_int): New method.
6789 * ui-out.c (ui_out::field_unsigned): New method.
6790 * symfile.c (generic_load): Use field_unsigned.
6791 (print_transfer_performance): Likewise.
6792 * record-btrace.c (ui_out_field_uint): Remove.
6793 (btrace_call_history_insn_range, btrace_call_history): Use
6794 field_unsigned.
6795 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6796 field_unsigned.
6797 * ui-out.h (class ui_out) <field_unsigned>: New method.
6798 <do_field_unsigned>: Likewise.
6799
33eca680
TT
68002019-07-15 Tom Tromey <tromey@adacore.com>
6801
6802 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6803 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6804 * target.c (flash_erase_command): Use field_string.
6805 * infrun.c (print_signal_received_reason): Use field_string.
6806 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6807 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6808 field_string.
6809 * ada-tasks.c (print_ada_task_info): Use field_string.
6810
ca8d69be
TT
68112019-07-15 Tom Tromey <tromey@adacore.com>
6812
6813 * target.c (flash_erase_command): Use field_core_addr.
6814 * symfile.c (generic_load): Use field_core_addr.
6815 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6816 Use field_core_addr.
6817 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6818 field_core_addr.
6819
0d4e84ed
AB
68202019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6821
6822 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6823 value if its desired type is smaller than a CORE_ADDR and signed.
6824
9a49df9d
AB
68252019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6826
6827 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6828 of changes to field names, and use new is_reference field to
6829 decide if a property is a reference or not.
6830 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6831 field.
6832 (struct dwarf2_property_baton): Update header comment, rename
6833 'referenced_type' to 'property_type' and update comments.
6834 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6835 default property type, store in property baton, update to take
6836 accound of renamed field.
6837 (read_func_scope): Update call to attr_to_dynamic_prop.
6838 (read_array_type): Likewise.
6839 (dwarf2_per_cu_addr_sized_int_type): New function.
6840 (read_subrange_index_type): Move type finding code to
6841 dwarf2_per_cu_addr_sized_int_type.
6842 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6843 (dwarf2_per_cu_addr_type): New function.
6844 (set_die_type): Update calls to attr_to_dynamic_prop.
6845
b86352cf
AB
68462019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6847
6848 * dwarf2read.c (read_subrange_index_type): New function.
6849 (read_subrange_type): Move code into new function and call it.
6850 * gdbtypes.c (create_range_type): Add some asserts.
6851
603490bf
AB
68522019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6853
6854 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6855 update return statements.
6856 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6857 declaration, and update comment to match.
6858 * gdbtypes.c (resolve_dynamic_array): Update call to
6859 dwarf2_evaluate_property to match new return type.
6860
592f9d27
AB
68612019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6862
6863 * valarith.c (value_subscripted_rvalue): Change lowerbound
6864 parameter type from int to LONGEST.
6865 * value.h (value_subscripted_rvalue): Likewise in declaration.
6866
60cfcb20
AB
68672019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6868
6869 * cli/cli-utils.c (info_print_command_completer): New function.
6870 * cli/cli-utils.h: Add 'completer.h' include, and forward
6871 declaration for 'struct cmd_list_element'.
6872 (info_print_command_completer): Declare.
6873 * stack.c (_initialize_stack): Add completer for 'info locals' and
6874 'info args'.
6875 * symtab.c (_initialize_symtab): Add completer for 'info
6876 variables' and 'info functions'.
6877 * NEWS: Mention completion for additional info commands.
6878
b16507e0
AB
68792019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6880
6881 * cli/cli-utils.c (extract_info_print_args): Delete.
6882 (extract_arg_maybe_quoted): Delete.
6883 (info_print_options_defs): New variable.
6884 (make_info_print_options_def_group): New function.
6885 (extract_info_print_options): Define new function.
6886 * cli/cli-utils.h (extract_info_print_args): Delete.
6887 (struct info_print_options): New structure.
6888 (extract_info_print_options): Declare new function.
6889 * stack.c (info_locals_command): Update to use new
6890 extract_info_print_options, also add a header comment.
6891 (info_args_command): Likewise.
6892 * symtab.c (info_variables_command): Likewise.
6893 (info_functions_command): Likewise.
6894
021d8588
AB
68952019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6896
6897 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6898 to extract string arguments.
6899 * common/common-utils.c (extract_string_maybe_quoted): New function.
6900 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6901
b777eb6d
TT
69022019-07-11 Tom Tromey <tromey@adacore.com>
6903
6904 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6905 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6906 * top.h (gdbinit): Don't declare.
6907 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6908 into...
6909 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6910 * top.c (gdb_init): Don't call init_cli_cmds.
6911 (gdbinit): Remove.
6912 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6913
72ee03ff
TT
69142019-07-11 Tom Tromey <tromey@adacore.com>
6915
6916 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6917 after it has been moved.
6918
00db9531
SM
69192019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6920
6921 * valops.c (value_must_coerce_to_target): Change return type to
6922 bool.
6923 * value.h (value_must_coerce_to_target): Likewise.
6924
f2478a7e
SM
69252019-07-10 Simon Marchi <simon.marchi@efficios.com>
6926
6927 * breakpoint.c (is_hardware_watchpoint): Remove
6928 forward-declaration.
6929 (is_masked_watchpoint): Change return type to bool.
6930 (is_tracepoint): Likewise.
6931 (is_breakpoint): Likewise.
6932 (is_hardware_watchpoint): Likewise.
6933 (is_watchpoint): Likewise.
6934 (is_no_memory_software_watchpoint): Likewise.
6935 (is_catchpoint): Likewise.
6936 (breakpoint_1): Make FILTER parameter's return type bool.
6937 is_masked_watchpoint): Change return type to bool.
6938 (save_breakpoints): Make FILTER parameter's return type bool.
6939 * breakpoint.h (is_breakpoint): Change return type to bool.
6940 (is_watchpoint): Likewise.
6941 (is_catchpoint): Likewise.
6942 (is_tracepoint): Likewise.
6943
0d12e84c
TT
69442019-07-10 Tom Tromey <tom@tromey.com>
6945
6946 * defs.h: Don't include gdbarch.h.
6947 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6948 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6949 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6950 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6951 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6952 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6953 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6954 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6955 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6956 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6957 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6958 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6959 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6960 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6961 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6962 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6963 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6964 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6965 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6966 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6967 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6968 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6969 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6970 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6971 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6972 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6973 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6974
f06f1252
TT
69752019-07-10 Tom Tromey <tromey@adacore.com>
6976
6977 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6978 * breakpoint.c (init_ada_exception_breakpoint): Register as
6979 bp_catchpoint.
6980 (print_one_breakpoint_location, print_one_breakpoint): Use
6981 is_ada_exception_catchpoint.
6982 * ada-lang.c (class ada_catchpoint_location): Pass
6983 bp_loc_software_breakpoint to bp_location constructor.
6984 (is_ada_exception_catchpoint): New function.
6985
7a5d944b
TT
69862019-07-10 Tom Tromey <tromey@adacore.com>
6987
6988 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6989 VEC.
6990 (struct arm_exidx_entry): New method operator<.
6991 (struct arm_exidx_data) <section_maps>: Change type.
6992 (arm_exidx_data_free): Remove.
6993 (arm_exidx_data_key): Change type. Move lower.
6994 (arm_exidx_new_objfile): Update.
6995 (arm_compare_exidx_entries): Remove.
6996 (arm_find_exidx_entry, _initialize_arm_tdep)
6997
48c66e1d
TT
69982019-07-10 Tom Tromey <tromey@adacore.com>
6999
7000 * solib-spu.c (ocl_program_data_key): Change type.
7001 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7002 Update.
7003
a269fbf1
TT
70042019-07-10 Tom Tromey <tromey@adacore.com>
7005
7006 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7007 (struct solib_aix_inferior_data) <library_list>: Change type.
7008 (solib_aix_inferior_data_handle): Change type.
7009 (get_solib_aix_inferior_data): Update.
7010 (solib_aix_free_library_list): Remove.
7011 (library_list_start_library): Update.
7012 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7013 return type.
7014 (solib_aix_get_library_list)
7015 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7016 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7017
c294730c
TT
70182019-07-10 Tom Tromey <tromey@adacore.com>
7019
7020 * solib-dsbt.c (struct dsbt_info): Add initializers.
7021 (solib_dsbt_pspace_data): Change type.
7022 (dsbt_pspace_data_cleanup): Remove.
7023 (get_dsbt_info, _initialize_dsbt_solib): Update.
7024
9d52077d
TT
70252019-07-10 Tom Tromey <tromey@adacore.com>
7026
7027 * spu-tdep.c (spu_overlay_data): Change type.
7028 (spu_get_overlay_table, spu_overlay_new_objfile)
7029 (_initialize_spu_tdep): Update.
7030
22a20dca
TT
70312019-07-10 Tom Tromey <tromey@adacore.com>
7032
7033 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7034 destructor.
7035 (dbx_objfile_data_key): Change type and declare later.
7036 (DBX_SYMFILE_INFO): Rewrite.
7037 * dbxread.c (dbx_objfile_data_key): Change type.
7038 (dbx_symfile_init): Update.
7039 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7040 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7041 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7042
cb60f420
TT
70432019-07-10 Tom Tromey <tromey@adacore.com>
7044
7045 * jit.c (jit_program_space_key): Change type. Move lower.
7046 (get_jit_program_space_data): Update.
7047 (jit_program_space_data_cleanup): Remove.
7048 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7049 Update.
7050 (struct jit_program_space_data): Add initializers.
7051
51df2ae3
TT
70522019-07-10 Tom Tromey <tromey@adacore.com>
7053
7054 * solib-darwin.c (struct darwin_info): Add initializers.
7055 (solib_darwin_pspace_data): Change type.
7056 (darwin_pspace_data_cleanup): Remove.
7057 (get_darwin_info, _initialize_darwin_solib): Update.
7058
18101a35
TT
70592019-07-10 Tom Tromey <tromey@adacore.com>
7060
7061 * remote-sim.c (struct sim_inferior_data): Add initializers,
7062 constructor, and destructor.
7063 (sim_inferior_data_key): Change type. Move lower.
7064 (check_for_duplicate_sim_descriptor): Update.
7065 (get_sim_inferior_data): Use new. Update.
7066 (~sim_inferior_data_cleanup): Rename from
7067 sim_inferior_data_cleanup. Simplify.
7068 (gdbsim_close_inferior, simulator_command)
7069 (sim_command_completer, _initialize_remote_sim): Update.
7070 (next_pid, INITIAL_PID): Move earlier.
7071
05b08ac1
TT
70722019-07-10 Tom Tromey <tromey@adacore.com>
7073
7074 * python/python-internal.h (create_thread_object): Return
7075 gdbpy_ref.
7076 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7077 * python/py-inferior.c (struct threadlist_entry): Add
7078 constructor.
7079 <thread_obj>: Now a gdbpy_ref.
7080 (thread_to_thread_object): Update.
7081 (add_thread_object): Use new.
7082 (delete_thread_object): Use delete.
7083 (infpy_threads): Update.
7084 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7085 GIL.
7086
32372d80
TT
70872019-07-10 Tom Tromey <tromey@adacore.com>
7088
7089 * valops.c (value_cast): Specialize error message for Ada.
7090
5c458ae8
SM
70912019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7092
7093 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7094
4c462cb0
SM
70952019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7096
7097 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7098 bpstat_should_step): Return bool, adjust comments.
7099 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7100 bpstat_should_step): Likewise.
7101
89abbcc2
AH
71022019-07-10 Alan Hayward <alan.hayward@arm.com>
7103
7104 * features/Makefile: Use feature target descriptions for Arm.
7105 * features/arm/arm-core.c: Generate new file.
7106 * features/arm/arm-fpa.c: Likewise.
7107 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7108 * features/arm/arm-m-profile.c: Likewise.
7109 * features/arm/arm-vfpv2.c: Likewise.
7110 * features/arm/arm-vfpv3.c: Likewise.
7111 * features/arm/xscale-iwmmxt.c: Likewise.
7112 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7113
166a82be
AH
71142019-07-10 Alan Hayward <alan.hayward@arm.com>
7115
7116 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7117 ptrace earlier.
7118
9fb4c7e9
AH
71192019-07-10 Alan Hayward <alan.hayward@arm.com>
7120
7121 * features/aarch64-pauth.c: Regenerate.
7122
e2d0f980
SM
71232019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7124
7125 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7126 bool.
7127 (bpstat_what): Use false instead of 0.
7128
a38118e5
PA
71292019-07-09 Pedro Alves <palves@redhat.com>
7130
7131 * break-catch-throw.c (is_exception_catchpoint): New.
7132 * breakpoint.c (print_one_breakpoint_location): New parameter
7133 'raw_loc'. Handle it. Use
7134 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7135 looking at the breakpoint's type.
7136 (print_one_breakpoint): If handling "maint info breakpoints", also
7137 print locations of exception catchpoints.
7138 * breakpoint.h (is_exception_catchpoint): Declare.
7139
cb1e4e32
PA
71402019-07-09 Pedro Alves <palves@redhat.com>
7141
7142 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7143 "addr" field.
7144 (allocate_location_exception_catchpoint): New.
7145 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7146 (initialize_throw_catchpoint_ops): Install
7147 allocate_location_exception_catchpoint as allocate_location
7148 method.
7149 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7150 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7151 bp_loc_other.
7152 (breakpoint_address_is_meaningful): Delete.
7153 (bl_address_is_meaningful): New.
7154 (breakpoint_locations_match): Adjust comment.
7155 (bp_location_from_bp_type): New, factored out of...
7156 (bp_location::bp_location(breakpoint *)): ... this.
7157 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7158 factored out of...
7159 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7160 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7161 breakpoint_address_is_meaningful.
7162 (bp_locations_compare): Adjust comment.
7163 (update_global_location_list): Use bl_address_is_meaningful
7164 instead of breakpoint_address_is_meaningful.
7165 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7166 explicit.
7167 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7168 * python/py-breakpoint.c (bppy_get_location): No longer check
7169 whether location is null.
7170
b58a68fe
PA
71712019-07-09 Pedro Alves <palves@redhat.com>
7172
7173 PR c++/15468
7174 * breakpoint.c (print_one_breakpoint_location): Remove
7175 single-location assert.
7176
268a13a5
TT
71772019-07-09 Tom Tromey <tom@tromey.com>
7178
7179 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7180 * configure: Rebuild.
7181 * configure.ac: Change common to gdbsupport.
7182 * gdbsupport: Rename from common.
7183 * acinclude.m4: Change common to gdbsupport.
7184 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7185 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7186 gdbsupport.
7187 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7188 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7189 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7190 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7191 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7192 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7193 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7194 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7195 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7196 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7197 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7198 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7199 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7200 coff-pe-read.c, command.h, compile/compile-c-support.c,
7201 compile/compile-c.h, compile/compile-cplus-symbols.c,
7202 compile/compile-cplus-types.c, compile/compile-cplus.h,
7203 compile/compile-loc2c.c, compile/compile.c, completer.c,
7204 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7205 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7206 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7207 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7208 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7209 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7210 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7211 features/aarch64-core.c, features/aarch64-fpu.c,
7212 features/aarch64-pauth.c, features/aarch64-sve.c,
7213 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7214 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7215 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7216 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7217 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7218 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7219 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7220 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7221 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7222 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7223 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7224 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7225 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7226 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7227 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7228 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7229 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7230 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7231 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7232 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7233 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7234 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7235 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7236 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7237 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7238 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7239 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7240 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7241 minsyms.c, mips-linux-tdep.c, namespace.h,
7242 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7243 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7244 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7245 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7246 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7247 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7248 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7249 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7250 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7251 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7252 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7253 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7254 procfs.c, producer.c, progspace.h, psymtab.h,
7255 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7256 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7257 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7258 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7259 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7260 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7261 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7262 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7263 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7264 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7265 target-memory.c, target.c, target.h, target/waitstatus.c,
7266 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7267 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7268 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7269 unittests/array-view-selftests.c,
7270 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7271 unittests/common-utils-selftests.c,
7272 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7273 unittests/format_pieces-selftests.c,
7274 unittests/function-view-selftests.c,
7275 unittests/lookup_name_info-selftests.c,
7276 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7277 unittests/mkdir-recursive-selftests.c,
7278 unittests/observable-selftests.c,
7279 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7280 unittests/parse-connection-spec-selftests.c,
7281 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7282 unittests/scoped_fd-selftests.c,
7283 unittests/scoped_mmap-selftests.c,
7284 unittests/scoped_restore-selftests.c,
7285 unittests/string_view-selftests.c, unittests/style-selftests.c,
7286 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7287 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7288 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7289 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7290 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7291 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7292
5b0e2db4
AB
72932019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7294
7295 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7296 bool value.
7297 (decode_digits_ordinary): Set explicit_line field in sal.
7298 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7299 symtab_and_line that was set on an explicit line number in
7300 assembler code. Do always update the recorded symtab and line if
7301 we do skip the prologue.
7302
0ba852ab
AB
73032019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7304
7305 * breakpoint.c (set_breakpoint_location_function): Remove
7306 explicit_loc parameter.
7307 (momentary_breakpoint_from_master): Update call to
7308 set_breakpoint_location_function.
7309 (add_location_to_breakpoint): Likewise.
7310
b3a7d171
AB
73112019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7312
7313 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7314 required features based on default bfd type when no specific bfd
7315 is present.
7316
1f6f6e21
PW
73172019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7318
7319 * NEWS: Mention that GDB printf and eval commands can now print
7320 C-style and Ada-style convenience var strings without
7321 calling the inferior.
7322 * printcmd.c (printf_c_string): Locally print GDB internal var
7323 instead of transiting via the inferior.
7324 (printf_wide_c_string): Likewise.
7325
73262019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7327
5862c886 7328 PR breakpoints/25011
ea142fbf
AH
7329 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7330
0598af48
TT
73312019-07-04 Tom Tromey <tom@tromey.com>
7332
7333 PR tui/24724:
7334 * tui/tui-winsource.c (tui_clear_source_content): Update.
7335 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7336 (tui_update_breakpoint_info): Update.
7337 (tui_set_exec_info_content): Update.
7338 * tui/tui-source.c (tui_set_source_content_nil): Update.
7339 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7340 has_break.
7341 * tui/tui-data.h (enum tui_bp_flag): New.
7342 (tui_bp_flags): New enum flags type.
7343 (struct tui_source_element) <break_mode>: Change type. Rename
7344 from has_break.
7345 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7346 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7347 constants.
7348 * tui/tui-winsource.h: Fix comment.
7349
350fab54
AH
73502019-07-04 Alan Hayward <alan.hayward@arm.com>
7351
7352 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7353 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7354 (store_fpregs_to_thread)
7355 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7356 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7357 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7358 (IWMMXT_REGS_SIZE): Add define.
7359 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7360 (fetch_vfp_regs, store_vfp_regs)
7361 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7362 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7363
f0452268
AH
73642019-07-04 Alan Hayward <alan.hayward@arm.com>
7365
7366 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7367 defines.
7368 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7369 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7370 (ARM_INT_REGISTER_SIZE): ...to this.
7371 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7372 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7373 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7374 (arm_linux_collect_gregset, supply_nwfpe_register)
7375 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7376 defines.
7377 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7378 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7379 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7380 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7381 (arm_return_in_memory, arm_store_return_value)
7382 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7383 (arm_record_ld_st_multiple): Likewise.
7384 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7385 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7386
e935475c
AH
73872019-07-04 Alan Hayward <alan.hayward@arm.com>
7388
7389 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7390 AARCH64_DISPLACED_MODIFIED_INSNS.
7391 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7392 (aarch64_displaced_step_copy_insn): Likewise.
7393 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7394 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7395 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7396 ARM_DISPLACED_MODIFIED_INSNS.
7397 * arm-tdep.c (arm_gdbarch_init): Likewise.
7398 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7399 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7400 (struct arm_displaced_step_closure): Use
7401 ARM_DISPLACED_MODIFIED_INSNS.
7402
df0bb381
AH
74032019-07-04 Alan Hayward <alan.hayward@arm.com>
7404
7405 * features/Makefile: Remove unused xml files.
7406 * features/aarch64.xml: Remove.
7407 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7408 * features/i386/amd64-avx-avx512.xml: Remove.
7409 * features/i386/amd64-avx-linux.xml: Remove.
7410 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7411 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7412 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7413 * features/i386/amd64-avx-mpx.xml: Remove.
7414 * features/i386/amd64-avx.xml: Remove.
7415 * features/i386/amd64-linux.xml: Remove.
7416 * features/i386/amd64-mpx-linux.xml: Remove.
7417 * features/i386/amd64-mpx.xml: Remove.
7418 * features/i386/amd64.xml: Remove.
7419 * features/i386/i386-avx-avx512-linux.xml: Remove.
7420 * features/i386/i386-avx-avx512.xml: Remove.
7421 * features/i386/i386-avx-linux.xml: Remove.
7422 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7423 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7424 * features/i386/i386-avx-mpx-linux.xml: Remove.
7425 * features/i386/i386-avx-mpx.xml: Remove.
7426 * features/i386/i386-avx.xml: Remove.
7427 * features/i386/i386-linux.xml: Remove.
7428 * features/i386/i386-mmx-linux.xml: Remove.
7429 * features/i386/i386-mmx.xml: Remove.
7430 * features/i386/i386-mpx-linux.xml: Remove.
7431 * features/i386/i386-mpx.xml: Remove.
7432 * features/i386/i386.xml: Remove.
7433 * features/i386/x32-avx-avx512-linux.xml: Remove.
7434 * features/i386/x32-avx-linux.xml: Remove.
7435 * features/i386/x32-linux.xml: Remove.
7436
edd6266a
AH
74372019-07-04 Alan Hayward <alan.hayward@arm.com>
7438
7439 * regformats/aarch64.dat: Remove.
7440 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7441 * regformats/i386/amd64-avx-linux.dat: Remove.
7442 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7443 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7444 * regformats/i386/amd64-linux.dat: Remove.
7445 * regformats/i386/amd64-mpx-linux.dat: Remove.
7446 * regformats/i386/amd64.dat: Remove.
7447 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7448 * regformats/i386/i386-avx-linux.dat: Remove.
7449 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7450 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7451 * regformats/i386/i386-linux.dat: Remove.
7452 * regformats/i386/i386-mmx-linux.dat: Remove.
7453 * regformats/i386/i386-mpx-linux.dat: Remove.
7454 * regformats/i386/i386.dat: Remove.
7455 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7456 * regformats/i386/x32-avx-linux.dat: Remove.
7457 * regformats/i386/x32-linux.dat: Remove.
7458
2b40fda7
AH
74592019-07-04 Alan Hayward <alan.hayward@arm.com>
7460
7461 * aarch64-tdep.c: Remove xml self tests.
7462 * amd64-linux-tdep.c: Likewise.
7463 * amd64-tdep.c: Likewise.
7464 * i386-linux-tdep.c: Likewise.
7465 * i386-tdep.c: Likewise.
7466
5f4ba3e7
PA
74672019-07-03 Pedro Alves <palves@redhat.com>
7468
7469 PR cli/24732
7470 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7471 (pipe_cmd_option_defs): New.
7472 (make_pipe_cmd_options_def_group): New.
7473 (pipe_command): Use gdb::option::process_options.
7474 (pipe_command_completer): New function.
7475 (_initialize_cli_cmds): Install completer for "pipe" command.
7476
3d9be6f5
PA
74772019-07-03 Pedro Alves <palves@redhat.com>
7478
7479 * cli/cli-option.c (union option_value) <string>: New field.
7480 (struct option_def_and_value): Add ctor, move ctor, dtor and
7481 use DISABLE_COPY_AND_ASSIGN.
7482 (option_def_and_value::clear_value): New.
7483 (parse_option, save_option_value_in_ctx, get_val_type_str)
7484 (add_setshow_cmds_for_options): Handle var_string.
7485 * cli-option.h (union option_def::var_address) <string>: New
7486 field.
7487 (struct string_option_def): New.
7488 * maint-test-options.c (struct test_options_opts): Add default
7489 ctor and use DISABLE_COPY_AND_ASSIGN.
7490 <string_opt>: New field.
7491 (test_options_opts::~test_options_opts): New.
7492 (test_options_opts::dump): Also dump "-string".
7493 (test_options_option_defs): Install "string.
7494
41fc454c
PA
74952019-07-03 Pedro Alves <palves@redhat.com>
7496
7497 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7498 option_value with a null enumeration.
7499 (complete_options): Save the option values in the context.
7500 (save_option_value_in_ctx): New, factored out from ...
7501 (process_options): ... here.
7502 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7503 of the function.
7504 * maint-test-options.c (test_options_opts::dump): New, factored
7505 out from ...
7506 (maintenance_test_options_command_mode): ... here.
7507 (maintenance_test_options_command_completion_result): Delete.
7508 (maintenance_test_options_command_completion_text): Update
7509 comment.
7510 (maintenance_show_test_options_completion_result): Change
7511 prototype. Just print
7512 maintenance_test_options_command_completion_text.
7513 (save_completion_result): New.
7514 (maintenance_test_options_completer_mode): Pass options context to
7515 complete_options, and then save a dump.
7516 (_initialize_maint_test_options): Use add_cmd to install "maint
7517 show test-options-completion-result".
7518
fdbc9870
PA
75192019-07-03 Pedro Alves <palves@redhat.com>
7520
7521 * NEWS (New commands): Mention "with" and "maint with".
7522 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7523 (with_command, with_command_completer): New.
7524 (pipe_command): Adjust to new repeat_previous
7525 interface.
7526 (_initialize_cli_cmds): Install the "with" command and its "w"
7527 alias.
7528 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7529 declarations.
7530 * cli/cli-setshow.c (parse_cli_var_uinteger)
7531 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7532 argument strings for all var_types.
7533 (get_setshow_command_value_string): New, factored out from ...
7534 (do_show_command): ... this.
7535 * cli/cli-setshow.h: Include <string>.
7536 (get_setshow_command_value_string): Declare.
7537 * command.h (repeat_previous): Now returns const char *. Adjust
7538 comment.
7539 * maint.c: Include "cli/cli-cmds.h".
7540 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7541 (_initialize_maint_cmds): Register the "maintenance with" command.
7542 * top.c (repeat_previous): Move bits from pipe_command here:
7543 Return the saved command line, if any; error out if there's no
7544 command to relaunch.
7545
c6ac8931
PA
75462019-07-03 Pedro Alves <palves@redhat.com>
7547
7548 * NEWS (New commands): Mention "maint set/show test-settings"
7549 instead of "maint test-settings".
7550 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7551 (maintenance_test_settings_set_list): Rename to ...
7552 (maintenance_set_test_settings_list): ... this.
7553 (maintenance_test_settings_show_list): Rename to ...
7554 (maintenance_show_test_settings_list): ... this.
7555 (maintenance_test_settings_cmd): Delete.
7556 (maintenance_test_settings_set_cmd): ...
7557 (maintenance_set_test_settings_cmd): ... this.
7558 (maintenance_test_settings_show_cmd): ...
7559 (maintenance_show_test_settings_cmd): ... this.
7560 (maintenance_test_settings_show_value_cmd):
7561 (maintenance_show_test_settings_value_cmd): ... this.
7562 (_initialize_maint_test_settings): No longer install the "maint
7563 test-settings" prefix command. Rename "maint test-settings set"
7564 to "maint set test-settings", and "maint test-settings show" to
7565 "maint show test-settings". Adjust all subcommands.
7566
d1fcf2fd
PA
75672019-07-03 Pedro Alves <palves@redhat.com>
7568
7569 * maint-test-settings.c: Fix file's intro comment. Replace all
7570 references to "test-options" with references to "test-settings",
7571 in comments.
7572
970f9d09
PA
75732019-07-03 Pedro Alves <palves@redhat.com>
7574
7575 * maint-test-settings.c (maintenance_test_settings_xxx)
7576 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7577 New.
7578 (maintenance_test_settings_enums): Use them.
7579 (maintenance_test_settings_enum): Default to
7580 maintenance_test_settings_xxx.
7581 (_initialize_maint_test_settings): Initialize
7582 MAINTENANCE_TEST_SETTINGS_FILENAME.
7583
f3869b1a
SM
75842019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7585
7586 * breakpoint.h (remove_breakpoints_inf): Change return type to
7587 void, move function documentation here.
7588 * breakpoint.c (remove_breakpoints_inf): Change return type to
7589 void, move function documentation to header.
7590
54d66006
PA
75912019-07-02 Pedro Alves <palves@redhat.com>
7592
7593 * NEWS (Completion improvements): Mention "info threads".
7594 * thread.c (struct info_threads_opts, info_threads_option_defs)
7595 (make_info_threads_options_def_group): New.
7596 (info_threads_command): Use gdb::option::process_options.
7597 (info_threads_command_completer): New.
7598 (_initialize_thread): Use gdb::option::build_help to build the
7599 help text for "info threads".
7600
854f6088
SM
76012019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7602
7603 * defs.h (generic_load): Move from here...
7604 * symfile.h (generic_load): ... to here. Rename name parameter
7605 to args.
7606 * symfile.c (generic_load): Add comment.
7607
54ee4252
TT
76082019-07-01 Tom Tromey <tromey@adacore.com>
7609
7610 * dwarf2read.c
7611 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7612 declaration of without_params. Fix formatting.
7613
65392b3e
TT
76142019-07-01 Tom Tromey <tromey@adacore.com>
7615
7616 * ada-exp.y (find_primitive_type): Update.
7617 * ada-lang.h (ada_lookup_symbol): Update.
7618 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7619 parameter.
7620 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7621
7d7571f0
SDJ
76222019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7623
7624 PR breakpoints/24541
7625 * gdbarch.c: Regenerate.
7626 * gdbarch.h: Regenerate.
7627 * gdbarch.sh: Add 'stap_adjust_register'.
7628 * i386-tdep.c: Include '<unordered_set>'.
7629 (i386_stap_adjust_register): New function.
7630 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7631 * stap-probe.c (stap_parse_register_operand): Call
7632 'gdbarch_stap_adjust_register'.
7633
5af5392a
SDJ
76342019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7635
7636 PR python/24742
7637 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7638 * python/python.c (do_start_initialization): Use 'xmalloc'
7639 instead of 'PyMem_Malloc'.
7640
10d06d82
TT
76412019-06-28 Tom Tromey <tromey@adacore.com>
7642
7643 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7644 for Ada.
7645
1b7f24cd
TT
76462019-06-27 Tom Tromey <tromey@adacore.com>
7647
7648 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7649 objfile_key.
7650 (arm_find_mapping_symbol, arm_record_special_symbol)
7651 (_initialize_arm_tdep): Update.
7652 (arm_objfile_data_free): Remove.
7653
3d507ff2
TT
76542019-06-27 Tom Tromey <tromey@adacore.com>
7655
7656 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7657 to cp_print_static_field.
7658
762c164d
TT
76592019-06-26 Tom Tromey <tromey@adacore.com>
7660
7661 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7662 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7663 declare.
7664
aa2f9bcf
AH
76652019-06-26 Alan Hayward <alan.hayward@arm.com>
7666
7667 * features/aarch64-core.c (create_feature_aarch64_core):
7668 Regenerate.
7669 * features/aarch64-core.xml: Add cpsr flags.
7670
3426ae57
AH
76712019-06-26 Alan Hayward <alan.hayward@arm.com>
7672
7673 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7674 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7675
4838e44c
SM
76762019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7677
7678 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7679 field.
7680 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7681 use.
7682 (arm_record_special_symbol): Don't insert new symbol in sorted
7683 position, push it at the end.
7684
54cc7474
SM
76852019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7686
7687 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7688 (arm_mapping_symbol_s): Remove.
7689 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7690 (arm_mapping_symbol_vec): New typedef.
7691 (struct arm_per_objfile): Add constructor.
7692 <section_maps>: Change type to
7693 std::unique_ptr<arm_mapping_symbol_vec[]>.
7694 (arm_compare_mapping_symbols): Remove.
7695 (arm_find_mapping_symbol): Adjust to section_maps type change.
7696 (arm_objfile_data_free): Call delete on arm_per_objfile.
7697 (arm_record_special_symbol): Adjust to section_maps type change.
7698 Allocate arm_per_objfile with new.
7699
b65b566c
PW
77002019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7701
7702 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7703 with the command prefix.
7704
c2fc64f5
TT
77052019-06-25 Tom Tromey <tom@tromey.com>
7706
7707 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7708 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7709
fb54fa76
TT
77102019-06-25 Tom Tromey <tom@tromey.com>
7711
7712 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7713 type.
7714 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7715 protected.
7716
f7952c57
TT
77172019-06-25 Tom Tromey <tom@tromey.com>
7718
7719 * tui/tui-winsource.c
7720 (tui_source_window_base::set_is_exec_point_at): Add check against
7721 LOA_ADDRESS.
7722
17568d78
TT
77232019-06-25 Tom Tromey <tom@tromey.com>
7724
7725 * tui/tui-source.c (tui_set_source_content): Don't check before
7726 xfree.
7727 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7728
53e7cdba
TT
77292019-06-25 Tom Tromey <tom@tromey.com>
7730
7731 * tui/tui-winsource.h (tui_update_source_window_as_is)
7732 (tui_alloc_source_buffer, tui_line_is_displayed)
7733 (tui_addr_is_displayed): Change type of win_info.
7734 * tui/tui-winsource.c (tui_update_source_window_as_is)
7735 (tui_clear_source_content, tui_show_source_line)
7736 (tui_show_source_content, tui_source_window_base::refill)
7737 (tui_source_window_base::set_is_exec_point_at)
7738 (tui_source_window_base::set_is_exec_point_at)
7739 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7740 (tui_alloc_source_buffer, tui_line_is_displayed)
7741 (tui_addr_is_displayed): Change type of win_info. Update.
7742 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7743 (tui_source_window_base::do_make_visible_with_new_height):
7744 Update.
7745 * tui/tui-source.c (tui_set_source_content)
7746 (tui_set_source_content_nil)
7747 (tui_source_window::do_scroll_vertical): Update.
7748 * tui/tui-layout.c (show_layout): Update.
7749 * tui/tui-disasm.c (tui_set_disassem_content)
7750 (tui_disasm_window::do_scroll_vertical): Update.
7751 * tui/tui-data.h (tui_win_content): Remove.
7752 (struct tui_gen_win_info) <content, content_size>: Remove.
7753 (struct tui_source_element): Add initializers and destructor.
7754 (union tui_which_element, struct tui_win_element): Remove.
7755 (struct tui_source_window_base) <content>: New field.
7756 (struct tui_data_window): Remove destructor.
7757 (tui_alloc_content, tui_free_win_content)
7758 (tui_free_all_source_wins_content): Don't declare.
7759 * tui/tui-data.c (tui_initialize_static_data): Update.
7760 (init_content_element, tui_alloc_content): Remove.
7761 (~tui_gen_win_info): Update.
7762 (~tui_data_window, tui_free_all_source_wins_content)
7763 (tui_free_win_content, free_content, free_content_elements):
7764 Remove.
7765
7908abbf
TT
77662019-06-25 Tom Tromey <tom@tromey.com>
7767
7768 * tui/tui-winsource.h (tui_clear_source_content)
7769 (tui_erase_source_content, tui_show_source_content): Change type
7770 of win_info.
7771 * tui/tui-winsource.c (tui_clear_source_content)
7772 (tui_erase_source_content, tui_show_source_content): Change type
7773 of win_info.
7774 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7775 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7776 win_info.
7777 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7778 win_info.
7779 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7780
02c28df0
TT
77812019-06-25 Tom Tromey <tom@tromey.com>
7782
7783 * tui/tui-winsource.c (tui_clear_source_content)
7784 (tui_source_window_base::set_is_exec_point_at): Update.
7785 * tui/tui-source.c (tui_set_source_content_nil): Update.
7786 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7787 a bool.
7788 * tui/tui-data.c (init_content_element): Update.
7789
6658b1bf
TT
77902019-06-25 Tom Tromey <tom@tromey.com>
7791
7792 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7793 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7794 * tui/tui-layout.c (init_and_make_win): Update.
7795 * tui/tui.h (enum tui_win_type): Update.
7796 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7797 tui_win_is_auxillary.
7798 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7799 tui_win_is_auxillary.
7800
21e1c91e
TT
78012019-06-25 Tom Tromey <tom@tromey.com>
7802
7803 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7804 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7805 (tui_delete_data_content_windows, tui_display_all_data)
7806 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7807 Update.
7808 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7809 * tui/tui-regs.c (tui_last_regs_line_no)
7810 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7811 (tui_show_registers): Update.
7812 (tui_show_register_group): Return void. Update.
7813 (tui_display_registers_from, tui_display_reg_element_at_line)
7814 (tui_display_registers_from_line, tui_check_register_values):
7815 Update.
7816 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7817 member.
7818 (struct tui_data_window) <regs_content>: Now a std::vector.
7819 <regs_content_count>: Remove.
7820 (tui_add_content_elements, tui_free_data_content): Don't declare.
7821 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7822 (init_content_element): Remove DATA_WIN case. Add assert.
7823 (tui_add_content_elements): Remove.
7824 (tui_data_window): Update.
7825 (tui_free_data_content): Remove.
7826 (free_content_elements): Remove DATA_WIN case.
7827
115ac53b
TT
78282019-06-25 Tom Tromey <tom@tromey.com>
7829
7830 * tui/tui-data.c (tui_data_item_window): Update.
7831 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7832 * tui/tui-windata.c (tui_display_all_data)
7833 (tui_display_data_from_line): Update.
7834 (tui_check_data_values): Remove.
7835 * tui/tui-regs.c (tui_show_register_group)
7836 (tui_display_reg_element_at_line): Update.
7837 * tui/tui-hooks.c (tui_register_changed)
7838 (tui_refresh_frame_and_register_information): Call
7839 tui_check_register_values.
7840 * tui/tui-data.h (struct tui_data_window) <data_content,
7841 data_content_count, data_type>: Remove.
7842 (enum tui_data_type): Remove.
7843
7844 * tui/tui-data.c (tui_data_window::clear_detail)
7845 (~tui_data_window): Update.
7846
eaf9738b
TT
78472019-06-25 Tom Tromey <tom@tromey.com>
7848
7849 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7850 declare.
7851 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7852 Rename from tui_first_data_item_displayed. Update.
7853 (tui_data_window::refresh_all)
7854 (tui_data_window::do_scroll_vertical): Update.
7855 * tui/tui-data.h (struct tui_data_window)
7856 <first_data_item_displayed>: Declare new method.
7857
31ca4723
TT
78582019-06-25 Tom Tromey <tom@tromey.com>
7859
7860 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7861 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7862 contents...
7863 (tui_initialize_static_data): ...here.
7864
41bcff7f
TT
78652019-06-25 Tom Tromey <tom@tromey.com>
7866
7867 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7868 (tui_display_registers_from, tui_check_register_values): Update.
7869 (tui_display_register): Remove win_info parameter; update.
7870 (tui_get_register): Change type of parameters.
7871 * tui/tui-data.h (struct tui_data_element): Remove.
7872 (union tui_which_element) <data>: Remove.
7873 <data_window>: Change type.
7874 (struct tui_data_item_window): New.
7875 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7876 case. Add assert.
7877 (~tui_data_item_window): New destructor.
7878 (free_content_elements): Remove DATA_ITEM_WIN case.
7879
d2802c33
TT
78802019-06-25 Tom Tromey <tom@tromey.com>
7881
7882 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7883 Remove.
7884
dd835f8b
TT
78852019-06-25 Tom Tromey <tom@tromey.com>
7886
7887 * tui/tui-data.h (struct tui_command_element): Remove.
7888 (union tui_which_element) <command>: Remove.
7889 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7890 assert.
7891 (free_content_elements): Remove CMD_WIN case.
7892
bd7db367
TT
78932019-06-25 Tom Tromey <tom@tromey.com>
7894
7895 * tui/tui-layout.c (tui_set_layout): Update.
7896 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7897 * tui/tui-data.c (layout_def): Update.
7898
3add462f
TT
78992019-06-25 Tom Tromey <tom@tromey.com>
7900
7901 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7902 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7903 (tui_source_window_base::set_new_height): Update.
7904 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7905 Update.
7906 (tui_set_locator_fullname, tui_set_locator_info)
7907 (tui_show_frame_info): Update.
7908 * tui/tui-source.c (tui_set_source_content)
7909 (tui_source_is_displayed): Update.
7910 * tui/tui-layout.c (show_source_disasm_command, show_data)
7911 (show_source_or_disasm_and_command): Update.
7912 * tui/tui-disasm.c (tui_set_disassem_content)
7913 (tui_get_begin_asm_address): Update.
7914 * tui/tui-data.h (struct tui_locator_element): Remove.
7915 (union tui_which_element) <locator>: Remove.
7916 (struct tui_locator_window): New.
7917 (tui_locator_win_info_ptr): Change return type.
7918 * tui/tui-data.c (_locator): Change type.
7919 (tui_locator_win_info_ptr): Change return type.
7920 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7921 (tui_alloc_content): Add assert.
7922
489e9d8b
TT
79232019-06-25 Tom Tromey <tom@tromey.com>
7924
7925 * tui/tui-winsource.c
7926 (tui_exec_info_window::maybe_allocate_content): New method.
7927 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7928 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7929 (make_source_or_disasm_window): Add cast.
7930 * tui/tui-data.h (union tui_which_element) <simple_string>:
7931 Remove.
7932 (struct tui_source_info): New.
7933 (struct tui_source_window_base) <execution_info>: Change type.
7934 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7935 case, and add assert.
7936 (tui_alloc_content): Add assert.
7937
c3fabb7d
TT
79382019-06-25 Tom Tromey <tom@tromey.com>
7939
7940 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7941 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7942 * tui/tui-data.c (tui_alloc_win_info): Remove.
7943
bbc228ee
TT
79442019-06-25 Tom Tromey <tom@tromey.com>
7945
7946 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7947 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7948 can_highlight.
7949
5fcee43a
TT
79502019-06-25 Tom Tromey <tom@tromey.com>
7951
7952 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7953 make_visible_with_new_height method.
7954 (tui_win_info::make_visible_with_new_height): New method.
7955 (tui_source_window_base::do_make_visible_with_new_height)
7956 (tui_data_window::do_make_visible_with_new_height)
7957 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7958 (make_visible_with_new_height): Remove.
7959 (tui_resize_all, tui_adjust_win_heights): Use
7960 make_visible_with_new_height method.
7961 * tui/tui-data.h (struct tui_win_info)
7962 <do_make_visible_with_new_height, make_visible_with_new_height>:
7963 New methods.
7964 (struct tui_source_window_base, struct tui_data_window)
7965 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7966 methods.
7967
d83f1fe6
TT
79682019-06-25 Tom Tromey <tom@tromey.com>
7969
7970 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7971 method.
7972 (update_tab_width): Call update_tab_width method.
7973 * tui/tui-data.h (struct tui_win_info)
7974 (struct tui_source_window_base) <update_tab_width>: New methods.
7975
17374de4
TT
79762019-06-25 Tom Tromey <tom@tromey.com>
7977
7978 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7979 parameter.
7980 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7981 parameter.
7982 (tui_gen_win_info::make_visible): Update.
7983 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7984 parameter.
7985 * tui/tui-data.h (enum tui_box): New enum.
7986 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7987
f936bca2
TT
79882019-06-25 Tom Tromey <tom@tromey.com>
7989
7990 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7991 init_and_make_win for EXEC_INFO_WIN.
7992 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7993 longer inline.
7994 (struct tui_win_info) <~tui_win_info>: Inline.
7995 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7996 Don't declare.
7997 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7998 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7999 Remove.
8000 (tui_initialize_static_data): Update.
8001 (~tui_gen_win_info): Handle more cleanup here.
8002 (~tui_source_window_base): Delete "execution_info".
8003 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8004
d6ba6a11
TT
80052019-06-25 Tom Tromey <tom@tromey.com>
8006
8007 * tui/tui-layout.c (make_command_window): Don't set
8008 can_highlight.
8009 (show_source_disasm_command): Call the reset method.
8010 (show_data): Don't set can_highlight. Call the reset method.
8011 (tui_gen_win_info::reset): Rename from init_gen_win_info
8012 (init_and_make_win): Simplify. Return tui_gen_win_info.
8013 (show_source_or_disasm_and_command): Call the reset method.
8014 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8015 (struct tui_cmd_window): Set can_highlight.
8016
48a3bd16
TT
80172019-06-25 Tom Tromey <tom@tromey.com>
8018
8019 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8020 from make_visible.
8021 (tui_make_visible, tui_make_invisible): Rewrite.
8022 (tui_win_info::make_visible): Remove.
8023 (tui_source_window_base::make_visible): Update.
8024 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8025 method. Moved from...
8026 (struct tui_win_info) <make_visible>: ...here.
8027
c3bd716f
TT
80282019-06-25 Tom Tromey <tom@tromey.com>
8029
8030 * tui/tui-winsource.c
8031 (tui_source_window_base::do_scroll_horizontal): Remove direction
8032 parameter.
8033 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8034 direction parameter.
8035 * tui/tui-win.c (tui_win_info::forward_scroll)
8036 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8037 (tui_win_info::right_scroll): Update.
8038 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8039 direction parameter.
8040 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8041 direction parameter.
8042 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8043 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8044 Remove direction parameter.
8045 (struct tui_source_window_base, struct tui_source_window)
8046 (struct tui_disasm_window, struct tui_data_window)
8047 (struct tui_cmd_window): Update.
8048
21c32dca
TT
80492019-06-25 Tom Tromey <tom@tromey.com>
8050
8051 * tui/tui-winsource.h (tui_set_exec_info_content)
8052 (tui_show_exec_info_content, tui_erase_exec_info_content)
8053 (tui_clear_exec_info_content, tui_update_exec_info): Change
8054 argument to tui_source_window_base.
8055 * tui/tui-winsource.c (tui_set_exec_info_content)
8056 (tui_show_exec_info_content, tui_erase_exec_info_content)
8057 (tui_clear_exec_info_content, tui_update_exec_info): Change
8058 argument to tui_source_window_base.
8059
73fbdc65
TT
80602019-06-25 Tom Tromey <tom@tromey.com>
8061
8062 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8063 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8064
33325343
TT
80652019-06-25 Tom Tromey <tom@tromey.com>
8066
8067 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8068 check.
8069
29d2c474
TT
80702019-06-25 Tom Tromey <tom@tromey.com>
8071
8072 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8073 type to void.
8074 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8075 type to void.
8076 * tui/tui-source.c (tui_set_source_content): Update.
8077 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8078
152f3f4b
TT
80792019-06-25 Tom Tromey <tom@tromey.com>
8080
8081 * tui/tui-win.c (window_name_completer, tui_set_focus)
8082 (tui_all_windows_info): Use name method.
8083 * tui/tui-data.h (struct tui_gen_win_info)
8084 (struct tui_source_window, struct tui_disasm_window)
8085 (struct tui_data_window, struct tui_cmd_window) <name>: New
8086 method.
8087 (tui_win_name): Don't declare.
8088 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8089 (tui_win_name): Remove.
8090
be4da588
TT
80912019-06-25 Tom Tromey <tom@tromey.com>
8092
8093 * tui/tui-winsource.h (tui_update_source_window)
8094 (tui_update_source_window_as_is): Change parameter type.
8095 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8096 to be a tui_source_window_base.
8097 (tui_update_source_window_as_is): Likewise.
8098 * tui/tui-win.c (make_visible_with_new_height): Update.
8099
5b81daba
TT
81002019-06-25 Tom Tromey <tom@tromey.com>
8101
8102 * tui/tui-winsource.c (tui_erase_source_content)
8103 (tui_show_source_content, tui_show_exec_info_content)
8104 (tui_erase_exec_info_content): Use refresh_window method.
8105 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8106 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8107 from tui_refresh_win.
8108 (tui_data_window::refresh_window): New method.
8109 (tui_win_info::refresh, tui_source_window_base::refresh)
8110 (tui_refresh_all): Use refresh_window method.
8111 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8112 method.
8113 * tui/tui-regs.c (tui_display_register): Call refresh_window
8114 method.
8115 * tui/tui-layout.c (show_source_disasm_command)
8116 (show_source_or_disasm_and_command): Call refresh_window method.
8117 * tui/tui-data.h (struct tui_gen_win_info)
8118 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8119 New method.
8120
cb2ce893
TT
81212019-06-25 Tom Tromey <tom@tromey.com>
8122
8123 * tui/tui.c (tui_rl_other_window, tui_enable)
8124 (tui_is_window_visible, tui_get_command_dimension): Update.
8125 * tui/tui-winsource.c (tui_update_source_window_as_is)
8126 (tui_clear_source_content, tui_erase_source_content)
8127 (tui_show_source_line, tui_source_window_base::refill)
8128 (tui_source_window_base::do_scroll_horizontal)
8129 (tui_source_window_base::set_is_exec_point_at)
8130 (tui_update_breakpoint_info, tui_set_exec_info_content)
8131 (tui_alloc_source_buffer, tui_line_is_displayed)
8132 (tui_addr_is_displayed): Update.
8133 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8134 (tui_check_and_display_highlight_if_needed)
8135 (tui_win_info::make_visible, tui_win_info::refresh)
8136 (tui_refresh_all): Update.
8137 * tui/tui-windata.c (tui_first_data_item_displayed)
8138 (tui_delete_data_content_windows, tui_erase_data_content)
8139 (tui_display_all_data, tui_data_window::refresh_all)
8140 (tui_check_data_values): Update.
8141 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8142 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8143 (tui_win_info::backward_scroll, tui_refresh_all_win)
8144 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8145 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8146 (tui_source_window_base::set_new_height)
8147 (tui_data_window::set_new_height)
8148 (make_invisible_and_set_new_height)
8149 (make_visible_with_new_height, new_height_ok)
8150 (parse_scrolling_args): Update.
8151 * tui/tui-stack.c (tui_show_frame_info): Update.
8152 * tui/tui-source.c (tui_set_source_content)
8153 (tui_set_source_content_nil, tui_source_is_displayed)
8154 (tui_source_window::do_scroll_vertical): Update.
8155 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8156 (tui_display_registers_from, tui_display_reg_element_at_line)
8157 (tui_check_register_values, tui_reg_command): Update.
8158 * tui/tui-layout.c (tui_default_win_height)
8159 (show_source_disasm_command, show_data, init_and_make_win)
8160 (show_source_or_disasm_and_command): Update.
8161 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8162 (tui_redisplay_readline, tui_mld_flush)
8163 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8164 (tui_getc): Update.
8165 * tui/tui-disasm.c (tui_set_disassem_content)
8166 (tui_disasm_window::do_scroll_vertical): Update.
8167 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8168 Now virtual.
8169 (struct tui_win_info): Derive from tui_gen_win_info.
8170 <~tui_win_info>: Mark as override.
8171 <generic>: Remove member.
8172 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8173 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8174 (~tui_data_window, ~tui_win_info)
8175 (tui_free_all_source_wins_content): Update.
8176 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8177
ab313b35
TT
81782019-06-25 Tom Tromey <tom@tromey.com>
8179
8180 * tui/tui-layout.c (init_and_make_win): Use new.
8181 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8182 destructor, initializers.
8183 (tui_alloc_generic_win_info): Don't declare.
8184 * tui/tui-data.c (_locator): Add argument to constructor.
8185 (source_win, disasm_win): New globals.
8186 (exec_info): Remove.
8187 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8188 Update.
8189 (tui_alloc_generic_win_info): Remove.
8190 (init_content_element): Use new.
8191 (tui_win_info::tui_win_info): Update.
8192 (free_content_elements) <case DATA_WIN>: Use delete.
8193
dc2c33e4
TT
81942019-06-25 Tom Tromey <tom@tromey.com>
8195
8196 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8197 * tui/tui-windata.c (tui_first_data_item_displayed)
8198 (tui_delete_data_content_windows): Update.
8199 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8200 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8201 (tui_display_registers_from, tui_check_register_values): Update.
8202 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8203 pointer.
8204 * tui/tui-data.c (init_content_element): Update. Allocate the new
8205 window.
8206 (tui_free_data_content): Update.
8207 (free_content_elements) <case DATA_WIN>: Free the window.
8208
214a5cbe
TT
82092019-06-25 Tom Tromey <tom@tromey.com>
8210
8211 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8212 Update.
8213 * tui/tui-layout.c (make_command_window)
8214 (show_source_disasm_command, show_data, init_and_make_win)
8215 (show_source_or_disasm_and_command): Update.
8216 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8217 method.
8218 <can_highight, is_highlighted>: Now bool.
8219 (tui_set_win_highlight): Don't declare.
8220 * tui/tui-data.c (tui_set_win_highlight): Remove.
8221
8e2daf15
TT
82222019-06-25 Tom Tromey <tom@tromey.com>
8223
8224 * tui/tui-wingeneral.c (make_visible): Remove check of window
8225 type.
8226
8903bd8a
TT
82272019-06-25 Tom Tromey <tom@tromey.com>
8228
8229 * tui/tui-win.c (tui_win_info::max_height)
8230 (tui_cmd_window::max_height): New methods.
8231 (new_height_ok): Call max_height.
8232 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8233 <max_height>: New method.
8234
3f02ce1e
TT
82352019-06-25 Tom Tromey <tom@tromey.com>
8236
8237 * tui/tui-win.c (tui_source_window_base::set_new_height)
8238 (tui_data_window::set_new_height): New methods.
8239 (make_invisible_and_set_new_height): Call set_new_height method.
8240 * tui/tui-data.h (struct tui_win_info)
8241 (struct tui_source_window_base, struct tui_data_window)
8242 <set_new_height>: New method.
8243
1825f487
TT
82442019-06-25 Tom Tromey <tom@tromey.com>
8245
8246 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8247 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8248 tui_refresh_data_win.
8249 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8250 method.
8251 (tui_refresh_all_win): Call the refresh_all method.
8252 (tui_set_focus): Likewise.
8253 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8254 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8255 Likewise.
8256
ad54d15b
TT
82572019-06-25 Tom Tromey <tom@tromey.com>
8258
8259 * tui/tui-winsource.h (tui_refill_source_window)
8260 (tui_set_is_exec_point_at): Don't declare.
8261 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8262 (tui_source_window_base::refill): Rename from
8263 tui_refill_source_window.
8264 (tui_source_window_base::do_scroll_horizontal): Update.
8265 (tui_source_window_base::set_is_exec_point_at): Rename from
8266 tui_set_is_exec_point_at.
8267 (tui_update_all_breakpoint_info): Update.
8268 * tui/tui-stack.c (tui_show_frame_info): Update.
8269 * tui/tui-layout.c (show_data): Add cast.
8270 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8271 * tui/tui-data.h (struct tui_source_window_base) <refill,
8272 set_is_exec_point_at>: New methods.
8273 (tui_source_windows, tui_add_to_source_windows): Update types.
8274 (tui_add_to_source_windows): Remove redundant declaration.
8275 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8276 (tui_source_windows): Change return type.
8277 (tui_clear_source_windows_detail): Update.
8278 (tui_add_to_source_windows): Change type of parameter.
8279 (tui_free_all_source_wins_content): Update.
8280
2042b506
TT
82812019-06-25 Tom Tromey <tom@tromey.com>
8282
8283 * tui/tui-wingeneral.c (tui_win_info::refresh)
8284 (tui_source_window_base::refresh): New methods.
8285 (tui_refresh_all): Call the refresh method.
8286 * tui/tui-data.h (struct tui_win_info)
8287 (struct tui_source_window_base) <refresh>: New method.
8288
56122977
TT
82892019-06-25 Tom Tromey <tom@tromey.com>
8290
8291 * tui/tui.h (tui_is_window_visible): Return bool.
8292 * tui/tui.c (tui_is_window_visible): Return bool.
8293 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8294 (tui_make_visible, tui_make_invisible)
8295 (tui_win_info::make_visible)
8296 (tui_source_window_base::make_visible, make_all_visible)
8297 (tui_make_all_visible, tui_make_all_invisible): Update.
8298 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8299 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8300 bool.
8301 (struct tui_win_info, struct tui_source_window_base)
8302 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8303 * tui/tui-data.c (tui_init_generic_part): Update.
8304
cda37efb
TT
83052019-06-25 Tom Tromey <tom@tromey.com>
8306
8307 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8308 (tui_source_window_base::make_visible): New methods.
8309 (make_all_visible): Make method call.
8310 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8311 (struct tui_source_window_base, struct tui_cmd_window): Override
8312 make_visible.
8313 (tui_win_is_source_type): Don't declare.
8314 * tui/tui-data.c (tui_win_is_source_type): Remove.
8315
6a0ee02c
TT
83162019-06-25 Tom Tromey <tom@tromey.com>
8317
8318 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8319 NULL check.
8320
63901aec
TT
83212019-06-25 Tom Tromey <tom@tromey.com>
8322
8323 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8324 Inline constructor. Add initializers for members.
8325 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8326 constructors; now inline in class.
8327
ceb13a13
TT
83282019-06-25 Tom Tromey <tom@tromey.com>
8329
8330 * tui/tui-regs.c (tui_show_registers): Update.
8331 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8332 bool.
8333 * tui/tui-data.c (tui_data_window::clear_detail)
8334 (tui_data_window): Update.
8335
238eb706
TT
83362019-06-25 Tom Tromey <tom@tromey.com>
8337
8338 * tui/tui-windata.c (tui_display_all_data)
8339 (tui_display_data_from_line, tui_display_data_from)
8340 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8341 Update.
8342 * tui/tui-regs.c (tui_last_regs_line_no)
8343 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8344 (tui_show_registers, tui_show_register_group)
8345 (tui_display_registers_from, tui_display_reg_element_at_line)
8346 (tui_display_registers_from_line, tui_check_register_values)
8347 (tui_reg_next, tui_reg_prev): Update.
8348 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8349 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8350 tui_data_window.
8351 (struct tui_win_info) <detail>: Remove. Add new fields from
8352 tui_data_info.
8353 (TUI_DATA_WIN): Add cast.
8354 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8355 (~tui_data_window): Simplify.
8356
81491aa0
TT
83572019-06-25 Tom Tromey <tom@tromey.com>
8358
8359 * tui/tui-layout.c (show_source_disasm_command)
8360 (show_source_or_disasm_and_command): Update.
8361 * tui/tui-io.c (update_cmdwin_start_line)
8362 (tui_redisplay_readline): Update.
8363 * tui/tui-data.h (struct tui_command_info): Remove.
8364 (struct tui_win_info) <detail>: Remove command_info member.
8365 (struct tui_data_window) <start_line>: New member, from
8366 tui_command_info.
8367 (TUI_CMD_WIN): Add casts.
8368
e6e41501
TT
83692019-06-25 Tom Tromey <tom@tromey.com>
8370
8371 * tui/tui-winsource.c (tui_update_source_window)
8372 (tui_refill_source_window)
8373 (tui_source_window_base::do_scroll_horizontal)
8374 (tui_update_breakpoint_info, tui_set_exec_info_content)
8375 (tui_show_exec_info_content, tui_erase_exec_info_content)
8376 (tui_clear_exec_info_content): Update.
8377 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8378 Update.
8379 * tui/tui-win.c (make_invisible_and_set_new_height)
8380 (make_visible_with_new_height): Update.
8381 * tui/tui-source.c (tui_set_source_content)
8382 (tui_show_symtab_source): Update.
8383 * tui/tui-layout.c (extract_display_start_addr)
8384 (show_source_disasm_command, show_data)
8385 (make_source_or_disasm_window)
8386 (show_source_or_disasm_and_command): Update.
8387 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8388 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8389 "gdbarch".
8390 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8391 to tui_source_window_base.
8392 (struct tui_win_info) <detail>: Remove source_info member.
8393 (struct tui_source_window_base) <has_locator>: Inline.
8394 Move contents from tui_source_info; rename has_locator member to
8395 m_has_locator.
8396 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8397 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8398 header file.
8399 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8400 Simplify.
8401 (tui_free_all_source_wins_content): Cast to
8402 tui_source_window_base.
8403
44f0e208
TT
84042019-06-25 Tom Tromey <tom@tromey.com>
8405
8406 * tui/tui-win.c (make_invisible_and_set_new_height)
8407 (make_visible_with_new_height): Call has_locator method.
8408 * tui/tui-layout.c (show_source_disasm_command, show_data)
8409 (show_source_or_disasm_and_command): Update for bool change.
8410 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8411 (tui_win_info) <has_locator>: New method.
8412 (struct tui_source_window_base) <has_locator>: New method.
8413 (tui_win_has_locator): Don't declare.
8414 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8415 from tui_win_has_locator.
8416 (tui_source_window_base): Use false, not FALSE.
8417
7778b912
TT
84182019-06-25 Tom Tromey <tom@tromey.com>
8419
8420 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8421 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8422 clear_detail method directly.
8423 (tui_clear_win_detail): Remove.
8424
f83d391c
TT
84252019-06-25 Tom Tromey <tom@tromey.com>
8426
8427 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8428 "this", not TUI_DISASM_WIN.
8429
13446e05
TT
84302019-06-25 Tom Tromey <tom@tromey.com>
8431
8432 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8433 declare.
8434 * tui/tui-winsource.c
8435 (tui_source_window_base::do_scroll_horizontal): Rename from
8436 tui_horizontal_source_scroll.
8437 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8438 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8439 from tui_vertical_data_scroll.
8440 * tui/tui-win.h (tui_scroll): Don't declare.
8441 * tui/tui-win.c (tui_win_info::forward_scroll)
8442 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8443 (tui_win_info::right_scroll): Rename and update.
8444 (tui_scroll_forward_command, tui_scroll_backward_command)
8445 (tui_scroll_left_command, tui_scroll_right_command): Update.
8446 (tui_scroll): Remove.
8447 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8448 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8449 from tui_vertical_source_scroll.
8450 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8451 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8452 from tui_vertical_disassem_scroll.
8453 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8454 do_scroll_horizontal>: New methods.
8455 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8456 Likewise.
8457 (struct tui_source_window_base): Add do_scroll_horizontal.
8458 (struct tui_source_window, struct tui_disasm_window): Add
8459 do_scroll_vertical.
8460 (struct tui_data_window, struct tui_cmd_window): Add
8461 do_scroll_horizontal and do_scroll_vertical.
8462 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8463
5cf82909
TT
84642019-06-25 Tom Tromey <tom@tromey.com>
8465
8466 * tui/tui-data.h (struct tui_source_window_base): New struct.
8467 (struct tui_source_window): Derive from tui_source_window_base.
8468 (struct tui_disasm_window): New struct.
8469 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8470 from tui_source_window::clear_detail.
8471 (tui_source_window_base): Rename from tui_source_window.
8472 (~tui_source_window_base): Rename from ~tui_source_window.
8473 (tui_alloc_win_info): Create a tui_disasm_window.
8474
ee1d42d6
TT
84752019-06-25 Tom Tromey <tom@tromey.com>
8476
8477 * tui/tui-data.h (struct tui_source_window)
8478 (struct tui_data_window): Declare destructors.
8479 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8480 destructors.
8481 (tui_win_info): Simplify.
8482
b4eb2452
TT
84832019-06-25 Tom Tromey <tom@tromey.com>
8484
8485 * tui/tui-winsource.c (tui_display_main)
8486 (tui_update_source_windows_with_addr)
8487 (tui_update_all_breakpoint_info): Update.
8488 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8489 (new_height_ok, parse_scrolling_args): Update.
8490 * tui/tui-stack.c (tui_show_frame_info): Update.
8491 * tui/tui-data.h (struct tui_list): Remove.
8492 (tui_source_windows): Return a reference to a std::vector.
8493 * tui/tui-data.c (source_windows): Now a std::vector.
8494 (tui_source_windows): Change return type.
8495 (tui_clear_source_windows): Rewrite.
8496 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8497 (tui_free_all_source_wins_content): Rewrite.
8498
8761a91b
TT
84992019-06-25 Tom Tromey <tom@tromey.com>
8500
8501 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8502 (struct tui_data_window, struct tui_cmd_window): Declare
8503 clear_detail method.
8504 * tui/tui-data.c (tui_source_window::clear_detail)
8505 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8506 methods.
8507 (tui_clear_win_detail): Simplify.
8508
0ed69eda
TT
85092019-06-25 Tom Tromey <tom@tromey.com>
8510
8511 * tui/tui-layout.c (make_source_window, make_disasm_window)
8512 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8513 Return the new window.
8514 (show_source_disasm_command, show_data)
8515 (show_source_or_disasm_and_command): Update.
8516
82432e10
TT
85172019-06-25 Tom Tromey <tom@tromey.com>
8518
8519 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8520 parameter. Return the new window.
8521 (show_source_disasm_command): Update and remove NULL check.
8522 (show_source_or_disasm_and_command): Update.
8523
ec328aa5
TT
85242019-06-25 Tom Tromey <tom@tromey.com>
8525
8526 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8527
33b906ab
TT
85282019-06-25 Tom Tromey <tom@tromey.com>
8529
8530 * tui/tui-data.h (struct tui_win_info): Make constructor
8531 protected. Make destructor virtual. Add initializers.
8532 (tui_source_window, tui_data_window, tui_cmd_window): New
8533 classes.
8534 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8535 constructor. Add "type" parameter.
8536 (tui_source_window, tui_data_window, tui_cmd_window): New
8537 constructors.
8538 (tui_alloc_win_info): Instantiate the appropriate subclass.
8539
e7e11af4
TT
85402019-06-25 Tom Tromey <tom@tromey.com>
8541
8542 * tui/tui-win.c (tui_resize_all): Use delete.
8543 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8544 destructor.
8545 (tui_free_window): Don't declare.
8546 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8547 Update.
8548
6792b55e
TT
85492019-06-25 Tom Tromey <tom@tromey.com>
8550
8551 * tui/tui-data.h (struct tui_win_info): Add constructor.
8552 * tui/tui-data.c (tui_alloc_win_info): Use new.
8553 (tui_free_window): Use delete.
8554
f95675e1
TT
85552019-06-22 Tom Tromey <tom@tromey.com>
8556
8557 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8558 declare.
8559 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8560
5bff081c
TT
85612019-06-22 Tom Tromey <tom@tromey.com>
8562
8563 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8564 declare.
8565 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8566
47e3f474
TV
85672019-06-22 Tom de Vries <tdevries@suse.de>
8568
8569 * dwarf2read.c (create_addrmap_from_aranges)
8570 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8571 instead of '%zu'.
8572
fd5866f6
SM
85732019-06-21 Simon Marchi <simon.marchi@efficios.com>
8574
8575 * dwarf2read.h (dwarf2_section_info_def): Remove.
8576 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8577 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8578 std::vector<dwarf2_section_info>.
8579 (struct dwo_file) <~dwo_file>: Remove.
8580 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8581 types field.
8582 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8583 (dwarf2_read_debug_names): Likewise.
8584 (create_debug_types_hash_table): Change parameter type to
8585 array_view, adjust code accordingly.
8586 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8587 (partial_die_info::fixup): Likewise.
8588 (determine_prefix): Likewise.
8589 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8590
fb1eb2f9
SM
85912019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8592
8593 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8594 gdb_bfd_ref_ptr.
8595 <~dwo_file>: Remove call to gdb_bfd_unref.
8596 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8597 gdb_bfd_ref_ptr::get.
8598
51ac9db5
SM
85992019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8600
8601 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8602 type to htab_up.
8603 * dwarf2read.c (struct dwo_file): Initialize fields.
8604 <~dwo_file>: New.
8605 (free_dwo_file): Remove, move content to ~dwo_file.
8606 (struct dwo_file_deleter): Remove.
8607 (dwo_file_up>: Remove custom deleter.
8608 (free_dwo_files): Remove.
8609 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8610 dwo_files.
8611 (process_skeletonless_type_units): Call unique_ptr::get.
8612 (allocate_dwo_file_hash_table): Add deleter to created hash
8613 table. Change return type to htab_up.
8614 (lookup_dwo_file_slot): Don't memset dwo_file, call
8615 unique_ptr::get.
8616 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8617 (create_dwo_unit_in_dwp_v2): Likewise.
8618 (open_and_init_dwo_file): Likewise.
8619 (free_dwo_file_from_slot): Remove.
8620
dc4ccb6f
SM
86212019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8622
8623 * dwarf2read.h (struct dwarf2_section_info) <readin,
8624 is_virtual>: Change type to bool.
8625 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8626 true instead of 1.
8627
e6a1c5cb
TT
86282019-06-19 Tom Tromey <tom@tromey.com>
8629
8630 * tui/tui-data.h (tui_init_content_element): Don't declare.
8631
6f6ffbeb
TT
86322019-06-19 Tom Tromey <tom@tromey.com>
8633
8634 * tui/tui-data.h (tui_init_win_info): Don't declare.
8635
f23f598e
TV
86362019-06-19 Tom de Vries <tdevries@suse.de>
8637
8638 * dwarf2read.h (abstract_to_concrete): Change type to
8639 std::unordered_map<sect_offset, std::vector<sect_offset>,
8640 gdb::hash_enum<sect_offset>>.
8641
680e1bee
TT
86422019-06-19 Tom Tromey <tromey@adacore.com>
8643
8644 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8645 EVAL_AVOID_SIDE_EFFECTS specially.
8646
dcf37923
TT
86472019-06-19 Tom Tromey <tromey@adacore.com>
8648
8649 * source-cache.c (highlighter): New global.
8650 (source_cache::get_source_lines): Create a highlighter on demand.
8651
494986d5
AB
86522019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8653
8654 * defs.h (deprecated_interactive_hook): Delete declaration.
8655 * interps.c (clear_interpreter_hooks): Remove use of
8656 deprecated_interactive_hook.
8657 * top.c (deprecated_interactive_hook): Delete definition.
8658 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8659
3360b6e7
TV
86602019-06-18 Tom de Vries <tdevries@suse.de>
8661
8662 PR gdb/24515
8663 * dwarf2read.h (abstract_to_concrete): Change type from
8664 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8665 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8666 * dwarf2read.c (read_variable): Update.
8667 (dwarf2_fetch_die_loc_sect_off): Update.
8668
310b3441
TV
86692019-06-17 Tom de Vries <tdevries@suse.de>
8670
8671 PR gdb/24617
8672 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8673 accessing parent[parent_len - 1].
8674
ba9777be
PP
86752019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8676
8677 PR gdb/24364
8678 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8679 call dtrace_process_dof with NULL dof.
8680
2b9f6e89
TV
86812019-06-16 Tom de Vries <tdevries@suse.de>
8682
8683 PR gdb/24445
8684 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8685
431b3ead
TT
86862019-06-16 Tom Tromey <tom@tromey.com>
8687
8688 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8689 (make_all_visible): Use address of member.
8690
d04b44a1
TT
86912019-06-16 Tom Tromey <tom@tromey.com>
8692
8693 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8694 (tui_free_window, free_content, free_content_elements): Remove
8695 unnecessary cast.
8696 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8697 cast.
8698 * tui/tui-regs.c (tui_show_register_group)
8699 (tui_display_registers_from, tui_display_reg_element_at_line):
8700 Remove unnecessary cast.
8701
bf5142e7
AB
87022019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8703
8704 * linux-nat.c (normal_mask): Delete.
8705 (_initialize_linux_nat): Don't initialise normal_mask.
8706
c4973306
SM
87072019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8708
8709 PR gdb/24445
8710 * dwarf-index-write.h (write_psymtabs_to_index): Add
8711 dwz_basename parameter.
8712 * dwarf-index-write.c (write_gdbindex): Move file writing to
8713 write_gdbindex_1. Change return type void.
8714 (assert_file_size): Move up, remove filename parameter.
8715 (write_gdbindex_1): New function.
8716 (write_debug_names): Change return type to void, call
8717 assert_file_size.
8718 (struct index_wip_file): New struct.
8719 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8720 file logic to index_wip_file. Write index for dwz file if
8721 needed.
8722 (save_gdb_index_command): Pass basename of dwz file, if present.
8723 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8724 build-id of dwz file, if present.
8725 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8726 (dwarf2_get_dwz_file): Likewise.
8727 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8728 (dwarf2_get_dwz_file): Likewise.
8729
395f9c91
TT
87302019-06-16 Tom Tromey <tom@tromey.com>
8731
8732 * coffread.c (process_coff_symbol): Use xstrdup.
8733 * value.c (create_internalvar): Use xstrdup.
8734
cafb3438
TT
87352019-06-16 Tom Tromey <tom@tromey.com>
8736
8737 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8738 * breakpoint.c (stopin_command, stopat_command)
8739 (until_break_command, decode_location_default): Remove unnecessary
8740 cast.
8741 * utils.c (subset_compare): Remove unnecessary cast.
8742 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8743 cast.
8744 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8745 cast.
8746 * infcmd.c (path_command): Remove unnecessary cast.
8747 * coffread.c (decode_type): Remove unnecessary cast.
8748 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8749 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8750 * tui/tui-stack.c (tui_show_locator_content)
8751 (tui_show_frame_info): Remove unnecessary cast.
8752 * tui/tui-win.c (tui_scroll_forward_command)
8753 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8754 (parse_scrolling_args): Remove unnecessary cast.
8755 * tui/tui-data.c (init_win_info, tui_del_window)
8756 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8757 (free_content_elements): Remove unnecessary cast.
8758 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8759 unnecessary cast.
8760 * tui/tui-source.c (tui_set_source_content)
8761 (tui_vertical_source_scroll): Remove unnecessary cast.
8762 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8763 cast.
8764 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8765 * tui/tui-regs.c (tui_display_registers_from)
8766 (tui_display_register): Remove unnecessary cast.
8767 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8768 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8769 (make_visible): Remove unnecessary cast.
8770 * tui/tui-winsource.c (tui_erase_source_content)
8771 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8772 unnecessary cast.
8773 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8774 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8775 * stabsread.c (read_type, read_array_type, read_range_type):
8776 Remove unnecessary cast.
8777 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8778 (parse_symbol, parse_type, upgrade_type, parse_external)
8779 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8780 unnecessary cast.
8781 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8782
730ead81
TT
87832019-06-16 Tom Tromey <tom@tromey.com>
8784
8785 * tui/tui-data.c (tui_alloc_generic_win_info)
8786 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8787 checks.
8788
584a927c
AB
87892019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8790 Andrew Burgess <andrew.burgess@embecosm.com>
8791
8792 * f-typeprint.c (f_print_type): Don't return early for not
8793 associated or not allocated types.
8794 (f_type_print_varspec_suffix): Add print_rank parameter and print
8795 ranks of array types in case they dangling.
8796 (f_type_print_base): Add print_rank parameter.
8797
30056ea0
AB
87982019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8799
8800 * NEWS: Mention new MI commands.
8801 * break-catch-throw.c (enum exception_event_kind): Move to
8802 breakpoint.h.
8803 (print_mention_exception_catchpoint): Output text as a single
8804 message.
8805 (catch_exception_command_1): Rename to...
8806 (catch_exception_event): ...this, make non-static, update header
8807 command, and change some parameter types.
8808 (catch_catch_command): Update for changes to
8809 catch_exception_command_1.
8810 (catch_throw_command): Likewise.
8811 (catch_rethrow_command): Likewise.
8812 * breakpoint.c (enum exception_event_kind): Delete.
8813 * breakpoint.h (enum exception_event_kind): Moved here from
8814 break-catch-throw.c.
8815 (catch_exception_event): Declare.
8816 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8817 (mi_cmd_catch_throw): New function.
8818 (mi_cmd_catch_rethrow): New function.
8819 (mi_cmd_catch_catch): New function.
8820 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8821 'catch-catch' entries.
8822 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8823 (mi_cmd_catch_rethrow): Declare.
8824 (mi_cmd_catch_catch): Declare.
8825
ec8e2b6d
AB
88262019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8827
8828 * annotate.c (annotate_source_line): Change return type to void,
8829 update implementation to match.
8830 * annotate.h (annotate_source_line): Change return type to void,
8831 update header comment.
8832 * stack.c (print_frame_info): Don't change what frame information
8833 is printed based on whether annotations are on or not.
8834
0d3abd8c
AB
88352019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8836
8837 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8838 (annotate_source): Make static.
8839 (annotate_source_line): Moved from source.c and renamed from
8840 identify_source_line. Update the return type.
8841 * annotate.h (annotate_source): Delete declaration.
8842 (annotate_source_line): Declaration moved from source.h, and
8843 renamed from identify_source_line. Return type updated.
8844 * source.c (identify_source_line): Moved to annotate.c and renamed
8845 to annotate_source_line.
8846 (info_line_command): Remove check of annotation_level.
8847 * source.h (identify_source_line): Move declaration to annotate.h
8848 and rename to annotate_source_line.
8849 * stack.c: Add 'annotate.h' include.
8850 (print_frame_info): Remove check of annotation_level before
8851 calling annotate_source_line.
8852
00df30ae
AB
88532019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8854
8855 * source-cache.c (source_cache::get_plain_source_lines): Use
8856 open_source_file_with_line_charpos instead of just
8857 open_source_file, remove call to find_source_lines.
8858 (source_cache::get_source_lines): Likewise.
8859 * source.c (find_source_lines): Make static.
8860 (get_filename_and_charpos): Renamed into...
8861 (open_source_file_with_line_charpos): ..this along with changes to
8862 return a scoped_fd, and some other minor clean ups.
8863 (identify_source_line): Use open_source_file_with_line_charpos.
8864 (search_command_helper): Use open_source_file_with_line_charpos
8865 instead of just open_source_file, remove call to
8866 find_source_lines.
8867 * source.h (open_source_file_with_line_charpos): Declare new
8868 function.
8869 (find_source_lines): Delete declaration.
8870
afda45a2
AB
88712019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8872
8873 * source.c (get_filename_and_charpos): Remove fullname
8874 parameter.
8875 (identify_source_line): Update call to get_filename_and_charpos.
8876
0735b091
TT
88772019-06-14 Tom Tromey <tromey@adacore.com>
8878
8879 PR gdb/24502:
8880 * ui-style.h (skip_ansi_escape): Update comment.
8881 * ui-file.h (class no_terminal_escape_file): New class.
8882 * ui-file.c (no_terminal_escape_file::write)
8883 (no_terminal_escape_file::puts): New methods.
8884 * cli/cli-logging.c (handle_redirections): Use
8885 no_terminal_escape_file.
8886
52ce35e2
TT
88872019-06-14 Tom Tromey <tromey@adacore.com>
8888
8889 * NEWS: Move convenience variable news above Python news.
8890
73cc7272
TT
88912019-06-14 Tom Tromey <tom@tromey.com>
8892
8893 * gnulib: Move directory to top-level.
8894 * configure.ac: Don't configure gnulib.
8895 * configure: Rebuild.
8896 * common/common-defs.h: Use new path to gnulib.
8897 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8898 (GNULIB_H): Remove.
8899 (INCGNU): Look in new gnulib location.
8900 (HFILES_NO_SRCDIR): Remove gnulib files.
8901 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8902 (generated_files): Remove GNULIB_H.
8903 ($(LIBGNU), all-lib): Remove targets.
8904 (distclean): Don't mention GNULIB_BUILDDIR.
8905 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8906
f5686554
TT
89072019-06-14 Tom Tromey <tromey@adacore.com>
8908
8909 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8910 Warn if symbol file does not provide any symbols.
8911
a0c1ffed
TT
89122019-06-14 Tom Tromey <tromey@adacore.com>
8913
8914 * source.c (find_and_open_source): Respect basenames_may_differ.
8915
7c39e397
AB
89162019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8917
8918 * annotate.c (annotate_breakpoints_invalid): Make use of
8919 scoped_restore_terminal_state.
8920 (annotate_frames_invalid): Likewise.
8921
f411722c
TT
89222019-06-14 Tom Tromey <tromey@adacore.com>
8923
8924 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8925 allow assignment to an internalvar.
8926
4268ec18
TT
89272019-06-14 Tom Tromey <tromey@adacore.com>
8928
8929 * ada-lex.l: Allow "_" in attribute names.
8930
abdb711e
TT
89312019-06-14 Tom Tromey <tromey@adacore.com>
8932
8933 PR gdb/24653:
8934 * regcache.c (registers_changed): Don't call alloca.
8935 * top.c (execute_command): Don't call alloca.
8936
4c048731
PA
89372019-06-13 Pedro Alves <palves@redhat.com>
8938
8939 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8940 'expression'. When parsing an expression, error out if there's
8941 junk after "unlimited".
8942 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8943 (do_set_command): Adjust calls to is_unlimited_literal.
8944
66eb1ed3
PA
89452019-06-13 Pedro Alves <palves@redhat.com>
8946
8947 * compile/compile.c (make_compile_options_def_group): Add braces
8948 around array_view initializer.
8949 * thread.c (make_thread_apply_all_options_def_group)
8950 (make_thread_apply_all_options_def_group): Likewise.
8951
3345721a
PA
89522019-06-13 Pedro Alves <palves@redhat.com>
8953
8954 * NEWS (New commands): Mention "maint test-options
8955 require-delimiter", "maint test-options unknown-is-error", "maint
8956 test-options unknown-is-operand" and "maint show
8957 test-options-completion-result".
8958 (New command options, command completion): New section.
8959 (Completion improvements): New section.
8960 Mention that you can abbreviate "unlimited".
8961
6206060d
PA
89622019-06-13 Pedro Alves <palves@redhat.com>
8963
8964 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8965 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8966 * unittests/cli-utils-selftests.c (test_parse_flags)
8967 (test_parse_flags_qcs): Delete.
8968 (test_cli_utils): Don't call deleted functions.
8969
6665660a
PA
89702019-06-13 Pedro Alves <palves@redhat.com>
8971
8972 * thread.c: Include "cli/cli-option.h".
8973 (tp_array_compar_ascending): Global.
8974 (tp_array_compar): Delete function.
8975 (tp_array_compar_ascending, tp_array_compar_descending): New
8976 functions.
8977 (ascending_option_def, qcs_flag_option_def)
8978 (thr_qcs_flags_option_defs)
8979 (make_thread_apply_all_options_def_group)
8980 (make_thread_apply_options_def_group): New.
8981 (thread_apply_all_command): Use gdb::option::process_options.
8982 (thread_apply_command_completer)
8983 (thread_apply_all_command_completer): New.
8984 (thread_apply_command): Use gdb::option::process_options.
8985 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8986 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8987 to generate help text of "thread apply". Adjust "taas"'s help.
8988 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8989 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8990
f7e13587
PA
89912019-06-13 Pedro Alves <palves@redhat.com>
8992
8993 * thread.c (thread_apply_command): Check for invalid TID with
8994 isdigit instead of !isalpha.
8995
5d707134
PA
89962019-06-13 Pedro Alves <palves@redhat.com>
8997
8998 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8999 (validate_flags_qcs): New.
9000 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9001 (validate_flags_qcs): Declare.
9002 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9003 (make_frame_apply_options_def_group): New.
9004 (frame_apply_command_count): Process options with
9005 gdb::option::process_options.
9006 (frame_apply_completer): New.
9007 (frame_apply_level_completer, frame_apply_all_completer)
9008 (frame_apply_completer): New.
9009 (_initialize_stack): Update help of "frame apply", "frame apply
9010 level", "frame apply all" and "faas" to mention supported options
9011 and install command completers.
9012 * stack.h (frame_apply_all_completer): Declare.
9013 * thread.c: Include "stack.h".
9014 (tfaas_command): Add "--".
9015 (_initialize_thread): Update help "tfaas" to mention supported
9016 options and install command completer.
9017
272d4594
PA
90182019-06-13 Pedro Alves <palves@redhat.com>
9019
9020 * completer.c (complete_nested_command_line): New.
9021 (gdb_completion_word_break_characters_throw): Add assertion.
9022 * completer.h (complete_nested_command_line): Declare.
9023
90a1ef87
PA
90242019-06-13 Pedro Alves <palves@redhat.com>
9025
9026 * stack.c (parse_backtrace_qualifiers): New.
9027 (backtrace_command): Use it.
9028 (backtrace_command_completer): Complete on qualifiers.
9029
d4c16835
PA
90302019-06-13 Pedro Alves <palves@redhat.com>
9031
9032 * frame.c: Include "cli/cli-option.h.
9033 (user_set_backtrace_options): New.
9034 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9035 Delete.
9036 (get_prev_frame): Adjust.
9037 (boolean_option_def, uinteger_option_def)
9038 (set_backtrace_option_defs): New.
9039 (_initialize_frame): Adjust and use
9040 gdb::option::add_setshow_cmds_for_options to install "set
9041 backtrace past-main" and "set backtrace past-entry".
9042 * frame.h: Include "cli/cli-option.h".
9043 (struct frame_print_options): Forward declare.
9044 (print_frame_arguments_all, print_frame_arguments_scalars)
9045 (print_frame_arguments_none): Declare.
9046 (print_entry_values): Delete declaration.
9047 (struct frame_print_options, user_frame_print_options): New.
9048 (struct set_backtrace_options): New.
9049 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9050 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9051 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9052 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9053 (list_args_or_locals): Add frame_print_options parameter.
9054 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9055 * python/py-framefilter.c (enumerate_args): Pass down
9056 USER_FRAME_PRINT_OPTIONS.
9057 * stack.c: Include "cli/cli-option.h".
9058 (print_frame_arguments_all, print_frame_arguments_scalars)
9059 (print_frame_arguments_none): Declare.
9060 (print_raw_frame_arguments, print_entry_values): Delete.
9061 (user_frame_print_options): New.
9062 (boolean_option_def, enum_option_def, frame_print_option_defs):
9063 New.
9064 (struct backtrace_cmd_options): New.
9065 (bt_flag_option_def): New.
9066 (backtrace_command_option_defs): New.
9067 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9068 (print_frame_arg, read_frame_arg, print_frame_args)
9069 (print_frame_info, print_frame): Add frame_print_options parameter
9070 and use it.
9071 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9072 (backtrace_command_1): Add frame_print_options and
9073 backtrace_cmd_options parameters and use them.
9074 (make_backtrace_options_def_group): New.
9075 (backtrace_command): Process command options with
9076 gdb::option::process_options.
9077 (backtrace_command_completer): New.
9078 (_initialize_stack): Extend "backtrace"'s help to mention
9079 supported options. Install completer for "backtrace".
9080 Install some settings commands with add_setshow_cmds_for_options.
9081
2daf894e
PA
90822019-06-13 Pedro Alves <palves@redhat.com>
9083
9084 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9085 and that "set/show print raw frame-arguments" are now deprecated.
9086
9087 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9088 command.
9089 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9090 * stack.c (_initialize_stack): Install "set/show print
9091 raw-frame-arguments", and deprecate "set/show print raw
9092 frame-arguments".
9093 * valprint.c (_initialize_valprint): Deprecate "set/show print
9094 raw".
9095
e6ed716c
PA
90962019-06-13 Pedro Alves <palves@redhat.com>
9097
9098 * compile/compile.c (struct compile_options): New.
9099 (compile_flag_option_def, compile_command_option_defs)
9100 (make_compile_options_def_group): New.
9101 (compile_file_command): Handle options with
9102 gdb::option::process_options.
9103 (compile_file_command_completer): New function.
9104 (compile_code_command): Handle options with
9105 gdb::option::process_options.
9106 (compile_code_command_completer): New function.
9107 (_initialize_compiler): Install completers for "compile code" and
9108 "compile file". Mention available options in "compile code" and
9109 "compile code"'s help.
9110 * completer.c (advance_to_completion_word): New, factored out from
9111 ...
9112 (advance_to_expression_complete_word_point): ... this.
9113 (advance_to_filename_complete_word_point): New.
9114 * completer.h (advance_to_filename_complete_word_point): New
9115 declaration.
9116
7d8062de
PA
91172019-06-13 Pedro Alves <palves@redhat.com>
9118
9119 * compile/compile.c: Include "cli/cli-option.h".
9120 (compile_print_value): Scope data pointer is now a
9121 value_print_options pointer; adjust.
9122 (compile_print_command): Process options. Scope data pointer is
9123 now a value_print_options pointer; adjust.
9124 (_initialize_compile): Update "compile print"'s help to include
9125 supported options. Install a completer for "compile print".
9126 * cp-valprint.c (show_vtblprint, show_objectprint)
9127 (show_static_field_print): Delete.
9128 (_initialize_cp_valprint): Don't install "set print
9129 static-members", "set print vtbl", "set print object" here.
9130 * printcmd.c: Include "cli/cli-option.h" and
9131 "common/gdb_optional.h".
9132 (print_command_parse_format): Rework to fill in a
9133 value_print_options instead of a format_data.
9134 (print_value): Change parameter type from format_data pointer to
9135 value_print_options reference. Adjust.
9136 (print_command_1): Process options. Adjust to pass down a
9137 value_print_options.
9138 (print_command_completer): New.
9139 (_initialize_printcmd): Install print_command_completer as
9140 handle_brkchars completer for the "print" command. Update
9141 "print"'s help to include supported options.
9142 * valprint.c: Include "cli/cli-option.h".
9143 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9144 here from cp-valprint.c.
9145 (boolean_option_def, uinteger_option_def)
9146 (value_print_option_defs, make_value_print_options_def_group):
9147 New. Use gdb::option::add_setshow_cmds_for_options to install
9148 "set print elements", "set print null-stop", "set print repeats",
9149 "set print pretty", "set print union", "set print array", "set
9150 print address", "set print symbol", "set print array-indexes".
9151 * valprint.h: Include <string> and "cli/cli-option.h".
9152 (make_value_print_options_def_group): Declare.
9153 (print_value): Change parameter type from format_data pointer to
9154 value_print_options reference.
9155 (print_command_completer): Declare.
9156
9d0faba9
PA
91572019-06-13 Pedro Alves <palves@redhat.com>
9158
9159 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9160 (COMMON_SFILES): Add maint-test-settings.c.
9161 * cli/cli-decode.c (boolean_enums): New global, factored out from
9162 ...
9163 (add_setshow_boolean_cmd): ... here.
9164 * cli/cli-decode.h (boolean_enums): Declare.
9165 * cli/cli-option.c: New file.
9166 * cli/cli-option.h: New file.
9167 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9168 factored out from ...
9169 (parse_cli_boolean_value(const char *)): ... this.
9170 (is_unlimited_literal): Change parameter type to pointer to
9171 pointer. Adjust and advance ARG pointer.
9172 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9173 (parse_cli_var_enum): New, factored out from ...
9174 (do_set_command): ... this. Adjust.
9175 * cli/cli-setshow.h (parse_cli_boolean_value)
9176 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9177 (parse_cli_var_enum): Declare.
9178 * cli/cli-utils.c: Include "cli/cli-option.h".
9179 (get_ulongest): New.
9180 * cli/cli-utils.h (get_ulongest): Declare.
9181 (check_for_argument): New overloads.
9182 * maint-test-options.c: New file.
9183
2c722807
PA
91842019-06-13 Pedro Alves <palves@redhat.com>
9185
9186 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9187 parse a range if "-" is at the end of the string.
9188
dee7b4c8
PA
91892019-06-13 Pedro Alves <palves@redhat.com>
9190
9191 * cli/cli-setshow.c (parse_auto_binary_operation)
9192 (parse_cli_boolean_value): Don't allow "o".
9193
dca0f6c0
PA
91942019-06-13 Pedro Alves <palves@redhat.com>
9195
9196 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9197 * NEWS: Mention maint test-settings KIND.
9198 * maint-test-settings.c: New file.
9199
597bf39d
PA
92002019-06-13 Pedro Alves <palves@redhat.com>
9201
9202 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9203 completer.
9204 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9205 "set" completers.
9206
48c410fb
PA
92072019-06-13 Pedro Alves <palves@redhat.com>
9208
9209 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9210 after item.
9211
93bcb043
PA
92122019-06-13 Pedro Alves <palves@redhat.com>
9213
9214 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9215
cbba3ecd
PA
92162019-06-13 Pedro Alves <palves@redhat.com>
9217
9218 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9219 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9220 call.
9221 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9222 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9223 calls.
9224 (check_for_argument): Skip spaces after argument.
9225
b9a3f842
PA
92262019-06-13 Pedro Alves <palves@redhat.com>
9227
9228 * thread.c (thread_apply_command): Adjust TID parsing.
9229 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9230 detected before end of string.
9231 (tid_is_in_list): Error out if LIST is invalid.
9232
3844e605
PA
92332019-06-13 Pedro Alves <palves@redhat.com>
9234
9235 * completer.c (complete_line_internal_1): Rewind completion word
9236 point.
9237 (completion_tracker::advance_custom_word_point_by): Change
9238 parameter type to int.
9239 * completer.h (completion_tracker::advance_custom_word_point_by):
9240 Likewise.
9241
00b56dbe
PA
92422019-06-13 Pedro Alves <palves@redhat.com>
9243
9244 * completer.c (advance_to_completion_word): Handle delimiters.
9245
d106773e
PA
92462019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9247
9248 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9249
08f10e02
TT
92502019-06-11 Tom Tromey <tom@tromey.com>
9251
9252 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9253 (xmalloc_failed): Move to alloc.c.
9254 * alloc.c: New file.
9255 * Makefile.in (COMMON_SFILES): Add alloc.c.
9256
1c7fe951
TT
92572019-06-11 Tom Tromey <tom@tromey.com>
9258
9259 * nat/linux-waitpid.c: Don't include server.h.
9260 (linux_debug): Remove.
9261 (my_waitpid): Update.
9262
89549d7f
TT
92632019-06-11 Tom Tromey <tromey@adacore.com>
9264
9265 * infcall.c (_initialize_infcall): Remove trailing newline from
9266 help.
9267 * user-regs.c (_initialize_user_regs): Remove trailing newline
9268 from help.
9269 * typeprint.c (_initialize_typeprint): Remove trailing newline
9270 from help.
9271 * reverse.c (_initialize_reverse): Remove trailing newlines from
9272 help.
9273 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9274 from help.
9275 * language.c (add_set_language_command): Remove trailing newline
9276 from help.
9277 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9278 help.
9279 * disasm.c (_initialize_disasm): Remove trailing newline from
9280 help.
9281 * top.c (init_main): Remove trailing newline from help.
9282 * interps.c (_initialize_interpreter): Remove trailing newline
9283 from help.
9284 * btrace.c (_initialize_btrace): Remove trailing newlines from
9285 help.
9286 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9287 from help.
9288 * python/python.c (_initialize_python): Remove trailing newline
9289 from help.
9290 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9291 help.
9292 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9293 from help. Reformat some text.
9294 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9295 from help.
9296 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9297 newline from help.
9298
86108c13
TT
92992019-06-11 Tom Tromey <tromey@adacore.com>
9300
9301 * darwin-nat.c (darwin_decode_exception_message)
9302 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9303
a7067863
AB
93042019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9305
9306 * valops.c (value_slice): Check for not allocated or not
9307 associated values.
9308
9ab08412
TV
93092019-06-10 Tom de Vries <tdevries@suse.de>
9310
9311 PR gdb/24618
9312 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9313 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9314 invalid.
9315
f19e22e9
TV
93162019-06-10 Tom de Vries <tdevries@suse.de>
9317
9318 PR gdb/24611
9319 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9320 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9321
e99f9db0
TV
93222019-06-10 Tom de Vries <tdevries@suse.de>
9323
9324 PR symtab/24545
9325 * symtab.c (struct demangled_name_entry): Add language field.
9326 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9327 static minimal symbol". Set and use language field.
9328
9bf7038b
TT
93292019-06-10 Tom Tromey <tromey@adacore.com>
9330
9331 * ada-lang.c (_initialize_ada_language): Update help text.
9332
422186a9
TT
93332019-06-10 Tom Tromey <tromey@adacore.com>
9334
9335 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9336 with a newline.
9337 * guile/guile.c (handle_boot_error): Don't end warning with a
9338 newline.
9339 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9340 warning with a newline.
9341 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9342 newline.
9343 (s12z_frame_cache): Likewise.
9344 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9345 a newline.
9346 * solib-svr4.c (disable_probes_interface): Don't end warning with
9347 a newline.
9348 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9349 newline.
9350 * python/python.c (do_finish_initialization): Don't end warning
9351 with a newline.
9352
25ce02ee
TT
93532019-06-10 Tom Tromey <tom@tromey.com>
9354
9355 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9356 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9357 gdbpy_enter.
9358
caa429d8
TT
93592019-06-10 Tom Tromey <tromey@adacore.com>
9360
9361 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9362 data.
9363 (elf_new_init): Don't call stabsread_new_init.
9364 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9365 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9366 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9367
81873cc8
TV
93682019-06-10 Tom de Vries <tdevries@suse.de>
9369
9370 PR symtab/16264
9371 PR symtab/24517
9372 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9373
4fa0265e
РИ
93742019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9375
9376 * source.c (find_and_open_source): Also rewrite relative file
9377 names.
9378
1a3da2cd
AB
93792019-04-26 Amos Bird <amosbird@gmail.com>
9380
9381 * annotate.c (annotate_thread_exited): Add "thread-exited"
9382 annotation.
9383
3847a7bf
TT
93842019-06-06 Tom Tromey <tromey@adacore.com>
9385
9386 * maint.h (class scoped_command_stats): Use
9387 DISABLE_COPY_AND_ASSIGN.
9388 <print_time>: New method.
9389 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9390 print_time.
9391 (scoped_command_stats::print_time): New method.
9392
312617a3
AB
93932019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9394
9395 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9396 instructions of lengths 6 or 8 bytes.
9397
b02f78f9
PA
93982019-06-04 Pedro Alves <palves@redhat.com>
9399
9400 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9401
9402 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9403 * breakpoint.c (condition_completer): Likewise.
9404 * cli/cli-dump.c (scan_expression): Likewise.
9405 * common/filestuff.c (mkdir_recursive): Likewise.
9406 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9407 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9408 (gdb_abspath): Likewise.
9409 * compile/compile-cplus-types.c
9410 (compile_cplus_instance::decl_name): Likewise.
9411 * completer.c (complete_explicit_location):
9412 (signal_completer, reg_or_group_completer_1): Likewise.
9413 * cp-support.c (cp_remove_params_if_any): Likewise.
9414 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9415 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9416 * infcmd.c (strip_bg_char): Likewise.
9417 * linespec.c (copy_token_string): Likewise.
9418 * mi/mi-main.c (output_cores): Likewise.
9419 * psymtab.c (psymtab_search_name):
9420 * symfile.c (test_set_ext_lang_command): Likewise.
9421 * target.c (target_fileio_read_stralloc): Likewise.
9422 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9423 * value.c (complete_internalvar): Likewise.
9424
e1f2e1a2
CB
94252019-06-04 Christian Biesinger <cbiesinger@google.com>
9426
9427 Add objfile property to gdb.Type.
d3238f7d
PA
9428 * NEWS: Mention Python API addition.
9429 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9430
e664d728
PW
94312019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9432
9433 * NEWS: Mention the new set|show style [title|highlight].
9434 Mention changes to "show style", "help" and "apropos".
9435
66d8c862
PW
94362019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9437
9438 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9439 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9440 instead of print_help_for_command.
9441 (print_doc_of_command): New function.
9442 (help_list): Add 'apropos -v word' suggestion.
9443 (print_help_for_command): Style the command name using title style.
9444 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9445 (_initialize_cli_cmds): Describe -v in apropos_command help.
9446
9303eb2f
PW
94472019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9448
9449 * cli/cli-style.h (cli_style_option): Add name in constructor,
9450 add m_name class member, add constructor with intensity,
9451 add name class function.
9452 (cli_style_option::add_setshow_commands): Remove name argument.
9453 (highlight_style, title_style): New styles.
9454 * cli/cli-style.c (do_show): New function that shows a style
9455 characteristic styling the style name with itself.
9456 (set_style_name): New function.
9457 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9458 Update all callers according to the changes in cli/cli-style.h.
9459 * utils.h (fputs_highlighted): New function.
9460 * utils.c (fputs_highlighted): Likewise.
9461
e2c52041
PW
94622019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9463
9464 * NEWS: Mention new pipe command and new convenience variables.
9465
947d3946
PW
94662019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9467
9468 * cli/cli-cmds.c (pipe_command): New function.
9469 (_initialize_cli_cmds): Call add_com for pipe_command.
9470 Define | as an alias for pipe.
9471 (exit_status_set_internal_vars): New function.
9472 (shell_escape): Call exit_status_set_internal_vars.
9473 cli/cli-decode.c (find_command_name_length): Recognize | as
9474 a single character command.
9475
b8fd0918
PW
94762019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9477
9478 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9479 top.c (execute_command_to_ui_file): New function, mostly a copy
9480 of execute_command_to_string.
9481 (execute_command_to_string): Implement by calling
9482 execute_command_to_ui_file.
9483
68bb5386
PW
94842019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9485
9486 * top.h (saved_command_line): Remove declaration.
9487 * top.c (previous_saved_command_line, previous_repeat_arguments):
9488 New variables.
9489 (saved_command_line): Make static, define together with other
9490 'repeat variables'.
9491 (dont_repeat): Clear repeat_arguments.
9492 (repeat_previous, get_saved_command_line, save_command_line):
9493 New functions.
9494 (gdb_init): Initialize saved_command_line
9495 and previous_saved_command_line.
9496 * main.c (captured_main_1): Remove saved_command_line initialization.
9497 * event-top.c (handle_line_of_input): Update to use
9498 the new 'repeat' related functions instead of direct access to
9499 saved_command_line.
9500 * command.h (repeat_previous, get_saved_command_line,
9501 save_command_line): New declarations.
9502 (dont_repeat): Add comment.
9503
bfcdb852
TT
95042019-05-30 Tom Tromey <tromey@adacore.com>
9505
9506 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9507 Fix comment.
9508 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9509
0ef209f2
JV
95102019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9511
9512 PR cli/24587
9513 * completer.c (complete): Initialize variable word.
9514
955b06fa
SDJ
95152019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9516
9517 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9518 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9519 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9520 'body' is NULL to the outter 'if', protecting the '!is_define'
9521 situation as well.
9522
fa9c3fa0
TT
95232019-05-29 Tom Tromey <tromey@adacore.com>
9524
9525 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9526 (dwarf_unknown): New function.
9527 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9528 (dwarf_type_encoding_name): Use dwarf_unknown.
9529
4330d61d
TT
95302019-05-29 Tom Tromey <tromey@adacore.com>
9531
9532 PR c++/20020:
9533 * cp-valprint.c (cp_print_value_fields): Call
9534 cp_print_static_field inside "try".
9535
33a6bc35
TT
95362019-05-29 Tom Tromey <tromey@adacore.com>
9537
9538 * inflow.c (struct terminal_info): Add default operator=.
9539 * configure: Rebuild.
9540 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9541 -Wdeprecated-copy-dtor, -Wredundant-move.
9542
000439d5
TT
95432019-05-29 Tom Tromey <tromey@adacore.com>
9544
9545 * NEWS: Add entry.
9546 * infcmd.c (print_return_value_1): Handle finish_print
9547 option.
9548 (show_print_finish): New function.
9549 (_initialize_infcmd): Add "set/show print finish" commands.
9550 * valprint.c (user_print_options): Initialize new member.
9551 * valprint.h (struct value_print_options) <finish_print>: New
9552 member.
9553
c0e70c62
TT
95542019-05-28 Tom Tromey <tromey@adacore.com>
9555
9556 * ada-lang.c (ada_remove_Xbn_suffix)
9557 (find_old_style_renaming_symbol)
9558 (parse_old_style_renaming): Remove.
9559 (ada_find_renaming_symbol): Don't call
9560 find_old_style_renaming_symbol.
9561 (ada_is_renaming_symbol): Rename from
9562 ada_find_renaming_symbol. Remove "block" parameter. Return
9563 bool. Now static.
9564 (ada_read_var_value): Update and simplify.
9565 * ada-exp.y (write_var_or_type): Remove old code.
9566
766f8836
AH
95672019-05-28 Alan Hayward <alan.hayward@arm.com>
9568
68255adc 9569 PR gdb/25010
766f8836
AH
9570 * event-top.c: Remove include comment.
9571 * inflow.c (class scoped_ignore_sigttou): Move from here...
9572 * inflow.h (class scoped_ignore_sigttou): ...to here.
9573 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9574 * top.c: Remove include comment.
9575
eb41253a
TT
95762019-05-27 Tom Tromey <tom@tromey.com>
9577
9578 * NEWS: Fix typo.
9579
4ca51187
TT
95802019-05-22 Tom Tromey <tromey@adacore.com>
9581
9582 * target.c (target_follow_exec): Constify parameter.
9583 * target-delegates.c: Rebuild.
9584 * remote.c (remote_target::follow_exec): Constify parameter.
9585 * infrun.c (follow_exec): Constify parameter.
9586 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9587 (target_follow_exec): Likewise.
9588
8fca4da0
AH
95892019-05-22 Alan Hayward <alan.hayward@arm.com>
9590
9591 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9592 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9593
b7060614
AH
95942019-05-22 Alan Hayward <alan.hayward@arm.com>
9595
9596 * NEWS: Add debugredirect and testsuite sections.
9597
0a5954bd
SC
95982019-05-22 Simon Cook <simon.cook@embecosm.com>
9599
9600 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9601 target descriptions using exclusively floating point register name
9602 aliases.
9603
dc42e902
AB
96042019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9605
9606 PR gdb/18644:
9607 * f-lang.c (build_fortran_types): Handle the case where
9608 gdbarch_floatformat_for_type returns a nullptr.
9609
fb7806c7
TV
96102019-05-21 Tom de Vries <tdevries@suse.de>
9611
9612 PR cli/24587
9613 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9614
34d11c68
AB
96152019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9616
9617 PR gdb/18644:
9618 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9619 16-byte floats.
9620 * i386-tdep.c (i386_floatformat_for_type): Use
9621 floatformats_ia64_quad for the 16-byte floating point component
9622 within a fortran 32-byte complex number.
9623
122cf0f2
AB
96242019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9625
9626 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9627 delete default constructor.
9628 (find_partial_die): Update to return const struct.
9629 (partial_die_parent_scope): Move variable declaration into scope
9630 of its use and change its type to auto.
9631 (guess_partial_die_structure_name): Likewise.
9632 (partial_die_info::fixup): Likewise.
9633
33d0e35a
TT
96342019-05-17 Tom Tromey <tromey@adacore.com>
9635
9636 * source.c (find_and_open_source): Remove cast.
9637
a45575b0
TT
96382019-05-17 Tom Tromey <tromey@adacore.com>
9639
9640 * annotate.c (annotate_source): Make "filename" const.
9641 * annotate.h (annotate_source): Use const.
9642
81f47ac2
AH
96432019-05-17 Alan Hayward <alan.hayward@arm.com>
9644
9645 * disasm.c (set_disassembler_options): Send errors to stderr.
9646
ca1285d1
AH
96472019-05-17 Alan Hayward <alan.hayward@arm.com>
9648
9649 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9650 (cli_interp_base::set_logging): Check debug_redirect.
9651 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9652 * cli/cli-logging.c (debug_redirect): Add static variable.
9653 (pop_output_files): Add default param.
9654 (handle_redirections): Print debug setting.
9655 (show_logging_command): Likewise.
9656 (_initialize_cli_logging): Add debugredirect command.
9657 * interps.c (current_interp_set_logging): Add debug_redirect
9658 parameter.
9659 * interps.h (set_logging): Add debug_redirect parameter.
9660 (current_interp_set_logging): Likewise.
9661 * mi/mi-common.h: Likewise.
9662 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9663
96642019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
9665 Tom Tromey <tromey@adacore.com>
9666
9667 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9668 directly.
9669 * cli/cli-interp.h (make_logging_output): Remove declaration.
9670 * cli/cli-logging.c (make_logging_output): Remove function.
9671 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9672 directly.
9673 * ui-file.c (tee_file::tee_file): Remove bools.
9674 (tee_file::~tee_file): Remove deletes.
9675 * ui-file.h (tee_file): Remove bools.
9676
26648588
JV
96772019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9678
9679 * mi/mi-cmds.h (mi_cmd_complete): New function.
9680 * mi/mi-main.c (mi_cmd_complete): Likewise.
9681 * mi/mi-cmds.c: Define new MI command -complete.
9682 * NEWS: Mention new -complete command.
9683
6e035501
JV
96842019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9685
9686 * completer.h (complete): New function.
9687 * completer.c (complete): Likewise.
9688 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9689 function defined in completer.h.
9690
7d0e2ece
JV
96912019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9692
e79be6e5 9693 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9694
fb816e8b
TV
96952019-05-17 Tom de Vries <tdevries@suse.de>
9696
9697 PR gdb/24094
9698 * dwarf2read.c (struct cu_partial_die_info): New struct.
9699 (find_partial_die): Return cu_partial_die_info.
9700 (partial_die_parent_scope, guess_partial_die_structure_name)
9701 (partial_die_info::fixup): Handle new return type of find_partial_die.
9702
677052f2
SDJ
97032019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9704
a1726c38 9705 PR breakpoints/24541
677052f2
SDJ
9706 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9707 "std::string", simplifying the algorithm.
9708
f3da9116
SDJ
97092019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9710
9711 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9712 (stap_static_probe_ops::get_probes): Likewise.
9713
f1bb75ab
SDJ
97142019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9715
9716 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9717 '-')" and "else if".
9718 (stap_parse_single_operand): Join checks for
9719 "gdbarch_stap_parse_special_token_p" and
9720 "gdbarch_stap_parse_special_token" in the same "if" statement.
9721 Invert check when verifying for operation on register
9722 displacement.
9723
3ca58cde
SDJ
97242019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9725
9726 * stap-probe.c (stap_get_opcode): Update comment.
9727 (stap_get_expected_argument_type): Likewise.
9728 (handle_stap_probe): Likewise.
9729
af2d9bee
SDJ
97302019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9731
9732 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9733 return type to 'bool'. Adjust comment. Use 'bool' when
9734 appropriate.
9735 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9736 * stap-probe.c (stap_parse_argument_1): Likewise.
9737 (stap_is_operator): Likewise.
9738 (stap_is_generic_prefix): Likewise.
9739 (stap_is_register_prefix): Likewise.
9740 (stap_is_register_indirection_prefix): Likewise.
9741 (stap_is_integer_prefix): Likewise.
9742 (stap_generic_check_suffix): Likewise.
9743 (stap_check_integer_suffix): Likewise.
9744 (stap_check_register_suffix): Likewise.
9745 (stap_check_register_indirection_suffix): Likewise.
9746 (stap_parse_register_operand): Likewise.
9747 (stap_parse_single_operand): Likewise.
9748 (stap_parse_argument_1): Likewise.
9749 (stap_probe::get_argument_count): Likewise.
9750 (stap_is_operator): Likewise.
9751
61c9c421
TT
97522019-05-16 Tom Tromey <tromey@adacore.com>
9753
9754 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9755 keyword to foreach.
9756
9ddc1af1
SM
97572019-05-15 Simon Marchi <simon.marchi@efficios.com>
9758
9759 * linux-thread-db.c (try_thread_db_load_1): Change return type
9760 to bool.
9761 (try_thread_db_load): Likewise.
9762 (try_thread_db_load_from_pdir_1): Likewise.
9763 (try_thread_db_load_from_pdir): Likewise.
9764 (try_thread_db_load_from_sdir): Likewise.
9765 (try_thread_db_load_from_dir): Likewise.
9766 (thread_db_load_search): Likewise.
9767 (has_libpthread): Likewise.
9768 (thread_db_load): Likewise.
9769
7bede828
SDJ
97702019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9771
9772 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9773 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9774 NULL, and complain/return if that's the case.
9775
c5358db4
JD
97762019-05-15 John Darrington <john@darrington.wattle.id.au>
9777
9778 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9779 (advance, posn, abstract_read_memory): New functions.
9780 [struct mem_read_abstraction]: New struct.
9781 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9782
c408a94f
TT
97832019-05-14 Tom Tromey <tromey@adacore.com>
9784
9785 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9786 value is not lval_memory.
9787
e7bd7fba
TT
97882019-05-14 Tom Tromey <tromey@adacore.com>
9789
9790 * solib.c (info_sharedlibrary_command): Style the file name.
9791
a6d0f249
AH
97922019-05-14 Alan Hayward <alan.hayward@arm.com>
9793
9794 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9795 (aarch64_vnv_type): Likewise.
9796 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9797 * common/tdesc.c: Likewise.
9798 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9799 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9800 * features/aarch64-fpu.xml: Add ieee half view.
9801 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9802 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9803 * gdbtypes.h (struct builtin_type): Likewise.
9804 (struct objfile_type): Likewise.
9805
66b8bb74
SM
98062019-05-12 Paul Naert <paul.naert@polymtl.ca>
9807
9808 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9809 typo.
9810 * location.h (string_to_event_location): Likewise.
9811
21c219fd
JB
98122019-05-11 Joel Brobecker <brobecker@adacore.com>
9813
9814 GDB 8.3 released.
9815
13674803
SM
98162019-05-10 Simon Marchi <simon.marchi@efficios.com>
9817
9818 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9819 New variable declaration.
9820 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9821 New variable.
9822 (print_one_breakpoint): Use ui_out::test_flags and new global
9823 variable to compute use_fixed_output.
9824 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9825 Remove.
9826 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9827 (mi_multi_location_breakpoint_output_fixed): Remove.
9828 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9829 new variable.
9830 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9831 fix_multi_location_breakpoint_output flag if version >= 3.
9832 * ui-out.h (enum ui_out_flag)
9833 <fix_multi_location_breakpoint_output>: New enumerator.
9834
a9eac7f9
SM
98352019-05-10 Simon Marchi <simon.marchi@efficios.com>
9836
9837 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9838
71bed2db
TT
98392019-05-10 Tom Tromey <tromey@adacore.com>
9840
9841 * ada-lang.c (catch_ada_completer): New function.
9842 (_initialize_ada_language): Use it.
9843
24c54127
TT
98442019-05-10 Tom Tromey <tromey@adacore.com>
9845
9846 * thread.c (print_thread_info): Make "requested_threads" const.
9847 * gdbthread.h (print_thread_info): Make "requested_threads"
9848 const.
9849 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9850 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9851
7a102139
TT
98522019-05-08 Tom Tromey <tom@tromey.com>
9853
9854 * gdbtypes.c (objfile_type_data): Change type.
9855 (objfile_type, _initialize_gdbtypes): Update.
9856
924d79e2
TT
98572019-05-08 Tom Tromey <tom@tromey.com>
9858
9859 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9860 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9861 (_initialize_dwarf2_frame): Update.
9862
4c58e337
TT
98632019-05-08 Tom Tromey <tom@tromey.com>
9864
9865 * objc-lang.c (objc_objfile_data): Change type.
9866 (find_methods): Update.
9867 (_initialize_objc_lang): Remove.
9868
d772d2ab
TT
98692019-05-08 Tom Tromey <tom@tromey.com>
9870
9871 * stabsread.c (rs6000_builtin_type_data): Change type.
9872 (rs6000_builtin_type, _initialize_stabsread): Update.
9873
d11d83f4
TT
98742019-05-08 Tom Tromey <tom@tromey.com>
9875
9876 * mips-tdep.c (mips_pdr_data): Remove.
9877 (_initialize_mips_tdep): Update.
9878
9a73f0ad
TT
98792019-05-08 Tom Tromey <tom@tromey.com>
9880
9881 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9882 (hppa_init_objfile_priv_data, read_unwind_info)
9883 (find_unwind_entry, _initialize_hppa_tdep): Update.
9884
8127a2fa
TT
98852019-05-08 Tom Tromey <tom@tromey.com>
9886
9887 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9888 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9889 on obstack.
9890 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9891
91d3055d
TT
98922019-05-08 Tom Tromey <tom@tromey.com>
9893
9894 * mdebugread.c (basic_type_data): Change type.
9895 (basic_type, _initialize_mdebugread): Update.
9896
31930bd3
TT
98972019-05-08 Tom Tromey <tom@tromey.com>
9898
9899 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9900
bdb3ed9e
TT
99012019-05-08 Tom Tromey <tom@tromey.com>
9902
9903 * nto-tdep.c (nto_inferior_data_reg): Change type.
9904 (nto_inferior_data): Update.
9905 (nto_inferior_data_cleanup, nto_new_inferior_data)
9906 (_initialize_nto_tdep): Remove.
9907 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9908
f37b313d
TT
99092019-05-08 Tom Tromey <tom@tromey.com>
9910
9911 * ada-lang.c (struct ada_inferior_data): Add initializers.
9912 (ada_inferior_data): Change type.
9913 (ada_inferior_data_cleanup): Remove.
9914 (get_ada_inferior_data, ada_inferior_exit)
9915 (struct ada_pspace_data): Add initializers, destructor.
9916 (ada_pspace_data_handle): Change type.
9917 (get_ada_pspace_data): Update.
9918 (ada_pspace_data_cleanup): Remove.
9919
24699405
TT
99202019-05-08 Tom Tromey <tom@tromey.com>
9921
9922 * coffread.c (struct coff_symfile_info): Add initializers.
9923 (coff_objfile_data_key): Move lower. Change type.
9924 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9925 Update.
9926 (coff_free_info): Remove.
9927
d4e05d2f
TT
99282019-05-08 Tom Tromey <tom@tromey.com>
9929
9930 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9931 (fbsd_pspace_data_handle): Move lower. Change type.
9932 (get_fbsd_pspace_data): Update.
9933 (fbsd_pspace_data_cleanup): Remove.
9934 (_initialize_fbsd_tdep): Update.
9935
14ef6690
TT
99362019-05-08 Tom Tromey <tom@tromey.com>
9937
9938 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9939 (get_ada_tasks_pspace_data): Update.
9940 (ada_tasks_pspace_data_cleanup): Remove.
9941 (_initialize_tasks): Update.
9942 (ada_tasks_inferior_data_handle): Change type.
9943 (get_ada_tasks_inferior_data): Update.
9944 (ada_tasks_inferior_data_cleanup): Remove.
9945 (struct ada_tasks_pspace_data): Add initializers.
9946
814cf43a
TT
99472019-05-08 Tom Tromey <tom@tromey.com>
9948
9949 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9950 * symfile-debug.c (debug_sym_get_probes): Change type.
9951 * stap-probe.c (handle_stap_probe):
9952 (stap_static_probe_ops::get_probes): Change type.
9953 * probe.h (class static_probe_ops) <get_probes>: Change type.
9954 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9955 (parse_probes_in_pspace): Update.
9956 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9957 Update.
9958 (any_static_probe_ops::get_probes): Change type.
9959 * elfread.c (elfread_data): New typedef.
9960 (probe_key): Change type.
9961 (elf_get_probes): Likewise. Update.
9962 (probe_key_free): Remove.
9963 (_initialize_elfread): Update.
9964 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9965 Change type.
9966 (dtrace_process_dof_probe, dtrace_process_dof)
9967 (dtrace_static_probe_ops::get_probe): Change type.
9968
02dc647e
TT
99692019-05-08 Tom Tromey <tom@tromey.com>
9970
9971 * xcoffread.c (struct xcoff_symfile_info): Rename from
9972 coff_symfile_info. Add initializers.
9973 (xcoff_objfile_data_key): Move lower. Change type.
9974 (XCOFF_DATA): Rewrite.
9975 (xcoff_free_info): Remove.
9976 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9977 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9978 (xcoff_initial_scan): Update.
9979
09232438
TT
99802019-05-08 Tom Tromey <tom@tromey.com>
9981
9982 * solib-svr4.c (struct svr4_info): Add initializers and
9983 destructor.
9984 <probes_table>: Now an htab_up.
9985 (solib_svr4_pspace_data): Change type.
9986 (free_probes_table): Simplify.
9987 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9988 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9989 (probes_table_remove_objfile_probes, register_solib_event_probe)
9990 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9991 (_initialize_svr4_solib): Update.
9992
7b4a314f
TT
99932019-05-08 Tom Tromey <tom@tromey.com>
9994
9995 * remote.c (remote_pspace_data): Change type.
9996 (remote_pspace_data_cleanup): Remove.
9997 (get_remote_exec_file, set_pspace_remote_exec_file)
9998 (_initialize_remote): Update.
9999
51d3063a
TT
100002019-05-08 Tom Tromey <tom@tromey.com>
10001
10002 * breakpoint.c (breakpoint_objfile_key): Change type.
10003 (get_breakpoint_objfile_data): Update.
10004 (free_breakpoint_objfile_data): Remove.
10005 (_initialize_breakpoint): Update.
10006
89fb8848
TT
100072019-05-08 Tom Tromey <tom@tromey.com>
10008
10009 * linux-tdep.c (struct linux_info): Add initializers.
10010 (linux_inferior_data): Move. Change type.
10011 (invalidate_linux_cache_inf): Update.
10012 (linux_inferior_data_cleanup): Remove.
10013 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10014
e9b89e2d
TT
100152019-05-08 Tom Tromey <tom@tromey.com>
10016
10017 * auxv.c (auxv_inferior_data): Move. Change type.
10018 (auxv_inferior_data_cleanup): Remove.
10019 (invalidate_auxv_cache_inf): Rewrite.
10020 (get_auxv_inferior_data, _initialize_auxv): Update.
10021
8c42777c
TT
100222019-05-08 Tom Tromey <tom@tromey.com>
10023
10024 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10025 (symfile_debug_objfile_data_key): Change type.
10026 (symfile_debug_installed, debug_qf_has_symbols)
10027 (debug_qf_find_last_source_symtab)
10028 (debug_qf_forget_cached_source_info)
10029 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10030 (debug_qf_print_stats, debug_qf_dump)
10031 (debug_qf_expand_symtabs_for_function)
10032 (debug_qf_expand_all_symtabs)
10033 (debug_qf_expand_symtabs_with_fullname)
10034 (debug_qf_map_matching_symbols)
10035 (debug_qf_expand_symtabs_matching)
10036 (debug_qf_find_pc_sect_compunit_symtab)
10037 (debug_qf_map_symbol_filenames)
10038 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10039 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10040 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10041 (debug_sym_read_linetable, debug_sym_relocate): Update.
10042 (symfile_debug_free_objfile): Remove.
10043 (install_symfile_debug_logging, _initialize_symfile_debug):
10044 Update.
10045
5bfd760d
TT
100462019-05-08 Tom Tromey <tom@tromey.com>
10047
10048 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10049 allocate_on_obstack.
10050 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10051 (get_dwarf2_per_objfile): Update.
10052 (set_dwarf2_per_objfile): Remove.
10053 (dwarf2_has_info, dwarf2_get_section_info): Update.
10054 (dwarf2_free_objfile): Remove.
10055 (_initialize_dwarf2_read): Update.
10056
e85e19b4
TT
100572019-05-08 Tom Tromey <tom@tromey.com>
10058
10059 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10060 initializers.
10061 <unsupported_script_warning_printed,
10062 script_not_found_warning_printed>: Now bool.
10063 (auto_load_pspace_data): Change type.
10064 (~auto_load_pspace_info): Rename from
10065 auto_load_pspace_data_cleanup.
10066 (get_auto_load_pspace_data, init_loaded_scripts_info)
10067 (clear_section_scripts, maybe_print_unsupported_script_warning)
10068 (maybe_print_script_not_found_warning, _initialize_auto_load):
10069 Update.
10070
f6aa7436
TT
100712019-05-08 Tom Tromey <tom@tromey.com>
10072
10073 * objfiles.c (objfile_pspace_info): Add destructor and
10074 initializers.
10075 (objfiles_pspace_data): Change type.
10076 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10077 (get_objfile_pspace_data): Update.
10078 (objfiles_bfd_data): Change type.
10079 (get_objfile_bfd_data): Update.
10080 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10081
6ae614f6
TT
100822019-05-08 Tom Tromey <tom@tromey.com>
10083
10084 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10085 Change type.
10086 (get_catch_syscall_inferior_data): Update.
10087 (catch_syscall_inferior_data_cleanup): Remove.
10088 (_initialize_break_catch_syscall): Update.
10089
6509b8eb
TT
100902019-05-08 Tom Tromey <tom@tromey.com>
10091
10092 * inflow.c (struct terminal_info): Add destructor and
10093 initializers.
10094 (inflow_inferior_data): Change type.
10095 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10096 (get_inflow_inferior_data, inflow_inferior_exit)
10097 (swap_terminal_info, _initialize_inflow): Update.
10098
35632941
TT
100992019-05-08 Tom Tromey <tom@tromey.com>
10100
10101 * target-dcache.c (target_dcache_cleanup): Remove.
10102 (target_dcache_aspace_key): Change type.
10103 (target_dcache_init_p, target_dcache_invalidate)
10104 (target_dcache_get, target_dcache_get_or_init)
10105 (_initialize_target_dcache): Update.
10106 * dcache.h (struct dcache_deleter): New.
10107
3017b94d
TT
101082019-05-08 Tom Tromey <tom@tromey.com>
10109
10110 * symtab.c (struct symbol_cache): Add destructor and
10111 initializers.
10112 (symbol_cache_key): Move. Change type.
10113 (make_symbol_cache, free_symbol_cache): Remove.
10114 (get_symbol_cache): Update.
10115 (symbol_cache_cleanup): Remove.
10116 (ALL_PSPACES, symbol_cache_flush)
10117 (maintenance_print_symbol_cache)
10118 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10119 Update.
10120
a32ad8c5
TT
101212019-05-08 Tom Tromey <tom@tromey.com>
10122
10123 * symtab.c (struct main_info): Add destructor and initializers.
10124 (main_progspace_key): Move. Change type.
10125 (get_main_info): Update.
10126 (main_info_cleanup): Remove.
10127 (_initialize_symtab): Update.
10128
5f6e90a0
TT
101292019-05-08 Tom Tromey <tom@tromey.com>
10130
10131 * registry.h (DECLARE_REGISTRY): Define the _key class.
10132
1bd0c6e4
AB
101332019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10134
10135 * NEWS: Merge two 'New commands' sections.
10136
2228ef77
XR
101372019-05-08 Joel Brobecker <brobecker@adacore.com>
10138
10139 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10140 parameter and use Ada language definition instead.
10141 (ada_val_print_ptr): Remove unused language parameter.
10142 (ada_val_print_num): Remove language parameter and use Ada language
10143 definition instead.
10144 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10145 parameter.
10146 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10147 parameter and use Ada language definition instead.
10148 (ada_val_print_1): Update all ada_val_print_xxx calls.
10149 Remove language parameter.
10150 (ada_val_print): Update ada_val_print_1 call.
10151
60fcc1c3
TT
101522019-05-08 Tom Tromey <tromey@adacore.com>
10153
10154 * remote.c (remote_hw_watchpoint_limit)
10155 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10156 Now static.
10157
ed2b7c17
TT
101582019-05-08 Tom Tromey <tromey@adacore.com>
10159
10160 * maint.c (_initialize_maint_cmds): Move initialization code to
10161 remote.c.
10162 (watchdog, show_watchdog): Move to remote.c.
10163 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10164 "watchdog" static.
10165 (_initialize_remote): Move initialization code from maint.c.
10166 * defs.h (watchdog): Don't declare.
10167
b0be6c91
TT
101682019-05-08 Tom Tromey <tromey@adacore.com>
10169
10170 * tui/tui-interp.c: Include main.h.
10171 * interps.c: Include main.h.
10172 * main.h (interpreter_p): Declare.
10173 * defs.h (interpreter_p): Don't declare.
10174
587ee17b
TT
101752019-05-08 Tom Tromey <tromey@adacore.com>
10176
10177 * dwarf2loc.c: Include dwarf2read.h.
10178 * defs.h (read_unsigned_leb128): Don't declare.
10179 * dwarf2read.h (read_unsigned_leb128): Declare.
10180
ca1df239
TT
101812019-05-08 Tom Tromey <tromey@adacore.com>
10182
10183 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10184 method.
10185
99f20f08
TT
101862019-05-08 Tom Tromey <tromey@adacore.com>
10187
10188 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10189 when no wrap column is set.
10190
80e55b13
TT
101912019-05-08 Tom Tromey <tromey@adacore.com>
10192
10193 * c-lang.c (c_get_string): Handle non-C-style arrays.
10194
9d3421af
TT
101952019-05-08 Tom Tromey <tromey@adacore.com>
10196
10197 * typeprint.c (print_offset_data::update): Print the bit offset,
10198 not the number of bits remaining.
10199
844333e2
TT
102002019-05-08 Tom Tromey <tromey@adacore.com>
10201
10202 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10203 padding at end of comment.
10204
988915ee
TT
102052019-05-08 Tom Tromey <tromey@adacore.com>
10206
10207 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10208 Compare main types.
10209
26bfd823
TT
102102019-05-06 Tom Tromey <tom@tromey.com>
10211
10212 * common/scoped_mmap.c: Include common-defs.h.
10213 * common/scoped_mmap.h: Don't include config.h.
10214
89055eaa
TT
102152019-05-04 Tom Tromey <tom@tromey.com>
10216
10217 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10218 (struct aarch64_call_info): Add initializers.
10219 <si>: Now a std::vector.
10220 (pass_on_stack, aarch64_push_dummy_call): Update.
10221
5da01df5
TT
102222019-05-04 Simon Marchi <simon.marchi@efficios.com>
10223 Tom Tromey <tom@tromey.com>
10224
10225 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10226 (ppc_threads): Now a std::vector. Now static.
10227 (hwdebug_find_thread_points_by_tid)
10228 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10229 Update.
10230
fbdf05a1
TT
102312019-05-04 Tom Tromey <tom@tromey.com>
10232
10233 * arc-tdep.c (arc_tdesc_init): Return bool.
10234
06d16ec9
TT
102352019-05-04 Tom Tromey <tom@tromey.com>
10236
10237 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10238 Use gdb_assert_not_reached.
10239
9c056022
TT
102402019-05-04 Tom Tromey <tom@tromey.com>
10241
10242 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10243 "false".
10244
fa9c2a59
TT
102452019-05-04 Tom Tromey <tom@tromey.com>
10246
10247 * arc-tdep.c (arc_tdesc_init): Use bool.
10248
e2eb806a
TT
102492019-05-04 Tom Tromey <tom@tromey.com>
10250
10251 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10252
6fe87677
TT
102532019-05-04 Tom Tromey <tom@tromey.com>
10254
10255 * cli/cli-cmds.c (valid_command_p): Return bool.
10256
7f008c9e
TT
102572019-05-04 Tom Tromey <tom@tromey.com>
10258
10259 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10260 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10261
b6484282
RT
102622019-05-04 Raul Tambre <raul@tambre.ee>
10263
10264 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10265 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10266 operator for comparison.
10267
af97b416
TT
102682019-05-04 Tom Tromey <tom@tromey.com>
10269
10270 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10271 (lookup_partial_symbol, print_partial_symbols)
10272 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10273 (psymbol_compare): Update.
10274 (add_psymbol_to_bcache): Clear the entire psymbol.
10275 (maintenance_check_psymtabs): Update.
10276 * psympriv.h (struct partial_symbol): Don't derive from
10277 general_symbol_info.
10278 <obj_section, unrelocated_address, address,
10279 set_unrelocated_address>: Update.
10280 <ginfo>: New member.
10281 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10282 (debug_names::write_psymbols): Update.
10283
9d6d4be8
TV
102842019-05-04 Tom de Vries <tdevries@suse.de>
10285
10286 * contrib/cc-with-tweaks.sh: Support -n arg.
10287
66452beb
PW
102882019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10289
10290 * corelow.c (core_target::detach): Ensure frame cache and
10291 register caches are cleared.
10292 inferior.c (exit_inferior_1): Likewise.
10293
bde09ab7
TT
102942019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10295 Tom Tromey <tom@tromey.com>
10296
10297 * dictionary.c (collate_pending_symbols_by_language): Remove
10298 "struct" from foreach.
10299 * symtab.c (lookup_global_symbol_from_objfile)
10300 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10301 foreach.
10302 * ser-tcp.c (net_open): Remove "struct" from foreach.
10303 * objfiles.c (objfile_relocate, objfile_rebase)
10304 (objfile_has_symbols): Remove "struct" from foreach.
10305 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10306 from foreach.
10307 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10308 foreach.
10309 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10310 "struct" from foreach.
10311 * ada-lang.c (create_excep_cond_exprs)
10312 (ada_exception_catchpoint_cond_string): Remove "struct" from
10313 foreach.
10314
222a8d25
TT
103152019-05-03 Tom Tromey <tromey@adacore.com>
10316
10317 * ada-exp.y (convert_char_literal): Check suffix of each
10318 enumerator.
10319
fcd60b84
DP
103202019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10321
10322 PR ada/21406:
10323 * ada-exp.y (yywrap): Don't define.
10324 * ada-lex.l (%option): Add noyywrap
10325 (yywrap): Remove.
10326
5f2459c2
EZ
103272019-05-03 Eli Zaretskii <eliz@gnu.org>
10328
353ea2d1
EZ
10329 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10330 _WIN32_WINNT to the XP level, unless already defined to a higher
10331 level.
10332
10333 * unittests/parse-connection-spec-selftests.c:
10334 * ser-tcp.c:
10335 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10336 override.
10337
5f2459c2
EZ
10338 * symfile.c (find_separate_debug_file): Remove colon from the
10339 drive spec of DOS/Windows file names of the target, so that the
10340 file name produced from DEBUGDIR and the target's directory will
10341 be valid on DOS/Windows systems.
10342
80062eb9
AB
103432019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10344
10345 * rust-lang.c (val_print_struct): Handle printing structures
10346 containing strings.
10347
b8c05e85
TT
103482019-05-02 Tom Tromey <tromey@adacore.com>
10349
10350 * valarith.c (_initialize_valarith): Remove.
10351
4504bbde
TT
103522019-05-01 Tom Tromey <tromey@adacore.com>
10353
10354 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10355 bitfields.
10356
d48e62f4
TT
103572019-05-01 Tom Tromey <tromey@adacore.com>
10358
10359 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10360 for big-endian copies.
10361
15f18d14
AT
103622019-04-30 Ali Tamur <tamur@google.com>
10363 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10364 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10365 (read_3_bytes): New function.
10366
ab4ee614
JB
103672019-04-30 Joel Brobecker <brobecker@adacore.com>
10368
10369 * windows-nat.c (main_thread_id): Delete.
10370 (handle_output_debug_string): Replace main_thread_id by
10371 current_event.dwThreadId.
10372 (fake_create_process): Likewise.
10373 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10374 Do not set main_thread_id.
10375 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10376 current_event.dwThreadId.
10377 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10378
8ed5b76e
JB
103792019-04-30 Joel Brobecker <brobecker@adacore.com>
10380
10381 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10382 Use current_event.dwThreadId instead of main_thread_id.
10383
2ff0a947
TT
103842019-04-30 Tom Tromey <tromey@adacore.com>
10385
10386 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10387 (create_excep_cond_exprs): Iterate over program spaces.
10388 (ada_exception_catchpoint_cond_string): Examine all minimal
10389 symbols for exception types.
10390
a776957c
TT
103912019-04-30 Tom Tromey <tromey@adacore.com>
10392
10393 PR c++/24470:
10394 * dwarf2read.c (process_structure_scope): Handle case where type
10395 has template parameters but no symbol was created.
10396
bc68014d
AB
103972019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10398 Chris January <chris.january@arm.com>
10399
10400 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10401 qualifier.
10402 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10403
f1fdc960
AB
104042019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10405
10406 * f-typeprint.c (f_print_type): Update rules for printing
10407 whitespace.
10408 (f_type_print_varspec_suffix): Likewise.
10409
bf7a4de1
AB
104102019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10411 Chris January <chris.january@arm.com>
10412
10413 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10414 function arguments.
10415
bbe75b9d
AB
104162019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10417
10418 * f-lang.c (build_fortran_types): Change name of void type to
10419 lower case.
10420 * f-typeprint.c (f_type_print_base): Print the name of the void
10421 type, rather than a fixed string.
10422 * f-valprint.c (f_decorations): Use lower case void string.
10423
1db455a7
AB
104242019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10425 Chris January <chris.january@arm.com>
10426
10427 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10428 types for Fortran.
10429
b6d03bb2
AB
104302019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10431 Chris January <chris.january@arm.com>
10432 David Lecomber <david.lecomber@arm.com>
10433
10434 * f-exp.y (BINOP_INTRINSIC): New token.
10435 (exp): New parser rule handling BINOP_INTRINSIC.
10436 (f77_keywords): Add new builtin procedures.
10437 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10438 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10439 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10440 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10441 (print_unop_subexp_f): New function.
10442 (print_binop_subexp_f): New function.
10443 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10444 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10445 (dump_subexp_body_f): Likewise.
10446 (operator_check_f): Likewise.
10447 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10448 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10449
83228e93
AB
104502019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10451
10452 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10453 UNOP_KIND.
10454 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10455 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10456 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10457 (operator_length_f): New fuction.
10458 (print_subexp_f): New function.
10459 (op_name_f): New function.
10460 (dump_subexp_body_f): New function.
10461 (operator_check_f): New function.
10462 (exp_descriptor_f): Replace standard expression handling functions
10463 with new functions.
10464 * gdb/fortran-operator.def: New file.
10465 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10466 * gdb/std-operator.def: Remove UNOP_KIND.
10467
6fdcd7cc
AB
104682019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10469
10470 * std-operator.def: Remove unbalanced, stray double quote
10471 character.
10472
2e62ab40
AB
104732019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10474 Chris January <chris.january@arm.com>
10475 Daniel Everett <daniel.everett@arm.com>
10476 Nick Forrington <nick.forrington@arm.com>
10477 Richard Bunt <richard.bunt@arm.com>
10478
10479 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10480 of depth when printing anonymous structs or unions.
10481 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10482 Don't print either the top-level value, or the children if the
10483 max-depth is exceeded.
10484 (ppscm_print_children): When printing the key of a map, allow one
10485 extra level of depth.
10486 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10487 print either the top-level value, or the children if the max-depth
10488 is exceeded.
10489 (print_children): When printing the key of a map, allow one extra
10490 level of depth.
10491 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10492 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10493 (user_print_options): Initialise max_depth field.
10494 (val_print_scalar_or_string_type_p): New function.
10495 (val_print): Check to see if the max depth has been reached.
10496 (val_print_check_max_depth): Define new function.
10497 (show_print_max_depth): New function.
10498 (_initialize_valprint): Add 'print max-depth' option.
10499 * valprint.h (struct value_print_options) <max_depth>: New field.
10500 (val_print_check_max_depth): Declare new function.
10501 * NEWS: Document new feature.
10502
4be290b2
AB
105032019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10504
10505 * ada-lang.c (ada_language_defn): Initialise new field.
10506 * c-lang.c (c_is_string_type_p): New function.
10507 (c_language_defn): Initialise new field.
10508 (cplus_language_defn): Initialise new field.
10509 (asm_language_defn): Initialise new field.
10510 (minimal_language_defn): Initialise new field.
10511 * c-lang.h (c_is_string_type_p): Declare new function.
10512 * d-lang.c (d_language_defn): Initialise new field.
10513 * f-lang.c (f_is_string_type_p): New function.
10514 (f_language_defn): Initialise new field.
10515 * go-lang.c (go_is_string_type_p): New function.
10516 (go_language_defn): Initialise new field.
10517 * language.c (default_is_string_type_p): New function.
10518 (unknown_language_defn): Initialise new field.
10519 (auto_language_defn): Initialise new field.
10520 * language.h (struct language_defn) <la_is_string_type_p>: New
10521 member variable.
10522 (default_is_string_type_p): Declare new function.
10523 * m2-lang.c (m2_language_defn): Initialise new field.
10524 * objc-lang.c (objc_language_defn): Initialise new field.
10525 * opencl-lang.c (opencl_language_defn): Initialise new field.
10526 * p-lang.c (pascal_is_string_type_p): New function.
10527 (pascal_language_defn): Initialise new field.
10528 * rust-lang.c (rust_is_string_type_p): New function.
10529 (rust_language_defn): Initialise new field.
10530
721b08c6
AB
105312019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10532
10533 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10534 New field.
10535 * ada-lang.c (ada_language_defn): Initialise new field.
10536 * c-lang.c (c_language_defn): Likewise.
10537 (cplus_language_defn): Likewise.
10538 (asm_language_defn): Likewise.
10539 (minimal_language_defn): Likewise.
10540 * d-lang.c (d_language_defn): Likewise.
10541 * f-lang.c (f_language_defn): Likewise.
10542 * go-lang.c (go_language_defn): Likewise.
10543 * language.c (unknown_language_defn): Likewise.
10544 (auto_language_defn): Likewise.
10545 * m2-lang.c (m2_language_defn): Likewise.
10546 * objc-lang.c (objc_language_defn): Likewise.
10547 * opencl-lang.c (opencl_language_defn): Likewise.
10548 * p-lang.c (pascal_language_defn): Likewise.
10549 * rust-lang.c (rust_language_defn): Likewise.
10550
fc913e53
AB
105512019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10552
10553 * ada-lang.c (ada_is_character_type): Change return type to bool.
10554 (ada_is_string_type): Likewise.
10555 * ada-lang.h (ada_is_character_type): Update declaration
10556 (ada_is_string_type): Likewise.
10557
fa731fa0
PW
105582019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10559
10560 Support style in 'frame|thread apply'
10561
10562 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10563 * record.c (record_start, record_stop): Update callers of
10564 execute_command_to_string with false.
10565 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10566 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10567 methods.
10568 (class string_file): New constructor with term_out parameter.
10569 Override methods term_out and can_emit_style_escape. New member
10570 term_out.
10571 (class stdio_file): Override can_emit_style_escape.
10572 (class tee_file): Override term_out and can_emit_style_escape.
10573 * utils.h (can_emit_style_escape): Remove.
10574 * utils.c (can_emit_style_escape): Likewise.
10575 Update all callers of can_emit_style_escape (SOMESTREAM) to
10576 SOMESTREAM->can_emit_style_escape.
10577 * source-cache.c (source_cache::get_source_lines): Likewise.
10578 * stack.c (frame_apply_command_count): Call execute_command_to_string
10579 passing the term_out characteristic of the current gdb_stdout.
10580 * thread.c (thr_try_catch_cmd): Likewise.
10581 * top.c (execute_command_to_string): pass term_out parameter
10582 to construct the string_file for the command output.
10583 * ui-file.c (term_cli_styling): New function (most code moved
10584 from utils.c can_emit_style_escape).
10585 (string_file::string_file, string_file::can_emit_style_escape,
10586 stdio_file::can_emit_style_escape, tee_file::term_out,
10587 tee_file::can_emit_style_escape): New functions.
10588
136afab8
PW
105892019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10590
10591 * NEWS: Mention the new set|show may-call-functions.
10592 * infcall.c (may_call_functions_p): New variable.
10593 (show_may_call_functions_p): New function.
10594 (call_function_by_hand_dummy): Throws an error if not
10595 may-call-functions.
10596 (_initialize_infcall): Call add_setshow_boolean_cmd for
10597 may-call-functions.
10598
725cbb63
KS
105992019-04-25 Keith Seitz <keiths@redhat.com>
10600
10601 PR c++/24367
10602 * cp-support.c (inspect_type): Don't attempt substitutions
10603 of symbol with the same name.
10604
3d1cbb78
TT
106052019-04-25 Tom Tromey <tromey@adacore.com>
10606
10607 PR gdb/24475:
10608 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10609 static.
10610
94aeb44b
TT
106112019-04-25 Tom Tromey <tromey@adacore.com>
10612
10613 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10614 rvalue reference.
10615 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10616 (gdb_xml_parser::parse): Use std::move.
10617 * python/python-internal.h (gdbpy_convert_exception): Take a const
10618 reference.
10619 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10620 std::move.
10621 * python/py-utils.c (gdbpy_convert_exception): Take a const
10622 reference.
10623 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10624 Use std::move.
10625 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10626 Use std::move.
10627 * mi/mi-main.c (mi_print_exception): Take a const reference.
10628 * main.c (handle_command_errors): Take a const reference.
10629 * linespec.c (parse_linespec): Use std::move.
10630 * infcall.c (run_inferior_call): Use std::move.
10631 (call_function_by_hand_dummy): Use std::move.
10632 * exec.c (try_open_exec_file): Use std::move.
10633 * exceptions.h (exception_print, exception_fprintf)
10634 (exception_print_same): Update.
10635 * exceptions.c (print_exception, exception_print)
10636 (exception_fprintf, exception_print_same): Change parameters to
10637 const reference.
10638 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10639 * common/new-op.c: Use std::move.
10640 * common/common-exceptions.h (struct gdb_exception): Add move
10641 constructor.
10642 (struct gdb_exception_error, struct gdb_exception_quit, struct
10643 gdb_quit_bad_alloc): Change constructor to move constructor.
10644 (throw_exception): Change parameter to rvalue reference.
10645 * common/common-exceptions.c (throw_exception): Take rvalue
10646 reference.
10647 * cli/cli-interp.c (safe_execute_command): Use std::move.
10648 * breakpoint.c (insert_bp_location, location_to_sals): Use
10649 std::move.
10650
680d7fd5
TT
106512019-04-25 Tom Tromey <tromey@adacore.com>
10652
10653 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10654 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10655 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10656 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10657 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10658 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10659 guile/scm-value.c: Use unpack.
10660 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10661 gdbscm_gdb_exception.
10662 (gdbscm_throw_gdb_exception): Likewise.
10663 (struct gdbscm_gdb_exception): New.
10664 (unpack): New function.
10665 (gdbscm_wrap): Use unpack.
10666
c6fdd8b2
TT
106672019-04-25 Tom Tromey <tromey@adacore.com>
10668
10669 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10670 (gdb_rl_callback_handler): Use std::move.
10671 * common/common-exceptions.h (struct gdb_exception): Add move
10672 assignment operator.
10673 (throw_exception_sjlj): Change "exception" to const reference.
10674 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10675 (throw_exception_sjlj): Change "exception" to const reference.
10676
cc06b668
TT
106772019-04-25 Tom Tromey <tromey@adacore.com>
10678
10679 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10680 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10681 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10682 Update.
10683 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10684 Update.
10685 * mi/mi-interp.c (mi_interp::exec): Update.
10686 * linespec.c (parse_linespec): Update.
10687 * infcall.c (run_inferior_call): Update.
10688 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10689 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10690 (gdbscm_lookup_global_symbol): Update.
10691 * guile/scm-param.c (gdbscm_parameter_value): Update.
10692 * guile/scm-frame.c (gdbscm_frame_read_register)
10693 (gdbscm_frame_read_var): Update.
10694 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10695 * exec.c (try_open_exec_file): Update.
10696 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10697 (gdb_rl_callback_handler): Update.
10698 * common/common-exceptions.h (exception_none): Don't declare.
10699 * common/common-exceptions.c (exception_none): Don't define.
10700 (struct catcher) <exception>: Update.
10701 * cli/cli-interp.c (safe_execute_command): Update.
10702 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10703
cf532bd1
AT
107042019-04-25 Ali Tamur <tamur@google.com>
10705
10706 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10707 (read_attribute_value): Likewise.
10708 (dwarf2_read_addr_index): Update comment.
10709 (read_str_index): Add DW_FORM_strx.
10710 (dwarf2_string_attr): Likewise.
10711 (dwarf2_const_value_attr): Likewise.
10712 (dump_die_shallow): Likewise.
10713 (dwarf2_fetch_constant_bytes): Likewise.
10714 (skip_form_bytes): Likewise.
10715 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10716
82433e3e
SDJ
107172019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10718
10719 PR corefiles/11608
10720 PR corefiles/18187
10721 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10722 OFFSET. Verify if current mapping contains an ELF header.
10723 (linux_find_memory_regions_full): Adjust call to
10724 dump_mapping_p.
10725
723adb65
SL
107262019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10727 Kang Li <kanglictf@gmail.com>
10728
10729 PR gdb/21600
10730
10731 * dwarf2-frame.c (read_initial_length): Be consistent about using
10732 unsigned representation of length.
10733 (decode_frame_entry_1): Likewise. Check for wraparound of
10734 end pointer as well as buffer overflow.
10735
596179f7
SDJ
107362019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10737
10738 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10739 "vq".
10740
a59240a4
TT
107412019-04-24 Tom Tromey <tromey@adacore.com>
10742
10743 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10744
f872fdbb
AB
107452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10746
10747 * s12z-tdep.c (s12z_unwind_pc): Delete.
10748 (s12z_unwind_sp): Delete.
10749 (s12z_gdbarch_init): Don't register deleted functions with
10750 gdbarch.
10751
b614e6f3
AB
107522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10753
10754 * rl78-tdep.c (rl78_unwind_sp): Delete.
10755 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10756
14faed38
AB
107572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10758
10759 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10760 (xstormy16_unwind_pc): Delete.
10761 (xstormy16_dummy_id): Delete.
10762 (xstormy16_gdbarch_init): Don't register deleted functions with
10763 gdbarch.
10764
541aad8a
AB
107652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10766
10767 * vax-tdep.c (vax_unwind_pc): Delete.
10768 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10769
29222070
AB
107702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10771
10772 * v850-tdep.c (v850_unwind_sp): Delete.
10773 (v850_unwind_pc): Delete.
10774 (v850_dummy_id): Delete.
10775 (v850_gdbarch_init): Don't register deleted functions with
10776 gdbarch.
10777
0f534d76
AB
107782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10779
10780 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10781 (tilegx_unwind_pc): Delete.
10782 (tilegx_unwind_dummy_id): Delete.
10783 (tilegx_gdbarch_init): Don't register deleted functions with
10784 gdbarch.
10785
1ba7b7f9
AB
107862019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10787
10788 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10789 (tic6x_dummy_id): Delete.
10790 (tic6x_gdbarch_init): Don't register deleted functions with
10791 gdbarch.
10792
d31f262c
AB
107932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10794
10795 * sparc-tdep.c (sparc_unwind_pc): Delete.
10796 (sparc32_gdbarch_init): Don't register deleted function with
10797 gdbarch.
10798
6d14d64d
AB
107992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10800
10801 * sh-tdep.c (sh_unwind_sp): Delete.
10802 (sh_unwind_pc): Delete.
10803 (sh_dummy_id): Delete.
10804 (sh_gdbarch_init): Don't register deleted functions with
10805 gdbarch.
10806
a40dde9d
AB
108072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10808
10809 * score-tdep.c (score_unwind_sp): Delete.
10810 (score_unwind_pc): Delete.
10811 (score_dummy_id): Delete.
10812 (score_gdbarch_init): Don't register deleted functions with
10813 gdbarch.
10814
47c47d69
AB
108152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10816
10817 * rx-tdep.c (rx_unwind_pc): Delete.
10818 (rx_unwind_sp): Delete.
10819 (rx_dummy_id): Delete.
10820 (rx_gdbarch_init): Don't register deleted functions with
10821 gdbarch. Update comment.
10822
833a4480
AB
108232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10824
10825 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10826 (rs6000_dummy_id): Delete.
10827 (rs6000_gdbarch_init): Don't register deleted functions with
10828 gdbarch.
10829
3f2cef49
AB
108302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10831
10832 * or1k-tdep.c (or1k_dummy_id): Delete.
10833 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10834
96acf884
AB
108352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10836
10837 * nios2-tdep.c (nios2_dummy_id): Delete.
10838 (nios2_unwind_sp): Delete.
10839 (nios2_gdbarch_init): Don't register deleted functions with
10840 gdbarch.
10841
ca0ab0aa
AB
108422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10843
10844 * nds32-tdep.c (nds32_dummy_id): Delete.
10845 (nds32_unwind_pc): Delete.
10846 (nds32_unwind_sp): Delete.
10847 (nds32_gdbarch_init): Don't register deleted functions with
10848 gdbarch.
10849
c8259044
AB
108502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10851
10852 * msp430-tdep.c (msp430_unwind_pc): Delete.
10853 (msp430_unwind_sp): Delete.
10854 (msp430_dummy_id): Delete.
10855 (msp430_gdbarch_init): Don't register deleted functions with
10856 gdbarch.
10857
27f113c8
AB
108582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10859
10860 * moxie-tdep.c (moxie_unwind_sp): Delete.
10861 (moxie_unwind_pc): Delete.
10862 (moxie_dummy_id): Delete.
10863 (moxie_gdbarch_init): Don't register deleted functions with
10864 gdbarch.
10865
aee6c3cd
AB
108662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10867
10868 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10869 (mn10300_unwind_pc): Delete.
10870 (mn10300_unwind_sp): Delete.
10871 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10872 mn10300_unwind_sp.
10873 (mn10300_frame_unwind_init): Don't register deleted functions with
10874 gdbarch.
10875
8e2b5aea
AB
108762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10877
10878 * mep-tdep.c (mep_unwind_pc): Delete.
10879 (mep_unwind_sp): Delete.
10880 (mep_dummy_id): Delete.
10881 (mep_gdbarch_init): Don't register deleted functions with
10882 gdbarch.
10883
43cf3ede
AB
108842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10885
10886 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10887 (m68hc11_unwind_sp): Delete.
10888 (m68hc11_gdbarch_init): Don't register deleted functions with
10889 gdbarch.
10890
5e79b7bb
AB
108912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10892
10893 * m32r-tdep.c (m32r_unwind_sp): Delete.
10894 (m32r_unwind_pc): Delete.
10895 (m32r_dummy_id): Delete.
10896 (m32r_gdbarch_init): Don't register deleted functions with
10897 gdbarch.
10898
89b268d8
AB
108992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10900
10901 * m32c-tdep.c (m32c_unwind_pc): Delete.
10902 (m32c_unwind_sp): Delete.
10903 (m32c_dummy_id): Delete.
10904 (m32c_gdbarch_init): Don't register deleted functions with
10905 gdbarch.
10906
946c28d2
AB
109072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10908
10909 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10910 (lm32_unwind_pc): Delete.
10911 (lm32_dummy_id): Delete.
10912 (lm32_gdbarch_init): Don't register deleted functions with
10913 gdbarch.
10914
bf12844a
AB
109152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10916
10917 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10918 (iq2000_unwind_pc): Delete.
10919 (iq2000_dummy_id): Delete.
10920 (iq2000_gdbarch_init): Don't register deleted functions with
10921 gdbarch.
10922
ecbc06d2
AB
109232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10924
10925 * nds32-tdep.c (nds32_type_align): Delete.
10926 (nds32_push_dummy_call): Use type_align instead.
10927
030197b4
AB
109282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10929
10930 * arm-tdep.c (arm_type_align): Only handle vector override case.
10931 (arm_push_dummy_call): Use type_align.
10932 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10933
b907456c
AB
109342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10935
10936 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10937 case.
10938 (pass_on_stack): Use type_align.
10939 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10940 function.
10941
9e97ba43
TT
109422019-04-23 Tom Tromey <tromey@adacore.com>
10943
10944 * dwarf2read.c (line_header::file_name_at): Remove unused
10945 overload.
10946
6892f601
TV
109472019-04-23 Tom de Vries <tdevries@suse.de>
10948
10949 PR gdb/24438
10950 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10951 invocation.
10952
336d760d
AT
10953
109542019-03-27 Ali Tamur <tamur@google.com>
10955
10956 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10957 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10958 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10959 (dwarf_expr_context::get_addr_index): Likewise
10960 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10961 (symbol_needs_eval_context::get_addr_index): Likewise
10962 (disassemble_dwarf_expression): Add DW_OP_addrx
10963 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10964 (read_cutu_die_from_dwo): Update comment
10965 (skip_one_die): Add DW_FORM_addrx
10966 (read_attribute_value): Likewise
10967 (var_decode_location): Add DW_OP_addrx
10968 (dwarf2_const_value_attr): Add DW_FORM_addrx
10969 (dump_die_shallow): Likewise
10970 (dwarf2_fetch_constant_bytes): Likewise
10971 (decode_locdesc): Add DW_OP_addrx
10972 (skip_form_bytes): Add DW_FORM_addrx
10973
ad9d13f8
AT
109742019-04-22 Ali Tamur <tamur@google.com>
10975
10976 * MAINTAINERS (Write After Approval): Add self.
10977
d70cc3ba
SM
109782019-04-22 Simon Marchi <simon.marchi@efficios.com>
10979
10980 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10981 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10982 (open_symbol_file_object): Likewise.
10983 (svr4_default_sos): Add info parameter.
10984 (svr4_read_so_list): Likewise.
10985 (svr4_current_sos_direct): Adjust functions calls to pass down
10986 info.
10987 (svr4_current_sos_1): Add info parameter.
10988 (svr4_current_sos): Call get_svr4_info, pass info down to
10989 svr4_current_sos_1.
10990 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10991 get_svr4_info.
10992 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10993 get_svr4_info.
10994 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10995 to get_svr4_info.
10996 (probes_table_remove_objfile_probes): Likewise.
10997 (register_solib_event_probe): Add info parameter.
10998 (solist_update_incremental): Pass info parameter down to
10999 svr4_read_so_list.
11000 (disable_probes_interface): Add info parameter.
11001 (svr4_handle_solib_event): Pass current_program_space to
11002 get_svr4_info. Adjust disable_probes_interface cleanup.
11003 (svr4_create_probe_breakpoints): Add info parameter, pass it
11004 down to register_solib_event_probe.
11005 (svr4_create_solib_event_breakpoints): Add info parameter,
11006 pass it down to svr4_create_probe_breakpoints.
11007 (enable_break): Pass info down to
11008 svr4_create_solib_event_breakpoints.
11009 (svr4_solib_create_inferior_hook): Pass current_program_space to
11010 get_svr4_info.
11011 (svr4_clear_solib): Likewise.
11012
7905fc35
PA
110132019-04-22 Pedro Alves <palves@redhat.com>
11014
11015 * solib-svr4.c (svr4_free_objfile_observer): New.
11016 (probe_and_action::objfile): New field.
11017 (probes_table_htab_remove_objfile_probes)
11018 (probes_table_remove_objfile_probes): New functions.
11019 (register_solib_event_probe): Add 'objfile' parameter. Store it
11020 in the new probe_and_action. Don't store the probe in 'lookup'.
11021 (svr4_create_probe_breakpoints): Pass objfile to
11022 register_solib_event_probe.
11023 (_initialize_svr4_solib): Register a free_objfile observer.
11024
fb881986
TT
110252019-04-19 Tom Tromey <tom@tromey.com>
11026
11027 * common/queue.h: Remove.
11028
8732db6c
TT
110292019-04-19 Tom Tromey <tom@tromey.com>
11030
11031 * event-loop.c: Don't include "common/queue.h".
11032
97dfbadd
TT
110332019-04-19 Tom Tromey <tom@tromey.com>
11034
11035 * remote.c (remote_target): Use delete.
11036 * remote-notif.h: Include <list>, not "common/queue.h".
11037 (notif_client_p): Remove typedef.
11038 (remote_notif_state): Add constructor, destructor, initializer.
11039 <notif_queue>: Now a std::list.
11040 (remote_notif_state_xfree): Don't declare.
11041 * remote-notif.c (remote_notif_process, handle_notification)
11042 (remote_notif_state_allocate): Update.
11043 (~remote_notif_state): Rename from remote_notif_state_xfree.
11044
cf250e36
TT
110452019-04-19 Tom Tromey <tom@tromey.com>
11046
11047 * symfile.c (reread_symbols): Update.
11048 * objfiles.c (objfile_register_static_link)
11049 (objfile_lookup_static_link): Update
11050 (~objfile) Don't delete static_links.
11051 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11052
61f4b350
TT
110532019-04-19 Tom Tromey <tom@tromey.com>
11054
11055 * type-stack.h (struct type_stack) <insert>: Constify string.
11056 * type-stack.c (type_stack::insert): Constify string.
11057 * gdbtypes.h (lookup_template_type): Update.
11058 (address_space_name_to_int): Update.
11059 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11060 const.
11061 (lookup_template_type): Make name const.
11062 * c-exp.y: Update rules.
11063 (lex_one_token, classify_name, classify_inner_name)
11064 (c_print_token): Update.
11065 * p-exp.y: Update rules.
11066 (yylex): Update.
11067 * f-exp.y: Update rules.
11068 (yylex): Update.
11069 * d-exp.y: Update rules.
11070 (lex_one_token, classify_name, classify_inner_name): Update.
11071 * parse.c (write_dollar_variable, copy_name): Return std::string.
11072 * parser-defs.h (copy_name): Change return type.
11073 * m2-exp.y: Update rules.
11074 (yylex): Update.
11075 * go-exp.y (lex_one_token): Update.
11076 Update rules.
11077 (classify_unsafe_function, classify_packaged_name)
11078 (classify_name, yylex): Update.
11079
189b8c2e
ST
110802019-04-19 Sergei Trofimovich <siarheit@google.com>
11081
11082 * configure.ac: add --enable-source-highlight switch.
11083 * configure: Regenerate.
11084 * top.c (print_gdb_version): plumb --enable-source-highlight
11085 status to "show configuration".
11086
8ecb59f8
TT
110872019-04-19 Tom Tromey <tromey@adacore.com>
11088
11089 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11090 Check ADA_TYPE_P.
11091 (empty_record, ada_template_to_fixed_record_type_1)
11092 (template_to_static_fixed_type)
11093 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11094 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11095 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11096 macros.
11097
62160ec9
TT
110982019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11099
11100 PR symtab/24423:
11101 * source.c (print_source_lines_base): Advance "iter" when a
11102 control character is seen.
11103
f2ae8bc8
PW
111042019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11105
11106 * inferior.h (struct infcall_suspend_state_deleter):
11107 Catch exception in destructor to avoid crash.
11108
d563b953
PW
111092019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11110
11111 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11112 close to the add_com "shell".
11113
dc34c897
TT
111142019-04-18 Tom Tromey <tromey@adacore.com>
11115
11116 * process-stratum-target.h (class process_stratum_target)
11117 <stratum>: Add "final".
11118
a12e5744
TT
111192019-04-17 Tom Tromey <tromey@adacore.com>
11120
11121 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11122 against nullptr before use.
11123
a7e559cc
AH
111242019-04-17 Alan Hayward <alan.hayward@arm.com>
11125
11126 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11127
c01660c6
AB
111282019-04-17 Jim Wilson <jimw@sifive.com>
11129 Andrew Burgess <andrew.burgess@embecosm.com>
11130
11131 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11132 code read might fail, assume 4-byte breakpoint in that case.
11133
4aa866af
LS
111342019-04-15 Leszek Swirski <leszeks@google.com>
11135
11136 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11137 rather than a hand-rolled POD check when checking for forced MEMORY
11138 classification.
11139
48574d91
AH
111402019-04-15 Alan Hayward <alan.hayward@arm.com>
11141
11142 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11143 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11144 function.
11145 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11146 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11147 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11148 declaration.
11149
4da037ef
AH
111502019-04-15 Alan Hayward <alan.hayward@arm.com>
11151
11152 * aarch64-linux-nat.c
11153 (aarch64_linux_nat_target::thread_architecture): Add override.
11154 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11155 each VQ.
11156
ccb8d7e8
AH
111572019-04-15 Alan Hayward <alan.hayward@arm.com>
11158
11159 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11160
35add35e
AB
111612019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11162
11163 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11164 target types of size 96-bits, add some additional comments, and
11165 check that the builtin type we found was the correct size.
11166
51196bbc
EZ
111672019-04-12 Eli Zaretskii <eliz@gnu.org>
11168
11169 * utils.c (prompt_for_continue): Don't restore the styling at the
11170 end, as applied_style has the wrong value. This fixes styling in
11171 long lists of file names that are interrupted by the "Continue?"
11172 prompt.
11173
62253a61
AB
111742019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11175
11176 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11177 * c-lang.c (c_language_defn): Likewise.
11178 (cplus_language_defn): Likewise.
11179 (asm_language_defn): Likewise.
11180 (minimal_language_defn): Likewise.
11181 * d-lang.c (d_language_defn): Likewise.
11182 * f-lang.c (f_language_defn): Likewise.
11183 * go-lang.c (go_language_defn): Likewise.
11184 * language.c (unknown_language_defn): Likewise.
11185 (auto_language_defn): Likewise.
11186 * language.h (struct language_defn): Remove la_magic field.
11187 (LANG_MAGIC): Delete.
11188 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11189 * objc-lang.c (objc_language_defn): Likewise.
11190 * opencl-lang.c (opencl_language_defn): Likewise.
11191 * p-lang.c (pascal_language_defn): Likewise.
11192 * rust-lang.c (rust_language_defn): Likewise.
11193
a9158a86
AB
111942019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11195
11196 * riscv-tdep.c (riscv_type_align): New function.
11197 (riscv_type_alignment): Delete.
11198 (riscv_arg_location): Use 'type_align'.
11199 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11200
41077b66
AB
112012019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11202
11203 * gdbtypes.c (type_align): A struct with no non-static fields also
11204 has alignment of 1.
11205
9f0272f8
AB
112062019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11207
11208 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11209 component to 0.
11210 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11211 member.
11212 (riscv_struct_info::analyse): New implementation using new
11213 analyse_inner member function.
11214 (riscv_struct_info::field_offset): New member function.
11215 (riscv_struct_info::m_offsets): New member variable.
11216 (riscv_struct_info::analyse_inner): New private member function,
11217 takes the old implementation of riscv_struct_info::analyse but
11218 extended to track field offsets.
11219 (riscv_call_arg_struct): Update the struct folding special cases
11220 to handle cases where empty C++ structs, which are non-zero
11221 length, are found.
11222 (riscv_arg_location): Initialise the length of each location, a
11223 non-zero length now indicates the location is in use.
11224 (riscv_push_dummy_call): Allow for the first location having a
11225 non-zero offset when setting up arguments.
11226 (riscv_return_value): Likewise, but for return values.
11227
02cf60c7
TT
112282019-04-11 Tom Tromey <tromey@adacore.com>
11229
11230 * utils.c (internal_vproblem): Make "msg" const.
11231
68811f8f
AH
112322019-04-11 Alan Hayward <alan.hayward@arm.com>
11233
11234 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11235 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11236 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11237 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11238
3f52fdbc
KB
112392019-04-10 Kevin Buettner <kevinb@redhat.com>
11240
11241 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11242 function.
11243 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11244 of amd64_collect_native_gregset.
11245 (amd64_linux_nat_target::store_registers): Likewise.
11246
e9ad22ee
TT
112472019-04-10 Tom Tromey <tom@tromey.com>
11248
11249 * symtab.c (lookup_global_symbol_from_objfile)
11250 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11251 * objfiles.h (class separate_debug_iterator): New.
11252 (class separate_debug_range): New.
11253 (struct objfile) <separate_debug_objfiles>: New method.
11254 (objfile_separate_debug_iterate): Don't declare.
11255 * objfiles.c (separate_debug_iterator::operator++): Rename from
11256 objfile_separate_debug_iterate.
11257 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11258 iterator.
11259 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11260 iterator.
11261
ee371134
TT
112622019-04-10 Tom Tromey <tom@tromey.com>
11263
11264 * symfile.c (reread_symbols): Remove old comment.
11265 * objfiles.c (free_all_objfiles): Fix a typo.
11266
bf227d61
TT
112672019-04-10 Tom Tromey <tom@tromey.com>
11268
11269 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11270 * minsyms.c (lookup_minimal_symbol): Use foreach.
11271 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11272 (lookup_minimal_symbol_solib_trampoline): Likewise.
11273 * symfile.c (reread_symbols): Use foreach.
11274
8dc433a0
TT
112752019-04-09 Ivan Begert <ivanbegert@gmail.com>
11276 Tom Tromey <tromey@adacore.com>
11277
11278 PR rust/24414:
11279 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11280 (rust_lex_int_test): Change "value" to be LONGEST.
11281 (rust_lex_tests): Add test for long integer literal.
11282
9ab8741a
TT
112832019-04-09 Tom Tromey <tromey@adacore.com>
11284
11285 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11286 to bool.
11287 (extended_remote_target::attach): Update.
11288 (remote_target::remote_notice_new_inferior): Update.
11289 (remote_target::add_current_inferior_and_thread): Update.
11290 * inferior.c (exit_inferior_1): Use "false".
11291 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11292
e242fd12
SM
112932019-04-09 Simon Marchi <simon.marchi@efficios.com>
11294
9ca1957f 11295 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11296 the "start" command.
11297
2b0c8b01
KB
112982019-04-08 Kevin Buettner <kevinb@redhat.com>
11299
11300 * python/py-inferior.c (infpy_thread_from_thread_handle):
11301 Adjust comments to reflect renaming of thread_from_thread_handle
11302 to thread_from_handle. Adjust keywords. Fix type error message.
11303 (inferior_object_methods): Add thread_from_handle. Retain
11304 thread_from_thread_handle, but mark it as deprecated.
11305
50a82723
KB
113062019-04-08 Kevin Buettner <kevinb@redhat.com>
11307
11308 * gdbthread.h (find_thread_by_handle): Revise declaration.
11309 * thread.c (find_thread_by_handle): Likewise. Adjust
11310 implementation too.
11311 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11312 support for buffer objects as handles.
11313
cf63b016
KB
113142019-04-08 Kevin Buettner <kevinb@redhat.com>
11315
11316 * python/py-infthread.c (thpy_thread_handle): New function.
11317 (thread_object_methods): Register thpy_thread_handle.
11318
3d6c6204
KB
113192019-04-08 Kevin Buettner <kevinb@redhat.com>
11320
11321 * gdbthread.h (thread_to_thread_handle): Declare.
11322 * thread.c (gdbtypes.h): Include.
11323 (thread_to_thread_handle): New function.
11324
11325 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11326 (target_thread_info_to_thread_handle): Declare.
11327 * target.c (target_thread_info_to_thread_handle): New function.
11328 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11329 * target-delegates.c: Regenerate.
11330
11331 * linux-thread-db.c (class thread_db_target): Add method
11332 thread_info_to_thread_handle.
11333 (thread_db_target::thread_info_to_thread_handle): Define.
11334 * remote.c (class remote_target): Add new method
11335 thread_info_to_thread_handle.
11336 (remote_target::thread_info_to_thread_handle): Define.
11337
56be6ea8
PA
113382019-04-08 Pedro Alves <palves@redhat.com>
11339
11340 * common/common-exceptions.c (throw_exception): Don't create
11341 named object to throw; throw directly.
11342 (throw_it): Likewise. Don't initialize gdb_exception::message
11343 here, with new; pass FMT and AP to the ctor instead.
11344 * common/common-exceptions.h: Include <string>.
11345 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11346 const char *, va_list)): New ctor. Use std::make_shared.
11347 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11348 errors)): Delete.
11349 (gdb_exception_error::gdb_exception_error(enum errors, const char
11350 *, va_list)): New.
11351 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11352 Add assertion.
11353 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11354 errors)): Delete.
11355 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11356 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11357 Add assertion.
11358
eedc3f4f
TT
113592019-04-08 Tom Tromey <tom@tromey.com>
11360
11361 * valops.c (value_rtti_indirect_type): Replace throw_exception
11362 with throw.
11363 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11364 with throw.
11365 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11366 throw.
11367 * target.c (target_translate_tls_address): Replace throw_exception
11368 with throw.
11369 * stack.c (frame_apply_command_count): Replace throw_exception
11370 with throw.
11371 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11372 throw.
11373 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11374 with throw.
11375 * rs6000-tdep.c (rs6000_frame_cache)
11376 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11377 * remote.c: Replace throw_exception with throw.
11378 * record-full.c (record_full_message, record_full_wait_1)
11379 (record_full_restore): Replace throw_exception with throw.
11380 * record-btrace.c:
11381 (get_thread_current_frame_id, record_btrace_start_replaying)
11382 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11383 (cmd_record_btrace_start): Replace throw_exception with throw.
11384 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11385 throw.
11386 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11387 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11388 * linespec.c:
11389 (find_linespec_symbols): Replace throw_exception with throw.
11390 * infrun.c (displaced_step_prepare, resume): Replace
11391 throw_exception with throw.
11392 * infcmd.c (post_create_inferior): Replace throw_exception with
11393 throw.
11394 * inf-loop.c (inferior_event_handler): Replace throw_exception
11395 with throw.
11396 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11397 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11398 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11399 (get_prev_frame_always, get_frame_pc_if_available)
11400 (get_frame_address_in_block_if_available, get_frame_language):
11401 Replace throw_exception with throw.
11402 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11403 throw_exception with throw.
11404 * eval.c (fetch_subexp_value, evaluate_var_value)
11405 (evaluate_funcall, evaluate_subexp_standard): Replace
11406 throw_exception with throw.
11407 * dwarf2loc.c (call_site_find_chain)
11408 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11409 Replace throw_exception with throw.
11410 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11411 with throw.
11412 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11413 throw.
11414 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11415 * completer.c (complete_line_internal): Replace throw_exception
11416 with throw.
11417 * compile/compile-object-run.c (compile_object_run): Replace
11418 throw_exception with throw.
11419 * cli/cli-script.c (process_next_line): Replace throw_exception
11420 with throw.
11421 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11422 (btrace_enable, btrace_maint_update_pt_packets): Replace
11423 throw_exception with throw.
11424 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11425 throw_exception with throw.
11426 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11427 throw_exception with throw.
11428 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11429 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11430 * aarch64-tdep.c (aarch64_make_prologue_cache)
11431 (aarch64_make_stub_cache): Replace throw_exception with throw.
11432
26003a20
TT
114332019-04-08 Tom Tromey <tom@tromey.com>
11434
11435 * common/common-exceptions.c (throw_exception): Rename from
11436 throw_exception_cxx. Remove old copy. Make argument const.
11437 (throw_it): Create and throw exception objects directly.
11438 * common/common-exceptions.h (throw_exception): Make argument
11439 const.
11440 (struct gdb_exception_error): Add constructor.
11441 (struct gdb_exception_quit): Add constructor.
11442
d272eb37
TT
114432019-04-08 Tom Tromey <tom@tromey.com>
11444
11445 * common/common-exceptions.h (exception_rethrow): Don't declare.
11446 (TRY_SJLJ): Update comment.
11447 (TRY, CATCH, END_CATCH): Remove.
11448 * common/common-exceptions.c (exception_rethrow): Remove.
11449
230d2906
TT
114502019-04-08 Tom Tromey <tom@tromey.com>
11451
11452 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11453 Remove.
11454 (gdb_exception_error): Rename from
11455 gdb_exception_RETURN_MASK_ERROR.
11456 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11457 (gdb_quit_bad_alloc): Update.
11458 * aarch64-tdep.c: Update.
11459 * ada-lang.c: Update.
11460 * ada-typeprint.c: Update.
11461 * ada-valprint.c: Update.
11462 * amd64-tdep.c: Update.
11463 * arch-utils.c: Update.
11464 * break-catch-throw.c: Update.
11465 * breakpoint.c: Update.
11466 * btrace.c: Update.
11467 * c-varobj.c: Update.
11468 * cli/cli-cmds.c: Update.
11469 * cli/cli-interp.c: Update.
11470 * cli/cli-script.c: Update.
11471 * common/common-exceptions.c: Update.
11472 * common/new-op.c: Update.
11473 * common/selftest.c: Update.
11474 * compile/compile-c-symbols.c: Update.
11475 * compile/compile-cplus-symbols.c: Update.
11476 * compile/compile-object-load.c: Update.
11477 * compile/compile-object-run.c: Update.
11478 * completer.c: Update.
11479 * corelow.c: Update.
11480 * cp-abi.c: Update.
11481 * cp-support.c: Update.
11482 * cp-valprint.c: Update.
11483 * darwin-nat.c: Update.
11484 * disasm-selftests.c: Update.
11485 * dtrace-probe.c: Update.
11486 * dwarf-index-cache.c: Update.
11487 * dwarf-index-write.c: Update.
11488 * dwarf2-frame-tailcall.c: Update.
11489 * dwarf2-frame.c: Update.
11490 * dwarf2loc.c: Update.
11491 * dwarf2read.c: Update.
11492 * eval.c: Update.
11493 * event-loop.c: Update.
11494 * event-top.c: Update.
11495 * exec.c: Update.
11496 * f-valprint.c: Update.
11497 * fbsd-tdep.c: Update.
11498 * frame-unwind.c: Update.
11499 * frame.c: Update.
11500 * gdbtypes.c: Update.
11501 * gnu-v3-abi.c: Update.
11502 * guile/guile-internal.h: Update.
11503 * guile/scm-block.c: Update.
11504 * guile/scm-breakpoint.c: Update.
11505 * guile/scm-cmd.c: Update.
11506 * guile/scm-disasm.c: Update.
11507 * guile/scm-frame.c: Update.
11508 * guile/scm-lazy-string.c: Update.
11509 * guile/scm-math.c: Update.
11510 * guile/scm-param.c: Update.
11511 * guile/scm-ports.c: Update.
11512 * guile/scm-pretty-print.c: Update.
11513 * guile/scm-symbol.c: Update.
11514 * guile/scm-symtab.c: Update.
11515 * guile/scm-type.c: Update.
11516 * guile/scm-value.c: Update.
11517 * i386-linux-tdep.c: Update.
11518 * i386-tdep.c: Update.
11519 * inf-loop.c: Update.
11520 * infcall.c: Update.
11521 * infcmd.c: Update.
11522 * infrun.c: Update.
11523 * jit.c: Update.
11524 * language.c: Update.
11525 * linespec.c: Update.
11526 * linux-fork.c: Update.
11527 * linux-nat.c: Update.
11528 * linux-tdep.c: Update.
11529 * linux-thread-db.c: Update.
11530 * main.c: Update.
11531 * mi/mi-cmd-break.c: Update.
11532 * mi/mi-cmd-stack.c: Update.
11533 * mi/mi-interp.c: Update.
11534 * mi/mi-main.c: Update.
11535 * objc-lang.c: Update.
11536 * p-valprint.c: Update.
11537 * parse.c: Update.
11538 * ppc-linux-tdep.c: Update.
11539 * printcmd.c: Update.
11540 * python/py-arch.c: Update.
11541 * python/py-breakpoint.c: Update.
11542 * python/py-cmd.c: Update.
11543 * python/py-finishbreakpoint.c: Update.
11544 * python/py-frame.c: Update.
11545 * python/py-framefilter.c: Update.
11546 * python/py-gdb-readline.c: Update.
11547 * python/py-inferior.c: Update.
11548 * python/py-infthread.c: Update.
11549 * python/py-lazy-string.c: Update.
11550 * python/py-linetable.c: Update.
11551 * python/py-objfile.c: Update.
11552 * python/py-param.c: Update.
11553 * python/py-prettyprint.c: Update.
11554 * python/py-progspace.c: Update.
11555 * python/py-record-btrace.c: Update.
11556 * python/py-record.c: Update.
11557 * python/py-symbol.c: Update.
11558 * python/py-type.c: Update.
11559 * python/py-unwind.c: Update.
11560 * python/py-utils.c: Update.
11561 * python/py-value.c: Update.
11562 * python/python.c: Update.
11563 * record-btrace.c: Update.
11564 * record-full.c: Update.
11565 * remote-fileio.c: Update.
11566 * remote.c: Update.
11567 * riscv-tdep.c: Update.
11568 * rs6000-aix-tdep.c: Update.
11569 * rs6000-tdep.c: Update.
11570 * rust-exp.y: Update.
11571 * rust-lang.c: Update.
11572 * s390-tdep.c: Update.
11573 * selftest-arch.c: Update.
11574 * solib-dsbt.c: Update.
11575 * solib-frv.c: Update.
11576 * solib-spu.c: Update.
11577 * solib-svr4.c: Update.
11578 * solib.c: Update.
11579 * sparc64-linux-tdep.c: Update.
11580 * stack.c: Update.
11581 * symfile-mem.c: Update.
11582 * symmisc.c: Update.
11583 * target.c: Update.
11584 * thread.c: Update.
11585 * top.c: Update.
11586 * tracefile-tfile.c: Update.
11587 * tui/tui.c: Update.
11588 * typeprint.c: Update.
11589 * unittests/cli-utils-selftests.c: Update.
11590 * unittests/parse-connection-spec-selftests.c: Update.
11591 * valops.c: Update.
11592 * valprint.c: Update.
11593 * value.c: Update.
11594 * varobj.c: Update.
11595 * windows-nat.c: Update.
11596 * x86-linux-nat.c: Update.
11597 * xml-support.c: Update.
11598
a70b8144
TT
115992019-04-08 Tom Tromey <tom@tromey.com>
11600
11601 * xml-support.c: Use C++ exception handling.
11602 * x86-linux-nat.c: Use C++ exception handling.
11603 * windows-nat.c: Use C++ exception handling.
11604 * varobj.c: Use C++ exception handling.
11605 * value.c: Use C++ exception handling.
11606 * valprint.c: Use C++ exception handling.
11607 * valops.c: Use C++ exception handling.
11608 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11609 handling.
11610 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11611 * typeprint.c: Use C++ exception handling.
11612 * tui/tui.c: Use C++ exception handling.
11613 * tracefile-tfile.c: Use C++ exception handling.
11614 * top.c: Use C++ exception handling.
11615 * thread.c: Use C++ exception handling.
11616 * target.c: Use C++ exception handling.
11617 * symmisc.c: Use C++ exception handling.
11618 * symfile-mem.c: Use C++ exception handling.
11619 * stack.c: Use C++ exception handling.
11620 * sparc64-linux-tdep.c: Use C++ exception handling.
11621 * solib.c: Use C++ exception handling.
11622 * solib-svr4.c: Use C++ exception handling.
11623 * solib-spu.c: Use C++ exception handling.
11624 * solib-frv.c: Use C++ exception handling.
11625 * solib-dsbt.c: Use C++ exception handling.
11626 * selftest-arch.c: Use C++ exception handling.
11627 * s390-tdep.c: Use C++ exception handling.
11628 * rust-lang.c: Use C++ exception handling.
11629 * rust-exp.y: Use C++ exception handling.
11630 * rs6000-tdep.c: Use C++ exception handling.
11631 * rs6000-aix-tdep.c: Use C++ exception handling.
11632 * riscv-tdep.c: Use C++ exception handling.
11633 * remote.c: Use C++ exception handling.
11634 * remote-fileio.c: Use C++ exception handling.
11635 * record-full.c: Use C++ exception handling.
11636 * record-btrace.c: Use C++ exception handling.
11637 * python/python.c: Use C++ exception handling.
11638 * python/py-value.c: Use C++ exception handling.
11639 * python/py-utils.c: Use C++ exception handling.
11640 * python/py-unwind.c: Use C++ exception handling.
11641 * python/py-type.c: Use C++ exception handling.
11642 * python/py-symbol.c: Use C++ exception handling.
11643 * python/py-record.c: Use C++ exception handling.
11644 * python/py-record-btrace.c: Use C++ exception handling.
11645 * python/py-progspace.c: Use C++ exception handling.
11646 * python/py-prettyprint.c: Use C++ exception handling.
11647 * python/py-param.c: Use C++ exception handling.
11648 * python/py-objfile.c: Use C++ exception handling.
11649 * python/py-linetable.c: Use C++ exception handling.
11650 * python/py-lazy-string.c: Use C++ exception handling.
11651 * python/py-infthread.c: Use C++ exception handling.
11652 * python/py-inferior.c: Use C++ exception handling.
11653 * python/py-gdb-readline.c: Use C++ exception handling.
11654 * python/py-framefilter.c: Use C++ exception handling.
11655 * python/py-frame.c: Use C++ exception handling.
11656 * python/py-finishbreakpoint.c: Use C++ exception handling.
11657 * python/py-cmd.c: Use C++ exception handling.
11658 * python/py-breakpoint.c: Use C++ exception handling.
11659 * python/py-arch.c: Use C++ exception handling.
11660 * printcmd.c: Use C++ exception handling.
11661 * ppc-linux-tdep.c: Use C++ exception handling.
11662 * parse.c: Use C++ exception handling.
11663 * p-valprint.c: Use C++ exception handling.
11664 * objc-lang.c: Use C++ exception handling.
11665 * mi/mi-main.c: Use C++ exception handling.
11666 * mi/mi-interp.c: Use C++ exception handling.
11667 * mi/mi-cmd-stack.c: Use C++ exception handling.
11668 * mi/mi-cmd-break.c: Use C++ exception handling.
11669 * main.c: Use C++ exception handling.
11670 * linux-thread-db.c: Use C++ exception handling.
11671 * linux-tdep.c: Use C++ exception handling.
11672 * linux-nat.c: Use C++ exception handling.
11673 * linux-fork.c: Use C++ exception handling.
11674 * linespec.c: Use C++ exception handling.
11675 * language.c: Use C++ exception handling.
11676 * jit.c: Use C++ exception handling.
11677 * infrun.c: Use C++ exception handling.
11678 * infcmd.c: Use C++ exception handling.
11679 * infcall.c: Use C++ exception handling.
11680 * inf-loop.c: Use C++ exception handling.
11681 * i386-tdep.c: Use C++ exception handling.
11682 * i386-linux-tdep.c: Use C++ exception handling.
11683 * guile/scm-value.c: Use C++ exception handling.
11684 * guile/scm-type.c: Use C++ exception handling.
11685 * guile/scm-symtab.c: Use C++ exception handling.
11686 * guile/scm-symbol.c: Use C++ exception handling.
11687 * guile/scm-pretty-print.c: Use C++ exception handling.
11688 * guile/scm-ports.c: Use C++ exception handling.
11689 * guile/scm-param.c: Use C++ exception handling.
11690 * guile/scm-math.c: Use C++ exception handling.
11691 * guile/scm-lazy-string.c: Use C++ exception handling.
11692 * guile/scm-frame.c: Use C++ exception handling.
11693 * guile/scm-disasm.c: Use C++ exception handling.
11694 * guile/scm-cmd.c: Use C++ exception handling.
11695 * guile/scm-breakpoint.c: Use C++ exception handling.
11696 * guile/scm-block.c: Use C++ exception handling.
11697 * guile/guile-internal.h: Use C++ exception handling.
11698 * gnu-v3-abi.c: Use C++ exception handling.
11699 * gdbtypes.c: Use C++ exception handling.
11700 * frame.c: Use C++ exception handling.
11701 * frame-unwind.c: Use C++ exception handling.
11702 * fbsd-tdep.c: Use C++ exception handling.
11703 * f-valprint.c: Use C++ exception handling.
11704 * exec.c: Use C++ exception handling.
11705 * event-top.c: Use C++ exception handling.
11706 * event-loop.c: Use C++ exception handling.
11707 * eval.c: Use C++ exception handling.
11708 * dwarf2read.c: Use C++ exception handling.
11709 * dwarf2loc.c: Use C++ exception handling.
11710 * dwarf2-frame.c: Use C++ exception handling.
11711 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11712 * dwarf-index-write.c: Use C++ exception handling.
11713 * dwarf-index-cache.c: Use C++ exception handling.
11714 * dtrace-probe.c: Use C++ exception handling.
11715 * disasm-selftests.c: Use C++ exception handling.
11716 * darwin-nat.c: Use C++ exception handling.
11717 * cp-valprint.c: Use C++ exception handling.
11718 * cp-support.c: Use C++ exception handling.
11719 * cp-abi.c: Use C++ exception handling.
11720 * corelow.c: Use C++ exception handling.
11721 * completer.c: Use C++ exception handling.
11722 * compile/compile-object-run.c: Use C++ exception handling.
11723 * compile/compile-object-load.c: Use C++ exception handling.
11724 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11725 * compile/compile-c-symbols.c: Use C++ exception handling.
11726 * common/selftest.c: Use C++ exception handling.
11727 * common/new-op.c: Use C++ exception handling.
11728 * cli/cli-script.c: Use C++ exception handling.
11729 * cli/cli-interp.c: Use C++ exception handling.
11730 * cli/cli-cmds.c: Use C++ exception handling.
11731 * c-varobj.c: Use C++ exception handling.
11732 * btrace.c: Use C++ exception handling.
11733 * breakpoint.c: Use C++ exception handling.
11734 * break-catch-throw.c: Use C++ exception handling.
11735 * arch-utils.c: Use C++ exception handling.
11736 * amd64-tdep.c: Use C++ exception handling.
11737 * ada-valprint.c: Use C++ exception handling.
11738 * ada-typeprint.c: Use C++ exception handling.
11739 * ada-lang.c: Use C++ exception handling.
11740 * aarch64-tdep.c: Use C++ exception handling.
11741
3d6e9d23
TT
117422019-04-08 Tom Tromey <tom@tromey.com>
11743
11744 * xml-support.c (gdb_xml_parser::parse): Update.
11745 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11746 * value.c (show_convenience): Update.
11747 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11748 (test_parse_flags_qcs): Update.
11749 * thread.c (thr_try_catch_cmd): Update.
11750 * target.c (target_translate_tls_address): Update.
11751 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11752 (info_frame_command_core, frame_apply_command_count): Update.
11753 * rust-exp.y (rust_lex_exception_test): Update.
11754 * riscv-tdep.c (riscv_print_one_register_info): Update.
11755 * remote.c (remote_target::enable_btrace): Update.
11756 * record-btrace.c (record_btrace_enable_warn): Update.
11757 * python/py-utils.c (gdbpy_convert_exception): Update.
11758 * printcmd.c (do_one_display, print_variable_and_value): Update.
11759 * mi/mi-main.c (mi_print_exception): Update.
11760 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11761 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11762 * linux-nat.c (linux_nat_target::attach): Update.
11763 * linux-fork.c (class scoped_switch_fork_info): Update.
11764 * infrun.c (displaced_step_prepare): Update.
11765 * infcall.c (call_function_by_hand_dummy): Update.
11766 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11767 * gnu-v3-abi.c (print_one_vtable): Update.
11768 * frame.c (get_prev_frame_always): Update.
11769 * f-valprint.c (info_common_command_for_block): Update.
11770 * exec.c (try_open_exec_file): Update.
11771 * exceptions.c (print_exception, exception_print)
11772 (exception_fprintf, exception_print_same): Update.
11773 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11774 * dwarf-index-cache.c (index_cache::store)
11775 (index_cache::lookup_gdb_index): Update.
11776 * darwin-nat.c (maybe_cache_shell): Update.
11777 * cp-valprint.c (cp_print_value_fields): Update.
11778 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11779 (gcc_cplus_symbol_address): Update.
11780 * compile/compile-c-symbols.c (gcc_convert_symbol)
11781 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11782 * common/selftest.c: Update.
11783 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11784 a std::string.
11785 (exception_try_scope_entry, exception_try_scope_exit): Don't
11786 declare.
11787 (struct exception_try_scope): Remove.
11788 (TRY): Don't use exception_try_scope.
11789 (struct gdb_exception): Add constructor, operator=.
11790 <what>: New method.
11791 (struct gdb_exception_RETURN_MASK_ALL)
11792 (struct gdb_exception_RETURN_MASK_ERROR)
11793 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11794 (struct gdb_quit_bad_alloc): Update.
11795 * common/common-exceptions.c (exception_none): Change
11796 initializer.
11797 (struct catcher) <state, exception>: Initialize inline.
11798 <prev>: Remove member.
11799 (current_catcher): Remove.
11800 (catchers): New global.
11801 (exceptions_state_mc_init): Simplify.
11802 (catcher_pop): Remove.
11803 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11804 (try_scope_depth, exception_try_scope_entry)
11805 (exception_try_scope_exit): Remove.
11806 (throw_exception_sjlj): Update.
11807 (exception_messages, exception_messages_size): Remove.
11808 (throw_it): Simplify.
11809 (gdb_exception_sliced_copy): Remove.
11810 (throw_exception_cxx): Update.
11811 * cli/cli-script.c (script_from_file): Update.
11812 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11813 Update.
11814 * ada-valprint.c (ada_val_print): Update.
11815 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11816 (create_excep_cond_exprs): Update.
11817
c5c10118
TT
118182019-04-08 Tom Tromey <tom@tromey.com>
11819
11820 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11821 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11822 (TRY, CATCH, END_CATCH): Remove some definitions.
11823 * common/common-exceptions.c: Don't use GDB_XCPT.
11824 (catcher_list_size): Remove.
11825 (throw_exception, throw_it): Simplify.
11826
4de283e4
TT
118272019-04-05 Tom Tromey <tom@tromey.com>
11828
11829 Revert the header-sorting patch.
11830 * ft32-tdep.c: Revert.
11831 * frv-tdep.c: Revert.
11832 * frv-linux-tdep.c: Revert.
11833 * frame.c: Revert.
11834 * frame-unwind.c: Revert.
11835 * frame-base.c: Revert.
11836 * fork-child.c: Revert.
11837 * findvar.c: Revert.
11838 * findcmd.c: Revert.
11839 * filesystem.c: Revert.
11840 * filename-seen-cache.h: Revert.
11841 * filename-seen-cache.c: Revert.
11842 * fbsd-tdep.c: Revert.
11843 * fbsd-nat.h: Revert.
11844 * fbsd-nat.c: Revert.
11845 * f-valprint.c: Revert.
11846 * f-typeprint.c: Revert.
11847 * f-lang.c: Revert.
11848 * extension.h: Revert.
11849 * extension.c: Revert.
11850 * extension-priv.h: Revert.
11851 * expprint.c: Revert.
11852 * exec.h: Revert.
11853 * exec.c: Revert.
11854 * exceptions.c: Revert.
11855 * event-top.c: Revert.
11856 * event-loop.c: Revert.
11857 * eval.c: Revert.
11858 * elfread.c: Revert.
11859 * dwarf2read.h: Revert.
11860 * dwarf2read.c: Revert.
11861 * dwarf2loc.c: Revert.
11862 * dwarf2expr.h: Revert.
11863 * dwarf2expr.c: Revert.
11864 * dwarf2-frame.c: Revert.
11865 * dwarf2-frame-tailcall.c: Revert.
11866 * dwarf-index-write.h: Revert.
11867 * dwarf-index-write.c: Revert.
11868 * dwarf-index-common.c: Revert.
11869 * dwarf-index-cache.h: Revert.
11870 * dwarf-index-cache.c: Revert.
11871 * dummy-frame.c: Revert.
11872 * dtrace-probe.c: Revert.
11873 * disasm.h: Revert.
11874 * disasm.c: Revert.
11875 * disasm-selftests.c: Revert.
11876 * dictionary.c: Revert.
11877 * dicos-tdep.c: Revert.
11878 * demangle.c: Revert.
11879 * dcache.h: Revert.
11880 * dcache.c: Revert.
11881 * darwin-nat.h: Revert.
11882 * darwin-nat.c: Revert.
11883 * darwin-nat-info.c: Revert.
11884 * d-valprint.c: Revert.
11885 * d-namespace.c: Revert.
11886 * d-lang.c: Revert.
11887 * ctf.c: Revert.
11888 * csky-tdep.c: Revert.
11889 * csky-linux-tdep.c: Revert.
11890 * cris-tdep.c: Revert.
11891 * cris-linux-tdep.c: Revert.
11892 * cp-valprint.c: Revert.
11893 * cp-support.c: Revert.
11894 * cp-namespace.c: Revert.
11895 * cp-abi.c: Revert.
11896 * corelow.c: Revert.
11897 * corefile.c: Revert.
11898 * continuations.c: Revert.
11899 * completer.h: Revert.
11900 * completer.c: Revert.
11901 * complaints.c: Revert.
11902 * coffread.c: Revert.
11903 * coff-pe-read.c: Revert.
11904 * cli-out.h: Revert.
11905 * cli-out.c: Revert.
11906 * charset.c: Revert.
11907 * c-varobj.c: Revert.
11908 * c-valprint.c: Revert.
11909 * c-typeprint.c: Revert.
11910 * c-lang.c: Revert.
11911 * buildsym.c: Revert.
11912 * buildsym-legacy.c: Revert.
11913 * build-id.h: Revert.
11914 * build-id.c: Revert.
11915 * btrace.c: Revert.
11916 * bsd-uthread.c: Revert.
11917 * breakpoint.h: Revert.
11918 * breakpoint.c: Revert.
11919 * break-catch-throw.c: Revert.
11920 * break-catch-syscall.c: Revert.
11921 * break-catch-sig.c: Revert.
11922 * blockframe.c: Revert.
11923 * block.c: Revert.
11924 * bfin-tdep.c: Revert.
11925 * bfin-linux-tdep.c: Revert.
11926 * bfd-target.c: Revert.
11927 * bcache.c: Revert.
11928 * ax-general.c: Revert.
11929 * ax-gdb.h: Revert.
11930 * ax-gdb.c: Revert.
11931 * avr-tdep.c: Revert.
11932 * auxv.c: Revert.
11933 * auto-load.c: Revert.
11934 * arm-wince-tdep.c: Revert.
11935 * arm-tdep.c: Revert.
11936 * arm-symbian-tdep.c: Revert.
11937 * arm-pikeos-tdep.c: Revert.
11938 * arm-obsd-tdep.c: Revert.
11939 * arm-nbsd-tdep.c: Revert.
11940 * arm-nbsd-nat.c: Revert.
11941 * arm-linux-tdep.c: Revert.
11942 * arm-linux-nat.c: Revert.
11943 * arm-fbsd-tdep.c: Revert.
11944 * arm-fbsd-nat.c: Revert.
11945 * arm-bsd-tdep.c: Revert.
11946 * arch-utils.c: Revert.
11947 * arc-tdep.c: Revert.
11948 * arc-newlib-tdep.c: Revert.
11949 * annotate.h: Revert.
11950 * annotate.c: Revert.
11951 * amd64-windows-tdep.c: Revert.
11952 * amd64-windows-nat.c: Revert.
11953 * amd64-tdep.c: Revert.
11954 * amd64-sol2-tdep.c: Revert.
11955 * amd64-obsd-tdep.c: Revert.
11956 * amd64-obsd-nat.c: Revert.
11957 * amd64-nbsd-tdep.c: Revert.
11958 * amd64-nbsd-nat.c: Revert.
11959 * amd64-nat.c: Revert.
11960 * amd64-linux-tdep.c: Revert.
11961 * amd64-linux-nat.c: Revert.
11962 * amd64-fbsd-tdep.c: Revert.
11963 * amd64-fbsd-nat.c: Revert.
11964 * amd64-dicos-tdep.c: Revert.
11965 * amd64-darwin-tdep.c: Revert.
11966 * amd64-bsd-nat.c: Revert.
11967 * alpha-tdep.c: Revert.
11968 * alpha-obsd-tdep.c: Revert.
11969 * alpha-nbsd-tdep.c: Revert.
11970 * alpha-mdebug-tdep.c: Revert.
11971 * alpha-linux-tdep.c: Revert.
11972 * alpha-linux-nat.c: Revert.
11973 * alpha-bsd-tdep.c: Revert.
11974 * alpha-bsd-nat.c: Revert.
11975 * aix-thread.c: Revert.
11976 * agent.c: Revert.
11977 * addrmap.c: Revert.
11978 * ada-varobj.c: Revert.
11979 * ada-valprint.c: Revert.
11980 * ada-typeprint.c: Revert.
11981 * ada-tasks.c: Revert.
11982 * ada-lang.c: Revert.
11983 * aarch64-tdep.c: Revert.
11984 * aarch64-ravenscar-thread.c: Revert.
11985 * aarch64-newlib-tdep.c: Revert.
11986 * aarch64-linux-tdep.c: Revert.
11987 * aarch64-linux-nat.c: Revert.
11988 * aarch64-fbsd-tdep.c: Revert.
11989 * aarch64-fbsd-nat.c: Revert.
11990 * aarch32-linux-nat.c: Revert.
11991
d55e5aa6
TT
119922019-04-05 Tom Tromey <tom@tromey.com>
11993
11994 * ft32-tdep.c: Sort headers.
11995 * frv-tdep.c: Sort headers.
11996 * frv-linux-tdep.c: Sort headers.
11997 * frame.c: Sort headers.
11998 * frame-unwind.c: Sort headers.
11999 * frame-base.c: Sort headers.
12000 * fork-child.c: Sort headers.
12001 * findvar.c: Sort headers.
12002 * findcmd.c: Sort headers.
12003 * filesystem.c: Sort headers.
12004 * filename-seen-cache.h: Sort headers.
12005 * filename-seen-cache.c: Sort headers.
12006 * fbsd-tdep.c: Sort headers.
12007 * fbsd-nat.h: Sort headers.
12008 * fbsd-nat.c: Sort headers.
12009 * f-valprint.c: Sort headers.
12010 * f-typeprint.c: Sort headers.
12011 * f-lang.c: Sort headers.
12012 * extension.h: Sort headers.
12013 * extension.c: Sort headers.
12014 * extension-priv.h: Sort headers.
12015 * expprint.c: Sort headers.
12016 * exec.h: Sort headers.
12017 * exec.c: Sort headers.
12018 * exceptions.c: Sort headers.
12019 * event-top.c: Sort headers.
12020 * event-loop.c: Sort headers.
12021 * eval.c: Sort headers.
12022 * elfread.c: Sort headers.
12023 * dwarf2read.h: Sort headers.
12024 * dwarf2read.c: Sort headers.
12025 * dwarf2loc.c: Sort headers.
12026 * dwarf2expr.h: Sort headers.
12027 * dwarf2expr.c: Sort headers.
12028 * dwarf2-frame.c: Sort headers.
12029 * dwarf2-frame-tailcall.c: Sort headers.
12030 * dwarf-index-write.h: Sort headers.
12031 * dwarf-index-write.c: Sort headers.
12032 * dwarf-index-common.c: Sort headers.
12033 * dwarf-index-cache.h: Sort headers.
12034 * dwarf-index-cache.c: Sort headers.
12035 * dummy-frame.c: Sort headers.
12036 * dtrace-probe.c: Sort headers.
12037 * disasm.h: Sort headers.
12038 * disasm.c: Sort headers.
12039 * disasm-selftests.c: Sort headers.
12040 * dictionary.c: Sort headers.
12041 * dicos-tdep.c: Sort headers.
12042 * demangle.c: Sort headers.
12043 * dcache.h: Sort headers.
12044 * dcache.c: Sort headers.
12045 * darwin-nat.h: Sort headers.
12046 * darwin-nat.c: Sort headers.
12047 * darwin-nat-info.c: Sort headers.
12048 * d-valprint.c: Sort headers.
12049 * d-namespace.c: Sort headers.
12050 * d-lang.c: Sort headers.
12051 * ctf.c: Sort headers.
12052 * csky-tdep.c: Sort headers.
12053 * csky-linux-tdep.c: Sort headers.
12054 * cris-tdep.c: Sort headers.
12055 * cris-linux-tdep.c: Sort headers.
12056 * cp-valprint.c: Sort headers.
12057 * cp-support.c: Sort headers.
12058 * cp-namespace.c: Sort headers.
12059 * cp-abi.c: Sort headers.
12060 * corelow.c: Sort headers.
12061 * corefile.c: Sort headers.
12062 * continuations.c: Sort headers.
12063 * completer.h: Sort headers.
12064 * completer.c: Sort headers.
12065 * complaints.c: Sort headers.
12066 * coffread.c: Sort headers.
12067 * coff-pe-read.c: Sort headers.
12068 * cli-out.h: Sort headers.
12069 * cli-out.c: Sort headers.
12070 * charset.c: Sort headers.
12071 * c-varobj.c: Sort headers.
12072 * c-valprint.c: Sort headers.
12073 * c-typeprint.c: Sort headers.
12074 * c-lang.c: Sort headers.
12075 * buildsym.c: Sort headers.
12076 * buildsym-legacy.c: Sort headers.
12077 * build-id.h: Sort headers.
12078 * build-id.c: Sort headers.
12079 * btrace.c: Sort headers.
12080 * bsd-uthread.c: Sort headers.
12081 * breakpoint.h: Sort headers.
12082 * breakpoint.c: Sort headers.
12083 * break-catch-throw.c: Sort headers.
12084 * break-catch-syscall.c: Sort headers.
12085 * break-catch-sig.c: Sort headers.
12086 * blockframe.c: Sort headers.
12087 * block.c: Sort headers.
12088 * bfin-tdep.c: Sort headers.
12089 * bfin-linux-tdep.c: Sort headers.
12090 * bfd-target.c: Sort headers.
12091 * bcache.c: Sort headers.
12092 * ax-general.c: Sort headers.
12093 * ax-gdb.h: Sort headers.
12094 * ax-gdb.c: Sort headers.
12095 * avr-tdep.c: Sort headers.
12096 * auxv.c: Sort headers.
12097 * auto-load.c: Sort headers.
12098 * arm-wince-tdep.c: Sort headers.
12099 * arm-tdep.c: Sort headers.
12100 * arm-symbian-tdep.c: Sort headers.
12101 * arm-pikeos-tdep.c: Sort headers.
12102 * arm-obsd-tdep.c: Sort headers.
12103 * arm-nbsd-tdep.c: Sort headers.
12104 * arm-nbsd-nat.c: Sort headers.
12105 * arm-linux-tdep.c: Sort headers.
12106 * arm-linux-nat.c: Sort headers.
12107 * arm-fbsd-tdep.c: Sort headers.
12108 * arm-fbsd-nat.c: Sort headers.
12109 * arm-bsd-tdep.c: Sort headers.
12110 * arch-utils.c: Sort headers.
12111 * arc-tdep.c: Sort headers.
12112 * arc-newlib-tdep.c: Sort headers.
12113 * annotate.h: Sort headers.
12114 * annotate.c: Sort headers.
12115 * amd64-windows-tdep.c: Sort headers.
12116 * amd64-windows-nat.c: Sort headers.
12117 * amd64-tdep.c: Sort headers.
12118 * amd64-sol2-tdep.c: Sort headers.
12119 * amd64-obsd-tdep.c: Sort headers.
12120 * amd64-obsd-nat.c: Sort headers.
12121 * amd64-nbsd-tdep.c: Sort headers.
12122 * amd64-nbsd-nat.c: Sort headers.
12123 * amd64-nat.c: Sort headers.
12124 * amd64-linux-tdep.c: Sort headers.
12125 * amd64-linux-nat.c: Sort headers.
12126 * amd64-fbsd-tdep.c: Sort headers.
12127 * amd64-fbsd-nat.c: Sort headers.
12128 * amd64-dicos-tdep.c: Sort headers.
12129 * amd64-darwin-tdep.c: Sort headers.
12130 * amd64-bsd-nat.c: Sort headers.
12131 * alpha-tdep.c: Sort headers.
12132 * alpha-obsd-tdep.c: Sort headers.
12133 * alpha-nbsd-tdep.c: Sort headers.
12134 * alpha-mdebug-tdep.c: Sort headers.
12135 * alpha-linux-tdep.c: Sort headers.
12136 * alpha-linux-nat.c: Sort headers.
12137 * alpha-bsd-tdep.c: Sort headers.
12138 * alpha-bsd-nat.c: Sort headers.
12139 * aix-thread.c: Sort headers.
12140 * agent.c: Sort headers.
12141 * addrmap.c: Sort headers.
12142 * ada-varobj.c: Sort headers.
12143 * ada-valprint.c: Sort headers.
12144 * ada-typeprint.c: Sort headers.
12145 * ada-tasks.c: Sort headers.
12146 * ada-lang.c: Sort headers.
12147 * aarch64-tdep.c: Sort headers.
12148 * aarch64-ravenscar-thread.c: Sort headers.
12149 * aarch64-newlib-tdep.c: Sort headers.
12150 * aarch64-linux-tdep.c: Sort headers.
12151 * aarch64-linux-nat.c: Sort headers.
12152 * aarch64-fbsd-tdep.c: Sort headers.
12153 * aarch64-fbsd-nat.c: Sort headers.
12154 * aarch32-linux-nat.c: Sort headers.
12155
699bd4cf
TT
121562019-04-04 Tom Tromey <tom@tromey.com>
12157
12158 * varobj.c (varobj_create): Update.
12159 * rust-exp.y (struct rust_parser) <update_innermost_block,
12160 lookup_symbol>: New methods.
12161 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12162 Rename.
12163 (rust_parser::rust_lookup_type)
12164 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12165 * printcmd.c (display_command, do_one_display): Update.
12166 * parser-defs.h (struct parser_state) <parser_state>: Add
12167 "tracker" parameter.
12168 (block_tracker): New member.
12169 (class innermost_block_tracker) <innermost_block_tracker>: Add
12170 "types" parameter.
12171 <reset>: Remove method.
12172 (innermost_block): Don't declare.
12173 (null_post_parser): Update.
12174 * parse.c (innermost_block): Remove global.
12175 (write_dollar_variable): Update.
12176 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12177 Remove "tracker_types" parameter.
12178 (parse_expression): Add "tracker" parameter.
12179 (parse_expression_for_completion): Update.
12180 (null_post_parser): Add "tracker" parameter.
12181 * p-exp.y: Update rules.
12182 * m2-exp.y: Update rules.
12183 * language.h (struct language_defn) <la_post_parser>: Add
12184 "tracker" parameter.
12185 * go-exp.y: Update rules.
12186 * f-exp.y: Update rules.
12187 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12188 parameter.
12189 * d-exp.y: Update rules.
12190 * c-exp.y: Update rules.
12191 * breakpoint.c (set_breakpoint_condition): Create an
12192 innermost_block_tracker.
12193 (watch_command_1): Likewise.
12194 * ada-lang.c (resolve): Add "tracker" parameter.
12195 (resolve_subexp): Likewise.
12196 * ada-exp.y (write_var_from_sym): Update.
12197
dac43e32
TT
121982019-04-04 Tom Tromey <tom@tromey.com>
12199
12200 * type-stack.h: New file.
12201 * type-stack.c: New file.
12202 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12203 type-stack.h.
12204 (insert_into_type_stack, insert_type, push_type, push_type_int)
12205 (insert_type_address_space, pop_type, pop_type_int)
12206 (pop_typelist, pop_type_stack, append_type_stack)
12207 (push_type_stack, get_type_stack, push_typelist)
12208 (follow_type_instance_flags, follow_types): Don't declare.
12209 * parse.c (type_stack): Remove global.
12210 (parse_exp_in_context): Update.
12211 (insert_into_type_stack, insert_type, push_type, push_type_int)
12212 (insert_type_address_space, pop_type, pop_type_int)
12213 (pop_typelist, pop_type_stack, append_type_stack)
12214 (push_type_stack, get_type_stack, push_typelist)
12215 (follow_type_instance_flags, follow_types): Remove (moved to
12216 type-stack.c).
12217 * f-exp.y (type_stack): New global.
12218 Update rules.
12219 (push_kind_type, f_parse): Update.
12220 * d-exp.y (type_stack): New global.
12221 Update rules.
12222 (d_parse): Update.
12223 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12224 Update rules.
12225 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12226 (HFILES_NO_SRCDIR): Add type-stack.h.
12227
2a612529
TT
122282019-04-04 Tom Tromey <tom@tromey.com>
12229
12230 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12231 (rust_parser::convert_ast_to_expression, rust_parse)
12232 (rust_lex_test_completion, rust_lex_tests): Update.
12233 * parser-defs.h (struct expr_completion_state): New.
12234 (struct parser_state) <parser_state>: Add completion parameter.
12235 <mark_struct_expression, mark_completion_tag>: New methods.
12236 <parse_completion, m_completion_state>: New members.
12237 (prefixify_expression, null_post_parser): Update.
12238 (mark_struct_expression, mark_completion_tag): Don't declare.
12239 * parse.c (parse_completion, expout_last_struct)
12240 (expout_tag_completion_type, expout_completion_name): Remove
12241 globals.
12242 (parser_state::mark_struct_expression)
12243 (parser_state::mark_completion_tag): Now methods.
12244 (prefixify_expression): Add last_struct parameter.
12245 (prefixify_subexp): Likewise.
12246 (parse_exp_1): Update.
12247 (parse_exp_in_context): Add cstate parameter. Update.
12248 (parse_expression_for_completion): Create an
12249 expr_completion_state.
12250 (null_post_parser): Add "completion" parameter.
12251 * p-exp.y: Update rules.
12252 (yylex): Update.
12253 * language.h (struct language_defn) <la_post_parser>: Add
12254 "completing" parameter.
12255 * go-exp.y: Update rules.
12256 (lex_one_token): Update.
12257 * expression.h (parse_completion): Don't declare.
12258 * d-exp.y: Update rules.
12259 (lex_one_token): Update rules.
12260 * c-exp.y: Update rules.
12261 (lex_one_token): Update.
12262 * ada-lang.c (resolve): Add "parse_completion" parameter.
12263 (resolve_subexp): Likewise.
12264 (ada_resolve_function): Likewise.
12265
43476f0b
TT
122662019-04-04 Tom Tromey <tom@tromey.com>
12267
12268 * parser-defs.h (struct parser_state) <start_arglist,
12269 end_arglist>: New methods.
12270 <arglist_len, m_funcall_chain>: New members.
12271 (arglist_len, start_arglist, end_arglist): Don't declare.
12272 * parse.c (arglist_len, funcall_chain): Remove global.
12273 (start_arglist, end_arglist): Remove functions.
12274 (parse_exp_in_context): Update.
12275 * p-exp.y: Update rules.
12276 * m2-exp.y: Update rules.
12277 * go-exp.y: Update rules.
12278 * f-exp.y: Update rules.
12279 * d-exp.y: Update rules.
12280 * c-exp.y: Update rules.
12281
5776fca3
TT
122822019-04-04 Tom Tromey <tom@tromey.com>
12283
12284 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12285 lex_operator, push_back>: New methods.
12286 Update all rules.
12287 (rust_parser::lex_hex, lex_escape): Rename and update.
12288 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12289 (rust_parser::lex_operator): Rename and update.
12290 (rust_parser::lex_number, rustyylex, rustyyerror)
12291 (rust_lex_test_init, rust_lex_test_sequence)
12292 (rust_lex_test_push_back, rust_lex_tests): Update.
12293 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12294 parameter.
12295 <lexptr, prev_lexptr>: New members.
12296 (lexptr, prev_lexptr): Don't declare.
12297 * parse.c (lexptr, prev_lexptr): Remove globals.
12298 (parse_exp_in_context): Update.
12299 * p-exp.y (yylex, yyerror): Update.
12300 * m2-exp.y (parse_number, yylex, yyerror): Update.
12301 * go-exp.y (lex_one_token, yyerror): Update.
12302 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12303 * d-exp.y (lex_one_token, yyerror): Update.
12304 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12305 (lex_one_token, yyerror): Update.
12306 * ada-lex.l (YY_INPUT): Update.
12307 (rewind_to_char): Update.
12308 * ada-exp.y (yyerror): Update.
12309
8621b685
TT
123102019-04-04 Tom Tromey <tom@tromey.com>
12311
12312 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12313 * parser-defs.h (struct parser_state) <parser_state>: Add new
12314 parameter.
12315 <comma_terminates>: New member.
12316 (comma_terminates): Don't declare global.
12317 * parse.c (comma_terminates): Remove global.
12318 (parse_exp_in_context): Update.
12319 * p-exp.y (yylex): Update.
12320 * m2-exp.y (yylex): Update.
12321 * go-exp.y (lex_one_token): Update.
12322 * f-exp.y (yylex): Update.
12323 * d-exp.y (lex_one_token): Update.
12324 * c-exp.y (lex_one_token): Update.
12325 * ada-lex.l: Update.
12326
28aaf3fd
TT
123272019-04-04 Tom Tromey <tom@tromey.com>
12328
12329 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12330 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12331 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12332 * parser-defs.h (paren_depth): Don't declare.
12333 * parse.c (paren_depth): Remove global.
12334 (parse_exp_in_context): Update.
12335 * p-exp.y (paren_depth): New global.
12336 (pascal_parse): Initialize it.
12337 * m2-exp.y (paren_depth): New global.
12338 (m2_parse): Initialize it.
12339 * go-exp.y (paren_depth): New global.
12340 (go_parse): Initialize it.
12341 * f-exp.y (paren_depth): New global.
12342 (f_parse): Initialize it.
12343 * d-exp.y (paren_depth): New global.
12344 (d_parse): Initialize it.
12345 * c-exp.y (paren_depth): New global.
12346 (c_parse): Initialize it.
12347 * ada-lex.l (paren_depth): New global.
12348 (lexer_init): Initialize it.
12349
1e58a4a4
TT
123502019-04-04 Tom Tromey <tom@tromey.com>
12351
12352 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12353 (rust_parser::convert_ast_to_type)
12354 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12355 * parser-defs.h (struct parser_state) <parser_state>: Add
12356 parameters. Initialize new members.
12357 <expression_context_block, expression_context_pc>: New members.
12358 * parse.c (expression_context_block, expression_context_pc):
12359 Remove globals.
12360 (parse_exp_in_context): Update.
12361 * p-exp.y: Update all rules.
12362 (yylex): Update.
12363 * m2-exp.y: Update all rules.
12364 (yylex): Update.
12365 * go-exp.y (yylex): Update.
12366 * f-exp.y (yylex): Update.
12367 * d-exp.y: Update all rules.
12368 (yylex): Update.
12369 * c-exp.y: Update all rules.
12370 (lex_one_token, classify_name, yylex, c_parse): Update.
12371 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12372
37eedb39
TT
123732019-04-04 Tom Tromey <tom@tromey.com>
12374
12375 * gdbarch.h, gdbarch.c: Rebuild.
12376 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12377 * stap-probe.h:
12378 (struct stap_parse_info): Replace "parser_state" with
12379 "expr_builder".
12380 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12381 (parser_state): New class.
12382 * parse.c (expr_builder): Rename.
12383 (expr_builder::release): Rename.
12384 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12385 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12386 (write_exp_elt_longcst, write_exp_elt_floatcst)
12387 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12388 (write_exp_string_vector, write_exp_bitstring)
12389 (write_exp_msymbol, mark_struct_expression)
12390 (write_dollar_variable)
12391 (insert_type_address_space, increase_expout_size): Replace
12392 "parser_state" with "expr_builder".
12393 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12394 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12395 "parser_state" with "expr_builder".
12396
73923d7e
TT
123972019-04-04 Tom Tromey <tom@tromey.com>
12398
12399 * rust-exp.y: Replace "parse_language" with method call.
12400 * p-exp.y:
12401 (yylex): Replace "parse_language" with method call.
12402 * m2-exp.y:
12403 (yylex): Replace "parse_language" with method call.
12404 * go-exp.y (classify_name): Replace "parse_language" with method
12405 call.
12406 * f-exp.y (yylex): Replace "parse_language" with method call.
12407 * d-exp.y (lex_one_token): Replace "parse_language" with method
12408 call.
12409 * c-exp.y:
12410 (lex_one_token, classify_name, yylex): Replace "parse_language"
12411 with method call.
12412 * ada-exp.y (find_primitive_type, type_char)
12413 (type_system_address): Replace "parse_language" with method call.
12414
fa9f5be6
TT
124152019-04-04 Tom Tromey <tom@tromey.com>
12416
12417 * rust-exp.y: Replace "parse_gdbarch" with method call.
12418 * parse.c (write_dollar_variable, insert_type_address_space):
12419 Replace "parse_gdbarch" with method call.
12420 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12421 call.
12422 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12423 call.
12424 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12425 "parse_gdbarch" with method call.
12426 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12427 with method call.
12428 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12429 "parse_gdbarch" with method call.
12430 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12431 "parse_gdbarch" with method call.
12432 * c-exp.y (parse_type, parse_number, classify_name): Replace
12433 "parse_gdbarch" with method call.
12434 * ada-lex.l: Replace "parse_gdbarch" with method call.
12435 * ada-exp.y (parse_type, find_primitive_type, type_char)
12436 (type_system_address): Replace "parse_gdbarch" with method call.
12437
1201a264
TT
124382019-04-04 Tom Tromey <tom@tromey.com>
12439
12440 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12441 * stap-probe.c (stap_parse_argument): Update.
12442 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12443 initial_size parameter.
12444 * rust-exp.y (rust_lex_tests): Update.
12445 * parse.c (parser_state): Update.
12446 (parse_exp_in_context): Update.
12447 * parser-defs.h (struct parser_state) <parser_state>: Remove
12448 "initial_size" parameter.
12449
e3980ce2
TT
124502019-04-04 Tom Tromey <tom@tromey.com>
12451
12452 * parser-defs.h (increase_expout_size): Don't declare.
12453 * parse.c (increase_expout_size): Now static.
12454
e9f8e3f1
TS
124552019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12456
12457 * gnu-nat.c (gnu_nat_target::wait): Fix
12458 target_waitstatus_to_string call.
12459
d7df6549
AB
124602019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12461
12462 * eval.c (evaluate_subexp_standard): Handle internal functions
12463 during Fortran function call handling.
12464
8bdc1658
AB
124652019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12466
12467 * NEWS: Mention new internal functions.
12468 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12469 (read_base_type): Use dwarf2_init_complex_target_type.
12470 * value.c (creal_internal_fn): New function.
12471 (cimag_internal_fn): New function.
12472 (_initialize_values): Register new internal functions.
12473
c29705b7
PW
124742019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12475
12476 * infrun.c (stop_all_threads): If debug_infrun, always
12477 trace the wait status after wait_one, using
12478 target_waitstatus_to_string and target_pid_to_str.
12479 (handle_inferior_event): Replace various trace of
12480 wait status kind by a single trace.
12481 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12482 wait status kind image by target_waitstatus_to_string.
12483 * target/waitstatus.c (target_waitstatus_to_string): Fix
12484 obsolete comment.
12485
05caa1d2
TT
124862019-04-01 Tom Tromey <tromey@adacore.com>
12487
12488 PR symtab/23331:
12489 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12490
9d1447e0
SDJ
124912019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12492 Pedro Alves <palves@redhat.com>
12493
12494 * top.c (quit_force): Call 'finalize_values'.
12495 * value.c (finalize_values): New function.
12496 * value.h (finalize_values): Declare.
12497
7734102d
EZ
124982019-03-30 Eli Zaretskii <eliz@gnu.org>
12499
12500 * NEWS: Announce $_gdb_major and $_gdb_minor.
12501
12502 * top.c (init_gdb_version_vars): New function.
12503 (gdb_init): Call init_gdb_version_vars.
12504
188e1fa9
TT
125052019-03-29 Tom Tromey <tromey@adacore.com>
12506
12507 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12508 help text. Remove dead code.
12509
2880242d
KS
125102019-03-29 Keith Seitz <keiths@redhat.com>
12511
12512 From Siddhesh Poyarekar:
12513 * f-lang.h (f77_get_upperbound): Return LONGEST.
12514 (f77_get_lowerbound): Likewise.
12515 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12516 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12517 print them.
12518 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12519 plongest to format print it.
12520 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12521 (f77_get_upperbound): Likewise.
12522 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12523 LOWER_BOUND to LONGEST.
12524 (f77_create_arrayprint_offset_tbl): Likewise.
12525
cc1defb1
KS
125262019-03-29 Keith Seitz <keiths@redhat.com>
12527
12528 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12529 %s/pulongest for TYPE_LENGTH instead of %d in format
12530 strings.
12531 * ada-typerint.c (ada_print_type): Likewise.
12532 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12533 * compile/compile-c-support.c (generate_register_struct): Likewise.
12534 * gdbtypes.c (recursive_dump_type): Likewise.
12535 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12536 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12537 instead of %d in format strings.
12538 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12539 to std::min to ULONGEST.
12540 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12541 instead of %d in format strings.
12542 * tracepoint.c (info_scope_command): Likewise.
12543 * typeprint.c (print_offset_data::update)
12544 (print_offset_data::finish): Likewise.
12545 * xtensa-tdep.c (xtensa_store_return_value)
12546 (xtensa_push_dummy_call): Likewise.
12547
e432ccf1
JT
125482019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12549
12550 * windows-nat.c (display_selector): Fixed format specifications
12551 for 64-bit Cygwin.
12552
65d2b333
PW
125532019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12554
12555 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12556
f489207e
SL
125572019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12558
12559 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12560 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12561 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12562 (nios2_linux_init_abi): Install it.
12563
bffa1015
AH
125642019-03-28 Alan Hayward <alan.hayward@arm.com>
12565
12566 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12567
fc96163a
AH
125682019-03-28 Alan Hayward <alan.hayward@arm.com>
12569
12570 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12571
20dc7e9b
PW
125722019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12573 Tom Tromey <tromey@adacore.com>
12574
12575 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12576
7f5331a8
JB
125772019-03-26 Joel Brobecker <brobecker@adacore.com>
12578
12579 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12580 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12581 method to compute the bounds of range types. Also print "[evaluated]"
12582 if the bounds' values come from a dynamic evaluation.
12583
18c77628
AB
125842019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12585
12586 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12587 whitespace when pretty printing is on.
12588
53c973f2
AH
125892019-03-26 Alan Hayward <alan.hayward@arm.com>
12590
e79be6e5 12591 * ppc-linux-nat.c: Add include.
53c973f2 12592
d851aa71
AH
125932019-03-26 Alan Hayward <alan.hayward@arm.com>
12594
e79be6e5 12595 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12596
2fe7bab7
AH
125972019-03-26 Alan Hayward <alan.hayward@arm.com>
12598
e79be6e5 12599 * arm-linux-nat.c: Add include.
2fe7bab7 12600
068ef30e
SM
126012019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12602
12603 * source-cache.c (source_cache::get_source_lines): Re-read
12604 fullname after calling open_source_file.
12605
81a24d04
JB
126062019-03-25 John Baldwin <jhb@FreeBSD.org>
12607
12608 * NEWS: Mention TLS support for FreeBSD.
12609
79e7ae11
TT
126102019-03-25 Tom Tromey <tromey@adacore.com>
12611
12612 * minsyms.c (BUNCH_SIZE): Update comment.
12613 (~minimal_symbol_reader): Remove old comment.
12614 (compact_minimal_symbols): Update comment.
12615 (minimal_symbol_reader::install): Remove old comment. Update
12616 other comments.
12617
d45963c2
AH
126182019-03-25 Alan Hayward <alan.hayward@arm.com>
12619
12620 * s390-linux-nat.c: Add include.
12621
0f83012e
AH
126222019-03-25 Alan Hayward <alan.hayward@arm.com>
12623
12624 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12625 Call linux_get_hwcap.
12626 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12627 Likewise.
12628 (aarch64_linux_get_hwcap): Remove function.
12629 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12630 declaration.
12631 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12632 linux_get_hwcap.
12633 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12634 * linux-tdep.c (linux_get_hwcap): Add function.
12635 (linux_get_hwcap2): Likewise.
12636 * linux-tdep.h (linux_get_hwcap): Add declaration.
12637 (linux_get_hwcap2): Likewise.
12638 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12639 (ppc_linux_get_hwcap2): Likewise.
12640 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12641 linux_get_hwcap.
12642 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12643 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12644 (ppc_linux_nat_target::read_description): Likewise.
12645 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12646 * s390-linux-nat.c: Likewise.
12647 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12648
6640a367
TT
126492019-03-24 Tom Tromey <tom@tromey.com>
12650
12651 * ada-lang.c (standard_lookup): Simplify initialization.
12652 (ada_lookup_symbol_nonlocal): Simplify return.
12653 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12654 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12655 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12656 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12657 initialization.
12658 * solib.c (solib_global_lookup): Simplify.
12659 * symtab.c (null_block_symbol): Remove.
12660 (symbol_cache_lookup): Simplify returns.
12661 (lookup_language_this): Simplify returns.
12662 (lookup_symbol_aux): Simplify return.
12663 (lookup_local_symbol): Simplify returns.
12664 (lookup_global_symbol_from_objfile): Simplify return.
12665 (lookup_symbol_in_objfile_symtabs)
12666 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12667 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12668 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12669 * cp-namespace.c (cp_lookup_bare_symbol)
12670 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12671 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12672 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12673 (cp_lookup_symbol_via_imports): Simplify initialization.
12674 (find_symbol_in_baseclass): Likewise.
12675 * symtab.h (null_block_symbol): Remove.
12676 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12677 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12678 (d_lookup_symbol_module): Likewise.
12679 (find_symbol_in_baseclass): Simplify initialization.
12680
a930ebcd
TT
126812019-03-24 Tom Tromey <tom@tromey.com>
12682
12683 * expression.h: Don't include symtab.h.
12684 (struct block): Forward declare.
12685
582942f4
TT
126862019-03-24 Tom Tromey <tom@tromey.com>
12687
12688 * c-exp.y (typebase): Remove casts.
12689 * gdbtypes.c (lookup_unsigned_typename, )
12690 (lookup_signed_typename): Remove cast.
12691 * eval.c (parse_to_comma_and_eval): Remove cast.
12692 * parse.c (write_dollar_variable): Remove cast.
12693 * block.h (struct block) <superblock>: Now const.
12694 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12695 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12696 (map_block): Make "block" const.
12697 * symfile.h (struct quick_symbol_functions)
12698 <map_matching_symbols>: Constify block argument to "callback".
12699 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12700 const.
12701 (find_pc_sect_compunit_symtab): Make "b" const.
12702 (find_symbol_at_address): Likewise.
12703 (search_symbols): Likewise.
12704 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12705 (dw2_debug_names_lookup_symbol): Likewise.
12706 (dw2_map_matching_symbols): Update.
12707 * p-valprint.c (pascal_val_print): Remove "block".
12708 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12709 (aux_add_nonlocal_symbols): Make "block" const.
12710 (resolve_subexp): Remove cast.
12711 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12712 const.
12713 (iterate_over_file_blocks): Likewise.
12714 * f-exp.y (%union) <bval>: Remove.
12715 * coffread.c (patch_opaque_types): Make "b" const.
12716 * spu-tdep.c (spu_catch_start): Make "block" const.
12717 * c-valprint.c (print_unpacked_pointer): Remove "block".
12718 * symmisc.c (dump_symtab_1): Make "b" const.
12719 (block_depth): Make "block" const.
12720 * d-exp.y (%union) <bval>: Remove.
12721 * cp-support.h (cp_lookup_rtti_type): Update.
12722 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12723 * psymtab.c (psym_lookup_symbol): Make "block" const.
12724 (maintenance_check_psymtabs): Make "b" const.
12725 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12726 (enumerate_locals, enumerate_args): Update.
12727 * python/py-symtab.c (stpy_global_block): Make "block" const.
12728 (stpy_static_block): Likewise.
12729 * inline-frame.c (block_starting_point_at): Make "new_block"
12730 const.
12731 * block.c (find_block_in_blockvector): Make return type const.
12732 (blockvector_for_pc_sect): Make "b" const.
12733 (find_block_in_blockvector): Make "b" const.
12734
7ad417dd
TT
127352019-03-23 Tom Tromey <tom@tromey.com>
12736
12737 * varobj.c (varobj_create): Update.
12738 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12739 * printcmd.c (display_command, do_one_display): Don't reset
12740 innermost_block.
12741 * parser-defs.h (enum innermost_block_tracker_type): Move to
12742 expression.h.
12743 (innermost_block): Update comment.
12744 * parse.c (parse_exp_1): Add tracker_types parameter.
12745 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12746 tracker_types parameter. Reset innermost_block.
12747 (parse_exp_in_context): Remove.
12748 (parse_expression_for_completion): Update.
12749 * objfiles.c (~objfile): Don't reset expression_context_block or
12750 innermost_block.
12751 * expression.h (enum innermost_block_tracker_type): Move from
12752 parser-defs.h.
12753 (parse_exp_1): Add tracker_types parameter.
12754 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12755 reset innermost_block.
12756
b366c208
TT
127572019-03-23 Tom Tromey <tom@tromey.com>
12758
12759 * objfiles.h: Include bcache.h.
12760
9bb9b2f9
TT
127612019-03-23 Tom Tromey <tom@tromey.com>
12762
12763 * linespec.c (get_current_search_block): Use
12764 scoped_restore_current_language.
12765 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12766
59c28372
AH
127672019-03-22 Alan Hayward <alan.hayward@arm.com>
12768 Jiong Wang <jiong.wang@arm.com>
12769
12770 * aarch64-linux-tdep.c
12771 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12772 section.
12773 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12774
17e116a7
AH
127752019-03-22 Alan Hayward <alan.hayward@arm.com>
12776 Jiong Wang <jiong.wang@arm.com>
12777
12778 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12779 instructions.
12780 (aarch64_analyze_prologue_test): Add PACIASP test.
12781 (aarch64_prologue_prev_register): Unmask PC value.
12782
11e1b75f
AH
127832019-03-22 Alan Hayward <alan.hayward@arm.com>
12784 Jiong Wang <jiong.wang@arm.com>
12785
12786 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12787 (aarch64_dwarf2_prev_register): Unmask PC value.
12788 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12789 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12790 DW_CFA_AARCH64_negate_ra_state.
12791 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12792
34dcc7cf
AH
127932019-03-22 Alan Hayward <alan.hayward@arm.com>
12794 Jiong Wang <jiong.wang@arm.com>
12795
12796 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12797 registers.
12798 (aarch64_pseudo_register_name): Likewise.
12799 (aarch64_pseudo_register_type): Likewise.
12800 (aarch64_pseudo_register_reggroup_p): Likewise.
12801 (aarch64_gdbarch_init): Add pauth registers.
12802 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12803 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12804 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12805 (struct gdbarch_tdep): Add regnum for ra_state.
12806
1ef53e6b
AH
128072019-03-22 Alan Hayward <alan.hayward@arm.com>
12808 Jiong Wang <jiong.wang@arm.com>
12809
12810 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12811
76bed0fd
AH
128122019-03-22 Alan Hayward <alan.hayward@arm.com>
12813 Jiong Wang <jiong.wang@arm.com>
12814
12815 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12816 function.
12817 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12818 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12819 (aarch64_gdbarch_init): Add puth registers.
12820 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12821 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12822 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12823
ee4fbcfa
AH
128242019-03-22 Alan Hayward <alan.hayward@arm.com>
12825 Jiong Wang <jiong.wang@arm.com>
12826
12827 * aarch64-linux-nat.c
12828 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12829 * aarch64-linux-tdep.c
12830 (aarch64_linux_core_read_description): Likewise.
12831 (aarch64_linux_get_hwcap): New function.
12832 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12833 (aarch64_linux_get_hwcap): New declaration.
12834
6dc0ebde
AH
128352019-03-22 Alan Hayward <alan.hayward@arm.com>
12836 Jiong Wang <jiong.wang@arm.com>
12837
12838 * aarch64-linux-nat.c
12839 (aarch64_linux_nat_target::read_description): Add pauth param.
12840 * aarch64-linux-tdep.c
12841 (aarch64_linux_core_read_description): Likewise.
12842 * aarch64-tdep.c (struct target_desc): Add in pauth.
12843 (aarch64_read_description): Add pauth param.
12844 (aarch64_gdbarch_init): Likewise.
12845 * aarch64-tdep.h (aarch64_read_description): Likewise.
12846 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12847 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12848 * features/Makefile: Add new files.
12849 * features/aarch64-pauth.c: New file.
12850 * features/aarch64-pauth.xml: New file.
12851
595915c1
TT
128522019-03-20 Tom Tromey <tromey@adacore.com>
12853
12854 * infrun.c (handle_inferior_event): Rename from
12855 handle_inferior_event_1. Create a scoped_value_mark.
12856 (handle_inferior_event): Remove.
12857
4c7d57e7
TT
128582019-03-19 Tom Tromey <tromey@adacore.com>
12859
12860 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12861 * infrun.h (print_stop_event): Add "displays" parameter.
12862 * infrun.c (print_stop_event): Add "displays" parameter.
12863
cb246234
PA
128642019-03-19 Pedro Alves <palves@redhat.com>
12865
12866 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12867 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12868 to -1. Fix TABs vs spaces.
12869 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12870 * tui/tui-out.h (tui_ui_out) Add intro comments.
12871 <m_line, m_start_of_line>: In-class initialize, and add describing
12872 comment.
12873
3a0e45b2
AH
128742019-03-18 Alan Hayward <alan.hayward@arm.com>
12875
12876 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12877 variable names.
12878 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12879
5371b850
PA
128802019-03-18 Pedro Alves <palves@redhat.com>
12881 Eli Zaretskii <eliz@gnu.org>
12882
12883 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12884 m_line and m_start_of_line.
12885
b17c4cd0
EZ
128862019-03-18 Eli Zaretskii <eliz@gnu.org>
12887
12888 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12889 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12890 it returns a newline. This fixes a regression in TU mode, whereby
12891 the next line is output on the same screen line as the user input.
12892
4bd56d18
TT
128932019-03-18 Tom Tromey <tromey@adacore.com>
12894
12895 * minsyms.c (minimal_symbol_reader::install): Remove call to
12896 obstack_blank.
12897
55c10aca
PA
128982019-03-18 Pedro Alves <palves@redhat.com>
12899
12900 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12901 New globals.
12902 (apply_style): New, factored out from ...
12903 (apply_ansi_escape): ... this. Handle reverse video mode.
12904 (tui_set_reverse_mode): New function.
12905 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12906 * tui/tui-winsource.c (tui_show_source_line): Use
12907 tui_set_reverse_mode instead of setting A_STANDOUT.
12908 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12909 New setter methods.
12910
647bb750
HD
129112019-03-18 Hannes Domani <ssbssa@yahoo.de>
12912
12913 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12914 Handle tabs.
12915
bff8c71f
TT
129162019-03-18 Tom Tromey <tromey@adacore.com>
12917
12918 * ada-lang.c (empty_array): Add "high" parameter.
12919 (ada_evaluate_subexp): Update.
12920
58785d98
ST
129212019-03-17 Sergei Trofimovich <siarheit@google.com>
12922
12923 * unittests/string_view-selftests.c: Define
12924 _initialize_string_view_selftests unconditionally.
12925
d4cbef22
ВМ
129262019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12927
12928 PR gdb/24350
12929 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12930
fce4c071
ВМ
129312019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12932
12933 PR gdb/24351
12934 * windows-nat.c (display_selector): Fix format specifiers.
12935
f7f0a123
EZ
129362019-03-17 Eli Zaretskii <eliz@gnu.org>
12937
12938 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12939 tui_refill_source_window instead of tui_refresh_win, to update the
12940 current execution line. This fixes redisplay of the current line
12941 when stepping through the code with "next" or "step".
12942
ab42892f
EZ
129432019-03-16 Eli Zaretskii <eliz@gnu.org>
12944
12945 * source-cache.c (source_cache::get_source_lines): Call
12946 find_source_lines to initialize s->nlines. This fixes vertical
12947 scrolling of TUI source window when the DOWN arrow is pressed.
12948
8d8c087f
PW
129492019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12950
12951 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12952 linux-thread-db.c (_initialize_thread_db): Likewise.
12953
798e1c30
EZ
129542019-03-16 Eli Zaretskii <eliz@gnu.org>
12955
12956 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12957 wclrtoeol in tui_show_source_line". This reverts changes made in
12958 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12959
eefba3da
TT
129602019-03-15 Tom Tromey <tom@tromey.com>
12961
12962 * symtab.h (struct minimal_symbol): Derive from
12963 general_symbol_info.
12964 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12965 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12966 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12967 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12968 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12969 (MSYMBOL_SEARCH_NAME): Update.
12970 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12971 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12972 * minsyms.c (minimal_symbol_reader::record_full): Update.
12973
0de2420c
TT
129742019-03-15 Tom Tromey <tom@tromey.com>
12975
12976 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12977
042d75e4
TT
129782019-03-15 Tom Tromey <tom@tromey.com>
12979
12980 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12981 unique_xmalloc_ptr.
12982 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12983 Update.
12984 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12985 (build_minimal_symbol_hash_tables)
12986 (minimal_symbol_reader::install): Update.
12987
db92718b
TT
129882019-03-15 Tom Tromey <tom@tromey.com>
12989
12990 * symtab.c (create_demangled_names_hash): Update.
12991 (symbol_set_names): Update.
12992 * objfiles.h (struct objfile_per_bfd_storage)
12993 <demangled_names_hash>: Now an htab_up.
12994 * objfiles.c (objfile_per_bfd_storage): Simplify.
12995
d6797f46
TT
129962019-03-15 Tom Tromey <tom@tromey.com>
12997
12998 * objfiles.h (struct objfile_per_bfd_storage): Declare
12999 destructor.
13000 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13001 New.
13002 (get_objfile_bfd_data): Use new. Don't initialize
13003 language_of_main.
13004 (free_objfile_per_bfd_storage): Remove.
13005 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13006
741d7538
TT
130072019-03-15 Tom Tromey <tom@tromey.com>
13008
13009 * symfile.c (reread_symbols): Update.
13010 * objfiles.c (objfile::objfile): Update.
13011 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13012 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13013 comment.
13014 (minimal_symbol_reader::install): Update.
13015 (terminate_minimal_symbol_table): Remove.
13016 * jit.c (jit_object_close_impl): Update.
13017
788c80d1
TT
130182019-03-15 Tom Tromey <tom@tromey.com>
13019
13020 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13021 initializations.
13022
1b7a07cb
TT
130232019-03-15 Tom Tromey <tom@tromey.com>
13024
13025 * objfiles.h (struct objfile_per_bfd_storage)
13026 <demangled_hash_languages>: Now a bitset.
13027 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13028 (lookup_minimal_symbol): Update.
13029
3db066bc
TT
130302019-03-15 Tom Tromey <tom@tromey.com>
13031
13032 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13033 Don't return the symbol.
13034 * coffread.c (record_minimal_symbol): Use record_full.
13035
3fff2c37
EZ
130362019-03-14 Eli Zaretskii <eliz@gnu.org>
13037
13038 The MS-Windows port of ncurses fails to switch to a color pair if
13039 one or both of the colors are the implicit default colors. This
13040 change records the default colors when TUI is initialized, and
13041 then specifies them explicitly when a color pair uses the default
13042 colors. This allows color styling in TUI mode on MS-Windows.
13043
13044 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13045 ncurses_norm_attr.
13046 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13047 colors in ncurses_norm_attr.
13048 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13049 "none", replace it with the default color recorded in
13050 ncurses_norm_attr.
13051
3b336828
TT
130522019-03-14 Tom Tromey <tromey@adacore.com>
13053
13054 * source-cache.h (class source_cache) <get_source_lines>: Return
13055 std::string.
13056 * source-cache.c (source_cache::extract_lines): Handle case where
13057 first_pos==npos. Return std::string.
13058 (source_cache::get_source_lines): Update.
13059
d085f989
TT
130602019-03-14 Tom Tromey <tromey@adacore.com>
13061
13062 * NEWS: Add item for "style sources" commands.
13063 * source-cache.c (source_cache::get_source_lines): Check
13064 source_styling.
13065 * cli/cli-style.c (source_styling): New global.
13066 (_initialize_cli_style): Add "style sources" commands.
13067 (show_style_sources): New function.
13068 * cli/cli-style.h (source_styling): Declare.
13069
6f11e682
TT
130702019-03-14 Pedro Alves <palves@redhat.com>
13071 Tom Tromey <tromey@adacore.com>
13072
13073 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13074 * tui/tui-winsource.c (tui_refill_source_window): New function,
13075 from...
13076 (tui_horizontal_source_scroll): ... here. Move some logic.
13077 * cli/cli-style.c (set_style_enabled): Notify new observable.
13078 * tui/tui-hooks.c (tui_redisplay_source): New function.
13079 (tui_attach_detach_observers): Attach or detach
13080 tui_redisplay_source.
13081 * observable.h (source_styling_changed): New observable.
13082 * observable.c: Define source_styling_changed observable.
13083
a068643d
TT
130842019-03-13 Tom Tromey <tromey@adacore.com>
13085
13086 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13087 (i386_gnu_nat_target::store_registers): Update.
13088 * target-debug.h (target_debug_print_std_string): New macro.
13089 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13090 * windows-tdep.c (display_one_tib): Update.
13091 * tui/tui-stack.c (tui_make_status_line): Update.
13092 * top.c (print_inferior_quit_action): Update.
13093 * thread.c (thr_try_catch_cmd): Update.
13094 (add_thread_with_info): Update.
13095 (thread_target_id_str): Update.
13096 (thr_try_catch_cmd): Update.
13097 (thread_command): Update.
13098 (thread_find_command): Update.
13099 * record-btrace.c (record_btrace_target::info_record)
13100 (record_btrace_resume_thread, record_btrace_target::resume)
13101 (record_btrace_cancel_resume, record_btrace_step_thread)
13102 (record_btrace_target::wait, record_btrace_target::wait)
13103 (record_btrace_target::wait, record_btrace_target::stop): Update.
13104 * progspace.c (print_program_space): Update.
13105 * process-stratum-target.c
13106 (process_stratum_target::thread_address_space): Update.
13107 * linux-fork.c (linux_fork_mourn_inferior)
13108 (detach_checkpoint_command, info_checkpoints_command)
13109 (linux_fork_context): Update.
13110 (linux_fork_detach): Update.
13111 (class scoped_switch_fork_info): Update.
13112 (delete_checkpoint_command): Update.
13113 * infrun.c (follow_fork_inferior): Update.
13114 (follow_fork_inferior): Update.
13115 (proceed_after_vfork_done): Update.
13116 (handle_vfork_child_exec_or_exit): Update.
13117 (follow_exec): Update.
13118 (displaced_step_prepare_throw): Update.
13119 (displaced_step_restore): Update.
13120 (start_step_over): Update.
13121 (resume_1): Update.
13122 (clear_proceed_status_thread): Update.
13123 (proceed): Update.
13124 (print_target_wait_results): Update.
13125 (do_target_wait): Update.
13126 (context_switch): Update.
13127 (stop_all_threads): Update.
13128 (restart_threads): Update.
13129 (finish_step_over): Update.
13130 (handle_signal_stop): Update.
13131 (switch_back_to_stepped_thread): Update.
13132 (keep_going_pass_signal): Update.
13133 (print_exited_reason): Update.
13134 (normal_stop): Update.
13135 * inferior.c (inferior_pid_to_str): Change return type.
13136 (print_selected_inferior): Update.
13137 (add_inferior): Update.
13138 (detach_inferior): Update.
13139 * dummy-frame.c (fprint_dummy_frames): Update.
13140 * dcache.c (dcache_info_1): Update.
13141 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13142 (btrace_fetch, btrace_clear): Update.
13143 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13144 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13145 type.
13146 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13147 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13148 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13149 * gdbarch.c, gdbarch.h: Rebuild.
13150 * gdbarch.sh (core_pid_to_str): Change return type.
13151 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13152 return type.
13153 (windows_nat_target::pid_to_str): Change return type.
13154 (windows_delete_thread): Update.
13155 (windows_nat_target::attach): Update.
13156 (windows_nat_target::files_info): Update.
13157 * target-delegates.c: Rebuild.
13158 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13159 return type.
13160 (sol_thread_target::pid_to_str): Change return type.
13161 * remote.c (class remote_target) <pid_to_str>: Change return
13162 type.
13163 (remote_target::pid_to_str): Change return type.
13164 (extended_remote_target::attach, remote_target::remote_stop_ns)
13165 (remote_target::remote_notif_remove_queued_reply)
13166 (remote_target::push_stop_reply, remote_target::disable_btrace):
13167 Update.
13168 (extended_remote_target::attach): Update.
13169 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13170 type.
13171 (gdbsim_target::pid_to_str): Change return type.
13172 * ravenscar-thread.c (struct ravenscar_thread_target)
13173 <pid_to_str>: Change return type.
13174 (ravenscar_thread_target::pid_to_str): Change return type.
13175 * procfs.c (class procfs_target) <pid_to_str>: Change return
13176 type.
13177 (procfs_target::pid_to_str): Change return type.
13178 (procfs_target::attach): Update.
13179 (procfs_target::detach): Update.
13180 (procfs_target::fetch_registers): Update.
13181 (procfs_target::store_registers): Update.
13182 (procfs_target::wait): Update.
13183 (procfs_target::files_info): Update.
13184 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13185 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13186 return type.
13187 (nto_procfs_target::pid_to_str): Change return type.
13188 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13189 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13190 return type.
13191 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13192 (exit_lwp): Update.
13193 (attach_proc_task_lwp_callback, get_detach_signal)
13194 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13195 (linux_nat_target::resume, wait_lwp, stop_callback)
13196 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13197 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13198 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13199 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13200 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13201 type.
13202 (inf_ptrace_target::attach): Update.
13203 (inf_ptrace_target::files_info): Update.
13204 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13205 type.
13206 (go32_nat_target::pid_to_str): Change return type.
13207 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13208 (gnu_nat_target::wait): Update.
13209 (gnu_nat_target::wait): Update.
13210 (gnu_nat_target::resume): Update.
13211 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13212 (fbsd_nat_target::wait): Update.
13213 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13214 type.
13215 (darwin_nat_target::attach): Update.
13216 * corelow.c (class core_target) <pid_to_str>: Change return type.
13217 (core_target::pid_to_str): Change return type.
13218 * target.c (normal_pid_to_str): Change return type.
13219 (default_pid_to_str): Likewise.
13220 (target_pid_to_str): Change return type.
13221 (target_translate_tls_address): Update.
13222 (target_announce_detach): Update.
13223 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13224 return type.
13225 (bsd_uthread_target::pid_to_str): Change return type.
13226 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13227 type.
13228 (bsd_kvm_target::pid_to_str): Change return type.
13229 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13230 return type.
13231 (aix_thread_target::pid_to_str): Change return type.
13232 * target.h (struct target_ops) <pid_to_str>: Change return type.
13233 (target_pid_to_str, normal_pid_to_str): Likewise.
13234 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13235 type.
13236 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13237 type.
13238 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13239 return type.
13240 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13241 type.
13242 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13243 type.
13244 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13245 return type.
13246
b4be1b06
SM
132472019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13248
13249 * NEWS: Mention that the new default MI version is 3. Mention
13250 changes to the output of commands and events that deal with
13251 multi-location breakpoints.
13252 * breakpoint.c: Include "mi/mi-out.h".
13253 (print_one_breakpoint): Change output syntax if using MI version
13254 >= 3.
13255 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13256 New.
13257 (mi_multi_location_breakpoint_output_fixed): New.
13258 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13259 (mi_cmd_fix_multi_location_breakpoint_output): New.
13260 (mi_multi_location_breakpoint_output_fixed): New.
13261 * mi/mi-cmds.c (mi_cmds): Register command
13262 -fix-multi-location-breakpoint-output.
13263 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13264 interpreter "mi".
13265
8e5e5494
SM
132662019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13267
13268 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13269 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13270 instantiate mi_ui_out based on interpreter name.
13271 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13272 * mi/mi-main.c (mi_load_progress): Likewise.
13273
197df35e
JB
132742019-03-12 John Baldwin <jhb@FreeBSD.org>
13275
13276 * NEWS: Combine separate "New targets" sections for 8.3.
13277
8399425f
JB
132782019-03-12 John Baldwin <jhb@FreeBSD.org>
13279
13280 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13281 (ppcfbsd_init_abi): Install gdbarch
13282 "fetch_tls_load_module_address" and "get_thread_local_address"
13283 methods.
13284
b0f87ed0
JB
132852019-03-12 John Baldwin <jhb@FreeBSD.org>
13286
13287 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13288 (riscv_fbsd_init_abi): Install gdbarch
13289 "fetch_tls_load_module_address" and "get_thread_local_address"
13290 methods.
13291
ce25aa57
JB
132922019-03-12 John Baldwin <jhb@FreeBSD.org>
13293
13294 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13295 (i386fbsd_init_abi): Install gdbarch
13296 "fetch_tls_load_module_address" and "get_thread_local_address"
13297 methods.
13298
f5424cfa
JB
132992019-03-12 John Baldwin <jhb@FreeBSD.org>
13300
13301 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13302 (amd64fbsd_init_abi): Install gdbarch
13303 "fetch_tls_load_module_address" and "get_thread_local_address"
13304 methods.
13305
945f3901
JB
133062019-03-12 John Baldwin <jhb@FreeBSD.org>
13307
13308 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13309 (struct fbsd_pspace_data): New type.
13310 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13311 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13312 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13313 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13314 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13315
ef0bd204
JB
133162019-03-12 John Baldwin <jhb@FreeBSD.org>
13317
13318 * gdbtypes.c (lookup_struct_elt): New function.
13319 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13320 * gdbtypes.h (struct struct_elt): New type.
13321 (lookup_struct_elt): New prototype.
13322
36c53a02
JB
133232019-03-12 John Baldwin <jhb@FreeBSD.org>
13324
13325 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13326 remove disabled code block.
13327
6e056c81
JB
133282019-03-12 John Baldwin <jhb@FreeBSD.org>
13329
13330 * gdbarch.sh (get_thread_local_address): New method.
13331 * gdbarch.h, gdbarch.c: Regenerate.
13332 * target.c (target_translate_tls_address): Use
13333 gdbarch_get_thread_local_address if present instead of
13334 target::get_thread_local_address.
13335
cd250a18
JB
133362019-03-12 John Baldwin <jhb@FreeBSD.org>
13337
13338 * target.h (target::get_thread_local_address): Update comment.
13339
df22c1e5
JB
133402019-03-12 John Baldwin <jhb@FreeBSD.org>
13341
13342 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13343 objfile->separate_debug_objfile_backlink if not NULL.
13344
dd6876c9
JB
133452019-03-12 John Baldwin <jhb@FreeBSD.org>
13346
13347 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13348 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13349 (amd64bsd_store_inferior_registers): Likewise.
13350 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13351 Enable segment base registers.
13352 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13353 PT_GETFSBASE and PT_GETGSBASE.
13354 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13355 PT_SETGSBASE.
13356 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13357 segment base registers.
13358 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13359
1163a4b7
JB
133602019-03-12 John Baldwin <jhb@FreeBSD.org>
13361
13362 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13363 Update calls to i386_target_description to add 'segments'
13364 parameter.
13365 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13366 add segment base registers.
13367 * arch/i386.c (i386_create_target_description): Add 'segments'
13368 parameter to enable segment base registers.
13369 * arch/i386.h (i386_create_target_description): Likewise.
13370 * features/i386/32bit-segments.xml: New file.
13371 * features/i386/32bit-segments.c: Generate.
13372 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13373 call to i386_target_description to add 'segments' parameter.
13374 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13375 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13376 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13377 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13378 if feature is present.
13379 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13380 Add 'segments' parameter to call to i386_target_description.
13381 (i386_target_description): Add 'segments' parameter to enable
13382 segment base registers.
13383 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13384 to call to i386_target_description.
13385 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13386 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13387 Define I386_NUM_REGS.
13388 (i386_target_description): Add 'segments' parameter to enable
13389 segment base registers.
13390
3a350822
EZ
133912019-03-12 Eli Zaretskii <eliz@gnu.org>
13392
13393 PR/24325
13394 * source-cache.c: #undef open and close, to avoid unresolved
13395 externals during linking.
13396
ffdd69cf
TT
133972019-03-12 Tom Tromey <tromey@adacore.com>
13398
13399 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13400 const. Add initializers.
13401 (_initialize_remote): Don't initialize ptid globals.
13402
ec148c57
PA
134032019-03-12 Pedro Alves <palves@redhat.com>
13404
13405 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13406
32764270
PA
134072019-03-12 Pedro Alves <palves@redhat.com>
13408
13409 * cp-name-parser.y (main): Remove unused 'len' variable.
13410
17547186
TT
134112019-03-12 Tom Tromey <tromey@adacore.com>
13412
13413 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13414 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13415
d3a70e03
TT
134162019-03-12 Tom Tromey <tromey@adacore.com>
13417
13418 * linux-nat.c (iterate_over_lwps): Update.
13419 (stop_callback): Remove parameter.
13420 (stop_wait_callback, detach_callback, resume_set_callback)
13421 (select_singlestep_lwp_callback, set_ignore_sigint)
13422 (status_callback, resumed_callback, resume_clear_callback)
13423 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13424 data parameter.
13425 (linux_nat_target::detach, linux_nat_target::resume)
13426 (linux_stop_and_wait_all_lwps, select_event_lwp)
13427 (linux_nat_filter_event, linux_nat_wait_1)
13428 (linux_nat_target::kill, linux_nat_target::stop)
13429 (linux_nat_target::stop): Update.
13430 (linux_nat_resume_callback): Change type.
13431 (resume_stopped_resumed_lwps, count_events_callback)
13432 (select_event_lwp_callback): Likewise.
13433 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13434 * arm-linux-nat.c (struct update_registers_data): Remove.
13435 (update_registers_callback): Change type.
13436 (arm_linux_insert_hw_breakpoint1): Update.
13437 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13438 parameter.
13439 (x86_linux_dr_set_addr): Update.
13440 (x86_linux_dr_set_control): Update.
13441 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13442 (iterate_over_lwps): Use gdb::function_view.
13443 * nat/aarch64-linux-hw-point.c (struct
13444 aarch64_dr_update_callback_param): Remove.
13445 (debug_reg_change_callback): Change type.
13446 (aarch64_notify_debug_reg_change): Update.
13447 * s390-linux-nat.c (s390_refresh_per_info): Update.
13448
82cb27ff
TT
134492019-03-11 Tom Tromey <tromey@adacore.com>
13450
13451 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13452 redundant assignment to "this_cu".
13453
568c0683
SM
134542019-03-08 Simon Marchi <simon.marchi@efficios.com>
13455
13456 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13457
f09ce22d
SM
134582019-03-08 Simon Marchi <simon.marchi@efficios.com>
13459
13460 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13461 from...
13462 (rank_one_type): ... this.
13463
595f96a9
SM
134642019-03-08 Simon Marchi <simon.marchi@efficios.com>
13465
13466 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13467 from...
13468 (rank_one_type): ... this.
13469
2598a94b
SM
134702019-03-08 Simon Marchi <simon.marchi@efficios.com>
13471
13472 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13473 from...
13474 (rank_one_type): ... this.
13475
7f17b20d
SM
134762019-03-08 Simon Marchi <simon.marchi@efficios.com>
13477
13478 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13479 from...
13480 (rank_one_type): ... this.
13481
2c509035
SM
134822019-03-08 Simon Marchi <simon.marchi@efficios.com>
13483
13484 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13485 from...
13486 (rank_one_type): ... this.
13487
0dd322dc
SM
134882019-03-08 Simon Marchi <simon.marchi@efficios.com>
13489
13490 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13491 from...
13492 (rank_one_type): ... this.
13493
41ea4728
SM
134942019-03-08 Simon Marchi <simon.marchi@efficios.com>
13495
13496 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13497 from...
13498 (rank_one_type): ... this.
13499
793cd1d2
SM
135002019-03-08 Simon Marchi <simon.marchi@efficios.com>
13501
13502 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13503 from...
13504 (rank_one_type): ... this.
13505
34910087
SM
135062019-03-08 Simon Marchi <simon.marchi@efficios.com>
13507
13508 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13509 from...
13510 (rank_one_type): ... this.
13511
f1f832d6
SM
135122019-03-08 Simon Marchi <simon.marchi@efficios.com>
13513
13514 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13515 from...
13516 (rank_one_type): ... this.
13517
b9f4512f
SM
135182019-03-08 Simon Marchi <simon.marchi@efficios.com>
13519
13520 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13521 from...
13522 (rank_one_type): ... this.
13523
9293fc63
SM
135242019-03-08 Simon Marchi <simon.marchi@efficios.com>
13525
13526 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13527 from...
13528 (rank_one_type): ... this.
13529
e3abbe7e
PW
135302019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13531
13532 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13533 inferior-events' shows the example events.
13534
e4adb939
EZ
135352019-03-08 Eli Zaretskii <eliz@gnu.org>
13536
13537 Support styling on native MS-Windows console
13538
13539 PR/24315
13540 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13541 on MS-Windows if $TERM is not defined.
13542
13543 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13544
13545 * posix-hdep.c (gdb_console_fputs):
13546 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13547 functions.
13548 * ui-file.h (gdb_console_fputs): Add prototype.
13549
13550 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13551 back to fputs only if the former returns zero.
13552
25629dfd
TT
135532019-03-07 Tom Tromey <tom@tromey.com>
13554
13555 * symmisc.c (print_symbol_bcache_statistics): Update.
13556 (print_objfile_statistics): Update.
13557 * symfile.c (allocate_symtab): Update.
13558 * stabsread.c: Don't include bcache.h.
13559 * psymtab.h (struct psymbol_bcache): Don't declare.
13560 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13561 (psymbol_bcache_init, psymbol_bcache_free)
13562 (psymbol_bcache_get_bcache): Don't declare.
13563 * psymtab.c (struct psymbol_bcache): Remove.
13564 (psymtab_storage::psymtab_storage): Update.
13565 (psymtab_storage::~psymtab_storage): Update.
13566 (psymbol_bcache_init, psymbol_bcache_free)
13567 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13568 (add_psymbol_to_bcache): Update.
13569 (allocate_psymtab): Update.
13570 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13571 macro_cache>: No longer pointers.
13572 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13573 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13574 * macrotab.c (macro_bcache): Update.
13575 * macroexp.c: Don't include bcache.h.
13576 * gdbtypes.c (check_types_worklist): Update.
13577 (types_deeply_equal): Remove TRY/CATCH. Update.
13578 * elfread.c (elf_symtab_read): Update.
13579 * dwarf2read.c: Don't include bcache.h.
13580 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13581 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13582 (print_bcache_statistics, bcache_memory_used): Don't declare.
13583 (struct bcache): Move from bcache.c. Add constructor, destructor,
13584 methods. Rename all data members.
13585 * bcache.c (struct bcache): Move to bcache.h.
13586 (bcache::expand_hash_table): Rename from expand_hash_table.
13587 (bcache): Remove.
13588 (bcache::insert): Rename from bcache_full.
13589 (bcache::compare): Rename from bcache_compare.
13590 (bcache_xmalloc): Remove.
13591 (bcache::~bcache): Rename from bcache_xfree.
13592 (bcache::print_statistics): Rename from print_bcache_statistics.
13593 (bcache::memory_used): Rename from bcache_memory_used.
13594
fe726667
PA
135952019-03-07 Pedro Alves <palves@redhat.com>
13596
13597 * infrun.c (normal_stop): Also check for
13598 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13599
7584bb30
AB
136002019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13601
13602 * f-lang.c (value_from_host_double): Moved to...
13603 * value.c (value_from_host_double): ...here.
13604 * value.h (value_from_host_double): Declare.
13605 * guile/scm-math.c (vlscm_convert_typed_number): Use
13606 value_from_host_double.
13607 (vlscm_convert_number): Likewise.
13608 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13609 * python/py-value.c (convert_value_from_python): Likewise.
13610
a7b1986e
TT
136112019-03-06 Tom Tromey <tom@tromey.com>
13612
13613 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13614
0ccf4211
TT
136152019-03-06 Tom Tromey <tom@tromey.com>
13616
13617 * utils.h (free_current_contents): Don't declare.
13618 * utils.c (free_current_contents): Remove.
13619
fe7b42e5
TT
136202019-03-06 Tom Tromey <tom@tromey.com>
13621
13622 * top.c (quit_force): Update.
13623 * main.c (captured_command_loop): Update.
13624 * common/new-op.c (operator new): Update.
13625 * common/common-exceptions.c (struct catcher)
13626 <save_cleanup_chain>: Remove member.
13627 (exceptions_state_mc_init): Update.
13628 (exception_try_scope_entry): Return nullptr.
13629 (exception_try_scope_exit, exception_rethrow)
13630 (throw_exception_sjlj, throw_exception_cxx): Update.
13631 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13632 (all_cleanups, do_cleanups, discard_cleanups)
13633 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13634 (restore_cleanups, restore_final_cleanups): Don't declare.
13635 (do_final_cleanups): Remove parameter.
13636 * common/cleanups.c (cleanup_chain, make_cleanup)
13637 (make_cleanup_dtor, all_cleanups, do_cleanups)
13638 (discard_my_cleanups, discard_cleanups)
13639 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13640 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13641 (null_cleanup): Remove.
13642 (do_final_cleanups): Remove parameter.
13643
c6321f19
TT
136442019-03-06 Tom Tromey <tom@tromey.com>
13645
13646 * remote.c (remote_target::remote_parse_stop_reply): Use
13647 unique_xmalloc_ptr.
13648
61b30099
TT
136492019-03-06 Tom Tromey <tom@tromey.com>
13650
13651 * stabsread.c (struct stabs_field_info): Rename from field_info.
13652 <list, fnlist>: Add initializers.
13653 <obstack>: New member.
13654 (read_member_functions, read_struct_fields, read_baseclasses):
13655 Allocate on obstack. Don't use cleanups.
13656 (read_one_struct_field, read_member_functions, read_struct_fields)
13657 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13658 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13659 (read_struct_type): Update.
13660
6cceac94
TT
136612019-03-06 Tom Tromey <tom@tromey.com>
13662
13663 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13664 * common/filestuff.h (make_cleanup_close): Don't declare.
13665 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13666 Remove.
13667
72412762
TT
136682019-03-06 Tom Tromey <tom@tromey.com>
13669
13670 * solib-aix.c: Use make_scope_exit.
13671
2b6ff1c0
TT
136722019-03-06 Tom Tromey <tom@tromey.com>
13673
13674 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13675 Use make_scope_exit.
13676
d01c5877
TT
136772019-03-06 Tom Tromey <tom@tromey.com>
13678
13679 * solib-svr4.c (disable_probes_interface): Remove parameter.
13680 (svr4_handle_solib_event): Use make_scope_exit.
13681
32603266
TT
136822019-03-06 Tom Tromey <tom@tromey.com>
13683
13684 * remote.c (struct stop_reply_deleter): Remove.
13685 (stop_reply_up): Update.
13686 (struct stop_reply): Derive from notif_event. Don't typedef.
13687 <regcache>: Now a std::vector.
13688 (stop_reply_xfree): Remove.
13689 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13690 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13691 (remote_target::discard_pending_stop_replies): Use delete.
13692 (remote_target::remote_parse_stop_reply): Update.
13693 (remote_target::process_stop_reply): Update.
13694 * remote-notif.h (struct notif_event): Add virtual destructor.
13695 Remove "dtr" member.
13696 (struct notif_client) <alloc_event>: Return a unique_ptr.
13697 (notif_event_xfree): Don't declare.
13698 (notif_event_up): New typedef.
13699 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13700 (notif_event_xfree, do_notif_event_xfree): Remove.
13701 (remote_notif_state_xfree): Update.
13702
9799571e
TT
137032019-03-06 Tom Tromey <tom@tromey.com>
13704
13705 * infrun.c (displaced_step_clear_cleanup): Now a
13706 forward_scope_exit type.
13707 (displaced_step_prepare_throw): Update.
13708 (displaced_step_fixup): Update.
13709
09e3c4ca
TT
137102019-03-06 Tom Tromey <tom@tromey.com>
13711
13712 * inferior.h (class inferior): Update comment.
13713 * gdbthread.h (class thread_info): Update comment.
13714
e2a03548
TT
137152019-03-06 Joel Brobecker <brobecker@adacore.com>
13716 Tom Tromey <tom@tromey.com>
13717
13718 * stabsread.h (struct stab_section_list): Remove.
13719 (coffstab_build_psymtabs): Update.
13720 * dbxread.c (symbuf_sections): Now a std::vector.
13721 (sect_idx): New global.
13722 (fill_symbuf): Update.
13723 (coffstab_build_psymtabs): Change type of stabsects parameter.
13724 Update.
13725 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13726 std::vector.
13727 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13728 (coff_locate_sections): Update.
13729 (coff_symfile_read): Remove cleanups. Update.
13730 (init_stringtab): Add storage parameter.
13731 (free_stringtab, free_stringtab_cleanup): Remove.
13732 (init_lineno): Add storage parameter.
13733 (free_linetab, free_linetab_cleanup): Remove.
13734
b7e60d85
PA
137352019-03-06 Pedro Alves <palves@redhat.com>
13736
13737 * linux-fork.c (fork_info::clobber_regs): Delete.
13738 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13739 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13740 comment. Adjust.
13741 (scoped_switch_fork_info::scoped_switch_fork_info)
13742 (checkpoint_command, linux_fork_context): Adjust
13743 fork_save_infrun_state calls.
13744
e52c971f
PA
137452019-03-06 Pedro Alves <palves@redhat.com>
13746
13747 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13748 (inf_has_multiple_threads): Return 'bool' and rewrite using
13749 inferior_info::threads().
13750
06974e6c
PA
137512019-03-06 Pedro Alves <palves@redhat.com>
13752
13753 * linux-fork.c: Include <list>.
13754 (fork_list): Now a std::list instance.
13755 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13756 (forks_exist_p, find_last_fork): Adjust.
13757 (new_fork): Delete.
13758 (one_fork_p): New.
13759 (add_fork): Adjust.
13760 (free_fork): Delete, folded into fork_info::~fork_info().
13761 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13762 Adjust.
13763 (init_fork_list): Delete.
13764 (linux_fork_killall, linux_fork_mourn_inferior)
13765 (linux_fork_detach, info_checkpoints_command): Adjust.
13766 (_initialize_linux_fork): No longer call init_fork_list.
13767
72f31aea
PA
137682019-03-06 Pedro Alves <palves@redhat.com>
13769
13770 * linux-fork.c (new_fork): New, split out of ...
13771 (add_fork): ... this. Return void. Move "first fork" special
13772 case from here, to ...
13773 (checkpoint_command): ... here.
13774 * linux-linux.h (add_fork): Return void.
13775
efbecbc1
AB
137762019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13777
13778 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13779
0841c79a
AB
137802019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13781 Chris January <chris.january@arm.com>
13782 David Lecomber <david.lecomber@arm.com>
13783
13784 * f-exp.y: New token, UNOP_INTRINSIC.
13785 (exp): New pattern using UNOP_INTRINSIC token.
13786 (f77_keywords): Add 'abs' keyword.
13787 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13788 (value_from_host_double): New function.
13789 (evaluate_subexp_f): Support UNOP_ABS.
13790
4a270568
AB
137912019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13792
13793 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13794 types.
13795
067630bd
AB
137962019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13797
13798 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13799 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13800 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13801
3be47f7a
AB
138022019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13803
13804 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13805
4d00f5d8
AB
138062019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13807 Chris January <chris.january@arm.com>
13808
13809 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13810 * f-exp.y: Define 'KIND' token.
13811 (exp): New pattern for KIND expressions.
13812 (ptype): Handle types with a kind extension.
13813 (direct_abs_decl): Extend to spot kind extensions.
13814 (f77_keywords): Add 'kind' to the list.
13815 (push_kind_type): New function.
13816 (convert_to_kind_type): New function.
13817 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13818 * parse.c (operator_length_standard): Likewise.
13819 * parser-defs.h (enum type_pieces): Add tp_kind.
13820 * std-operator.def: Add UNOP_KIND.
13821
e454224f
AB
138222019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13823
13824 * f-exp.y (f_parse): Set yydebug.
13825
9dad4a58
AB
138262019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13827
13828 * f-lang.c (evaluate_subexp_f): New function.
13829 (exp_descriptor_f): New global.
13830 (f_language_defn): Use exp_descriptor_f instead of
13831 exp_descriptor_standard.
13832
c8f91604
AB
138332019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13834
13835 * f-exp.y (struct token): Add comments.
13836 (dot_ops): Remove uppercase versions and the end marker.
13837 (f77_keywords): Likewise.
13838 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13839 entries in the dot_ops array are case insensitive, and use
13840 strncasecmp to compare strings. Also some whitespace cleanup in
13841 this area. Similar for the f77_keywords array, except entries in
13842 this list might be case sensitive.
13843
dd9f2c76
AB
138442019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13845
13846 * f-exp.y (struct f77_boolean_val): Add comments.
13847 (boolean_values): Remove uppercase versions, and end marker.
13848 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13849 and use strncasecmp to achieve case insensitivity. Additionally,
13850 perform whitespace cleanup around this code.
13851
67a3048c
TT
138522019-03-06 Tom Tromey <tromey@adacore.com>
13853
13854 * remote-sim.c (gdbsim_target_open): Use result of
13855 gdb_argv::release.
13856
aa3cfbda
RB
138572019-03-06 Richard Bunt <richard.bunt@arm.com>
13858 Dirk Schubert <dirk.schubert@arm.com>
13859 Chris January <chris.january@arm.com>
13860
13861 * eval.c (evaluate_subexp_standard): Call Fortran argument
13862 wrapping logic.
13863 * f-lang.c (struct value): A value which can be passed into a
13864 Fortran function call.
13865 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13866 where appropriate.
13867 (struct type): Value ready for a Fortran function call.
13868 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13869 is needed.
13870 * f-lang.h (fortran_argument_convert): Declaration.
13871 (fortran_preserve_arg_pointer): Declaration.
13872 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13873
ea38e5df
TT
138742019-03-05 Tom Tromey <tromey@adacore.com>
13875
13876 * python/py-prettyprint.c (print_string_repr): Remove #if.
13877 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13878
06b5b831
TT
138792019-03-05 Tom Tromey <tromey@adacore.com>
13880
13881 * target.c (the_dummy_target): Move later. Change type to
13882 "dummy_target".
13883 (initialize_targets): Don't initialize the_dummy_target.
13884
edbd9e45
TT
138852019-03-05 Tom Tromey <tromey@adacore.com>
13886
13887 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13888 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13889
c119e040
TT
138902019-03-05 Tom Tromey <tromey@adacore.com>
13891
13892 * windows-nat.c (windows_nat_target::attach)
13893 (windows_nat_target::detach): Don't call gdb_flush.
13894 * valprint.c (generic_val_print, val_print, val_print_string):
13895 Don't call gdb_flush.
13896 * utils.c (defaulted_query): Don't call gdb_flush.
13897 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13898 * target.c (target_announce_detach): Don't call gdb_flush.
13899 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13900 * remote.c (extended_remote_target::attach): Don't call
13901 gdb_flush.
13902 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13903 * printcmd.c (do_examine): Don't call gdb_flush.
13904 (info_display_command): Don't call gdb_flush.
13905 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13906 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13907 * memattr.c (info_mem_command): Don't call gdb_flush.
13908 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13909 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13910 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13911 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13912 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13913 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13914 (gnu_nat_target::detach): Don't call gdb_flush.
13915 * f-valprint.c (f_val_print): Don't call gdb_flush.
13916 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13917 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13918 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13919 gdb_flush.
13920 * c-valprint.c (c_val_print): Don't call gdb_flush.
13921 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13922
895dafa6
TT
139232019-03-05 Tom Tromey <tromey@adacore.com>
13924
13925 * varobj.c (update_dynamic_varobj_children): Update.
13926 (install_default_visualizer): Use reset, not release.
13927 * value.c (set_internalvar): Update.
13928 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13929 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13930 ATTRIBUTE_UNUSED_RESULT.
13931
88a774b9
TT
139322019-03-05 Tom Tromey <tromey@adacore.com>
13933
13934 * remote.c (class scoped_remote_fd) <release>: Add
13935 ATTRIBUTE_UNUSED_RESULT.
13936
4e4a8b93
TT
139372019-03-05 Tom Tromey <tromey@adacore.com>
13938
13939 * macroexp.c (struct macro_buffer) <release>: Add
13940 ATTRIBUTE_UNUSED_RESULT.
13941
083eef1f
TT
139422019-03-05 Tom Tromey <tromey@adacore.com>
13943
13944 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13945 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13946 ATTRIBUTE_UNUSED_RESULT.
13947
3cabd438
TT
139482019-03-05 Tom Tromey <tromey@adacore.com>
13949
13950 * common/scoped_fd.h (class scoped_fd) <release>: Add
13951 ATTRIBUTE_UNUSED_RESULT.
13952
41e3300a
TT
139532019-03-05 Tom Tromey <tromey@adacore.com>
13954
13955 * parser-defs.h (struct parser_state) <release>: Add
13956 ATTRIBUTE_UNUSED_RESULT.
13957
18cb7c9f
TT
139582019-03-05 Tom Tromey <tromey@adacore.com>
13959
13960 * utils.h (class gdb_argv) <release>: Add
13961 ATTRIBUTE_UNUSED_RESULT.
13962 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13963
41fa577f
EZ
139642019-03-02 Eli Zaretskii <eliz@gnu.org>
13965
a6a4b2c6
EZ
13966 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13967 for-loop range, to avoid compiler warnings.
13968
13969 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13970 avoid compiler warnings about unused variables.
13971
742a7df5
EZ
13972 * NEWS: Mention end of support for native debugging on MS-Windows
13973 before XP.
13974
41fa577f
EZ
13975 PR gdb/24292
13976 * common/netstuff.c:
13977 * gdbserver/gdbreplay.c
13978 * gdbserver/remote-utils.c:
13979 * ser-tcp.c:
13980 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13981 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13982 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13983 'getaddrinfo' and 'freeaddrinfo' were not available before
13984 Windows XP, and mingw.org's MinGW headers by default define
13985 _WIN32_WINNT to 0x500.
13986
827f438f
GB
139872019-03-01 Gary Benson <gbenson@redhat.com>
13988
13989 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13990
92137da0
RO
139912019-02-28 Brian Vandenberg <phantall@gmail.com>
13992 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13993
13994 PR gdb/8527
13995 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13996 set_sigint_trap, clear_sigint_trap.
13997
799efbe8
PW
139982019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13999
14000 * target.c (target_detach): Clear the regcache and the
14001 frame cache.
14002
8ed25214
PA
140032019-02-27 Pedro Alves <palves@redhat.com>
14004
14005 * utils.c (set_screen_size): When we cap the height/width sizes,
14006 tweak the corresponding command variable to show "unlimited":
14007
23031e31
SJ
140082019-02-27 Saagar Jha <saagar@saagarjha.com>
14009 Pedro Alves <palves@redhat.com>
14010
14011 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14012 before calling rl_set_screen_size.
14013
6c28e44a
TT
140142019-02-27 Tom Tromey <tromey@adacore.com>
14015
14016 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14017 define.
14018 * python/py-value.c: Remove Python 2.4 workaround.
14019 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14020 workaround.
14021 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14022 Python 2.4 workaround.
14023 * python/python-internal.h: Remove Python 2.4 comment.
14024 (Py_ssize_t): Don't define.
14025 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14026 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14027 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14028 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14029 * python/python.c (do_start_initialization): Remove Python 2.4
14030 workaround.
14031 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14032 (print_children): Remove Python 2.4 workaround.
14033 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14034 workaround.
14035 (CHARBUFFERPROC_NAME): Remove.
14036 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14037 Python 2.4 workaround.
14038
2c3fc25d 140392019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14040
2c3fc25d
KB
14041 * NEWS: Note minimum Python version.
14042
6ca62222
KB
140432019-02-27 Kevin Buettner <kevinb@redhat.com>
14044
14045 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14046 code from these functions. Remove corresponding ifdefs. Use
14047 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14048 Remove gotos and target of gotos.
14049 (infpy_search_memory): Likewise.
14050
f4bc7d2c
AB
140512019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14052
14053 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14054 (hppa_gdbarch_init): Don't register deleted functions with
14055 gdbarch.
14056
9734a586
AB
140572019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14058
14059 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14060 (h8300_unwind_sp): Delete.
14061 (h8300_dummy_id): Delete.
14062 (h8300_gdbarch_init): Don't register deleted functions with
14063 gdbarch.
14064
68b867f3
AB
140652019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14066
14067 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14068 (ft32_unwind_pc): Delete.
14069 (ft32_unwind_sp): Delete.
14070 (ft32_gdbarch_init): Don't register deleted functions with
14071 gdbarch.
14072
2fbe7ad0
AB
140732019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14074
14075 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14076 (frv_unwind_pc): Delete.
14077 (frv_unwind_sp): Delete.
14078 (frv_gdbarch_init): Don't register deleted functions with
14079 gdbarch.
14080
76055cbe
AB
140812019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14082
14083 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14084 (riscv_unwind_pc): Delete.
14085 (riscv_unwind_sp): Delete.
14086 (riscv_gdbarch_init): Don't register deleted functions with
14087 gdbarch.
14088
4133e5a1
AB
140892019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14090
14091 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14092 (csky_unwind_pc): Delete.
14093 (csky_unwind_sp): Delete.
14094 (csky_gdbarch_init): Don't register deleted functions with
14095 gdbarch.
14096
8010f576
AB
140972019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14098
14099 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14100 (cris_unwind_pc): Delete.
14101 (cris_unwind_sp): Delete.
14102 (cris_gdbarch_init): Don't register deleted functions with
14103 gdbarch.
14104
b56bf084
AB
141052019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14106
14107 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14108 (bfin_unwind_pc): Delete.
14109 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14110
a19a650f
AB
141112019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14112
14113 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14114 (arm_unwind_pc): Delete.
14115 (arm_unwind_sp): Delete.
14116 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14117
f8278c3c
AB
141182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14119
14120 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14121 (arc_unwind_pc): Delete.
14122 (arc_unwind_sp): Delete.
14123 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14124
480e46cf
AB
141252019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14126
14127 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14128 (alpha_unwind_pc): Delete.
14129 (alpha_gdbarch_init): Don't register deleted functions with
14130 gdbarch.
14131
7a995095
AB
141322019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14133
14134 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14135 (aarch64_unwind_pc): Delete.
14136 (aarch64_unwind_sp): Delete.
14137 (aarch64_gdbarch_init): Don't register deleted functions with
14138 gdbarch.
14139
bf9a735e
AB
141402019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14141
14142 * gdbtypes.c (type_align): Don't consider static members when
14143 computing structure alignment.
14144
5561fc30
AB
141452019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14146
14147 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14148 return 0 for other types.
14149 * arch-utils.c (default_type_align): Always return 0.
14150 * gdbarch.h: Regenerate.
14151 * gdbarch.sh (type_align): Extend comment.
14152 * gdbtypes.c (type_align): Add additional comments, always call
14153 gdbarch_type_align before applying the default rules.
14154 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14155 generic code will then apply a suitable default.
14156 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14157 types, return 0 for other types.
14158
9335e75a
JB
141592019-02-27 Joel Brobecker <brobecker@adacore.com>
14160
14161 * NEWS: Create a new section for the next release branch.
14162 Rename the section of the current branch, now that it has
14163 been cut.
14164
3d34d8de
JB
141652019-02-27 Joel Brobecker <brobecker@adacore.com>
14166
14167 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14168 * version.in: Bump version to 8.3.50.DATE-git.
14169
143420fb
SM
141702019-02-26 Simon Marchi <simon.marchi@efficios.com>
14171
14172 * aix-thread.c (ptid_cmp): Remove unused variable.
14173 (get_signaled_thread): Likewise.
14174 (store_regs_user_thread): Likewise.
14175 (store_regs_kernel_thread): Likewise.
14176 (fetch_regs_kernel_thread): Remove shadowed variable.
14177
172fb711
AB
141782019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14179
14180 * features/riscv/32bit-cpu.xml: Add register numbers.
14181 * features/riscv/32bit-fpu.c: Regenerate.
14182 * features/riscv/32bit-fpu.xml: Add register numbers.
14183 * features/riscv/64bit-cpu.xml: Add register numbers.
14184 * features/riscv/64bit-fpu.c: Regenerate.
14185 * features/riscv/64bit-fpu.xml: Add register numbers.
14186
26c89782
KB
141872019-02-26 Kevin Buettner <kevinb@redhat.com>
14188
af54ade9 14189 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14190 * python/py-value.c (convert_buffer_and_type_to_value): New
14191 function.
14192 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14193 Add support for handling an optional second argument. Call
14194 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14195 * python/python-internal.h (Py_buffer_deleter): New struct.
14196 (Py_buffer_up): New typedef.
14197
0f58c9e8
JB
141982019-02-25 John Baldwin <jhb@FreeBSD.org>
14199
14200 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14201 instead of releasing ownership.
14202
0a0f4c01
JR
142032019-02-25 Jordan Rupprecht <rupprecht@google.com>
14204
14205 * dwarf2read.c (open_and_init_dwp_file): Call
14206 elf_numsections instead of bfd_count_sections to initialize
14207 dwp_file->num_sections.
14208
cd5a152c
TT
142092019-02-25 Tom Tromey <tromey@adacore.com>
14210
14211 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14212
8a6a8513
SDJ
142132019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14214
14215 * gcore.in: Add '--readnever' option when invoking GDB.
14216
04dcda9c
SM
142172019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14218
14219 * MAINTAINERS: Update my email address.
14220
07bc701d
SM
142212019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14222
14223 * build-id.c (build_id_to_debug_bfd_1): New function.
14224 (build_id_to_debug_bfd): Look for separate debug file in
14225 sysroot.
14226
c6f4a5d0
AB
142272019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14228
14229 * gdbarch.sh: Update the copyright year range that is placed into
14230 generated files.
14231
9600246d
KS
142322019-02-22 Keith Seitz <keiths@redhat.com>
14233
14234 PR symtab/23853
14235 * linespec.c (create_sals_line_offset): Search for the default
14236 symtab's filename instead of its fullname.
14237
7557a514
AH
142382019-02-21 Alan Hayward <alan.hayward@arm.com>
14239
14240 * NEWS: Update style defaults.
14241
ee2bcb0c
AH
142422019-02-21 Alan Hayward <alan.hayward@arm.com>
14243
14244 * main.c (captured_main_1): Disable styling in batch mode.
14245
0c95f9ed
TT
142462019-02-20 Tom Tromey <tom@tromey.com>
14247
14248 * symtab.c (symtab_symbol_info): Fix typos.
14249
c763b894
TT
142502019-02-20 Tom Tromey <tromey@adacore.com>
14251
14252 * findcmd.c (_initialize_mem_search): Use upper case for
14253 metasyntactic variables.
14254
0ef8a082
AH
142552019-02-20 Alan Hayward <alan.hayward@arm.com>
14256
14257 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14258 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14259
6caa91b6
SM
142602019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14261
14262 * top.h (source_file_name): Change to std::string.
14263 * top.c (source_file_name): Likewise.
14264 (command_line_input): Adjust.
14265 * cli/cli-script.c (script_from_file): Adjust.
14266
98814c6c
TT
142672019-02-19 Tom Tromey <tromey@adacore.com>
14268
14269 * ravenscar-thread.c
14270 (ravenscar_thread_target::update_thread_list): Don't call
14271 ada_build_task_list.
14272 * ada-lang.h (ada_build_task_list): Don't declare.
14273 * ada-tasks.c (struct ada_tasks_inferior_data)
14274 <task_list_valid_p>: Now bool.
14275 (read_known_tasks, ada_task_list_changed)
14276 (ada_tasks_invalidate_inferior_data): Update.
14277 (read_known_tasks_array): Return bool.
14278 (read_known_tasks_list): Likewise.
14279 (read_known_tasks): Return void.
14280 (ada_build_task_list): Now static.
14281
70cd633e
AB
142822019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14283
14284 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14285 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14286
040b3e95
PW
142872019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14288
14289 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14290 variant for ada_tasks_pspace_data_handle and
14291 ada_tasks_inferior_data_handle.
14292 (ada_tasks_pspace_data_cleanup): New function.
14293 (ada_tasks_inferior_data_cleanup): New function.
14294
9409233b
TT
142952019-02-17 Tom Tromey <tom@tromey.com>
14296
14297 * macrotab.h (macro_source_fullname): Return a std::string.
14298 * macrotab.c (macro_include, check_for_redefinition)
14299 (macro_undef, macro_lookup_definition, foreach_macro)
14300 (foreach_macro_in_scope): Update.
14301 (macro_source_fullname): Return a std::string.
14302 * macrocmd.c (show_pp_source_pos): Update.
14303
6506371f
TT
143042019-02-17 Tom Tromey <tom@tromey.com>
14305
14306 * macrocmd.c (show_pp_source_pos): Style the file names.
14307
0c820d67
TT
143082019-02-17 Tom Tromey <tom@tromey.com>
14309
14310 PR tui/24197:
14311 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14312
a0087920
TT
143132019-02-17 Tom Tromey <tom@tromey.com>
14314
14315 * ada-lang.c (user_select_syms): Use filtered printing.
14316 * utils.c (wrap_style): New global.
14317 (desired_style): Remove.
14318 (emit_style_escape): Add stream parameter.
14319 (set_output_style, reset_terminal_style, prompt_for_continue):
14320 Update.
14321 (flush_wrap_buffer): Only flush gdb_stdout.
14322 (wrap_here): Set wrap_style.
14323 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14324 treat escape sequences as a character. Change when wrap buffer is
14325 flushed.
14326 (fputs_styled): Do not set the output style when the default is
14327 requested.
14328 * ui-style.h (struct ui_file_style) <is_default>: New method.
14329 * source.c (print_source_lines_base): Emit escape sequences in one
14330 piece.
14331
75ba10dc
JB
143322019-02-17 Joel Brobecker <brobecker@adacore.com>
14333
14334 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14335 integers and enumeration types.
14336
a2cd4f14
JB
143372019-02-17 Joel Brobecker <brobecker@adacore.com>
14338
14339 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14340 instead of lookup_symbol_in_language
14341 (do_exact_match): New function.
14342 (ada_get_symbol_name_matcher): Return do_exact_match when
14343 doing a verbatim match.
14344
485b851b
TT
143452019-02-15 Tom Tromey <tromey@adacore.com>
14346
14347 * ravenscar-thread.c (ravenscar_thread_target::resume)
14348 (ravenscar_thread_target::wait): Special case wildcard requests.
14349
0b790b1e
TT
143502019-02-15 Tom Tromey <tromey@adacore.com>
14351
14352 * ravenscar-thread.c (base_ptid): Remove.
14353 (struct ravenscar_thread_target) <close>: New method.
14354 <m_base_ptid>: New member.
14355 <update_inferior_ptid, active_task, task_is_currently_active,
14356 runtime_initialized>: Declare methods.
14357 <ravenscar_thread_target>: Add constructor.
14358 (ravenscar_thread_target::task_is_currently_active)
14359 (ravenscar_thread_target::update_inferior_ptid)
14360 (ravenscar_runtime_initialized): Rename. Now methods.
14361 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14362 (ravenscar_thread_target::update_thread_list): Update.
14363 (ravenscar_thread_target::active_task): Now method.
14364 (ravenscar_thread_target::store_registers)
14365 (ravenscar_thread_target::prepare_to_store)
14366 (ravenscar_thread_target::prepare_to_store)
14367 (ravenscar_thread_target::mourn_inferior): Update.
14368 (ravenscar_inferior_created): Use "new" to create target.
14369 (ravenscar_thread_target::get_ada_task_ptid): Update.
14370 (_initialize_ravenscar): Don't initialize base_ptid.
14371 (ravenscar_ops): Remove global.
14372
dea57a62
TT
143732019-02-15 Tom Tromey <tromey@adacore.com>
14374
14375 * target.h (push_target): Declare new overload.
14376 * target.c (push_target): New overload, taking an rvalue reference.
14377 * remote.c (remote_target::open_1): Use push_target overload.
14378 * corelow.c (core_target_open): Use push_target overload.
14379
989f3c58
TT
143802019-02-15 Tom Tromey <tromey@adacore.com>
14381
14382 * ravenscar-thread.c (is_ravenscar_task)
14383 (ravenscar_task_is_currently_active): Return bool.
14384 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14385 (_initialize_ravenscar): Remove "(void)".
14386 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14387 Return bool.
14388
6cbcc006
TT
143892019-02-15 Tom Tromey <tromey@adacore.com>
14390
14391 * ravenscar-thread.c (ravenscar_runtime_initializer)
14392 (has_ravenscar_runtime, get_running_thread_id)
14393 (ravenscar_thread_target::resume): Fix indentation.
14394
7657f14d
TT
143952019-02-15 Tom Tromey <tromey@adacore.com>
14396
14397 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14398 from ravenscar_arch_ops.
14399 (sparc_ravenscar_ops::fetch_registers)
14400 (sparc_ravenscar_ops::store_registers): Now methods.
14401 (sparc_ravenscar_prepare_to_store): Remove.
14402 (sparc_ravenscar_ops): Redefine.
14403 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14404 methods and destructor. Remove members.
14405 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14406 (ravenscar_thread_target::store_registers)
14407 (ravenscar_thread_target::prepare_to_store): Update.
14408 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14409 Remove.
14410 (struct ppc_ravenscar_powerpc_ops): Derive from
14411 ravenscar_arch_ops.
14412 (ppc_ravenscar_powerpc_ops::fetch_registers)
14413 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14414 (ppc_ravenscar_powerpc_ops): Redefine.
14415 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14416 (ppc_ravenscar_e500_ops::fetch_registers)
14417 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14418 (ppc_ravenscar_e500_ops): Redefine.
14419 * aarch64-ravenscar-thread.c
14420 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14421 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14422 (aarch64_ravenscar_fetch_registers)
14423 (aarch64_ravenscar_store_registers): Now methods.
14424 (aarch64_ravenscar_ops): Redefine.
14425
5b6ea500
TT
144262019-02-15 Tom Tromey <tromey@adacore.com>
14427
14428 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14429 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14430 (ravenscar_thread_target::stopped_by_watchpoint)
14431 (ravenscar_thread_target::stopped_data_address)
14432 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14433
e397fd39
TT
144342019-02-15 Tom Tromey <tromey@adacore.com>
14435
14436 * ravenscar-thread.c: Fix some typos.
14437
cc12f4a8
TT
144382019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14439 Tom Tromey <tromey@adacore.com>
14440
14441 * ada-lang.c (ada_exception_sal): Change addr_string to a
14442 std::string.
14443 (create_ada_exception_catchpoint): Update.
14444
5f486660
TT
144452019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14446 Tom Tromey <tromey@adacore.com>
14447
14448 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14449 (bp_location_ops): Remove.
14450 (base_breakpoint_allocate_location): Update.
14451 (free_bp_location): Update.
14452 * ada-lang.c (class ada_catchpoint_location)
14453 <ada_catchpoint_location>: Remove ops parameter.
14454 (ada_catchpoint_location_dtor): Remove.
14455 (ada_catchpoint_location_ops): Remove.
14456 (allocate_location_exception): Update.
14457 * breakpoint.h (struct bp_location_ops): Remove.
14458 (class bp_location) <bp_location>: Remove bp_location_ops
14459 parameter.
14460 <~bp_location>: Add destructor.
14461 <ops>: Remove.
14462
b671c7fb
TS
144632019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14464 Pedro Alves <palves@redhat.com>
14465
14466 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14467 'PATH_MAX'.
14468
8071c5ce
DM
144692019-02-14 David Michael <fedora.dm0@gmail.com>
14470 Samuel Thibault <samuel.thibault@gnu.org>
14471 Thomas Schwinge <thomas@codesourcery.com>
14472
14473 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14474 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14475
b1041ae0
TS
144762019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14477
924514e1
TS
14478 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14479 (check_empty): Use "const char *".
14480
c29ee8d4
TS
14481 * gnu-nat.c (gnu_nat_target::detach): Instead of
14482 'detach_inferior (pid)' call
14483 'detach_inferior (find_inferior_pid (pid))'.
14484
6c6ef69f
TS
14485 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14486 'nat/fork-inferior.o'.
14487 * gnu-nat.c: #include "nat/fork-inferior.h".
14488
2d0a338c
TS
14489 * gnu-nat.c (gnu_nat_target::detach): Instead of
14490 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14491 * gnu-nat.h: #include "inf-child.h".
14492 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14493 'i386_gnu_nat_target::fetch_registers'.
14494 (gnu_store_registers): Rename/move to
14495 'i386_gnu_nat_target::store_registers'.
14496
cabb5f06
TS
14497 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14498 * gnu-nat.h (mach_thread_info): New function.
14499 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14500
b1041ae0
TS
14501 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14502
2988d01e
KF
145032019-02-14 Frederic Konrad <konrad@adacore.com>
14504
14505 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14506
c559d709
JB
145072019-02-14 Joel Brobecker <brobecker@adacore.com>
14508
14509 * windows-nat.c (windows_add_thread): Add new parameter
14510 "main_thread_p" with default value set to false. Update
14511 function documentation as well as all callers.
14512 (windows_delete_thread): Likewise.
14513 (fake_create_process): Update call to windows_add_thread.
14514 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14515 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14516 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14517 call to windows_delete_thread.
14518
007024cc
SM
145192019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14520
14521 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14522
f62318e9
JB
145232019-02-12 John Baldwin <jhb@FreeBSD.org>
14524
14525 * symfile.c (find_separate_debug_file): Use canonical path of
14526 sysroot with child_path instead of gdb_sysroot if it is valid.
14527
cd4b7848
JB
145282019-02-12 John Baldwin <jhb@FreeBSD.org>
14529
14530 * symfile.c (find_separate_debug_file): Use child_path to
14531 determine if an object file is under a sysroot.
14532
efac4bfe
JB
145332019-02-12 John Baldwin <jhb@FreeBSD.org>
14534
14535 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14536 unittests/child-path-selftests.c.
14537 * common/pathstuff.c (child_path): New function.
14538 * common/pathstuff.h (child_path): New prototype.
14539 * unittests/child-path-selftests.c: New file.
14540
402d2bfe
JB
145412019-02-12 John Baldwin <jhb@FreeBSD.org>
14542
14543 * symfile.c (find_separate_debug_file): Look for separate debug
14544 files in debug directories under the sysroot.
14545
1ed9f74e
PW
145462019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14547
14548 * symtab.h (struct minimal_symbol data_p): New const method.
14549 (struct minimal_symbol text_p): Likewise.
14550 * symtab.c (output_source_filename): Use file name style
14551 to print file name.
14552 (print_symbol_info): Likewise.
14553 (print_msymbol_info): Use address style to print addresses.
14554 Use function name style to print executable text symbols.
14555 (expand_symtab_containing_pc): Use data_p.
14556 (find_pc_sect_compunit_symtab): Likewise.
14557
2636d81d
PW
145582019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14559
14560 * breakpoint.c (describe_other_breakpoints): Use address style
14561 to print addresses.
14562 (say_where): Likewise.
14563
ac8c53cc
PW
145642019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14565
14566 * ada-typeprint.c (print_func_type): Print function name
14567 style to print function name.
14568 * c-typeprint.c (c_print_type_1): Likewise.
14569
ea638c43
AH
145702019-02-11 Alan Hayward <alan.hayward@arm.com>
14571
14572 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14573 for execve.
14574
ab759ca8
PW
145752019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14576
14577 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14578 type_stack.
14579
aff29d1c
JB
145802019-02-10 Joel Brobecker <brobecker@adacore.com>
14581
14582 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14583 TYPE_CODE_REF types.
14584
617126bc
JW
145852019-02-08 Jim Wilson <jimw@sifive.com>
14586
14587 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14588 (riscv_linux_fregset): New.
14589 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14590
46e3ed7f
TT
145912019-02-07 Tom Tromey <tom@tromey.com>
14592
14593 * thread.c (thread_cancel_execution_command): Update.
14594 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14595 methods.
14596 (struct thread_fsm_ops): Remove.
14597 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14598 (thread_fsm_should_stop, thread_fsm_return_value)
14599 (thread_fsm_set_finished, thread_fsm_finished_p)
14600 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14601 Don't declare.
14602 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14603 * infrun.c (clear_proceed_status_thread)
14604 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14605 (print_stop_event): Update.
14606 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14607 Add constructor.
14608 (step_command_fsm_ops): Remove.
14609 (new_step_command_fsm): Remove.
14610 (step_1): Update.
14611 (step_command_fsm::should_stop): Rename from
14612 step_command_fsm_should_stop.
14613 (step_command_fsm::clean_up): Rename from
14614 step_command_fsm_clean_up.
14615 (step_command_fsm::do_async_reply_reason): Rename from
14616 step_command_fsm_async_reply_reason.
14617 (struct until_next_fsm): Inherit from thread_fsm. Add
14618 constructor.
14619 (until_next_fsm_ops): Remove.
14620 (new_until_next_fsm): Remove.
14621 (until_next_fsm::should_stop): Rename from
14622 until_next_fsm_should_stop.
14623 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14624 (until_next_fsm::do_async_reply_reason): Rename from
14625 until_next_fsm_async_reply_reason.
14626 (struct finish_command_fsm): Inherit from thread_fsm. Add
14627 constructor. Change type of breakpoint.
14628 (finish_command_fsm_ops): Remove.
14629 (new_finish_command_fsm): Remove.
14630 (finish_command_fsm::should_stop): Rename from
14631 finish_command_fsm_should_stop.
14632 (finish_command_fsm::clean_up): Rename from
14633 finish_command_fsm_clean_up.
14634 (finish_command_fsm::return_value): Rename from
14635 finish_command_fsm_return_value.
14636 (finish_command_fsm::do_async_reply_reason): Rename from
14637 finish_command_fsm_async_reply_reason.
14638 (finish_command): Update.
14639 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14640 Add constructor.
14641 (call_thread_fsm_ops): Remove.
14642 (call_thread_fsm::call_thread_fsm): Rename from
14643 new_call_thread_fsm.
14644 (call_thread_fsm::should_stop): Rename from
14645 call_thread_fsm_should_stop.
14646 (call_thread_fsm::should_notify_stop): Rename from
14647 call_thread_fsm_should_notify_stop.
14648 (run_inferior_call, call_function_by_hand_dummy): Update.
14649 * cli/cli-interp.c (should_print_stop_to_console): Update.
14650 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14651 Add constructor. Change type of location_breakpoint,
14652 caller_breakpoint.
14653 (until_break_fsm_ops): Remove.
14654 (new_until_break_fsm): Remove.
14655 (until_break_fsm::should_stop): Rename from
14656 until_break_fsm_should_stop.
14657 (until_break_fsm::clean_up): Rename from
14658 until_break_fsm_clean_up.
14659 (until_break_fsm::do_async_reply_reason): Rename from
14660 until_break_fsm_async_reply_reason.
14661 (until_break_command): Update.
14662 * thread-fsm.c: Remove.
14663 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14664
1a5c2598
TT
146652019-02-07 Tom Tromey <tom@tromey.com>
14666
14667 * yy-remap.h: Add include guard.
14668 * xtensa-tdep.h: Add include guard.
14669 * xcoffread.h: Rename include guard.
14670 * varobj-iter.h: Add include guard.
14671 * tui/tui.h: Rename include guard.
14672 * tui/tui-winsource.h: Rename include guard.
14673 * tui/tui-wingeneral.h: Rename include guard.
14674 * tui/tui-windata.h: Rename include guard.
14675 * tui/tui-win.h: Rename include guard.
14676 * tui/tui-stack.h: Rename include guard.
14677 * tui/tui-source.h: Rename include guard.
14678 * tui/tui-regs.h: Rename include guard.
14679 * tui/tui-out.h: Rename include guard.
14680 * tui/tui-layout.h: Rename include guard.
14681 * tui/tui-io.h: Rename include guard.
14682 * tui/tui-hooks.h: Rename include guard.
14683 * tui/tui-file.h: Rename include guard.
14684 * tui/tui-disasm.h: Rename include guard.
14685 * tui/tui-data.h: Rename include guard.
14686 * tui/tui-command.h: Rename include guard.
14687 * tic6x-tdep.h: Add include guard.
14688 * target/waitstatus.h: Rename include guard.
14689 * target/wait.h: Rename include guard.
14690 * target/target.h: Rename include guard.
14691 * target/resume.h: Rename include guard.
14692 * target-float.h: Rename include guard.
14693 * stabsread.h: Add include guard.
14694 * rs6000-tdep.h: Add include guard.
14695 * riscv-fbsd-tdep.h: Add include guard.
14696 * regformats/regdef.h: Rename include guard.
14697 * record.h: Rename include guard.
14698 * python/python.h: Rename include guard.
14699 * python/python-internal.h: Rename include guard.
14700 * python/py-stopevent.h: Rename include guard.
14701 * python/py-ref.h: Rename include guard.
14702 * python/py-record.h: Rename include guard.
14703 * python/py-record-full.h: Rename include guard.
14704 * python/py-record-btrace.h: Rename include guard.
14705 * python/py-instruction.h: Rename include guard.
14706 * python/py-events.h: Rename include guard.
14707 * python/py-event.h: Rename include guard.
14708 * procfs.h: Add include guard.
14709 * proc-utils.h: Add include guard.
14710 * p-lang.h: Add include guard.
14711 * or1k-tdep.h: Rename include guard.
14712 * observable.h: Rename include guard.
14713 * nto-tdep.h: Rename include guard.
14714 * nat/x86-linux.h: Rename include guard.
14715 * nat/x86-linux-dregs.h: Rename include guard.
14716 * nat/x86-gcc-cpuid.h: Add include guard.
14717 * nat/x86-dregs.h: Rename include guard.
14718 * nat/x86-cpuid.h: Rename include guard.
14719 * nat/ppc-linux.h: Rename include guard.
14720 * nat/mips-linux-watch.h: Rename include guard.
14721 * nat/linux-waitpid.h: Rename include guard.
14722 * nat/linux-ptrace.h: Rename include guard.
14723 * nat/linux-procfs.h: Rename include guard.
14724 * nat/linux-osdata.h: Rename include guard.
14725 * nat/linux-nat.h: Rename include guard.
14726 * nat/linux-namespaces.h: Rename include guard.
14727 * nat/linux-btrace.h: Rename include guard.
14728 * nat/glibc_thread_db.h: Rename include guard.
14729 * nat/gdb_thread_db.h: Rename include guard.
14730 * nat/gdb_ptrace.h: Rename include guard.
14731 * nat/fork-inferior.h: Rename include guard.
14732 * nat/amd64-linux-siginfo.h: Rename include guard.
14733 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14734 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14735 * nat/aarch64-linux.h: Rename include guard.
14736 * nat/aarch64-linux-hw-point.h: Rename include guard.
14737 * mn10300-tdep.h: Add include guard.
14738 * mips-linux-tdep.h: Add include guard.
14739 * mi/mi-parse.h: Rename include guard.
14740 * mi/mi-out.h: Rename include guard.
14741 * mi/mi-main.h: Rename include guard.
14742 * mi/mi-interp.h: Rename include guard.
14743 * mi/mi-getopt.h: Rename include guard.
14744 * mi/mi-console.h: Rename include guard.
14745 * mi/mi-common.h: Rename include guard.
14746 * mi/mi-cmds.h: Rename include guard.
14747 * mi/mi-cmd-break.h: Rename include guard.
14748 * m2-lang.h: Add include guard.
14749 * location.h: Rename include guard.
14750 * linux-record.h: Rename include guard.
14751 * linux-nat.h: Add include guard.
14752 * linux-fork.h: Add include guard.
14753 * i386-darwin-tdep.h: Rename include guard.
14754 * hppa-linux-offsets.h: Add include guard.
14755 * guile/guile.h: Rename include guard.
14756 * guile/guile-internal.h: Rename include guard.
14757 * gnu-nat.h: Rename include guard.
14758 * gdb-stabs.h: Rename include guard.
14759 * frv-tdep.h: Add include guard.
14760 * f-lang.h: Add include guard.
14761 * event-loop.h: Add include guard.
14762 * darwin-nat.h: Rename include guard.
14763 * cp-abi.h: Rename include guard.
14764 * config/sparc/nm-sol2.h: Rename include guard.
14765 * config/nm-nto.h: Rename include guard.
14766 * config/nm-linux.h: Add include guard.
14767 * config/i386/nm-i386gnu.h: Rename include guard.
14768 * config/djgpp/nl_types.h: Rename include guard.
14769 * config/djgpp/langinfo.h: Rename include guard.
14770 * compile/gcc-cp-plugin.h: Add include guard.
14771 * compile/gcc-c-plugin.h: Add include guard.
14772 * compile/compile.h: Rename include guard.
14773 * compile/compile-object-run.h: Rename include guard.
14774 * compile/compile-object-load.h: Rename include guard.
14775 * compile/compile-internal.h: Rename include guard.
14776 * compile/compile-cplus.h: Rename include guard.
14777 * compile/compile-c.h: Rename include guard.
14778 * common/xml-utils.h: Rename include guard.
14779 * common/x86-xstate.h: Rename include guard.
14780 * common/version.h: Rename include guard.
14781 * common/vec.h: Rename include guard.
14782 * common/tdesc.h: Rename include guard.
14783 * common/selftest.h: Rename include guard.
14784 * common/scoped_restore.h: Rename include guard.
14785 * common/scoped_mmap.h: Rename include guard.
14786 * common/scoped_fd.h: Rename include guard.
14787 * common/safe-iterator.h: Rename include guard.
14788 * common/run-time-clock.h: Rename include guard.
14789 * common/refcounted-object.h: Rename include guard.
14790 * common/queue.h: Rename include guard.
14791 * common/ptid.h: Rename include guard.
14792 * common/print-utils.h: Rename include guard.
14793 * common/preprocessor.h: Rename include guard.
14794 * common/pathstuff.h: Rename include guard.
14795 * common/observable.h: Rename include guard.
14796 * common/netstuff.h: Rename include guard.
14797 * common/job-control.h: Rename include guard.
14798 * common/host-defs.h: Rename include guard.
14799 * common/gdb_wait.h: Rename include guard.
14800 * common/gdb_vecs.h: Rename include guard.
14801 * common/gdb_unlinker.h: Rename include guard.
14802 * common/gdb_unique_ptr.h: Rename include guard.
14803 * common/gdb_tilde_expand.h: Rename include guard.
14804 * common/gdb_sys_time.h: Rename include guard.
14805 * common/gdb_string_view.h: Rename include guard.
14806 * common/gdb_splay_tree.h: Rename include guard.
14807 * common/gdb_setjmp.h: Rename include guard.
14808 * common/gdb_ref_ptr.h: Rename include guard.
14809 * common/gdb_optional.h: Rename include guard.
14810 * common/gdb_locale.h: Rename include guard.
14811 * common/gdb_assert.h: Rename include guard.
14812 * common/filtered-iterator.h: Rename include guard.
14813 * common/filestuff.h: Rename include guard.
14814 * common/fileio.h: Rename include guard.
14815 * common/environ.h: Rename include guard.
14816 * common/common-utils.h: Rename include guard.
14817 * common/common-types.h: Rename include guard.
14818 * common/common-regcache.h: Rename include guard.
14819 * common/common-inferior.h: Rename include guard.
14820 * common/common-gdbthread.h: Rename include guard.
14821 * common/common-exceptions.h: Rename include guard.
14822 * common/common-defs.h: Rename include guard.
14823 * common/common-debug.h: Rename include guard.
14824 * common/cleanups.h: Rename include guard.
14825 * common/buffer.h: Rename include guard.
14826 * common/btrace-common.h: Rename include guard.
14827 * common/break-common.h: Rename include guard.
14828 * cli/cli-utils.h: Rename include guard.
14829 * cli/cli-style.h: Rename include guard.
14830 * cli/cli-setshow.h: Rename include guard.
14831 * cli/cli-script.h: Rename include guard.
14832 * cli/cli-interp.h: Rename include guard.
14833 * cli/cli-decode.h: Rename include guard.
14834 * cli/cli-cmds.h: Rename include guard.
14835 * charset-list.h: Add include guard.
14836 * buildsym-legacy.h: Rename include guard.
14837 * bfin-tdep.h: Add include guard.
14838 * ax.h: Rename include guard.
14839 * arm-linux-tdep.h: Add include guard.
14840 * arm-fbsd-tdep.h: Add include guard.
14841 * arch/xtensa.h: Rename include guard.
14842 * arch/tic6x.h: Add include guard.
14843 * arch/i386.h: Add include guard.
14844 * arch/arm.h: Rename include guard.
14845 * arch/arm-linux.h: Rename include guard.
14846 * arch/arm-get-next-pcs.h: Rename include guard.
14847 * arch/amd64.h: Add include guard.
14848 * arch/aarch64-insn.h: Rename include guard.
14849 * arch-utils.h: Rename include guard.
14850 * annotate.h: Add include guard.
14851 * amd64-darwin-tdep.h: Rename include guard.
14852 * aarch64-linux-tdep.h: Add include guard.
14853 * aarch64-fbsd-tdep.h: Add include guard.
14854 * aarch32-linux-nat.h: Add include guard.
14855
ab9268d2
PW
148562019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14857
14858 * macrotab.c (macro_define_internal): New function that
14859 factorizes macro_define_object_internal and macro_define_function
14860 code.
14861 (macro_define_object_internal): Use macro_define_internal.
14862 (macro_define_function): Likewise.
14863
bb0da2b4
PW
148642019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14865
14866 * macrocmd.c (extract_identifier): Return
14867 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14868 callers.
14869
424eb552
JB
148702019-02-06 John Baldwin <jhb@FreeBSD.org>
14871
14872 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14873
1688cb29
TT
148742019-02-05 Tom Tromey <tom@tromey.com>
14875
14876 * target.c (target_stack::unpush): Move assertion earlier.
14877
b5eba2d8
TT
148782019-01-30 Tom Tromey <tom@tromey.com>
14879
14880 PR python/23615:
14881 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14882 (gdbpy_parse_and_eval): Likewise.
14883 * python/python-internal.h (gdbpy_allow_threads): New class.
14884
7054e2ff
JB
148852019-01-28 John Baldwin <jhb@FreeBSD.org>
14886
14887 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14888 (aarch64_fbsd_fpregmap): Move earlier.
14889 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14890 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14891 instead of individual calls to trad_frame_set_reg_addr.
14892 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14893 earlier.
14894 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14895 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14896 instead of individual calls to trad_frame_set_reg_addr.
14897
36c25ffa
AH
148982019-01-28 Alan Hayward <alan.hayward@arm.com>
14899
14900 * CONTRIBUTE: Replace contribution list with wiki link.
14901
a0707f3c
TT
149022019-01-25 Tom Tromey <tom@tromey.com>
14903
14904 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14905
0747795c
TT
149062019-01-25 Tom Tromey <tom@tromey.com>
14907
14908 * xtensa-linux-nat.c: Fix common/ includes.
14909 * xml-support.h: Fix common/ includes.
14910 * xml-support.c: Fix common/ includes.
14911 * x86-linux-nat.c: Fix common/ includes.
14912 * windows-nat.c: Fix common/ includes.
14913 * varobj.h: Fix common/ includes.
14914 * varobj.c: Fix common/ includes.
14915 * value.c: Fix common/ includes.
14916 * valops.c: Fix common/ includes.
14917 * utils.c: Fix common/ includes.
14918 * unittests/xml-utils-selftests.c: Fix common/ includes.
14919 * unittests/utils-selftests.c: Fix common/ includes.
14920 * unittests/unpack-selftests.c: Fix common/ includes.
14921 * unittests/tracepoint-selftests.c: Fix common/ includes.
14922 * unittests/style-selftests.c: Fix common/ includes.
14923 * unittests/string_view-selftests.c: Fix common/ includes.
14924 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14925 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14926 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14927 * unittests/rsp-low-selftests.c: Fix common/ includes.
14928 * unittests/parse-connection-spec-selftests.c: Fix common/
14929 includes.
14930 * unittests/optional-selftests.c: Fix common/ includes.
14931 * unittests/offset-type-selftests.c: Fix common/ includes.
14932 * unittests/observable-selftests.c: Fix common/ includes.
14933 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14934 * unittests/memrange-selftests.c: Fix common/ includes.
14935 * unittests/memory-map-selftests.c: Fix common/ includes.
14936 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14937 * unittests/function-view-selftests.c: Fix common/ includes.
14938 * unittests/environ-selftests.c: Fix common/ includes.
14939 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14940 * unittests/common-utils-selftests.c: Fix common/ includes.
14941 * unittests/cli-utils-selftests.c: Fix common/ includes.
14942 * unittests/array-view-selftests.c: Fix common/ includes.
14943 * ui-file.c: Fix common/ includes.
14944 * tui/tui-io.c: Fix common/ includes.
14945 * tracepoint.h: Fix common/ includes.
14946 * tracepoint.c: Fix common/ includes.
14947 * tracefile-tfile.c: Fix common/ includes.
14948 * top.h: Fix common/ includes.
14949 * top.c: Fix common/ includes.
14950 * thread.c: Fix common/ includes.
14951 * target/waitstatus.h: Fix common/ includes.
14952 * target/waitstatus.c: Fix common/ includes.
14953 * target.h: Fix common/ includes.
14954 * target.c: Fix common/ includes.
14955 * target-memory.c: Fix common/ includes.
14956 * target-descriptions.c: Fix common/ includes.
14957 * symtab.h: Fix common/ includes.
14958 * symfile.c: Fix common/ includes.
14959 * stap-probe.c: Fix common/ includes.
14960 * spu-linux-nat.c: Fix common/ includes.
14961 * sparc-nat.c: Fix common/ includes.
14962 * source.c: Fix common/ includes.
14963 * solib.c: Fix common/ includes.
14964 * solib-target.c: Fix common/ includes.
14965 * ser-unix.c: Fix common/ includes.
14966 * ser-tcp.c: Fix common/ includes.
14967 * ser-pipe.c: Fix common/ includes.
14968 * ser-base.c: Fix common/ includes.
14969 * selftest-arch.c: Fix common/ includes.
14970 * s12z-tdep.c: Fix common/ includes.
14971 * rust-exp.y: Fix common/ includes.
14972 * rs6000-aix-tdep.c: Fix common/ includes.
14973 * riscv-tdep.c: Fix common/ includes.
14974 * remote.c: Fix common/ includes.
14975 * remote-notif.h: Fix common/ includes.
14976 * remote-fileio.h: Fix common/ includes.
14977 * remote-fileio.c: Fix common/ includes.
14978 * regcache.h: Fix common/ includes.
14979 * regcache.c: Fix common/ includes.
14980 * record-btrace.c: Fix common/ includes.
14981 * python/python.c: Fix common/ includes.
14982 * python/py-type.c: Fix common/ includes.
14983 * python/py-inferior.c: Fix common/ includes.
14984 * progspace.h: Fix common/ includes.
14985 * producer.c: Fix common/ includes.
14986 * procfs.c: Fix common/ includes.
14987 * proc-api.c: Fix common/ includes.
14988 * printcmd.c: Fix common/ includes.
14989 * ppc-linux-nat.c: Fix common/ includes.
14990 * parser-defs.h: Fix common/ includes.
14991 * osdata.c: Fix common/ includes.
14992 * obsd-nat.c: Fix common/ includes.
14993 * nat/x86-linux.c: Fix common/ includes.
14994 * nat/x86-linux-dregs.c: Fix common/ includes.
14995 * nat/x86-dregs.h: Fix common/ includes.
14996 * nat/x86-dregs.c: Fix common/ includes.
14997 * nat/ppc-linux.c: Fix common/ includes.
14998 * nat/mips-linux-watch.h: Fix common/ includes.
14999 * nat/mips-linux-watch.c: Fix common/ includes.
15000 * nat/linux-waitpid.c: Fix common/ includes.
15001 * nat/linux-ptrace.h: Fix common/ includes.
15002 * nat/linux-ptrace.c: Fix common/ includes.
15003 * nat/linux-procfs.c: Fix common/ includes.
15004 * nat/linux-personality.c: Fix common/ includes.
15005 * nat/linux-osdata.c: Fix common/ includes.
15006 * nat/linux-namespaces.c: Fix common/ includes.
15007 * nat/linux-btrace.h: Fix common/ includes.
15008 * nat/linux-btrace.c: Fix common/ includes.
15009 * nat/fork-inferior.c: Fix common/ includes.
15010 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15011 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15012 * nat/aarch64-linux.c: Fix common/ includes.
15013 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15014 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15015 * namespace.h: Fix common/ includes.
15016 * mips-linux-tdep.c: Fix common/ includes.
15017 * minsyms.c: Fix common/ includes.
15018 * mi/mi-parse.h: Fix common/ includes.
15019 * mi/mi-main.c: Fix common/ includes.
15020 * mi/mi-cmd-env.c: Fix common/ includes.
15021 * memrange.h: Fix common/ includes.
15022 * memattr.c: Fix common/ includes.
15023 * maint.h: Fix common/ includes.
15024 * maint.c: Fix common/ includes.
15025 * main.c: Fix common/ includes.
15026 * machoread.c: Fix common/ includes.
15027 * location.c: Fix common/ includes.
15028 * linux-thread-db.c: Fix common/ includes.
15029 * linux-nat.c: Fix common/ includes.
15030 * linux-fork.c: Fix common/ includes.
15031 * inline-frame.c: Fix common/ includes.
15032 * infrun.c: Fix common/ includes.
15033 * inflow.c: Fix common/ includes.
15034 * inferior.h: Fix common/ includes.
15035 * inferior.c: Fix common/ includes.
15036 * infcmd.c: Fix common/ includes.
15037 * inf-ptrace.c: Fix common/ includes.
15038 * inf-child.c: Fix common/ includes.
15039 * ia64-linux-nat.c: Fix common/ includes.
15040 * i387-tdep.c: Fix common/ includes.
15041 * i386-tdep.c: Fix common/ includes.
15042 * i386-linux-tdep.c: Fix common/ includes.
15043 * i386-linux-nat.c: Fix common/ includes.
15044 * i386-go32-tdep.c: Fix common/ includes.
15045 * i386-fbsd-tdep.c: Fix common/ includes.
15046 * i386-fbsd-nat.c: Fix common/ includes.
15047 * guile/scm-type.c: Fix common/ includes.
15048 * guile/guile.c: Fix common/ includes.
15049 * go32-nat.c: Fix common/ includes.
15050 * gnu-nat.c: Fix common/ includes.
15051 * gdbthread.h: Fix common/ includes.
15052 * gdbarch-selftests.c: Fix common/ includes.
15053 * gdb_usleep.c: Fix common/ includes.
15054 * gdb_select.h: Fix common/ includes.
15055 * gdb_bfd.c: Fix common/ includes.
15056 * gcore.c: Fix common/ includes.
15057 * fork-child.c: Fix common/ includes.
15058 * findvar.c: Fix common/ includes.
15059 * fbsd-nat.c: Fix common/ includes.
15060 * event-top.c: Fix common/ includes.
15061 * event-loop.c: Fix common/ includes.
15062 * dwarf2read.c: Fix common/ includes.
15063 * dwarf2loc.c: Fix common/ includes.
15064 * dwarf2-frame.c: Fix common/ includes.
15065 * dwarf-index-cache.c: Fix common/ includes.
15066 * dtrace-probe.c: Fix common/ includes.
15067 * disasm-selftests.c: Fix common/ includes.
15068 * defs.h: Fix common/ includes.
15069 * csky-tdep.c: Fix common/ includes.
15070 * cp-valprint.c: Fix common/ includes.
15071 * cp-support.h: Fix common/ includes.
15072 * cp-support.c: Fix common/ includes.
15073 * corelow.c: Fix common/ includes.
15074 * completer.h: Fix common/ includes.
15075 * completer.c: Fix common/ includes.
15076 * compile/compile.c: Fix common/ includes.
15077 * compile/compile-loc2c.c: Fix common/ includes.
15078 * compile/compile-cplus-types.c: Fix common/ includes.
15079 * compile/compile-cplus-symbols.c: Fix common/ includes.
15080 * command.h: Fix common/ includes.
15081 * cli/cli-dump.c: Fix common/ includes.
15082 * cli/cli-cmds.c: Fix common/ includes.
15083 * charset.c: Fix common/ includes.
15084 * build-id.c: Fix common/ includes.
15085 * btrace.h: Fix common/ includes.
15086 * btrace.c: Fix common/ includes.
15087 * breakpoint.h: Fix common/ includes.
15088 * breakpoint.c: Fix common/ includes.
15089 * ax.h:
15090 (enum agent_op): Fix common/ includes.
15091 * ax-general.c (struct aop_map): Fix common/ includes.
15092 * ax-gdb.c: Fix common/ includes.
15093 * auxv.c: Fix common/ includes.
15094 * auto-load.c: Fix common/ includes.
15095 * arm-tdep.c: Fix common/ includes.
15096 * arch/riscv.c: Fix common/ includes.
15097 * arch/ppc-linux-common.c: Fix common/ includes.
15098 * arch/i386.c: Fix common/ includes.
15099 * arch/arm.c: Fix common/ includes.
15100 * arch/arm-linux.c: Fix common/ includes.
15101 * arch/arm-get-next-pcs.c: Fix common/ includes.
15102 * arch/amd64.c: Fix common/ includes.
15103 * arch/aarch64.c: Fix common/ includes.
15104 * arch/aarch64-insn.c: Fix common/ includes.
15105 * arch-utils.c: Fix common/ includes.
15106 * amd64-windows-tdep.c: Fix common/ includes.
15107 * amd64-tdep.c: Fix common/ includes.
15108 * amd64-sol2-tdep.c: Fix common/ includes.
15109 * amd64-obsd-tdep.c: Fix common/ includes.
15110 * amd64-nbsd-tdep.c: Fix common/ includes.
15111 * amd64-linux-tdep.c: Fix common/ includes.
15112 * amd64-linux-nat.c: Fix common/ includes.
15113 * amd64-fbsd-tdep.c: Fix common/ includes.
15114 * amd64-fbsd-nat.c: Fix common/ includes.
15115 * amd64-dicos-tdep.c: Fix common/ includes.
15116 * amd64-darwin-tdep.c: Fix common/ includes.
15117 * agent.c: Fix common/ includes.
15118 * ada-lang.h: Fix common/ includes.
15119 * ada-lang.c: Fix common/ includes.
15120 * aarch64-tdep.c: Fix common/ includes.
15121
2f5c153e
TT
151222019-01-25 Tom Tromey <tom@tromey.com>
15123
15124 * common/create-version.sh: Use common/version.h.
15125
adc6a863
PA
151262019-01-24 Pedro Alves <palves@redhat.com>
15127
15128 * infrun.c (signal_stop, signal_print, signal_program)
15129 (signal_catch, signal_pass): Now arrays instead of pointers.
15130 (update_signals_program_target, do_target_resume)
15131 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15132 * linux-nat.c (linux_nat_target::pass_signals)
15133 (linux_nat_target::create_inferior, linux_nat_target::attach):
15134 Adjust.
15135 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15136 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15137 * procfs.c (procfs_target::pass_signals): Adjust.
15138 * record-full.c (record_full_target::resume): Adjust.
15139 * remote.c (remote_target::pass_signals)
15140 (remote_target::program_signals): Adjust.
15141 * target-debug.h (target_debug_print_signals): Now takes a
15142 gdb::array_view as parameter. Adjust.
15143 * target.h (target_ops) <pass_signals, program_signals>: Replace
15144 pointer and length parameters with gdb::array_view.
15145 (target_pass_signals, target_program_signals): Likewise.
15146 * target-delegates.c: Regenerate.
15147
3046d67a
PA
151482019-01-24 Pedro Alves <palves@redhat.com>
15149
15150 * common/forward-scope-exit.h
15151 (forward_scope_exit::forward_scope_exit): Pass arguments to
15152 m_bind_function directly, instead of creating a std::bind and
15153 copying that.
15154
353229bf
AH
151552019-01-24 Alan Hayward <alan.hayward@arm.com>
15156
15157 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15158 for static members.
15159 (pass_in_v_vfp_candidate): Likewise.
15160
311dc83a
TT
151612019-01-23 Tom Tromey <tom@tromey.com>
15162 Pedro Alves <palves@redhat.com>
15163
15164 * regcache.c (class regcache_invalidator): Remove.
15165 (regcache::raw_write): Use make_scope_exit.
15166
296bd123
TT
151672019-01-23 Tom Tromey <tom@tromey.com>
15168
15169 * ui-out.h (class ui_out_emit_type): Update comment.
15170
979a0d13
TT
151712019-01-23 Tom Tromey <tom@tromey.com>
15172
15173 * infrun.c (fetch_inferior_event): Update comment.
15174
d238133d
TT
151752019-01-23 Tom Tromey <tom@tromey.com>
15176 Pedro Alves <palves@redhat.com>
15177
15178 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15179 parameter.
15180 (fetch_inferior_event): Use SCOPE_EXIT.
15181
15182
9885e6bb
TT
151832019-01-23 Tom Tromey <tom@tromey.com>
15184 Pedro Alves <palves@redhat.com>
15185
15186 * infrun.c (disable_thread_events): Delete.
15187 (stop_all_threads): Use SCOPE_EXIT.
15188
286526c1
TT
151892019-01-23 Tom Tromey <tom@tromey.com>
15190 Pedro Alves <palves@redhat.com>
15191
15192 * symfile.c: Include forward-scope-exit.h.
15193 (clear_symtab_users_cleanup): Replace forward declaration with
15194 a FORWARD_SCOPE_EXIT.
15195 (syms_from_objfile_1): Use the forward_scope_exit and
15196 gdb::optional instead of cleanup_function.
15197 (reread_symbols): Use the forward_scope_exit instead of
15198 cleanup_function.
15199 (clear_symtab_users_cleanup): Remove function.
15200
1db93f14
TT
152012019-01-23 Tom Tromey <tom@tromey.com>
15202 Pedro Alves <palves@redhat.com>
15203
15204 * linux-nat.c: Include scope-exit.h.
15205 (cleanup_target_stop): Remove.
15206 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15207 SCOPE_EXIT.
15208
2cc83d1e
TT
152092019-01-23 Tom Tromey <tom@tromey.com>
15210 Pedro Alves <palves@redhat.com>
15211
15212 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15213 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15214
694c6bf5
TT
152152019-01-23 Tom Tromey <tom@tromey.com>
15216 Andrew Burgess <andrew.burgess@embecosm.com>
15217 Pedro Alves <palves@redhat.com>
15218
15219 * infrun.c (fetch_inferior_event): Use scope_exit.
15220 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15221 * top.c (execute_command): Use scope_exit.
15222 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15223 * utils.c (do_bpstat_clear_actions_cleanup)
15224 (make_bpstat_clear_actions_cleanup): Remove.
15225
4c41382a
TT
152262019-01-23 Tom Tromey <tom@tromey.com>
15227 Pedro Alves <palves@redhat.com>
15228
15229 * infrun.c: Include "common/scope-exit.h"
15230 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15231 (wait_for_inferior): Use SCOPE_EXIT.
15232 (fetch_inferior_event): Use scope_exit.
15233
89f8fb50
TT
152342019-01-23 Tom Tromey <tom@tromey.com>
15235 Pedro Alves <palves@redhat.com>
15236
15237 * breakpoint.c (create_breakpoint): Remove cleanup.
15238
5419bdae
TT
152392019-01-23 Tom Tromey <tom@tromey.com>
15240 Andrew Burgess <andrew.burgess@embecosm.com>
15241 Pedro Alves <palves@redhat.com>
15242
e587ef42
PA
152432019-01-23 Pedro Alves <palves@redhat.com>
15244
15245 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15246
77f0e74c
PA
152472019-01-23 Pedro Alves <palves@redhat.com>
15248 Andrew Burgess <andrew.burgess@embecosm.com>
15249
15250 * gdbthread.h: Include "common/forward-scope-exit.h".
15251 (scoped_finish_thread_state): Redefine custom class in terms of
15252 forward_scope_exit.
15253
5b9b3e53
PA
152542019-01-23 Pedro Alves <palves@redhat.com>
15255 Andrew Burgess <andrew.burgess@embecosm.com>
15256
15257 * common/forward-scope-exit.h: New file.
15258
54b65c9b
PA
152592019-01-23 Pedro Alves <palves@redhat.com>
15260 Andrew Burgess <andrew.burgess@embecosm.com>
15261 Tom Tromey <tom@tromey.com>
15262
15263 * common/scope-exit.h: New file.
15264
cf08fb29
PA
152652019-01-23 Pedro Alves <palves@redhat.com>
15266
15267 * common/preprocessor.h (ESC): Rename to ...
15268 (ESC_PARENS): ... this.
15269 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15270 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15271
ae73e2e2
TT
152722019-01-23 Tom Tromey <tom@tromey.com>
15273
15274 * language.h (class scoped_switch_to_sym_language_if_auto):
15275 Initialize m_lang in both cases.
15276
6594e122
AH
152772019-01-23 Alan Hayward <alan.hayward@arm.com>
15278
15279 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15280 with XCNEW.
15281
a7c9855d
TT
152822019-01-22 Tom Tromey <tom@tromey.com>
15283
15284 * corelow.c: Do not include sys/file.h.
15285
93cc1d53
TT
152862019-01-22 Tom Tromey <tom@tromey.com>
15287
15288 * tui/tui-wingeneral.h: Include gdb_curses.h.
15289
38561778
TT
152902019-01-22 Tom Tromey <tom@tromey.com>
15291
15292 * source-cache.h (class source_cache) <get_source_lines,
15293 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15294
37b3ab5b
TT
152952019-01-22 Tom Tromey <tom@tromey.com>
15296
15297 * remote-fileio.h (struct remote_target): Declare.
15298
3fabc016
TT
152992019-01-22 Tom Tromey <tom@tromey.com>
15300
15301 * python/py-arch.c: Do not include py-ref.h.
15302 * python/py-bpevent.c: Do not include py-ref.h.
15303 * python/py-cmd.c: Do not include py-ref.h.
15304 * python/py-continueevent.c: Do not include py-ref.h.
15305 * python/py-event.h: Do not include py-ref.h.
15306 * python/py-evtregistry.c: Do not include py-ref.h.
15307 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15308 * python/py-frame.c: Do not include py-ref.h.
15309 * python/py-framefilter.c: Do not include py-ref.h.
15310 * python/py-function.c: Do not include py-ref.h.
15311 * python/py-infevents.c: Do not include py-ref.h.
15312 * python/py-linetable.c: Do not include py-ref.h.
15313 * python/py-objfile.c: Do not include py-ref.h.
15314 * python/py-param.c: Do not include py-ref.h.
15315 * python/py-prettyprint.c: Do not include py-ref.h.
15316 * python/py-progspace.c: Do not include py-ref.h.
15317 * python/py-symbol.c: Do not include py-ref.h.
15318 * python/py-symtab.c: Do not include py-ref.h.
15319 * python/py-type.c: Do not include py-ref.h.
15320 * python/py-unwind.c: Do not include py-ref.h.
15321 * python/py-utils.c: Do not include py-ref.h.
15322 * python/py-value.c: Do not include py-ref.h.
15323 * python/py-varobj.c: Do not include py-ref.h.
15324 * python/py-xmethods.c: Do not include py-ref.h.
15325 * python/python.c: Do not include py-ref.h.
15326 * varobj.c: Do not include py-ref.h.
15327
6b4d7774
TT
153282019-01-22 Tom Tromey <tom@tromey.com>
15329
15330 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15331 keyword for bcache.
15332
7af7e9b5
TT
153332019-01-22 Tom Tromey <tom@tromey.com>
15334
15335 * compile/compile-cplus-types.c: Remove a comment by #include.
15336
951d1049
TT
153372019-01-22 Tom Tromey <tom@tromey.com>
15338
15339 * compile/gcc-c-plugin.h: Include compile-internal.h.
15340
d65d5705
TT
153412019-01-22 Tom Tromey <tom@tromey.com>
15342
15343 * stabsread.c (EXTERN): Do not define.
15344 (symnum, next_symbol_text_func, processing_gcc_compilation)
15345 (within_function, global_sym_chain, global_stabs)
15346 (previous_stab_code, this_object_header_files)
15347 (n_this_object_header_files)
15348 (n_allocated_this_object_header_files): Define.
15349 * stabsread.h (EXTERN): Never define. Use "extern".
15350
b6fb1ee5
PW
153512019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15352
15353 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15354 history_value.
15355
be6d4f74
TT
153562019-01-21 Tom Tromey <tom@tromey.com>
15357
15358 * ui-out.c: Fix includes.
15359 * tui/tui-source.c: Fix includes.
15360 * target.c: Fix includes.
15361 * remote.c: Fix includes.
15362 * regcache.c: Fix includes.
15363 * python/py-block.c: Fix includes.
15364 * printcmd.c: Fix includes.
15365 * or1k-tdep.c: Fix includes.
15366 * mi/mi-main.c: Fix includes.
15367 * m32r-tdep.c: Fix includes.
15368 * csky-tdep.c: Fix includes.
15369 * compile/compile-cplus-types.c: Fix includes.
15370 * cli/cli-interp.c: Fix includes.
15371
73021deb
AH
153722019-01-21 Alan Hayward <alan.hayward@arm.com>
15373
15374 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15375 for padding.
15376
7932255d
TT
153772019-01-16 Tom Tromey <tom@tromey.com>
15378
15379 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15380 earlier.
15381 (struct objfile) <msymbols_range>: Move from top level.
15382 <msymbols>: New method.
15383 (class objfile_msymbols): Remove.
15384 * symtab.c (default_collect_symbol_completion_matches_break_on):
15385 Update.
15386 * symmisc.c (dump_msymbols): Update.
15387 * stabsread.c (scan_file_globals): Update.
15388 * objc-lang.c (info_selectors_command, info_classes_command)
15389 (find_methods): Update.
15390 * minsyms.c (find_solib_trampoline_target): Update.
15391 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15392 * coffread.c (coff_symfile_read): Update.
15393 * ada-lang.c (ada_lookup_simple_minsym)
15394 (ada_collect_symbol_completion_matches): Update.
15395
604b1bfb
TT
153962019-01-16 Tom Tromey <tom@tromey.com>
15397
15398 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15399 type. Remove no-argument constructor.
15400 <iterator::operator++>: Simplify.
15401 <begin>: Update.
15402 <end>: Use minimal_symbol_count.
15403
f252c6d5
TT
154042019-01-16 Tom Tromey <tom@tromey.com>
15405
15406 * objfiles.h (struct objfile) <psymtabs>: New method.
15407 (class objfile_psymtabs): Remove.
15408 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15409 typedef.
15410 <range>: New method.
15411 (require_partial_symbols): Change return type.
15412 * psymtab.c (require_partial_symbols)
15413 (psym_expand_symtabs_matching): Update.
15414 * mdebugread.c (parse_partial_symbols): Update.
15415 * dbxread.c (dbx_end_psymtab): Update.
15416
b669c953
TT
154172019-01-15 Tom Tromey <tom@tromey.com>
15418
15419 * symtab.c (lookup_objfile_from_block)
15420 (lookup_symbol_in_objfile_symtabs)
15421 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15422 (find_line_symtab, info_sources_command)
15423 (default_collect_symbol_completion_matches_break_on)
15424 (make_source_files_completion_list): Update.
15425 * symmisc.c (print_objfile_statistics, dump_objfile)
15426 (maintenance_print_symbols, maintenance_info_symtabs)
15427 (maintenance_check_symtabs, maintenance_info_line_tables):
15428 Update.
15429 * source.c (select_source_symtab)
15430 (forget_cached_source_info_for_objfile): Update.
15431 * objfiles.h (class objfile_compunits): Remove.
15432 (struct objfile) <compunits_range>: New typedef.
15433 (compunits): New method.
15434 * objfiles.c (objfile_relocate1): Update.
15435 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15436 * maint.c (count_symtabs_and_blocks): Update.
15437 * linespec.c (iterate_over_all_matching_symtabs): Update.
15438 * cp-support.c (add_symbol_overload_list_qualified): Update.
15439 * coffread.c (coff_symtab_read): Update.
15440 * ada-lang.c (add_nonlocal_symbols)
15441 (ada_collect_symbol_completion_matches)
15442 (ada_add_global_exceptions): Update.
15443
7e955d83
TT
154442019-01-15 Tom Tromey <tom@tromey.com>
15445
15446 * progspace.h (program_space) <objfiles_safe_range>: New
15447 typedef.
15448 <objfiles_safe>: New method.
15449 * objfiles.h (class all_objfiles_safe): Remove.
15450 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15451 * jit.c (jit_inferior_exit_hook): Update.
15452
2030c079
TT
154532019-01-17 Tom Tromey <tom@tromey.com>
15454
15455 * progspace.h (program_space) <objfiles_range>: New typedef.
15456 <objfiles>: New method.
15457 <objfiles_head>: Rename from objfiles.
15458 (object_files): Update.
15459 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15460 * guile/scm-pretty-print.c
15461 (ppscm_find_pretty_printer_from_objfiles): Update.
15462 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15463 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15464 Update.
15465 * python/py-progspace.c (pspy_get_objfiles): Update.
15466 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15467 Update.
15468 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15469 (objfpy_lookup_objfile_by_build_id): Update.
15470 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15471 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15472 Update.
15473 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15474 (expand_symtab_containing_pc, lookup_objfile_from_block)
15475 (lookup_static_symbol, basic_lookup_transparent_type)
15476 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15477 (find_line_symtab, info_sources_command)
15478 (default_collect_symbol_completion_matches_break_on)
15479 (make_source_files_completion_list, find_main_name): Update.
15480 * symmisc.c (print_symbol_bcache_statistics)
15481 (print_objfile_statistics, maintenance_print_symbols)
15482 (maintenance_print_msymbols, maintenance_print_objfiles)
15483 (maintenance_info_symtabs, maintenance_check_symtabs)
15484 (maintenance_expand_symtabs, maintenance_info_line_tables):
15485 Update.
15486 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15487 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15488 (map_overlay_command, unmap_overlay_command)
15489 (simple_overlay_update, expand_symtabs_matching)
15490 (map_symbol_filenames): Update.
15491 * symfile-debug.c (set_debug_symfile): Update.
15492 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15493 Update.
15494 * source.c (select_source_symtab, forget_cached_source_info):
15495 Update.
15496 * solib.c (solib_read_symbols): Update.
15497 * solib-spu.c (append_ocl_sos): Update.
15498 * psymtab.c (maintenance_print_psymbols)
15499 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15500 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15501 * printcmd.c (info_symbol_command): Update.
15502 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15503 Update.
15504 * objfiles.h (class all_objfiles): Remove.
15505 * objfiles.c (have_partial_symbols, have_full_symbols)
15506 (have_minimal_symbols, qsort_cmp, update_section_map)
15507 (shared_objfile_contains_address_p)
15508 (default_iterate_over_objfiles_in_search_order): Update.
15509 * objc-lang.c (info_selectors_command, info_classes_command)
15510 (find_methods): Update.
15511 * minsyms.c (find_solib_trampoline_target): Update.
15512 * maint.c (maintenance_info_sections)
15513 (maintenance_translate_address, count_symtabs_and_blocks):
15514 Update.
15515 * main.c (captured_main_1): Update.
15516 * linux-thread-db.c (try_thread_db_load_from_pdir)
15517 (has_libpthread): Update.
15518 * linespec.c (iterate_over_all_matching_symtabs)
15519 (search_minsyms_for_name): Update.
15520 * jit.c (jit_find_objf_with_entry_addr): Update.
15521 * hppa-tdep.c (find_unwind_entry)
15522 (hppa_lookup_stub_minimal_symbol): Update.
15523 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15524 Update.
15525 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15526 (elf_gnu_ifunc_resolve_by_got): Update.
15527 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15528 * dwarf-index-write.c (save_gdb_index_command): Update.
15529 * cp-support.c (add_symbol_overload_list_qualified): Update.
15530 * breakpoint.c (create_overlay_event_breakpoint)
15531 (create_longjmp_master_breakpoint)
15532 (create_std_terminate_master_breakpoint)
15533 (create_exception_master_breakpoint): Update.
15534 * blockframe.c (find_pc_partial_function): Update.
15535 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15536 (ada_collect_symbol_completion_matches)
15537 (ada_add_global_exceptions): Update.
15538
776489e0
TT
155392019-01-17 Tom Tromey <tom@tromey.com>
15540
15541 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15542 declare VEC.
15543 (solib_target_parse_libraries): Change return type.
15544 (library_list_start_segment, library_list_start_section)
15545 (library_list_end_library, library_list_start_library); Update.
15546 (solib_target_free_library_list): Remove.
15547 (solib_target_parse_libraries): Remove cleanup. Change return
15548 type.
15549 (solib_target_current_sos): Update.
15550
6471e7d2
TT
155512019-01-17 Tom Tromey <tromey@bapiya>
15552
15553 * valprint.c: Replace "the the" with "the".
15554 * symtab.c: Replace "the the" with "the".
15555 * solib.c: Replace "the the" with "the".
15556 * solib-dsbt.c: Replace "the the" with "the".
15557 * linespec.c: Replace "the the" with "the".
15558 * dwarf2loc.h: Replace "the the" with "the".
15559 * amd64-windows-tdep.c: Replace "the the" with "the".
15560 * aarch64-tdep.c: Replace "the the" with "the".
15561
c24bdb02
KS
155622019-01-16 Keith Seitz <keiths@redhat.com>
15563
15564 PR gdb/23773
15565 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15566 <builder>: Rename to ..
15567 <m_builder>: ... this and make private.
15568 (dwarf2_cu::get_builder): New method. Change all users of
15569 `builder' to use this method.
15570 (dwarf2_start_symtab): Move to ...
15571 (dwarf2_cu::start_symtab): ... here. Update all callers
15572 (setup_type_unit_groups): Move to ...
15573 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15574 callers.
15575 (dwarf2_cu::reset_builder): New method.
15576 (process_full_compunit, process_full_type_unit): Use
15577 dwarf2_cu::reset_builder.
15578 (follow_die_offset): Record the ancestor CU if it is different
15579 from the followed DIE's CU.
15580 (follow_die_sig_1): Likewise.
15581
8d64371b
TT
155822019-01-15 Tom Tromey <tom@tromey.com>
15583
15584 * remote.c (class remote_state) <buf>: Now a char_vector.
15585 <buf_size>: Remove.
15586 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15587 parameter.
15588 (remote_target::getpkt_or_notif_sane_1)
15589 (remote_target::getpkt_sane)
15590 (remote_target::getpkt_or_notif_sane): Likewise.
15591 (class remote_target) <putpkt>: New overload.
15592 (remote_target::read_frame): Change type of "buf_p". Remove
15593 sizeof_p parameter.
15594 (packet_ok): New overload.
15595 (packet_check_result): New overload.
15596 Update all uses.
15597
bb277751
TT
155982019-01-14 Tom Tromey <tom@tromey.com>
15599
15600 * remote-notif.c (handle_notification, remote_notif_ack)
15601 (remote_notif_parse): Make "buf" const.
15602 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15603 const.
15604 (remote_notif_parse, remote_notif_ack, handle_notification):
15605 Likewise.
15606 * remote.c (remote_notif_stop_parse): Make "buf" const.
15607 (remote_target::remote_parse_stop_reply): Make "buf" const.
15608 (remote_notif_stop_ack): Make "buf" const.
15609
05be00a8
TT
156102019-01-14 Tom Tromey <tom@tromey.com>
15611
15612 * remote.c (remote_console_output): Make parameter const.
15613
491adeca
TT
156142019-01-14 Tom Tromey <tom@tromey.com>
15615
15616 * target-debug.h (target_debug_print_signals): Constify.
15617 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15618 * procfs.c (procfs_target::pass_signals): Update.
15619 * linux-nat.c (linux_nat_target::pass_signals): Update.
15620 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15621 * target-delegates.c: Rebuild.
15622 * remote.c (remote_target::program_signals): Update.
15623 (remote_target::pass_signals): Update.
15624 * target.c (target_pass_signals): Constify argument.
15625 (target_program_signals): Likewise.
15626 * target.h (struct target_ops) <pass_signals, program_signals>:
15627 Constify argument.
15628 (target_pass_signals, target_program_signals): Constify argument.
15629
bbd94648
TT
156302019-01-14 Tom Tromey <tom@tromey.com>
15631
15632 PR tui/28819:
15633 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15634
6f072a10
PFC
156352019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15636
15637 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15638 field.
15639 * rs6000-tdep.c: Include reggroups.h.
15640 (IS_V_ALIAS_PSEUDOREG): Define.
15641 (rs6000_register_name): Return names for the "vX" aliases.
15642 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15643 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15644 aliases. Call default_register_reggroup_p for all other
15645 pseudo-registers.
15646 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15647 New functions.
15648 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15649 Handle "vX" aliases.
15650 (v_alias_pseudo_register_collect): New function.
15651 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15652 (rs6000_gdbarch_init): Initialize "vX" aliases as
15653 pseudo-registers. Restore registration of
15654 rs6000_pseudo_register_reggroup_p with
15655 set_tdesc_pseudo_register_reggroup_p.
15656
1a782351
MF
156572019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15658
15659 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15660 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15661 set_gdbarch_num_pseudo_regs.
15662
d73cff18
PW
156632019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15664
15665 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15666 Remove arg prefixname, add do_set and do_show.
15667 Add member functions set_list and show_list.
15668 * cli/cli-style.c (class cli_style_option): Update accordingly.
15669 (style_set_list): Move to file scope.
15670 (style_show_list): Likewise.
15671 (set_style): Call help_list.
15672 (show_style): Call cmd_show_list.
15673 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15674 Update to use the new macro.
15675
60a90376
JB
156762019-10-12 Joel Brobecker <brobecker@adacore.com>
15677
15678 * ada-lang.c (_initialize_ada_language): Expand the help text
15679 for the "catch exception" command.
15680
9d7c67bf
PW
156812019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15682
15683 * symtab.c (matching_obj_sections): Initialize obj,
15684 declare it closer to its usage.
15685
7cf47dc4
TT
156862019-01-10 Tom Tromey <tom@tromey.com>
15687
15688 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15689 (basic_inf_threads_range): Remove.
15690 (inf_threads_range, inf_non_exited_threads_range)
15691 (safe_inf_threads_range): Use next_adapter.
15692
d3cb6808
KS
156932019-01-10 Keith Seitz <keiths@redhat.com>
15694
15695 PR gdb/23712
15696 PR symtab/23010
15697 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15698 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15699
63a20375
KS
157002019-01-10 Keith Seitz <keiths@redhat.com>
15701
15702 PR gdb/23712
15703 PR symtab/23010
15704 * dictionary.c (pending_to_vector): Remove.
15705 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15706 Remove _1 suffix, replacing functions of the same name. Update
15707 all callers.
15708 (dict_create_hashed, dict_create_hashed_expandable)
15709 (dict_create_linear, dict_create_linear_expandable, dict_free)
15710 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15711 Make functions static.
15712
b026f593
KS
157132019-01-10 Keith Seitz <keiths@redhat.com>
15714
15715 PR gdb/23712
15716 PR symtab/23010
15717 * dictionary.h (struct dictionary): Replace declaration with
15718 multidictionary.
15719 (dict_create_hashed, dict_create_hashed_expandable)
15720 (dict_create_linear, dict_create_linear_expandable)
15721 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15722 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15723 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15724 taking multidictionary argument.
15725 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15726 * block.h (struct block) <dict>: Change to multidictionary
15727 and rename `multidict'.
15728 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15729 symmisc.c: Update all dictionary references to multidictionary.
15730
c7748ee9
KS
157312019-01-10 Keith Seitz <keiths@redhat.com>
15732
15733 PR gdb/23712
15734 PR symtab/23010
15735 * dictionary.c: Include unordered_map.
15736 (pending_to_vector): New function.
15737 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15738 Rewrite the non-"_1" functions to take vector instead
15739 of linked list.
15740 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15741 "new" _1 versions of the same name.
15742 (multidictionary): Define.
15743 (std::hash<enum language): New definition.
15744 (collate_pending_symbols_by_language, mdict_create_hashed)
15745 (mdict_create_hashed_expandable, mdict_create_linear)
15746 (mdict_create_linear_expandable, mdict_free)
15747 (find_language_dictionary, create_new_language_dictionary)
15748 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15749 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15750 (mdict_size, mdict_empty): New functions.
15751 * dictionary.h (mdict_iterator): Define.
15752
67aa1f3c
PA
157532019-01-10 Pedro Alves <palves@redhat.com>
15754
15755 * breakpoint.c (read_uploaded_action)
15756 (create_tracepoint_from_upload): Adjust to use
15757 gdb::unique_xmalloc_ptr.
15758 * ctf.c (ctf_write_uploaded_tp):
15759 (SET_ARRAY_FIELD): Use emplace_back.
15760 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15761 * tracefile-tfile.c (tfile_write_uploaded_tp):
15762 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15763 gdb::unique_xmalloc_ptr.
15764 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15765 at_string, cond_string, cmd_strings>: Replace char pointers
15766 with gdb::unique_xmalloc_ptr.
15767
2f667667
PA
157682019-01-10 Pedro Alves <palves@redhat.com>
15769
15770 * solib-target.c (library_list_start_library): Don't xstrdup name.
15771
36cb7237
PA
157722019-01-10 Pedro Alves <palves@redhat.com>
15773
15774 * mdebugread.c (parse_partial_symbols): Use
15775 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15776
da584958
AB
157772019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15778
15779 * linux-fork.c (scoped_switch_fork_info)
15780 <~scoped_switch_fork_info>: Fix incorrect variable name.
15781
1ef8573c
AB
157822019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15783
15784 * linux-fork.c (scoped_switch_fork_info)
15785 <scoped_switch_fork_info>: Make explicit.
15786 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15787
8d7bcccb
TT
157882019-01-10 Tom Tromey <tom@tromey.com>
15789
15790 * objfiles.h (objfile::reset_psymtabs): Update.
15791 * objfiles.c (objfile::objfile): Update.
15792 * psymtab.h (psymtab_storage::obstack): Update.
15793 (psymtab_storage::m_obstack): Use gdb::optional.
15794 (class psymtab_storage): Update comment. Remove objfile
15795 parameter.
15796 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15797
b596a3c7
TT
157982019-01-10 Tom Tromey <tom@tromey.com>
15799
15800 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15801 <free_psymtabs>: Now private.
15802 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15803 (allocate_psymtab): Use new method.
15804
a9342b62
TT
158052019-01-10 Tom Tromey <tom@tromey.com>
15806
15807 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15808 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15809 * mdebugread.c (parse_partial_symbols): Use
15810 allocate_dependencies.
15811 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15812 allocate_dependencies.
15813 (process_psymtab_comp_unit_reader)
15814 (build_type_psymtab_dependencies): Likewise.
15815 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15816
5af70966
TT
158172019-01-10 Tom Tromey <tom@tromey.com>
15818
15819 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15820 PSYMBOL_SET_LANGUAGE.
15821 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15822
5923a04c
TT
158232019-01-10 Tom Tromey <tom@tromey.com>
15824
15825 * psymtab.h (psymtab_storage::obstack): New method.
15826 <m_obstack>: Rename from obstack; now private.
15827 * psymtab.c (psymtab_storage): Update.
15828 * dwarf2read.c (create_addrmap_from_index)
15829 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15830 Update.
15831
6d6a12bf
TT
158322019-01-10 Tom Tromey <tom@tromey.com>
15833
15834 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15835 * objfiles.h (objfile::reset_psymtabs): New method.
15836
d320c2b5
TT
158372019-01-10 Tom Tromey <tom@tromey.com>
15838
15839 * symmisc.c (print_symbol_bcache_statistics): Update.
15840 (print_objfile_statistics): Update.
15841 * symfile.c (reread_symbols): Update.
15842 * psymtab.h (class psymtab_storage): New.
15843 * psymtab.c (psymtab_storage): New constructor.
15844 (~psymtab_storage): New destructor.
15845 (require_partial_symbols): Update.
15846 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15847 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15848 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15849 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15850 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15851 (start_psymtab_common, end_psymtab_common)
15852 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15853 (allocate_psymtab): Update.
15854 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15855 Update.
15856 (dump_psymtab_addrmap, maintenance_print_psymbols)
15857 (maintenance_check_psymtabs): Update.
15858 (class objfile_psymtabs): Move to objfiles.h.
15859 * psympriv.h (discard_psymtab): Now inline.
15860 (psymtab_discarder::psymtab_discarder): Update.
15861 (psymtab_discarder::~psymtab_discarder): Update.
15862 (ALL_OBJFILE_PSYMTABS): Rewrite.
15863 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15864 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15865 Remove fields.
15866 <partial_symtabs>: New field.
15867 (class objfile_psymtabs): Move from psymtab.h. Update.
15868 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15869 psymbol_cache.
15870 (objfile::~objfile): Don't destroy psymbol_cache.
15871 * mdebugread.c (parse_partial_symbols): Update.
15872 * dwarf2read.c (create_addrmap_from_index)
15873 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15874 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15875 (add_partial_subprogram, dwarf2_ranges_read): Update.
15876 * dwarf-index-write.c (write_address_map)
15877 (write_one_signatured_type, recursively_write_psymbols)
15878 (class debug_names, class debug_names, write_psymtabs_to_index):
15879 Update.
15880
1d94a5a3
TT
158812019-01-10 Tom Tromey <tom@tromey.com>
15882
15883 * symtab.h (SYMBOL_SET_NAMES): Update.
15884 (symbol_set_names): Update.
15885 (MSYMBOL_SET_NAMES): Update.
15886 * symtab.c (symbol_set_names): Change argument to be an
15887 objfile_per_bfd_storage.
15888 * psymtab.c (add_psymbol_to_bcache): Update.
15889 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15890
0f14768a
TT
158912019-01-10 Tom Tromey <tom@tromey.com>
15892
15893 * symtab.c (create_demangled_names_hash): Change argument to be an
15894 objfile_per_bfd_storage.
15895 (symbol_set_names): Update.
15896
6eee24ce
TT
158972019-01-10 Tom Tromey <tom@tromey.com>
15898
15899 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15900 init_psymbol_list.
15901 * psymtab.c (init_psymbol_list): Do nothing if already called.
15902 * psympriv.h (init_psymbol_list): Add comment.
15903 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15904 init_psymbol_list.
15905 * dbxread.c (dbx_symfile_read): Unconditionally call
15906 init_psymbol_list.
15907
75aedd27
TT
159082019-01-10 Tom Tromey <tom@tromey.com>
15909
15910 * xcoffread.c (scan_xcoff_symtab): Update.
15911 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15912 "where".
15913 * mdebugread.c (parse_partial_symbols)
15914 (handle_psymbol_enumerators): Update.
15915 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15916 * dbxread.c (read_dbx_symtab): Update.
15917 * psympriv.h (psymbol_placement): New enum.
15918 (add_psymbol_to_list): Update.
15919
939652a5
TT
159202019-01-10 Tom Tromey <tom@tromey.com>
15921
15922 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15923 static_psymbols parameters.
15924 (scan_xcoff_symtab): Update.
15925 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15926 static_psymbols parameters.
15927 * psympriv.h (start_psymtab_common): Update.
15928 * mdebugread.c (parse_partial_symbols): Update.
15929 * dwarf2read.c (create_partial_symtab): Update.
15930 * dbxread.c (read_dbx_symtab): Update.
15931 (start_psymtab): Remove global_psymbols and static_psymbols
15932 parameters.
15933
baa62830
TT
159342019-01-10 Tom Tromey <tom@tromey.com>
15935
15936 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15937 * psymtab.c (allocate_psymtab): Add comment.
15938 * psympriv.h (allocate_psymtab): Add comment.
15939 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15940 initializations.
15941 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15942
0e8f53ba
TT
159432019-01-10 Tom Tromey <tom@tromey.com>
15944
15945 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15946 Don't declare.
15947 * mipsread.c: Include mdebugread.h.
15948 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15949 Declare.
15950 * elfread.c: Include mdebugread.h.
15951
b22a7c6a
TT
159522019-01-09 Tom Tromey <tom@tromey.com>
15953
15954 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15955 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15956 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15957 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15958 (psym_lookup_symbol, psym_find_last_source_symtab)
15959 (psym_forget_cached_source_info, psym_print_stats)
15960 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15961 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15962 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15963 (psym_find_compunit_symtab_by_address)
15964 (maintenance_print_psymbols, maintenance_info_psymtabs)
15965 (maintenance_check_psymtabs): Use ranged for.
15966 * psymtab.h (class objfile_psymtabs): New.
15967 (require_partial_symbols): Return objfile_psymtabs.
15968 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15969
3b9d3ac2
TT
159702019-01-09 Tom Tromey <tom@tromey.com>
15971
15972 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15973 (find_pc_mapped_section, list_overlays_command)
15974 (map_overlay_command, unmap_overlay_command)
15975 (simple_overlay_update): Use all_objfiles.
15976 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15977 * printcmd.c (info_symbol_command): Use all_objfiles.
15978 * objfiles.h (ALL_OBJSECTIONS): Remove.
15979 * maint.c (maintenance_translate_address): Use all_objfiles.
15980 * gcore.c (gcore_create_callback): Use all_objfiles.
15981 (objfile_find_memory_regions): Likewise.
15982
8b31193a
TT
159832019-01-09 Tom Tromey <tom@tromey.com>
15984
15985 * symtab.c (find_line_symtab, info_sources_command)
15986 (make_source_files_completion_list): Use objfile_compunits.
15987 * source.c (select_source_symtab): Use objfile_compunits.
15988 * objfiles.h (struct objfile): Update comment.
15989 (ALL_OBJFILES): Remove.
15990 (ALL_FILETABS): Remove.
15991 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15992 objfile_compunits.
15993
d5da8b3c
TT
159942019-01-09 Tom Tromey <tom@tromey.com>
15995
15996 * symmisc.c (print_objfile_statistics, dump_objfile)
15997 (maintenance_print_symbols): Use compunit_filetabs.
15998 * source.c (forget_cached_source_info_for_objfile): Use
15999 compunit_filetabs.
16000 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16001 (ALL_FILETABS): Use compunit_filetabs.
16002 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16003 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16004
5accd1a0
TT
160052019-01-09 Tom Tromey <tom@tromey.com>
16006
16007 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16008 (compunit_filetabs): New.
16009 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16010 compunit_filetabs.
16011 (info_sources_command, make_source_files_completion_list): Remove
16012 declaration.
16013 * symmisc.c (print_objfile_statistics, dump_objfile)
16014 (maintenance_print_symbols): Remove declaration.
16015 (maintenance_info_symtabs): Use compunit_filetabs.
16016 (maintenance_info_line_tables): Likewise.
16017 * source.c (select_source_symtab): Change local variable name.
16018 (forget_cached_source_info_for_objfile): Remove declaration.
16019 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16020 * objfiles.c (objfile_relocate1): Remove declaration.
16021 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16022 declaration.
16023 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16024 * coffread.c (coff_symtab_read): Remove declaration.
16025 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16026 compunit_filetabs.
16027
d8aeb77f
TT
160282019-01-09 Tom Tromey <tom@tromey.com>
16029
16030 * symtab.c (lookup_objfile_from_block)
16031 (find_pc_sect_compunit_symtab, search_symbols)
16032 (default_collect_symbol_completion_matches_break_on): Use
16033 objfile_compunits.
16034 * objfiles.h (ALL_COMPUNITS): Remove.
16035 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16036 * cp-support.c (add_symbol_overload_list_qualified): Use
16037 objfile_compunits.
16038 * ada-lang.c (ada_collect_symbol_completion_matches)
16039 (ada_add_global_exceptions): Use objfile_compunits.
16040
592553c4
TT
160412019-01-09 Tom Tromey <tom@tromey.com>
16042
16043 * source.c (select_source_symtab)
16044 (forget_cached_source_info_for_objfile): Remove declaration.
16045 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16046 declaration.
16047 * maint.c (count_symtabs_and_blocks): Remove declaration.
16048 * cp-support.c (add_symbol_overload_list_qualified): Remove
16049 declaration.
16050 * coffread.c (coff_symtab_read): Remove declaration.
16051 * symtab.c (lookup_symbol_in_objfile_symtabs)
16052 (basic_lookup_transparent_type_1): Use objfile_compunits.
16053 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16054 (info_sources_command, search_symbols)
16055 (default_collect_symbol_completion_matches_break_on)
16056 (make_source_files_completion_list): Remove declaration.
16057 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16058 (ada_collect_symbol_completion_matches)
16059 (ada_add_global_exceptions): Remove declaration.
16060 * linespec.c (iterate_over_all_matching_symtabs): Use
16061 objfile_compunits.
16062 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16063 (class objfile_compunits): New.
16064 (ALL_COMPUNITS): Use objfile_compunits.
16065 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16066 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16067 objfile_compunits.
16068 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16069
5325b9bf
TT
160702019-01-09 Tom Tromey <tom@tromey.com>
16071
16072 * symtab.c (search_symbols)
16073 (default_collect_symbol_completion_matches_break_on): Use
16074 objfile_msymbols.
16075 * ada-lang.c (ada_lookup_simple_minsym)
16076 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16077 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16078 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16079 objfile_msymbols.
16080 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16081 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16082 * objc-lang.c (find_methods): Use objfile_msymbols.
16083 (info_selectors_command, info_classes_command): Likewise.
16084 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16085 * objfiles.h (class objfile_msymbols): New.
16086 (ALL_OBJFILE_MSYMBOLS): Remove.
16087 (ALL_MSYMBOLS): Remove.
16088
cac85af2
TT
160892019-01-09 Tom Tromey <tom@tromey.com>
16090
16091 * common/next-iterator.h (next_adapter): Add Iterator template
16092 parameter.
16093 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16094 (class all_objfiles_safe): New.
16095 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16096 * objfiles.c (put_objfile_before): Update comment.
16097 (add_separate_debug_objfile): Likewise.
16098 (free_all_objfiles): Use all_objfiles_safe.
16099 (objfile_purge_solibs): Likewise.
16100
aed57c53
TT
161012019-01-09 Tom Tromey <tom@tromey.com>
16102
16103 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16104 (expand_symtab_containing_pc, lookup_static_symbol)
16105 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16106 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16107 all_objfiles.
16108 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16109 * breakpoint.c (create_overlay_event_breakpoint)
16110 (create_longjmp_master_breakpoint)
16111 (create_std_terminate_master_breakpoint)
16112 (create_exception_master_breakpoint): Use all_objfiles.
16113 * linux-thread-db.c (try_thread_db_load_from_pdir)
16114 (has_libpthread): Use all_objfiles.
16115 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16116 * linespec.c (iterate_over_all_matching_symtabs)
16117 (search_minsyms_for_name): Use all_objfiles.
16118 * maint.c (maintenance_info_sections): Use all_objfiles.
16119 * main.c (captured_main_1): Use all_objfiles.
16120 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16121 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16122 * guile/scm-pretty-print.c
16123 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16124 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16125 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16126 (maintenance_print_msymbols): Use all_objfiles.
16127 * source.c (select_source_symtab): Use all_objfiles.
16128 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16129 * symfile.c (remove_symbol_file_command)
16130 (expand_symtabs_matching, map_symbol_filenames): Use
16131 all_objfiles.
16132 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16133 all_objfiles.
16134 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16135 * objc-lang.c (find_methods): Use all_objfiles.
16136 * objfiles.c (have_partial_symbols, have_full_symbols)
16137 (have_minimal_symbols, qsort_cmp)
16138 (default_iterate_over_objfiles_in_search_order): Use
16139 all_objfiles.
16140 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16141 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16142 (maintenance_check_psymtabs): Use all_objfiles.
16143 (ALL_PSYMTABS): Remove.
16144 * compile/compile-object-run.c (do_module_cleanup): Use
16145 all_objfiles.
16146 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16147 * cp-support.c (add_symbol_overload_list_qualified): Use
16148 all_objfiles.
16149 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16150 Use all_objfiles.
16151 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16152 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16153 all_objfiles.
16154 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16155 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16156 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16157 Uses all_objfiles.
16158 * solib.c (solib_read_symbols): Use all_objfiles
16159
99d89cde
TT
161602019-01-09 Tom Tromey <tom@tromey.com>
16161
16162 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16163 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16164 all_objfiles.
16165 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16166 * symmisc.c (print_symbol_bcache_statistics)
16167 (print_objfile_statistics, maintenance_print_objfiles)
16168 (maintenance_info_symtabs, maintenance_check_symtabs)
16169 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16170 all_objfiles.
16171 * source.c (forget_cached_source_info): Use all_objfiles.
16172 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16173 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16174 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16175 * objfiles.c (update_section_map): Use all_objfiles.
16176 (shared_objfile_contains_address_p): Likewise.
16177 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16178 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16179
21708325
TT
161802019-01-09 Tom Tromey <tom@tromey.com>
16181
16182 * common/next-iterator.h: New file.
16183 * objfiles.h (class all_objfiles): New.
16184 (struct objfile_iterator): New.
16185
669e09f6
PW
161862019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16187
16188 * NEWS: Move the description of the changed "frame", "select-frame",
16189 and "info frame" commands to the Changed commands section.
16190
041be526
SM
161912019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16192
16193 * gdbtypes.c (check_stub_method_group): Remove handling of old
16194 mangling schemes.
16195 * linespec.c (find_methods): Likewise.
16196 * stabsread.c (read_member_functions): Likewise.
16197 * valops.c (search_struct_method): Likewise.
16198 (value_struct_elt_for_reference): Likewise.
16199 * NEWS: Mention this change.
16200
0e2a2133
AB
162012019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16202
16203 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16204 print_source_lines.
16205 * source.c (print_source_lines_base): Update line number check.
16206 (print_source_lines): New function.
16207 (source_lines_range::source_lines_range): New function.
16208 * source.h (class source_lines_range): New class.
16209 (print_source_lines): New declaration.
16210
1055a3b4
PW
162112019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16212
16213 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16214
cfeadda5
TT
162152019-01-08 Tom Tromey <tom@tromey.com>
16216 Simon Marchi <simon.marchi@ericsson.com>
16217
16218 PR gdb/24060
16219 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16220 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16221 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16222 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16223 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16224 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16225
583068ca
AB
162262019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16227
16228 * source.c (select_source_symtab): Move header comment to
16229 declaration in source.h.
16230 (forget_cached_source_info_for_objfile): Likewise.
16231 (forget_cached_source_info): Likewise.
16232 (identify_source_line): Likewise.
16233 * source.h (identify_source_line): Move declaration from symtab.h
16234 and add comment from source.c
16235 (print_source_lines): Likewise.
16236 (forget_cached_source_info_for_objfile): Likewise.
16237 (forget_cached_source_info): Likewise.
16238 (select_source_symtab): Likewise.
16239 (enum print_source_lines_flag): Move definition from symtab.h.
16240 * symtab.h (identify_source_line): Move declaration to source.h.
16241 (print_source_lines): Likewise.
16242 (forget_cached_source_info_for_objfile): Likewise.
16243 (forget_cached_source_info): Likewise.
16244 (select_source_symtab): Likewise.
16245 (enum print_source_lines_flag): Move definition to source.h.
16246 * tui/tui-hooks.c: Add 'source.h' include.
16247
ec98a4ad
AB
162482019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16249
16250 * source.c (print_source_lines_base): Handle requests to print
16251 reverse line number sequences, and guard against empty lines
16252 string.
16253
62ea19c1
AB
162542019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16255
16256 * source.c (print_source_lines_base): Fix skip of '\r' if next
16257 character is '\n'.
16258
9d30e1fd
TT
162592019-01-06 Tom Tromey <tom@tromey.com>
16260
16261 * c-exp.y (struct c_parse_state) <macro_original_text,
16262 expansion_obstack>: New member.
16263 (macro_original_text, expansion_obstack): Remove globals.
16264 (scan_macro_expansion, scanning_macro_expansion)
16265 (finished_macro_expansion): Update.
16266 (scan_macro_cleanup): Remove.
16267 (yylex, c_parse): Update.
16268
c65bac38
TT
162692019-01-06 Tom Tromey <tom@tromey.com>
16270
16271 * c-exp.y (struct c_parse_state) <strings>: New member.
16272 (operator_stoken): Update.
16273
02e12e38
TT
162742019-01-06 Tom Tromey <tom@tromey.com>
16275
16276 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16277 (union type_stack_elt) <typelist_val>: Now a pointer to
16278 std::vector.
16279 (type_stack_cleanup): Don't declare.
16280 (push_typelist): Update.
16281 * parse.c (pop_typelist): Return a std::vector.
16282 (push_typelist): Take a std::vector.
16283 (follow_types): Update. Do not free args.
16284 (type_stack_cleanup): Remove.
16285 * c-exp.y (struct c_parse_state): New.
16286 (cpstate): New global.
16287 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16288 (nonempty_typelist): Update.
16289 (func_mod): Create a new vector.
16290 (c_parse): Create a c_parse_state.
16291 (check_parameter_typelist): Do not delete params.
16292 (function_method): Update. Do not delete type_list.
16293
f097f5ad
TT
162942019-01-06 Tom Tromey <tom@tromey.com>
16295
16296 PR gdb/28155:
16297 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16298 check_typedef.
16299 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16300 (print_return_value): Likewise.
16301
d2adf9f1
TT
163022019-01-05 Tom Tromey <tom@tromey.com>
16303
16304 * contrib/cleanup_check.py: Remove.
16305 * contrib/gcc-with-excheck: Remove.
16306 * contrib/exsummary.py: Remove.
16307 * contrib/excheck.py: Remove.
16308
2eab46b1
JB
163092019-01-05 Joel Brobecker <brobecker@adacore.com>
16310
16311 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16312 NULL. Initialize tpprev to NULL instead of assigning it
16313 to NULL on the next statement.
16314 * windows-nat.c (windows_delete_thread): Remove check for
16315 main_thread_id before printing thread exit notifications.
16316 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16317 Remove thread ID check against main_thread_id.
16318 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16319 windows_delete_thread.
16320 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16321
48c5e7e2
TT
163222019-01-04 Tom Tromey <tom@tromey.com>
16323
16324 * compile/compile.c (_initialize_compile): Use upper case for
16325 metasyntactic variables.
16326 * symmisc.c (_initialize_symmisc): Use upper case for
16327 metasyntactic variables.
16328 * psymtab.c (_initialize_psymtab): Use upper case for
16329 metasyntactic variables.
16330 * demangle.c (demangle_command): Use upper case for metasyntactic
16331 variables.
16332 (_initialize_demangler): Likewise.
16333 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16334 variables.
16335
986041cd
TT
163362019-01-03 Tom Tromey <tom@tromey.com>
16337
16338 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16339
7c711119
TT
163402019-01-03 Tom Tromey <tom@tromey.com>
16341
16342 * python/py-symtab.c (salpy_str): Update.
16343 (struct salpy_sal_object) <symtab>: Now a PyObject.
16344 (salpy_dealloc): Update.
16345 (del_objfile_sal): Use gdbpy_ref.
16346
1b20edf0
TT
163472019-01-03 Tom Tromey <tom@tromey.com>
16348
16349 * python/py-type.c (convert_field): Use new_reference. Return
16350 gdbpy_ref.
16351 (make_fielditem): Return gdbpy_ref.
16352 (typy_fields): Update.
16353 (typy_getitem): Update.
16354 (field_name): Return gdbpy_ref. Use new_reference.
16355 (typy_iterator_iternext): Update.
16356
ea41325b
TT
163572019-01-03 Tom Tromey <tom@tromey.com>
16358
16359 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16360
2a3c71d6
TT
163612019-01-03 Tom Tromey <tom@tromey.com>
16362
16363 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16364 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16365 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16366 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16367 (pspy_set_type_printers): Likewise.
16368 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16369 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16370 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16371 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16372 (objfpy_set_type_printers): Likewise.
16373
5c329e6a
TT
163742019-01-03 Tom Tromey <tom@tromey.com>
16375
16376 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16377 (gdbpy_print_stack): Use gdbpy_err_fetch.
16378 * python/python-internal.h (class gdbpy_err_fetch): New class.
16379 (class gdbpy_enter) <m_error_type, m_error_value,
16380 m_error_traceback>: Remove.
16381 <m_error>: New member.
16382 (gdbpy_exception_to_string): Don't declare.
16383 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16384 * python/py-value.c (convert_value_from_python): Use
16385 gdbpy_err_fetch.
16386 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16387 gdbpy_exception_to_string.
16388 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16389 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16390 gdbpy_err_fetch.
16391
169bb27b
AB
163922019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16393
16394 * linux-nat.c (delete_lwp_cleanup): Delete.
16395 (struct lwp_deleter): New struct.
16396 (lwp_info_up): New typedef.
16397 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16398 lwp_info_up.
16399
a07c8880
AB
164002019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16401
16402 * linux-fork.c (class scoped_switch_fork_info): New class.
16403 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16404
26089c49
AB
164052019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16406
16407 * valops.c (find_overload_match): Remove use of null_cleanup, and
16408 calls to do_cleanups.
16409
06d3e5b0
AB
164102019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16411
16412 * compile/compile-cplus-types.c
16413 (compile_cplus_instance::decl_name): Handle changes to
16414 cp_func_name.
16415 * cp-support.c (cp_func_name): Update header comment, update
16416 return type.
16417 * cp-support.h (cp_func_name): Update return type in declaration.
16418 * valops.c (find_overload_match): Move temp_func local to top
16419 level of function and change its type. Use temp_func to hold and
16420 delete temporary string obtained from cp_func_name.
16421
66644cd3
AB
164222019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16423
16424 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16425 gdb::char_vector, remove cleanup, and update uses of `msg`.
16426
592d8c0a
JW
164272019-01-03 Jim Wilson <jimw@sifive.com>
16428
16429 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16430
c55d06ec
TT
164312019-01-02 Tom Tromey <tom@tromey.com>
16432
16433 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16434 (tdesc_parse_xml): Remove cleanups.
16435 * target-descriptions.h (make_cleanup_free_target_description):
16436 Don't declare.
16437 (target_desc_deleter): New struct.
16438 (target_desc_up): New typedef.
16439 * target-descriptions.c (target_desc_deleter::operator()): Rename
16440 from free_target_description.
16441 (make_cleanup_free_target_description): Remove.
16442
3a6ae42d
TT
164432019-01-02 Tom Tromey <tom@tromey.com>
16444
16445 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16446 constructor, destructor.
16447 (linespec_parser): Remove typedef.
16448 (~linespec_parser): Rename from linespec_parser_delete.
16449 (linespec_lex_to_end, linespec_complete_label)
16450 (linespec_complete): Update.
16451 (decode_line_full): Remove cleanups.
16452 (decode_line_1): Update.
16453
61fd3e73
TT
164542019-01-02 Tom Tromey <tom@tromey.com>
16455
16456 * python/python-internal.h (inferior_to_inferior_object): Change
16457 return type.
16458 * python/py-exitedevent.c (create_exited_event_object): Update.
16459 * python/py-inferior.c (inferior_to_inferior_object): Return
16460 gdbpy_ref.
16461 (python_new_inferior, python_inferior_deleted)
16462 (thread_to_thread_object, delete_thread_object)
16463 (build_inferior_list, gdbpy_selected_inferior): Update.
16464 * python/py-infthread.c (create_thread_object): Update. Also fail
16465 if inferior_to_inferior_object fails.
16466
d20172fc
SM
164672019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16468
16469 * inferior.h (class inferior) <displaced_step_state>: New field.
16470 * infrun.h (struct displaced_step_state): Move here from
16471 infrun.c. Initialize fields, add constructor.
16472 <inf>: Remove field.
16473 <reset>: New method.
16474 * infrun.c (struct displaced_step_inferior_state): Move to
16475 infrun.h.
16476 (displaced_step_inferior_states): Remove.
16477 (get_displaced_stepping_state): Adust.
16478 (displaced_step_in_progress_any_inferior): Adjust.
16479 (displaced_step_in_progress_thread): Adjust.
16480 (displaced_step_in_progress): Adjust.
16481 (add_displaced_stepping_state): Remove.
16482 (get_displaced_step_closure_by_addr): Adjust.
16483 (remove_displaced_stepping_state): Remove.
16484 (infrun_inferior_exit): Call displaced_step_state.reset.
16485 (use_displaced_stepping): Don't check for NULL.
16486 (displaced_step_prepare_throw): Call
16487 get_displaced_stepping_state.
16488 (displaced_step_fixup): Don't check for NULL.
16489 (prepare_for_detach): Don't check for NULL.
16490
e3319240
PW
164912019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16492
16493 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16494 in case of call that did not complete.
16495
5d36dfb9
AU
164962019-01-02 Andrey Utkin <autkin@undo.io>
16497
16498 * symfile.c (find_separate_debug_file): Fix search of debug files for
16499 remote debuggee.
16500
8833fbf0
TT
165012019-01-02 Tom Tromey <tom@tromey.com>
16502
16503 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16504 indentation.
16505 * python/py-frame.c (frapy_older): Remove cast.
16506 (frapy_newer): Likewise.
16507 * python/py-breakpoint.c (local_setattro): Remove cast.
16508 * python/py-arch.c (archpy_name): Remove local variable.
16509 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16510
4ada3dfd
JB
165112019-01-02 Joel Brobecker <brobecker@adacore.com>
16512
16513 * unittests/basic_string_view/element_access/char/empty.cc:
16514 Fix year range in copyright header.
16515
113b7b81
AB
165162019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16517
16518 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16519 Delete.
16520 <operator==>: Update with for removed field.
16521 <hash>: Likewise.
16522 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16523 <isa_features>: ...this.
16524 <abi_features>: New field.
16525 (riscv_isa_flen): Update comment.
16526 (riscv_abi_xlen): New declaration.
16527 (riscv_abi_flen): New declaration.
16528 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16529 isa_features.
16530 (riscv_abi_xlen): New function.
16531 (riscv_isa_flen): Update to get answer from isa_features.
16532 (riscv_abi_flen): New function.
16533 (riscv_has_fp_abi): Update to get answer from abi_features.
16534 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16535 xlen and flen.
16536 (riscv_call_info) <xlen, flen>: Update comment.
16537 (riscv_call_arg_struct): Remove invalid assertions
16538 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16539 is removed.
16540 (riscv_gdbarch_init): Gather isa features and abi features
16541 separately, ensure both match on the gdbarch when reusing an old
16542 gdbarch. Relax an error check to allow 32-bit abi float to run on
16543 a target with 64-bit float hardware.
16544
b18ca514
PW
165452019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16546
16547 * source.c (search_command_helper): Stop reverse search
16548 when line 1 has been searched.
16549
ec70d8db
PW
165502019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16551
16552 * record-full.c (record_full_base_target::close): Rewrite
16553 record_full_core_buf_list free logic.
16554
5b38f9c1
PW
165552019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16556
16557 * break-catch-syscall.c (print_one_catch_syscall): xfree
16558 the last text.
16559
66d91b39
JB
165602019-01-01 Joel Brobecker <brobecker@adacore.com>
16561
16562 * top.c (print_gdb_version): Update Copyright year in version
16563 message.
16564
42a4f53d
JB
165652019-01-01 Joel Brobecker <brobecker@adacore.com>
16566
16567 Update copyright year range in all GDB files.
16568
7e955d83 165692019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16570
5bbd631d 16571 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16572
5bbd631d 16573For older changes see ChangeLog-2018.
c906108c
SS
16574\f
16575Local Variables:
16576mode: change-log
16577left-margin: 8
16578fill-column: 74
16579version-control: never
57da7796 16580coding: utf-8
c906108c 16581End:
5bbd631d 16582