]>
git.ipfire.org Git - thirdparty/util-linux.git/log
Karel Zak [Wed, 12 Jun 2019 09:02:51 +0000 (11:02 +0200)]
findmnt: (verify) ignore passno for XFS
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=
1719069
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 11 Jun 2019 10:11:32 +0000 (12:11 +0200)]
lib/sysfs: fix reference counting for parent
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 11 Jun 2019 09:22:22 +0000 (11:22 +0200)]
cfdisk: free libfdisk items
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 11 Jun 2019 09:05:12 +0000 (11:05 +0200)]
fstrim: update man page, reuse libmnt_iter
* add info about read-only to the man page
* don't be systemd specific, people aso use crond
* reuse libmnt_iter
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 11 Jun 2019 08:54:22 +0000 (10:54 +0200)]
cfdisk: simplify code
Signed-off-by: Karel Zak <kzak@redhat.com>
Stanislav Brabec [Mon, 10 Jun 2019 19:59:17 +0000 (21:59 +0200)]
fstrim: properly de-duplicate fstrim -A
fstab can contain tag based mounts. De-duplication by source has to be
done after resolving the full source path.
Perform the table iteration twice. First time, prepare for
de-duplication, second time perform the TRIM itself.
Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
Stanislav Brabec [Mon, 10 Jun 2019 19:59:45 +0000 (21:59 +0200)]
fstrim -a/-A: Skip read-only volumes
Calling TRIM on some read-only volumes can fail with:
fstrim: /win: FITRIM ioctl failed: Bad file descriptor
Skipping all read-only mounts seems to be safe and logical strategy.
Fixes opensuse#
1106214 .
Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
Stanislav Brabec [Mon, 10 Jun 2019 19:59:21 +0000 (21:59 +0200)]
fstrim: Fix fstrim_all() comment
"convert LABEL=" does not happens in mnt_fs_get_source(), but later in
mnt_resolve_spec(). To make this more clean, move the comment before this
chunk of code.
Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
Karel Zak [Mon, 10 Jun 2019 09:00:38 +0000 (11:00 +0200)]
lib/canonicalize: fix compiler warning [-Wsign-compare]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 7 Jun 2019 10:37:28 +0000 (12:37 +0200)]
libmount: (docs) add reference to v2.33 and v2.34
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 7 Jun 2019 10:32:45 +0000 (12:32 +0200)]
libsmartcols: (docs) add reference to v2.33 and v2.34
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 7 Jun 2019 10:30:13 +0000 (12:30 +0200)]
libfdisk: (docs) add reference to v2.33
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 6 Jun 2019 12:52:40 +0000 (14:52 +0200)]
umount: be more strict about --all
If you by accident execute
umount ls -al /mnt/
then umount --all is executed and another arguments silently ignored.
It seems better to be more strict in this case.
Reported-by: Harald Dunkel <harald.dunkel@aixigo.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 6 Jun 2019 10:33:03 +0000 (12:33 +0200)]
wall: make sure ut_line is not empty
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=
1711574
Signed-off-by: Karel Zak <kzak@redhat.com>
Milan Broz [Tue, 4 Jun 2019 10:16:57 +0000 (12:16 +0200)]
libblkid: fix detection of dm-integrity superblock version
Kernel 5.2 can use superblock version 3 for dm-integrity.
Let's remove the explicit version check to be compatible
with future extensions.
Signed-off-by: Milan Broz <gmazyland@gmail.com>
Karel Zak [Fri, 31 May 2019 09:50:40 +0000 (11:50 +0200)]
hardlink: fix bad formatting in hardlink.1
* fix regex\f to regex\fR (issue #805)
* replace \fP with \fR to be consistent with our another man pages
Addresses: https://github.com/karelzak/util-linux/issues/805
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 31 May 2019 09:48:10 +0000 (11:48 +0200)]
docs: add lscpu --caches to ReleaseNotes
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 30 May 2019 10:06:50 +0000 (12:06 +0200)]
build-sys: release++ (v2.34-rc2)
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 30 May 2019 10:01:36 +0000 (12:01 +0200)]
docs: update v2.34-ReleaseNotes
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 30 May 2019 09:58:26 +0000 (11:58 +0200)]
docs: update AUTHORS file
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 30 May 2019 09:54:20 +0000 (11:54 +0200)]
po: merge changes
Signed-off-by: Karel Zak <kzak@redhat.com>
Božidar Putanec [Thu, 30 May 2019 09:49:43 +0000 (11:49 +0200)]
po: update hr.po (from translationproject.org)
Karel Zak [Wed, 29 May 2019 16:01:04 +0000 (18:01 +0200)]
libmount: add selinuxfs between pseudo filesystems
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=
1714826
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 29 May 2019 16:01:04 +0000 (18:01 +0200)]
libmount: add bpf between pseudo filesystems
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=
1714826
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 29 May 2019 15:59:33 +0000 (17:59 +0200)]
findmnt: fix filters use on --list
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=
1714826
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 29 May 2019 11:22:01 +0000 (13:22 +0200)]
tests: add asan build-sys test
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 28 May 2019 13:12:31 +0000 (15:12 +0200)]
fdisk: add note about -S and -H
It's seems people still follow old advices for SSD/4K devices. Let's
make CHS deprecation more visible at the begin of the man page...
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 28 May 2019 11:33:03 +0000 (13:33 +0200)]
ul: make sure buffers are zeroized [coverity scan]
Karel Zak [Tue, 28 May 2019 11:25:15 +0000 (13:25 +0200)]
column: make code more robust [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 28 May 2019 11:11:14 +0000 (13:11 +0200)]
setpriv: fix memory leak in local scope [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 28 May 2019 11:08:21 +0000 (13:08 +0200)]
setarch: avoid NULL dereference [coverity check]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 28 May 2019 10:53:58 +0000 (12:53 +0200)]
rtcwake: terminate mode and excl[]
* terminate string read from /proc
* terminate array for exclusive options
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 28 May 2019 10:37:14 +0000 (12:37 +0200)]
build-sys: add info about ASAN
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 28 May 2019 10:19:23 +0000 (12:19 +0200)]
renice: make code more readable for static analyzer [coverity scan]
It seems coverity and clag have no clue about relation between argv[]
and argc. Let's make code more readable for them...
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 28 May 2019 10:17:26 +0000 (12:17 +0200)]
readprofile: be more explicit with used types [cppcheck]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 28 May 2019 10:05:03 +0000 (12:05 +0200)]
lscpu: check scols_line_set_data() return value [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 28 May 2019 09:58:51 +0000 (11:58 +0200)]
lscpu: make lookup() use more consistent [coverity scan]
We usually check lookup() return value. Let's do it in this case too.
It seems static analyzers will be happy with consistent code.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 27 May 2019 11:07:12 +0000 (13:07 +0200)]
mesg: avoid 'ttyname failed: Success' message
The ttyname(3) can fail to access /dev/ path, and that will cause function
to fail without setting errno value with result of rather confusing error
message. Lets start setting stdin permission via /proc when this happens as
a go-around, with hope kernel following symlink does not fail. Ok, noted,
that hopes of symlink follow working are pretty slim.
Based on patch from Sami Kerola <kerolasa@iki.fi>.
Reference: https://github.com/lxc/lxd/issues/1724
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 27 May 2019 10:49:12 +0000 (12:49 +0200)]
lib/ttyutils: introduce get_terminal_stdfd()
Let's use separate function to detect what is the current terminal.
Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Thu, 23 May 2019 20:06:23 +0000 (21:06 +0100)]
libblkid: remove unneeded fields from struct bcache_super_block
This started as fix to following warning.
libblkid/src/superblocks/bcache.c:33:3: warning: ISO C99 doesn’t
support unnamed structs/unions [-Wc99-c11-compat]
But when sent to review Karel told out rather than getting rid of warnings
lets get rid of everything unnecessary.
[kzak@redhat.com: - use original struct member names rather than 'padN']
Reference: https://github.com/karelzak/util-linux/pull/802
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 19:27:37 +0000 (20:27 +0100)]
login: retire use of __FUNCTION__ macro
This fixes following warning about deprecatd __FUNCTION__ that is another
name for __func__ since GCC (pre 2.95, released July 1999).
login-utils/login.c:860:10: warning: ISO C does not support
‘__FUNCTION__’ predefined identifier [-Wpedantic]
Co-Author: Sami Kerola <kerolasa@iki.fi>
Reference: https://c0x.coding-guidelines.com/6.4.2.2.html
Reference: https://github.com/karelzak/util-linux/pull/802
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 13:32:59 +0000 (15:32 +0200)]
ipcs: check return value when read from /proc [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 13:28:07 +0000 (15:28 +0200)]
hwclock: don't use uninitialized value [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 13:17:16 +0000 (15:17 +0200)]
fallocate: make posix_fadvise() use more readable for analyzers
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 12:18:29 +0000 (14:18 +0200)]
dmesg: make strtok() use more robust
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 11:57:35 +0000 (13:57 +0200)]
blkzone: remove never read value
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 11:53:00 +0000 (13:53 +0200)]
whereis: make subdirs scan more robust
* call strchr() only once
* avoid things like strcat(buf, strchr(dir, '*') + 1)
* make it more readable
* improve debug messages
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 10:36:53 +0000 (12:36 +0200)]
lsblk: make sure __process_one_device() has proper arguments [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 10:31:49 +0000 (12:31 +0200)]
lsblk: check ul_path_scanf() return value [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 10:28:13 +0000 (12:28 +0200)]
lsblk: check stat() return code [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 10:14:10 +0000 (12:14 +0200)]
logger: make code more robust for static analyzer [clang scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 23 May 2019 10:12:07 +0000 (12:12 +0200)]
hardlink: avoid uninitialized variables [clang scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Wed, 22 May 2019 18:45:54 +0000 (19:45 +0100)]
libfdisk: assert if self_pte() returns NULL
The self_pte() can return NULL if partitions array is not large enough,
but that should also be impossible and definitely a bug.
libfdisk/src/dos.c:984:8: warning: potential null pointer dereference [-Wnull-dereference]
libfdisk/src/dos.c:1031:8: warning: potential null pointer dereference [-Wnull-dereference]
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Karel Zak [Wed, 22 May 2019 15:42:48 +0000 (17:42 +0200)]
libfdisk: (bsd) improve checksum calculation [-Waddress-of-packed-member]
Let's keep compilers and static analyzers happy. The idea is to use
memcpy() to copy from buffer to variable and use all label as unsigned
char rather than vectorize by unsigned short.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 22 May 2019 15:42:48 +0000 (17:42 +0200)]
libblkid: (silicon raid) improve checksum calculation [-Waddress-of-packed-member]
Let's keep compilers and static analyzers happy. The idea is to use
memcpy() to copy from buffer to variable and use all label as unsigned
char rather than vectorize by uint16_t.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 22 May 2019 15:42:48 +0000 (17:42 +0200)]
libfdisk: (sgi) improve checksum calculation [-Waddress-of-packed-member]
Let's keep compilers and static analyzers happy. The idea is to use
memcpy() to copy from buffer to variable and use all label as unsigned
char rather than vectorize by uint32_t.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 21 May 2019 14:27:17 +0000 (16:27 +0200)]
include/c: use __has_attribute
The __has macros are more portable (supported by gcc as well as
clang).
The old __GNUC_PREREQ is deprecated and it should be removed in
future. (Well, the __has macros are supported since gcc 5, so we
should be patient as some old stable distros (e.g. RHEL 7) use gcc
4.x).
This patch helps clang to correctly analyze our xalloc.h stuff.
Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Mon, 20 May 2019 18:56:19 +0000 (19:56 +0100)]
bash-completion: add hardlink completion
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 20 May 2019 18:34:10 +0000 (19:34 +0100)]
Karel Zak [Mon, 20 May 2019 11:03:58 +0000 (13:03 +0200)]
lib/ismounted: use xstrncpy()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 20 May 2019 10:59:40 +0000 (12:59 +0200)]
zramctl: use xstrncpy()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 20 May 2019 10:59:02 +0000 (12:59 +0200)]
whereis: use xstrncpy()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 20 May 2019 10:57:39 +0000 (12:57 +0200)]
vipw: use xstrncpy()
It's already used by vipw, so use it everywhere.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 20 May 2019 10:57:16 +0000 (12:57 +0200)]
lib/path: use xstrncpy()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 20 May 2019 10:57:07 +0000 (12:57 +0200)]
lib/sysfs: use xstrncpy()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 20 May 2019 10:46:39 +0000 (12:46 +0200)]
losetup: use xstrncpy()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 20 May 2019 10:42:43 +0000 (12:42 +0200)]
sfdisk: use xstrcpy()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 20 May 2019 10:41:12 +0000 (12:41 +0200)]
lib/colors: remove unnecessary goto
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 20 May 2019 10:35:38 +0000 (12:35 +0200)]
Merge branch '2019wk19' of https://github.com/kerolasa/util-linux
* '2019wk19' of https://github.com/kerolasa/util-linux:
lib/colors: remove redundant if statement
wipefs: fix variable / function shadowing [cppcheck]
sulogin: fix variable / function shadowing [cppcheck]
lscpu: remove redundant condition check [cppcheck]
libmount: avoid possible null pointer dereference [cppcheck]
lib/mangle: fix possible null pointer dereference [cppcheck]
sfdisk: remove unnecessary size check [cppcheck]
Karel Zak [Mon, 20 May 2019 10:35:09 +0000 (12:35 +0200)]
Merge branch 'lscpu_midr_updates' of https://github.com/jlinton/util-linux
* 'lscpu_midr_updates' of https://github.com/jlinton/util-linux:
lscpu: Add additional aarch64 models
Karel Zak [Mon, 20 May 2019 10:34:45 +0000 (12:34 +0200)]
Merge branch 'lscpu-another' of https://github.com/kerolasa/util-linux
* 'lscpu-another' of https://github.com/kerolasa/util-linux:
lscpu: fix floating point exception
include/strutils: fix potential null pointer dereference
lscpu: remove extra space from field key name
Sami Kerola [Sat, 18 May 2019 21:56:15 +0000 (22:56 +0100)]
lib/colors: remove redundant if statement
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 18 May 2019 21:39:58 +0000 (22:39 +0100)]
wipefs: fix variable / function shadowing [cppcheck]
[misc-utils/wipefs.c:636] -> [misc-utils/wipefs.c:310]: (style) Local
variable usage shadows outer function
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 18 May 2019 21:36:44 +0000 (22:36 +0100)]
sulogin: fix variable / function shadowing [cppcheck]
[login-utils/sulogin.c:398] -> [login-utils/sulogin.c:171]: (style) Local
variable set shadows outer function
[login-utils/sulogin.c:398] -> [login-utils/sulogin.c:830]: (style) Local
variable set shadows outer function
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 18 May 2019 21:25:11 +0000 (22:25 +0100)]
lscpu: remove redundant condition check [cppcheck]
[sys-utils/lscpu.c:1783] -> [sys-utils/lscpu.c:1785]: (warning) Either the
condition 'desc' is redundant or there is possible null pointer dereference: desc.
[sys-utils/lscpu.c:1840] -> [sys-utils/lscpu.c:1842]: (warning) Either the
condition 'desc' is redundant or there is possible null pointer dereference: desc.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 18 May 2019 21:14:20 +0000 (22:14 +0100)]
libmount: avoid possible null pointer dereference [cppcheck]
[libmount/src/monitor.c:797]: (warning) Possible null pointer dereference: me
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 18 May 2019 21:09:25 +0000 (22:09 +0100)]
lib/mangle: fix possible null pointer dereference [cppcheck]
Fix effects code that is used when testing util-linux, so quite low impact.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 18 May 2019 20:46:08 +0000 (21:46 +0100)]
sfdisk: remove unnecessary size check [cppcheck]
Following warning is false positive. Size of the buffer is defined using
BUFSIZ, and so the strncpy() will never overwrite the last byte that is
initialized to zero in get_user_reply().
[disk-utils/sfdisk.c:137] -> [disk-utils/sfdisk.c:136]: (warning) Either the
condition 'bufsz!=0' is redundant or strncpy() argument nr 3 can have
invalid value. The value is -1 but the valid values are '0:'.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 18 May 2019 17:43:08 +0000 (18:43 +0100)]
lscpu: fix floating point exception
As the title tells this change indeed fixes floating point exception, but
post processing as value overwrite feels a wrong. Possibly something in
input is making cpu set count to go wrong, but I could not get my head
around what could it be. Anyway avoiding division by zero seems better than
crashing so lets do this atleast for now.
Caused-by: e5f721132ec8b8c933a396d8dcb3efcb67854f13
Addresses: https://github.com/karelzak/util-linux/issues/788
Reported-by: Lars Wendler <polynomial-c@gentoo.org>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Thu, 16 May 2019 20:56:57 +0000 (21:56 +0100)]
include/strutils: fix potential null pointer dereference
Recent lscpu fix caused gcc -Wnull-dereference to go off that this change
addresses.
Reference:
b94acada9ed0e11a7e82f8f60280c5b6058e4250
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Thu, 16 May 2019 20:51:47 +0000 (21:51 +0100)]
lscpu: remove extra space from field key name
The extra space was more obvious in json output. But as the expected test
output displays also the standard output can be effected by this change.
$ lscpu --json | jq '.lscpu | .[].field' | grep ': '
"L1d cache: "
"L1i cache: "
"L2 cache: "
"L3 cache: "
"Vulnerability L1tf: "
"Vulnerability Mds: "
"Vulnerability Meltdown: "
"Vulnerability Spec store bypass: "
"Vulnerability Spectre v1: "
"Vulnerability Spectre v2: "
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Jeremy Linton [Thu, 16 May 2019 17:10:17 +0000 (12:10 -0500)]
lscpu: Add additional aarch64 models
ARM has released docs for Cortex-A76, Neoverse-N1 and Neoverse-E1.
That means we know the midr partnums, so we can add them to the
human readable model name table.
Signed-off-by: Jeremy Linton <lintonrjeremy@gmail.com>
Karel Zak [Thu, 16 May 2019 12:38:12 +0000 (14:38 +0200)]
findmnt: keep it easy for static analyzers
Karel Zak [Thu, 16 May 2019 12:33:47 +0000 (14:33 +0200)]
findmnt: (verify) check mnt_table_next_fs() return code [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 16 May 2019 12:27:15 +0000 (14:27 +0200)]
fincore: remove unused variable [clang scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 16 May 2019 12:20:32 +0000 (14:20 +0200)]
cal: make sure months_in_row makes sense [coverity scan]
* avoid divide by zero in mountly() dues to wrong months_in_row
* make sure months_in_row is at least 1
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 16 May 2019 11:56:34 +0000 (13:56 +0200)]
blkid: improve strcpy() usage [coverity scan]
The old deprecated list output format ("-o list") copies gettex string
into fixed buffer, that's really bad idea.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 16 May 2019 11:46:03 +0000 (13:46 +0200)]
utmpdump: check ftello() return value
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 16 May 2019 11:31:30 +0000 (13:31 +0200)]
Merge branch 'lscpu-output-fix' of https://github.com/kerolasa/util-linux
* 'lscpu-output-fix' of https://github.com/kerolasa/util-linux:
lscpu: move trailing null after removing characters from a string
Sami Kerola [Thu, 16 May 2019 10:44:38 +0000 (11:44 +0100)]
lscpu: move trailing null after removing characters from a string
From the test input string ':' characters are removed:
cat x86_64-epyc_7451/sys/devices/system/cpu/vulnerabilities/spectre_v2
Mitigation: Full AMD retpoline, IBPB: conditional, STIBP: disabled, RSB filling
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Karel Zak [Wed, 15 May 2019 15:46:31 +0000 (17:46 +0200)]
libsmartcols: (groups) improve scols_table_group_lines() args check [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 15 May 2019 15:25:04 +0000 (17:25 +0200)]
libmount: fix memory leak on error [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 15 May 2019 15:12:38 +0000 (17:12 +0200)]
libfdisk: avoid memory leak [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 15 May 2019 15:10:38 +0000 (17:10 +0200)]
libfdisk: avoid division by zero [clang scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 15 May 2019 14:59:52 +0000 (16:59 +0200)]
libfdisk: remove unused code [clang scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 15 May 2019 14:49:26 +0000 (16:49 +0200)]
libfdisk: properly check return code of add_to_partitions_array() [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 15 May 2019 14:28:31 +0000 (16:28 +0200)]
libblkid: make partitions reference counting more robust [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 15 May 2019 14:24:51 +0000 (16:24 +0200)]
libblkid: don't ignore blkid_probe_set_magic() errors [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 15 May 2019 14:15:15 +0000 (16:15 +0200)]
libblkid: fix possible uninitialized value use [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 15 May 2019 14:09:16 +0000 (16:09 +0200)]
lib/strutils: keep static analyzer happy [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>