Michael Trapp [Thu, 10 Mar 2022 12:18:52 +0000 (13:18 +0100)]
libuuid: extend cache in uuid_generate_time_generic()
Improve throughput and reduce clock sequence increments
for high load situation with time based version 1 uuids.
In a high load scenario, where an application continiously reads time
based version 1 uuids from uuidd, we have noticed the following
behaviour.
The application reads more uuids as there are available in the
corresponding timeframe and each bulk request results in an increment of
the clock sequence because of the 'step back' in time. Due to the
14bit size of the clock sequence this also results in overflows of
the clock sequence.
As uuidd calls
uuid_generate_time_safe()
uuid_generate_time_generic()
the default value for the bulk request in the '#ifdef HAVE_TLS' section
of uuid_generate_time_generic() is set to 1000.
Extending the 'cache' of uuid_generate_time_generic() by increasing
the default of num to 1000000 doesn't solve the issue, but reduces
the clock sequence increments by factor 1000 and it also improves
the uuid throughput in our setup by factor 3-4.
It might be possible to implement a cache for
UUIDD_OP_BULK_TIME_UUID
UUIDD_OP_TIME_UUID
in the uuidd request handling, but it would not be as simple as this fix
in uuid_generate_time_generic().
Karel Zak [Fri, 4 Mar 2022 08:53:49 +0000 (09:53 +0100)]
Merge branch 'new-gpt-types' of https://github.com/gyakovlev/util-linux
* 'new-gpt-types' of https://github.com/gyakovlev/util-linux:
libfdisk: add new verity root and /usr part types
libfdisk: add new root and /usr part types
Karel Zak [Mon, 28 Feb 2022 10:25:30 +0000 (11:25 +0100)]
Merge branch 'lsfd-tests' of https://github.com/masatake/util-linux
* 'lsfd-tests' of https://github.com/masatake/util-linux:
tests: (lsfd) don't check an unused program
tests: (lsfd) don't use findmnt to verify device numbers
tests: (lsfd) improve the help messages of test_mkfds helper command
losetup: don't skip adding a new device if it already has a device node
Linux plans to deprecate the auto-creation of block devices based on
access to the device node starting from kernel 5.18. Without that feature
losetup will fail to create the loop device if a device node already
exists, but the loop device to back it in the kernel does not exist yet.
This is a scenario that should not happen in modern udev based
distributions, but apparently there still are various scripts around that
manually call the superfluous mknod.
Change losetup to unconditionally call loopcxt_add_device when a specific
device node is specified on the command line. If the loop device
already exists the LOOP_CTL_ADD ioctl will fail, but given that losetup
ignores the return value from loopcxt_add_device that failure has no
further effect.
Reported-by: Luis Chamberlain <mcgrof@kernel.org> Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Signed-off-by: Karel Zak <kzak@redhat.com>
Masatake YAMATO [Sat, 26 Feb 2022 18:42:09 +0000 (03:42 +0900)]
tests: (lsfd) don't use findmnt to verify device numbers
This change tries to fix the failures in testing reported in:
* https://lkml.org/lkml/2022/1/31/1333, and
* https://lkml.org/lkml/2022/2/2/171
The original test cases depended on a wrong assumption; if M and M'
are the same, D and D' are the same, too. Here, M is a mnt_id in
/proc/$pid/mountinfo. D is the device number for M in
/proc/$pid/mountinfo. M' is the mnt_id value in
/proc/$pid/fdinfo/$fd. D' is the device number reported by stat
syscall for /proc/$pid/fd/$fd.
The original test compared the device numbers reported by findmnt and
lsfd. findmnt retrieves a device number from /proc/$pid/mountinfo.
lsfd retrieves a device number from stat syscall.
This assumption is not correct for a file on an overlay file system
whose block devices behind lowerdir and upperdir are different.
Using findmnt is not suitable for comparing device numbers.
This change uses stat command instead of findmnt to retrieve the
device number.
Karel Zak [Mon, 21 Feb 2022 10:04:31 +0000 (11:04 +0100)]
Merge branch 'cdown/2022-02-15/dmesg_subsys_after_blank' of https://github.com/cdown/util-linux
* 'cdown/2022-02-15/dmesg_subsys_after_blank' of https://github.com/cdown/util-linux:
dmesg: Start colouring subsys delimiter only after trailing blank
Chris Down [Tue, 15 Feb 2022 13:39:57 +0000 (13:39 +0000)]
dmesg: Start colouring subsys delimiter only after trailing blank
This improves colouring when certain message levels are configured to
display a background colour using terminal-colors.d. Previously the
background colour starts at ":" on messages with a subsystem present,
which looks pretty odd. Now it starts from the remaining message after
the subsys (if there is one).
If one only uses foreground colours, this largely makes no difference:
the colon is now coloured with the same subsys colour, but there's no
difference for the blank.
Karel Zak [Mon, 14 Feb 2022 12:16:27 +0000 (13:16 +0100)]
Merge branch 'manpage-fixes' of https://github.com/mariobl/util-linux
* 'manpage-fixes' of https://github.com/mariobl/util-linux:
Fix several adoc files as reported by Helge Kreutzmann
eject.1.adoc: Fix markup
colors.adoc: format command name bold
Add missing *.adoc files to Makemodule.am
Add help-version.adoc to po4a configuration file
Add new *.adoc files to po4a configuration file
Fix markup and wording in colors.adoc
Karel Zak [Mon, 14 Feb 2022 12:14:51 +0000 (13:14 +0100)]
Merge branch 'lsfd-fix-wrong-fmt-str-and-cast-type' of https://github.com/masatake/util-linux
* 'lsfd-fix-wrong-fmt-str-and-cast-type' of https://github.com/masatake/util-linux:
lsfd: fix the way to print length of mmap area
lsfd: fix the way to print stat.st_nlink
lsfd: fix the way to print stat.st_size
Karel Zak [Thu, 10 Feb 2022 11:03:17 +0000 (12:03 +0100)]
chsh, chfn: remove readline support [CVE-2022-0563]
The readline library uses INPUTRC= environment variable to get a path
to the library config file. When the library cannot parse the
specified file, it prints an error message containing data from the
file.
Unfortunately, the library does not use secure_getenv() (or a similar
concept) to avoid vulnerabilities that could occur if set-user-ID or
set-group-ID programs.
Reported-by: Rory Mackie <rory.mackie@trailofbits.com> Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 11 Feb 2022 11:06:41 +0000 (12:06 +0100)]
libsmartcols: change "export" behavior, add "shellvar" flag
In version 2.37 the "export" output format automatically modifies
column names to be compatible with shell's requirements for variable
names. This change was backwardly incompatible for people who use for
example "lsblk -P" in non-shell environment.
It's painful to modify this behavior again in v2.38, but it seems
better to add a way how to control this behavior independently on
output format as it seems attractive feature for more use-cases.
This commit introduces scols_table_enable_shellvar() function to
enable/disable this feature.
Masatake YAMATO [Thu, 10 Feb 2022 07:14:11 +0000 (16:14 +0900)]
lsfd: fix the way to print stat.st_nlink
The type used for casting the member was too small; for the
"%ju" format spec, we should use uintmax_t for the purpose.
This change may fix the bug reported in
https://github.com/util-linux/util-linux/issues/1511#issuecomment-1033697617
in GitHub#1511 by Anatoly Pugachev <matorola@gmail.com>. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Karel Zak [Mon, 7 Feb 2022 10:10:03 +0000 (11:10 +0100)]
misc: use everywhere mkstemp_cloexec() as fallback to mkostemp()
The function mkostemp() does not have to be available everywhere,
and for this reason, we have mkstemp_cloexec() as a fallback solution.
Unfortunately, some codes (usually fuzzy tests) do not use the
fallback. Let's fix it.
kill.1.adoc: clarify syntax of -SIG argument in synopsis
kill.1.adoc has this synopsis line
*kill* [-signal|*-s* _signal_]
For "-signal", the leading "-" should be typed literally, and the
"signal" suffix should be replaced by a signal name/number.
This means that according to GNU man(1), the "-" should render in
bold font whereas the "signal" placeholder should use italic (which
terminals often render with underscores).
Make it so. Use two askerisks because one is not enough for sub-word
markup [*].
projects / thirdparty / util-linux.git / log
